On Fri, 07 Dec 2012 11:37:44 -0700 Eric Blake <ebl...@redhat.com> wrote:
> On 12/07/2012 11:31 AM, Luiz Capitulino wrote: > >>>> +++ b/.gitignore > >>>> @@ -93,3 +93,4 @@ cscope.* > >>>> tags > >>>> TAGS > >>>> *~ > >>>> +!scripts/qemu-guest-agent/fsfreeze-hook.d > >>> > >>> Why? Do we expect to have *~ files in there? > >> > >> What does your question have to do with the patch, which isn't even > >> touching the pre-existing *~ line? > > > > As far I could understand the ! prefix in gitignore documention, it's > > changing the *~ meaning for the fsfreeze-hoo.d directory, and I wanted > > to understand why. > > > > No, it is changing a much earlier line: > > *.d > > to say that this _particular_ .d is allowed to be committed. It has > nothing to do with *~. Ah, now it makes a lot of sense, thanks Eric. It would be nice to move it right below *.d, to avoid stupid comments :) > Still, I have to wonder if we really want to store these files in a .d > in the repository itself, or if we should store them under some other > file name and only at 'make install' time insert them into a .d at the > install destination. It would clean up this confusion about the > .gitignore as well as the change to the 'find' command during 'make clean'. Well, now that I understand it both ways are fine with me (ie. what you suggest and what's been implemented in this patch).
