** Also affects: qemu-linaro
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1082292
Title:
[ARM] pflash_write: Unimplemented flash cmd sequence
Status in
ping ?
On Mon, Oct 8, 2012 at 5:53 PM, Julien Grall wrote:
> On 09/19/2012 12:50 PM, Julien Grall wrote:
>
> > This is the tenth version of patch series about ioport registration.
> >
> > Some part of QEMU still use register_ioport* functions to register
> ioport.
> > These functions doesn't all
Latest upstream qemu.git still reproduces this, so marking it as
affecting QEMU.
** Also affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/107971
Something new...
I have started to compile qemu with all the audio drivers --audio-drv-
list="oss alsa ps sdl esd" on 0.14.1 with a patch that was included in
0.15 and it compiles IF I edit ioctls.h and remove 3 lines about sound.
Oddly enough my kernel from CM9\Ubuntu is not compiled with those
This fixes the following assertion caused by local temp reaching the end
of TB in discarded state:
qemu-system-xtensa: tcg/tcg.c:1665: temp_save: Assertion
`s->temps[temp].val_type == 2 || s->temps[temp].fixed_reg' failed.
Aborted
Signed-off-by: Max Filippov
---
target-xtensa/cpu.h |
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: qemu-linaro (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/955379
Title:
Public bug reported:
I find the bug already reported on qemu-devel mailing-list [1] w/o
replies also on other sources.
Tested on Darwin (Mac OS X 10.7.5) and Scientific Linux 6.3 hosts. Also
using the latest 1.2.X and 1.3.0-rc0 and qemu-linaro. On all host
operating systems and with different ver
This patch adds basic Websocket Protocol version 13 - RFC 6455 - support
to QEMU VNC. Binary encoding support on the client side is mandatory.
Because of the GnuTLS requirement the Websockets implementation is
optional (--enable-vnc-ws).
To activate Websocket support the VNC option "websocket"is
pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily
creates a drive without a medium.
When pc_system_flash_init() asks for its size, bdrv_getlength() fails
with -ENOMEDIUM, which isn't checked either. It fails relatively
cleanly only because -ENOMEDIUM isn't a multiple of 4096:
Harmless, because we the error inevitably leads to another, fatal one
in pc_system_flash_init(): PC system firmware (pflash) not available.
Fix it anyway.
Signed-off-by: Markus Armbruster
---
hw/pc_sysfw.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/pc_sysfw.c b/hw/
Straightforward bug fixes, so they could qualify for 1.3. But since
the bugs are fairly harmless, we might want to postpone to 1.4
regardless. If we do, perhaps qemu-trivial could pick them up.
Markus Armbruster (2):
pc_sysfw: Check for qemu_find_file() failure
pc_sysfw: Plug memory leak on
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c | 24 ++--
1 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index a85c2d4..b75be72 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -57,6 +57,7 @@ struct pci_status {
type
Il 23/11/2012 18:02, Andreas Färber ha scritto:
>> Store in the object the freeing function that will be used at deletion
>> > time. This makes it possible to use object_delete on statically-allocated
>> > (embedded) objects. Dually, it makes it possible to use object_unparent
>> > and object_unr
Il 23/11/2012 18:12, Andreas Färber ha scritto:
> We have not yet started using the in-place mechanism much (i440fx and
> prep_pci patches, not in master; also my tegra branch), so I would like
> to keep this for symmetry with "initialize" vs. "new" and their
> distinguished semantics.
But you do
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index e03b1a6..b3022c0 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
@@ -170,9 +170,6 @@ static uint32_t pm_ioport_readl(void *opaque, ui
Il 23/11/2012 18:07, Andreas Färber ha scritto:
>> > bus = g_malloc0(sizeof(*bus));
>> > -bus->qbus.glib_allocated = true;
>> > pci_bus_new_inplace(bus, parent, name, address_space_mem,
>> > address_space_io, devfn_min);
>> > +OBJECT(bus)->free = g_free;
>
Am 23.11.2012 09:47, schrieb Paolo Bonzini:
> It is not used anymore, and there is no need to make it public.
>
> Signed-off-by: Paolo Bonzini
We have not yet started using the in-place mechanism much (i440fx and
prep_pci patches, not in master; also my tegra branch), so I would like
to keep thi
Am 23.11.2012 09:47, schrieb Paolo Bonzini:
> All conditional deallocation can now be done with object_delete.
> Remove the @qom_allocated and @glib_allocated fields; replace the latter
> with a direct assignment of the @free function pointer.
>
> Signed-off-by: Paolo Bonzini
I am grateful for y
Am 23.11.2012 09:47, schrieb Paolo Bonzini:
> Store in the object the freeing function that will be used at deletion
> time. This makes it possible to use object_delete on statically-allocated
> (embedded) objects. Dually, it makes it possible to use object_unparent
> and object_unref without lea
Signed-off-by: Gerd Hoffmann
---
hw/acpi.c | 19 +--
hw/acpi.h |5 +++--
hw/acpi_piix4.c |5 +
hw/vt82c686.c |6 +-
4 files changed, 22 insertions(+), 13 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
index f4aca49..ba25c23 100644
--- a/hw/acp
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c | 46 --
hw/acpi_ich9.h |1 +
2 files changed, 37 insertions(+), 10 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index aa290d6..cdfa266 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
On 05.11.2012, at 12:34, Avik Sil wrote:
> On 10/26/2012 05:15 PM, Alexander Graf wrote:
>>
>> On 25.10.2012, at 22:57, Alexander Graf wrote:
>>
>>>
>>> On 25.10.2012, at 22:50, Peter Maydell wrote:
>>>
On 25 October 2012 21:18, Anthony Liguori wrote:
> The other approach to this w
With gpe being switched to memory api this is no longer needed.
Signed-off-by: Gerd Hoffmann
---
hw/acpi.c |7 ---
hw/acpi.h |2 --
hw/acpi_ich9.c |1 -
hw/acpi_piix4.c |1 -
4 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
in
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c | 23 ++-
1 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index cd876c8..a85c2d4 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -146,12 +146,33 @@ static void pm_io_spac
Am 23.11.2012 09:47, schrieb Paolo Bonzini:
> Add an ObjectClass method that is done at object_unparent time. It
> should remove any backlinks to the object in the composition tree,
> so that object_delete will be able to drop the last reference and
> free the object.
>
> Use it for qdev buses.
>
Il 23/11/2012 17:30, Andreas Färber ha scritto:
> If having SCSI_BUS() return NULL was your intent you would not have
> needed to switch to object_dynamic_cast in your second patch. :)
In the second patch I needed object_dynamic_cast in case the bus was not
a SCSI bus at all.
For example:
$ qemu
Am 23.11.2012 09:47, schrieb Paolo Bonzini:
> The reference count for embedded objects is always one too low, because
> object_initialize_with_type returns with zero references to the object.
> This causes premature finalization of the object (or an assertion failure)
> after calling object_ref to
Am 23.11.2012 13:41, schrieb Marcelo Tosatti:
> From: Bruce Rogers
>
> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
> should be marked as having no argument.
>
> Signed-off-by: Bruce Rogers
> Reviewed-by: Jan Kiszka
Missing a
Reviewed-by: Stefan Hajnoczi
from
Am 23.11.2012 17:06, schrieb Alexander Graf:
>
> On 19.10.2012, at 12:17, Julio Guerra wrote:
>
>> This patch fixes bug 1031698 :
>> https://bugs.launchpad.net/qemu/+bug/1031698
>>
>> If we look at the (truncated) translation of the conditional branch
>> instruction in the test submitted in the b
Am 23.11.2012 17:25, schrieb Paolo Bonzini:
> Il 23/11/2012 17:16, Andreas Färber ha scritto:
@@ -430,7 +430,7 @@ Object *object_dynamic_cast_assert(Object *obj, const
char *typename)
inst = object_dynamic_cast(obj, typename);
-if (!inst) {
+if (
Il 23/11/2012 17:16, Andreas Färber ha scritto:
>> > @@ -430,7 +430,7 @@ Object *object_dynamic_cast_assert(Object *obj, const
>> > char *typename)
>> >
>> > inst = object_dynamic_cast(obj, typename);
>> >
>> > -if (!inst) {
>> > +if (!inst && obj) {
>> > fprintf(stderr,
On Thu, Nov 22, 2012 at 09:02:54PM +0100, Christian Borntraeger wrote:
> here are two followup patches.
>
>
> Christian Borntraeger (2):
> block: simply default_drive
> block: clarify comment about IF_IDE = 0
>
> blockdev.h |6 +-
> vl.c | 20 ++--
> 2 files
Peter Maydell wrote:
> On 23 November 2012 15:31, Jamie Lokier wrote:
> > x86 instruction sets haven't followed a linear progression of features
> > for quite a while, especially including non-Intel chips, so it stopped
> > making sense for GCC to indicate the instruction set in that way.
>
> If
Peter Maydell wrote:
> On 23 November 2012 15:17, Peter Maydell wrote:
> > On 23 November 2012 15:15, Paolo Bonzini wrote:
> >> You should at least test __i686__ too:
> >>
> >> $ gcc -m32 -dM -E -x c /dev/null |grep __i
> >> #define __i686 1
> >> #define __i686__ 1
> >> #define __i386 1
> >> #def
On Fri, Nov 23, 2012 at 03:29:52PM +0100, Konrad Frederic wrote:
> On 23/11/2012 13:38, Stefan Hajnoczi wrote:
> >On Thu, Nov 22, 2012 at 03:50:49PM +0100, fred.kon...@greensocs.com wrote:
> >>From: KONRAD Frederic
> >>I made the changes you suggest in the last RFC.
> >>
> >>There are still two iss
Signed-off-by: Gerd Hoffmann
---
hw/vt82c686.c | 28 +++-
1 files changed, 23 insertions(+), 5 deletions(-)
diff --git a/hw/vt82c686.c b/hw/vt82c686.c
index 5d7c00c..7f9c7a2 100644
--- a/hw/vt82c686.c
+++ b/hw/vt82c686.c
@@ -24,6 +24,7 @@
#include "pm_smbus.h"
#includ
Am 23.11.2012 16:56, schrieb Paolo Bonzini:
> Trying to cast a NULL value will cause a crash. Returning
> NULL is also sensible, and it is also what the type-unsafe
> DO_UPCAST macro does.
>
> Reported-by: Markus Armbruster
> Signed-off-by: Paolo Bonzini
I believe we had a lengthy discussion o
On Fri, Nov 23, 2012 at 03:21:30PM +0100, Konrad Frederic wrote:
> On 23/11/2012 13:23, Stefan Hajnoczi wrote:
> >On Thu, Nov 22, 2012 at 03:50:50PM +0100, fred.kon...@greensocs.com wrote:
> >>+struct VirtioBusInfo {
> >This is defining an ad-hoc interface. QOM has support for interfaces so
> >tha
Signed-off-by: Gerd Hoffmann
---
hw/acpi.c | 49 +++--
hw/acpi.h |6 --
hw/acpi_piix4.c | 18 +-
hw/vt82c686.c | 18 +-
4 files changed, 53 insertions(+), 38 deletions(-)
diff --git a/hw/acpi.
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c | 33 +++--
hw/acpi_ich9.h |1 +
2 files changed, 24 insertions(+), 10 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index 61034d3..e03b1a6 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
@@ -29,6 +29,
On 20.11.2012, at 19:16, Peter Maydell wrote:
> Pass qemu_sglist_init the global dma_context_memory rather than a NULL
> pointer; this fixes a segfault in dma_memory_map() when the guest
> starts using DMA.
>
> Reported-by: Amadeusz Sławiński
> Signed-off-by: Peter Maydell
Thanks, applied to
On 19.10.2012, at 12:17, Julio Guerra wrote:
> This patch fixes bug 1031698 :
> https://bugs.launchpad.net/qemu/+bug/1031698
>
> If we look at the (truncated) translation of the conditional branch
> instruction in the test submitted in the bug post, the call to the
> exception helper is missing
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c | 30 +++---
1 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 519269a..086f230 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -28,6 +28,7 @@
#include "range.h
Nothing left to do, everything handled by subregions,
we can zap the reaw/write handlers now.
Signed-off-by: Gerd Hoffmann
---
hw/vt82c686.c | 61 +
1 files changed, 1 insertions(+), 60 deletions(-)
diff --git a/hw/vt82c686.c b/hw/vt82c6
Commit 0d93692 (qdev: Convert busses to QEMU Object Model, 2012-05-02)
removed a check on the type of the bus where a SCSI disk is hotplugged.
However, hot-plugging to the wrong kind of device now causes a crash
due to either a NULL pointer dereference (avoided by the previous patch)
or a failed QO
Trying to cast a NULL value will cause a crash. Returning
NULL is also sensible, and it is also what the type-unsafe
DO_UPCAST macro does.
Reported-by: Markus Armbruster
Signed-off-by: Paolo Bonzini
---
qom/object.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qom/ob
Reported by Markus, and a regression from 1.1. Not really SCSI stuff,
just happens to have it in the name, so I'm not sending it through my tree.
Paolo Bonzini (2):
qom: dynamic_cast of NULL is always NULL
hmp: do not crash on invalid SCSI hotplug
hw/pci-hotplug.c | 8 +++-
qom/object.c
On Fri, Nov 23, 2012 at 3:15 PM, Peter Maydell wrote:
> On 23 November 2012 14:11, Stefan Hajnoczi wrote:
>> On Thu, Nov 22, 2012 at 10:07 AM, Stefan Priebe
>> wrote:
>>> diff --git a/block/rbd.c b/block/rbd.c
>>> index 5a0f79f..0384c6c 100644
>>> --- a/block/rbd.c
>>> +++ b/block/rbd.c
>>> @@
>>Can you post more details about your benchmark setup so that this can be
>>reproduced? And does it reproduce with local files as well or only using
>>NFS?
Sure, I have redone tests, here the results:
(note that my netapp san have a nvram journal, so directio are as fast than
buffered io)
pre
Signed-off-by: Gerd Hoffmann
---
hw/acpi.c | 38 ++
hw/acpi.h |5 +++--
hw/acpi_piix4.c |8 +---
hw/vt82c686.c |8 +---
4 files changed, 35 insertions(+), 24 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
index ba25c23..956
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c | 37 +
1 files changed, 29 insertions(+), 8 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index d74fff9..93aa319 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -42,6 +42,9 @@
#define G
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c |5 ++---
hw/pm_smbus.c | 17 +
hw/pm_smbus.h |3 +--
hw/smbus_ich9.c | 52 +++-
hw/vt82c686.c |6 ++
5 files changed, 33 insertions(+), 50 deletions(-)
diff
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c | 18 +-
1 files changed, 1 insertions(+), 17 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index 237b577..0f025f8 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
@@ -105,17 +105,7 @@ static uint32_t pm_ioport_readb(v
Signed-off-by: Gerd Hoffmann
---
hw/ich9.h |1 +
hw/lpc_ich9.c | 29 +
hw/smbus_ich9.c | 12
3 files changed, 30 insertions(+), 12 deletions(-)
diff --git a/hw/ich9.h b/hw/ich9.h
index de49135..34e216f 100644
--- a/hw/ich9.h
+++ b/hw/ich9.
Nothing left to do, everything handled by subregions,
we can zap the reaw/write handlers now.
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c | 41 +
1 files changed, 1 insertions(+), 40 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index b3022c0..237b577 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
@@ -116,9 +116,6 @@ static void pm_ioport_writew(void *opaque, ui
Nothing left to do, everything handled by subregions,
we can zap the reaw/write handlers now.
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c | 125 +---
1 files changed, 1 insertions(+), 124 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c | 38 --
hw/acpi_ich9.h |1 +
2 files changed, 29 insertions(+), 10 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index 0f025f8..aa290d6 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
@@ -73,1
Hi,
While wading through the qemu acpi and seabios aml code I've figured the
qemu acpi codebase is *way* too messy. So this patch series switches
the apci code to the memory api. That alone cleans up quite a bit and
makes the code in hw/acpi.c more self-contained. As bonus everything
shows up
On 23 November 2012 15:31, Jamie Lokier wrote:
> x86 instruction sets haven't followed a linear progression of features
> for quite a while, especially including non-Intel chips, so it stopped
> making sense for GCC to indicate the instruction set in that way.
If you're going to go down that rout
On 23 November 2012 15:17, Peter Maydell wrote:
> On 23 November 2012 15:15, Paolo Bonzini wrote:
>> You should at least test __i686__ too:
>>
>> $ gcc -m32 -dM -E -x c /dev/null |grep __i
>> #define __i686 1
>> #define __i686__ 1
>> #define __i386 1
>> #define __i386__ 1
>
> Yuck. I had assumed
Peter Maydell wrote:
> On 23 November 2012 15:15, Paolo Bonzini wrote:
> > Il 23/11/2012 16:12, Peter Maydell ha scritto:
> >> Adjust the conditional which guards the implementation of
> >>
> >> -#elif defined(__i386__)
> >> +#elif defined(__i586__)
> >>
> >> static inline int64_t cpu_get_real_ti
Am 23.11.2012 08:26, schrieb Dietmar Maurer:
> qcow2 snapshot on newly created files are fast:
>
> # qemu-img create -f qcow2 test.img 200G
> # time qemu-img snapshot -c snap1 test.img
> real 0m0.014s
>
> but if metadata is allocated it gets very slow:
>
> # qemu-img create -f qcow2 -o "p
Paolo Bonzini writes:
> Il 22/11/2012 15:02, Markus Armbruster ha scritto:
>> Watch this:
>>
>> (qemu) drive_add 0 if=scsi
>> Segmentation fault (core dumped)
>>
>> Broken in commit 0d936928 "qdev: Convert busses to QEMU Object Model".
>> Before:
>>
>> (qemu) drive_add 0 if=scsi
>>
Am 23.11.2012 11:18, schrieb Jens Freimann:
> From: Viktor Mihajlovski
>
> This enables qemu -cpu ? to return the list of supported CPU models
> on s390. Since only the host model is supported at this point in time
> this is pretty straight-forward. Further, a validity check for the
> requested C
On 23 November 2012 15:15, Paolo Bonzini wrote:
> Il 23/11/2012 16:12, Peter Maydell ha scritto:
>> Adjust the conditional which guards the implementation of
>>
>> -#elif defined(__i386__)
>> +#elif defined(__i586__)
>>
>> static inline int64_t cpu_get_real_ticks(void)
>> {
>>
>
> You should at
Il 23/11/2012 16:12, Peter Maydell ha scritto:
> Adjust the conditional which guards the implementation of
> cpu_get_real_ticks() via RDTSC, so that we don't try to use it
> on x86 CPUs which don't implement RDTSC. Instead we will fall
> back to the no-cycle-counter-available default implementatio
Signed-off-by: Paolo Bonzini
---
tests/Makefile | 2 +
tests/test-aio.c | 667 +++
2 files changed, 669 insertions(+)
create mode 100644 tests/test-aio.c
diff --git a/tests/Makefile b/tests/Makefile
index ca680e5..61cbe3b 100644
--- a/test
Signed-off-by: Paolo Bonzini
---
tests/Makefile | 2 +
tests/test-thread-pool.c | 213 +++
2 files changed, 215 insertions(+)
create mode 100644 tests/test-thread-pool.c
diff --git a/tests/Makefile b/tests/Makefile
index 61cbe3b..b60f0fb 1
As requested. :) The tests pass on both Linux and Wine.
I'm not sure if it makes sense to include these in 1.3, but the idea
has some worth.
Paolo Bonzini (2):
tests: add AioContext unit tests
tests: add thread pool unit tests
tests/Makefile | 4 +
tests/test-aio.c | 66
On 23.11.2012, at 16:02, Peter Maydell wrote:
> On 23 November 2012 10:18, Jens Freimann wrote:
>> +/* The initial reset call is needed here to reset in-kernel
>> + * vcpu data that we can't access directly from QEMU.
>
> If there's in-kernel vcpu data we can't access from QEMU,
> doesn
Adjust the conditional which guards the implementation of
cpu_get_real_ticks() via RDTSC, so that we don't try to use it
on x86 CPUs which don't implement RDTSC. Instead we will fall
back to the no-cycle-counter-available default implementation.
Reported-by: Yurij Popov
Signed-off-by: Peter Mayd
Christian Borntraeger writes:
> here are two followup patches.
Thanks!
Stefan, PATCH 1/2 could be squashed into "Support default block
interfaces per QEMUMachine". Your choice.
Reviewed-by: Markus Armbruster
On 23 November 2012 10:18, Jens Freimann wrote:
> +/* The initial reset call is needed here to reset in-kernel
> + * vcpu data that we can't access directly from QEMU.
If there's in-kernel vcpu data we can't access from QEMU,
doesn't this cause problems for migration?
> Before
> + *
The repeated calls to WaitForMultipleObjects may cause a livelock in aio_poll,
where no progress is made on bottom halves. This patch matches the behavior
of the POSIX code.
Signed-off-by: Paolo Bonzini
---
Found by the new unit tests.
aio-win32.c | 5 -
1 file changed, 4 insertion
Am 23.11.2012 15:17, schrieb Alexandre DERUMIER:
>>> Preallocation doesn't matter much these days.
>
> I have done benchmark through nfs on a netapp san, (with directio),
>
> I got 300 iops without preallocation, and 6000 iops with preallocation
This doesn't sound right, even for writethrou
Hi,
i'm not a ceph or inktank guy. I can't made any decision on what to
change. At least right now you'll see failing I/O's in your guest, when
you discard whole disks.
I could fix this for me with int64 and with ssize_t. So if i should
resend another patch i need a concrete advise how to pa
On Fri, 23 Nov 2012 15:12:45 +0100
Konrad Frederic wrote:
> On 23/11/2012 13:08, Cornelia Huck wrote:
> > On Thu, 22 Nov 2012 15:50:50 +0100
> > fred.kon...@greensocs.com wrote:
> >
> >
> >> +/* Create a virtio bus. */
> >> +VirtioBus *virtio_bus_new(DeviceState *host, const VirtioBusInfo *info)
On 23.11.2012, at 15:32, Christian Borntraeger wrote:
> On 23/11/12 14:40, Alexander Graf wrote:
>>
>> On 23.11.2012, at 11:18, Jens Freimann wrote:
>>
>>> When resetting vcpus on s390/kvm we have to clear registers, psw
>>> and prefix as described in the z/Architecture PoP, otherwise a
>>> reb
On 23/11/2012 15:26, Peter Maydell wrote:
On 23 November 2012 14:23, Konrad Frederic wrote:
On 23/11/2012 13:34, Peter Maydell wrote:
On 23 November 2012 12:29, Stefan Hajnoczi wrote:
Eventually VirtIOBindings can probably be inlined into VirtioBusInfo. I
don't see a need for separate stru
On 23/11/12 14:40, Alexander Graf wrote:
>
> On 23.11.2012, at 11:18, Jens Freimann wrote:
>
>> When resetting vcpus on s390/kvm we have to clear registers, psw
>> and prefix as described in the z/Architecture PoP, otherwise a
>> reboot won't work. IPL PSW and prefix are set later on by the
>> s3
On 23/11/2012 13:38, Stefan Hajnoczi wrote:
On Thu, Nov 22, 2012 at 03:50:49PM +0100, fred.kon...@greensocs.com wrote:
From: KONRAD Frederic
I made the changes you suggest in the last RFC.
There are still two issues with the command line :
* When I use ./qemu* -device virtio-blk -device v
On 23.11.2012, at 15:18, Michael S. Tsirkin wrote:
> On Fri, Nov 23, 2012 at 03:03:24PM +0100, Alexander Graf wrote:
>>
>> On 23.11.2012, at 15:01, Michael S. Tsirkin wrote:
>>
>>> On Fri, Nov 23, 2012 at 02:44:15PM +0100, Alexander Graf wrote:
On 23.11.2012, at 14:44, Michael S. Tsi
On 23 November 2012 14:23, Konrad Frederic wrote:
> On 23/11/2012 13:34, Peter Maydell wrote:
>> On 23 November 2012 12:29, Stefan Hajnoczi wrote:
>>> Eventually VirtIOBindings can probably be inlined into VirtioBusInfo. I
>>> don't see a need for separate structs.
>>
>> I agree. It might (or mi
On 23/11/2012 13:34, Peter Maydell wrote:
On 23 November 2012 12:29, Stefan Hajnoczi wrote:
On Thu, Nov 22, 2012 at 03:50:51PM +0100, fred.kon...@greensocs.com wrote:
+static const struct VirtioBusInfo virtio_bus_info = {
+.init_cb = virtio_pci_init_cb,
+.exit_cb = virtio_pci_exit_cb,
On 23/11/2012 13:23, Stefan Hajnoczi wrote:
On Thu, Nov 22, 2012 at 03:50:50PM +0100, fred.kon...@greensocs.com wrote:
+/* Bind the VirtIODevice to the VirtioBus. */
+void virtio_bus_bind_device(VirtioBus *bus)
+{
+BusState *qbus = BUS(bus);
+assert(bus != NULL);
+assert(bus->vdev !=
On Thu, Nov 22, 2012 at 9:02 PM, Christian Borntraeger
wrote:
> here are two followup patches.
>
>
> Christian Borntraeger (2):
> block: simply default_drive
> block: clarify comment about IF_IDE = 0
>
> blockdev.h |6 +-
> vl.c | 20 ++--
> 2 files changed, 11
>>Preallocation doesn't matter much these days.
I have done benchmark through nfs on a netapp san, (with directio),
I got 300 iops without preallocation, and 6000 iops with preallocation
- Mail original -
De: "Kevin Wolf"
À: "Alexandre DERUMIER"
Cc: "Dietmar Maurer" , qemu-deve
On Fri, Nov 23, 2012 at 03:03:24PM +0100, Alexander Graf wrote:
>
> On 23.11.2012, at 15:01, Michael S. Tsirkin wrote:
>
> > On Fri, Nov 23, 2012 at 02:44:15PM +0100, Alexander Graf wrote:
> >>
> >> On 23.11.2012, at 14:44, Michael S. Tsirkin wrote:
> >>
> >>> On Fri, Nov 23, 2012 at 11:59:51PM
On 23 November 2012 14:11, Stefan Hajnoczi wrote:
> On Thu, Nov 22, 2012 at 10:07 AM, Stefan Priebe wrote:
>> diff --git a/block/rbd.c b/block/rbd.c
>> index 5a0f79f..0384c6c 100644
>> --- a/block/rbd.c
>> +++ b/block/rbd.c
>> @@ -69,7 +69,7 @@ typedef enum {
>> typedef struct RBDAIOCB {
>>
On 23/11/2012 13:08, Cornelia Huck wrote:
On Thu, 22 Nov 2012 15:50:50 +0100
fred.kon...@greensocs.com wrote:
+/* Create a virtio bus. */
+VirtioBus *virtio_bus_new(DeviceState *host, const VirtioBusInfo *info)
+{
+/*
+ * This is needed, as we want to have different names for each vir
On Thu, Nov 22, 2012 at 10:07 AM, Stefan Priebe wrote:
> diff --git a/block/rbd.c b/block/rbd.c
> index 5a0f79f..0384c6c 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -69,7 +69,7 @@ typedef enum {
> typedef struct RBDAIOCB {
> BlockDriverAIOCB common;
> QEMUBH *bh;
> -int ret;
Am 23.11.2012 15:03, schrieb Alexandre DERUMIER:
> performance is also reduced when snapshot exist. (like if they are no
> preallocated metadatas)
Preallocation doesn't matter much these days.
> see initial git commit
>
> http://git.qemu.org/?p=qemu.git;a=commit;h=a35e1c177debb01240243bd656caca
performance is also reduced when snapshot exist. (like if they are no
preallocated metadatas)
see initial git commit
http://git.qemu.org/?p=qemu.git;a=commit;h=a35e1c177debb01240243bd656caca302410d38c
"qcow2: Metadata preallocation
This introduces a qemu-img create option for qcow2 which allow
On 23.11.2012, at 15:01, Michael S. Tsirkin wrote:
> On Fri, Nov 23, 2012 at 02:44:15PM +0100, Alexander Graf wrote:
>>
>> On 23.11.2012, at 14:44, Michael S. Tsirkin wrote:
>>
>>> On Fri, Nov 23, 2012 at 11:59:51PM +1100, David Gibson wrote:
> Look, even if solution using a required proper
On Fri, Nov 23, 2012 at 02:44:15PM +0100, Alexander Graf wrote:
>
> On 23.11.2012, at 14:44, Michael S. Tsirkin wrote:
>
> > On Fri, Nov 23, 2012 at 11:59:51PM +1100, David Gibson wrote:
> >>> Look, even if solution using a required property is less elegant for CLI
> >>> use, it will work, won't
On 23.11.2012, at 14:44, Michael S. Tsirkin wrote:
> On Fri, Nov 23, 2012 at 11:59:51PM +1100, David Gibson wrote:
>>> Look, even if solution using a required property is less elegant for CLI
>>> use, it will work, won't it?
>>> So how about we merge it so that things work, and then we can discus
On 23.11.2012, at 11:18, Jens Freimann wrote:
> From: Cornelia Huck
>
> Some gcc versions rightly complain about a possibly unitialized rc,
> so let's move setting it before the QTAILQ_FOREACH().
>
> Signed-off-by: Cornelia Huck
> Signed-off-by: Christian Borntraeger
> Signed-off-by: Jens Fr
On Fri, Nov 23, 2012 at 11:59:51PM +1100, David Gibson wrote:
> > Look, even if solution using a required property is less elegant for CLI
> > use, it will work, won't it?
> > So how about we merge it so that things work, and then we can discuss a
> > patch on top that auto-generates this property?
On 23.11.2012, at 11:18, Jens Freimann wrote:
> When resetting vcpus on s390/kvm we have to clear registers, psw
> and prefix as described in the z/Architecture PoP, otherwise a
> reboot won't work. IPL PSW and prefix are set later on by the
> s390-ipl device reset code.
>
> Signed-off-by: Jens
1 - 100 of 161 matches
Mail list logo
