Re: [Qemu-devel] [PATCH v2] target-cris: Fix buffer overflow

2012-09-07 Thread Edgar E. Iglesias
On Fri, Sep 07, 2012 at 10:36:08PM +0200, Stefan Weil wrote: > Report from smatch: > > target-cris/translate.c:3464 cpu_dump_state(32) error: > buffer overflow 'env->sregs' 4 <= 255 > > sregs is declared 'uint32_t sregs[4][16]', so the first index must be > less than 4 or ARRAY_SIZE(env->sregs).

Re: [Qemu-devel] QEMU (no kvm) Win7 (64bit) boot error

2012-09-07 Thread Stefan Weil
Am 08.09.2012 02:48, schrieb Clemens Kolbitsch: Hi guys, I need to run Win7 64bit in Qemu without KVM support. I found a few messages concerning the "unsupported architecture" problem (Windows shows a BSOD with "STOP 0x005D ..." on boot), for example http://lists.gnu.org/archive/html/qemu-d

Re: [Qemu-devel] [PATCH 18/21] target-cris: switch to AREG0 free mode

2012-09-07 Thread Edgar E. Iglesias
> > > case 6: > > > > > > Similarly to what I reported for the microblaze and sh4 target, I think > > > we should not start using cpu_single_env (a global variable) to replace > > > env (a global variable stored in a register). > > > > > > It is possible to pass env through the

[Qemu-devel] buildbot failure in qemu on block_mingw32

2012-09-07 Thread qemu
The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/318 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason: The

[Qemu-devel] Qemu (no kvm) Win7 (64bit) boot error

2012-09-07 Thread Clemens Kolbitsch
Hi guys, I need to run Win7 64bit in Qemu without KVM support. I found a few messages concerning the "unsupported architecture" problem (Windows shows a BSOD with "STOP 0x005D ..." on boot), for example http://lists.gnu.org/archive/html/qemu-devel/2011-03/msg01623.html or http://permalink.gma

Re: [Qemu-devel] [PATCH v2] target-mips: Implement Loongson Multimedia Instructions

2012-09-07 Thread Aurelien Jarno
On Fri, Mar 30, 2012 at 01:13:13PM -0400, Richard Henderson wrote: > Implements all of the COP2 instructions except for the S > family of comparisons. The documentation is unclear for those. > > Signed-off-by: Richard Henderson > --- > > v2: Rebased vs master. > > Makefile.target |

Re: [Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-07 Thread Don Slutz
Don Slutz wrote: On 09/07/12 18:47, Igor Mammedov wrote: On Fri, 7 Sep 2012 18:12:00 -0400 Don Slutz wrote: On 09/07/12 16:55, Igor Mammedov wrote: Signed-off-by: Igor Mammedov Acked-by: Andreas Färber -- v2: * replaced _hz suffix for frequency visitor by _freq suffix suggested-b

Re: [Qemu-devel] [PATCH] MIPS/user: Fix reset CPU state initialization

2012-09-07 Thread Aurelien Jarno
On Fri, Jun 08, 2012 at 02:04:40AM +0100, Maciej W. Rozycki wrote: > > This change updates the CPU reset sequence to use a common piece of code > that figures out CPU state flags, fixing the problem with MIPS_HFLAG_COP1X > not being set where applicable that causes floating-point MADD family >

[Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2012-09-07 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/369 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 B

[Qemu-devel] [Bug 1047576] [NEW] qemu unittest emulator failure on latest git master

2012-09-07 Thread Lucas Meneghel Rodrigues
'unittest_vm' 16:01:30 INFO | -nodefaults 16:01:30 INFO | -chardev socket,id=hmp_id_humanmonitor1,path=/tmp/monitor-humanmonitor1-20120907-155940-WomlFZY3,server,nowait 16:01:30 INFO | -mon chardev=hmp_id_humanmonitor1,mode=readline 16:01:30 INFO | -chardev socket,id=serial_i

[Qemu-devel] [Bug 1047576] Re: qemu unittest emulator failure on latest git master

2012-09-07 Thread Lucas Meneghel Rodrigues
tests/virt/kvm/qemu 16:01:30 INFO | -S 16:01:30 INFO | -name 'unittest_vm' 16:01:30 INFO | -nodefaults 16:01:30 INFO | -chardev socket,id=hmp_id_humanmonitor1,path=/tmp/monitor-humanmonitor1-20120907-155940-WomlFZY3,server,nowait 16:01:30 INF

[Qemu-devel] [Bug 1047576] Re: qemu unittest emulator failure on latest git master

2012-09-07 Thread Lucas Meneghel Rodrigues
ults 16:01:30 INFO | -chardev socket,id=hmp_id_humanmonitor1,path=/tmp/monitor-humanmonitor1-20120907-155940-WomlFZY3,server,nowait 16:01:30 INFO | -mon chardev=hmp_id_humanmonitor1,mode=readline 16:01:30 INFO | -chardev socket,id=serial_id_20120907-155940-WomlFZY3,path=/

Re: [Qemu-devel] [PATCH] iSCSI: We need to support SG_IO also from iscsi_ioctl()

2012-09-07 Thread ronnie sahlberg
ping? On Thu, Aug 30, 2012 at 5:28 PM, Ronnie Sahlberg wrote: > We need to support SG_IO from the synchronous iscsi_ioctl() since > scsi-block uses this to do an INQ to the device to discover its properties > This patch makes scsi-block work with iscsi. > > Signed-off-by: Ronnie Sahlberg > --- >

[Qemu-devel] [Bug 1047470] [NEW] qemu/kvm hangs reading from serial console

2012-09-07 Thread Buck
Public bug reported: This is for a qemu-kvm running on RHEL 5, so it's pretty old, but i think the problem still exists in 1.2 We have conman running on our hosts, connecting to the kvm/qemu's using virsh console which just opens up the console /dev/pts/slave that qemu opens up when run with

[Qemu-devel] [Bug 1047470] Re: qemu/kvm hangs reading from serial console

2012-09-07 Thread Buck
** Description changed: This is for a qemu-kvm running on RHEL 5, so it's pretty old, but i think the problem still exists in 1.2 We have conman running on our hosts, connecting to the kvm/qemu's using - virsh console + virsh console which just opens up the console /dev/pts/sl

Re: [Qemu-devel] [PATCH] iSCSI: We dont need to explicitely call qemu_notify_event() any more

2012-09-07 Thread ronnie sahlberg
Ping? On Thu, Aug 30, 2012 at 4:56 PM, Ronnie Sahlberg wrote: > We no longer need to explicitely call qemu_notify_event() any more since this > is now done automatically any time the filehandles we listen to change. > > Signed-off-by: Ronnie Sahlberg > --- > block/iscsi.c |6 -- > 1 fi

Re: [Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-07 Thread Don Slutz
On 09/07/12 18:47, Igor Mammedov wrote: On Fri, 7 Sep 2012 18:12:00 -0400 Don Slutz wrote: On 09/07/12 16:55, Igor Mammedov wrote: Signed-off-by: Igor Mammedov Acked-by: Andreas Färber -- v2: * replaced _hz suffix for frequency visitor by _freq suffix suggested-by: Andreas Färber

Re: [Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-07 Thread Igor Mammedov
On Fri, 7 Sep 2012 18:12:00 -0400 Don Slutz wrote: > On 09/07/12 16:55, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > Acked-by: Andreas Färber > > -- > > v2: > >* replaced _hz suffix for frequency visitor by _freq suffix > > suggested-by: Andreas Färber > >* fixed typo

Re: [Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-07 Thread Don Slutz
On 09/07/12 16:55, Igor Mammedov wrote: Signed-off-by: Igor Mammedov Acked-by: Andreas Färber -- v2: * replaced _hz suffix for frequency visitor by _freq suffix suggested-by: Andreas Färber * fixed typo & extra space spotted-by: Andreas Färber --- qapi/qapi-visit-core.c | 11 +

Re: [Qemu-devel] [PATCH 18/22] target-i386: parse cpu_model string into set of stringified properties

2012-09-07 Thread Don Slutz
On 09/07/12 16:55, Igor Mammedov wrote: cpu_model string does represent features in following format: ([+-]feat)|(feat=foo)|(feat) which makes it impossible directly use property infrastructure to set features on CPU. This patch introduces parser that splits CPU name from cpu_model and converts

[Qemu-devel] [PATCH 07/22] target-i386: convert cpuid features into properties

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov -- v2: * replaced mask/ffs tricks by plain 'for (bit = 0; bit < 32; bit++)' as suggested by Eduardo Habkost v3: * check if property exists before adding it * rebased on top of "i386: cpu: remove duplicate feature names" http://www.mail-archive.com/

[Qemu-devel] [PATCH 08/22] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)()

2012-09-07 Thread Igor Mammedov
It's needed for the next 3 patches to avoid build breakage when qemu is built with --disable-kvm option. Signed-off-by: Igor Mammedov Reported-by: Eduardo Habkost --- target-i386/hyperv.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target-i386/hyperv.h b/target-

[Qemu-devel] [PATCH 09/22] target-i386: convert 'hv_spinlocks' feature into property

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ae3bc9d..7d45c6c 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1203,6 +1203,32 @@ static void x86_cpuid_

[Qemu-devel] [PATCH 12/22] target-i386: convert 'check' and 'enforce' features into properties

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov -- v2: * restore original behavior, check features against host before they might be filtered out by TCG masks. spotted-by: Eduardo Habkost --- target-i386/cpu.c | 68 ++- 1 file changed, 57 insertions(+), 11 d

[Qemu-devel] [PATCH 01/22] target-i386: return Error from cpu_x86_find_by_name()

2012-09-07 Thread Igor Mammedov
it will allow to use property setters there later. Signed-off-by: Igor Mammedov -- v2: style change, add braces (reqested by Blue Swirl) --- target-i386/cpu.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index

[Qemu-devel] [PATCH 05/22] target-i386: move out CPU features initialization in separate func

2012-09-07 Thread Igor Mammedov
later it could be used in cpu_x86_find_by_name() to init CPU from found cpu_def Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- v2: - rebased on top of "i386: cpu: remove duplicate feature names" http://www.mail-archive.com/qemu-devel@nongnu.org/msg129458.html --- target-

[Qemu-devel] [PATCH 19/22] target-i386: use properties to set/unset user specified features on CPU

2012-09-07 Thread Igor Mammedov
[ehabkost: rebase on top of latest qemu.git master, where default KVM features are set differently Signed-off-by: Igor Mammedov Signed-off-by: Eduardo Habkost -- v2: * fix error of initializing from incorrect cpu model definition use x86_cpu_def instead of def. spotted-by: Eduardo Habkost

[Qemu-devel] [PATCH 15/22] target-i386: introduce vendor-override property

2012-09-07 Thread Igor Mammedov
currently 'cpuid_vendor_override' can be set only via cmd line cpu_model string. But setting it in 'vendor' property prevents using 'vendor' property on its own without setting cpuid_vendor_override. So fix/remove enabling cpuid_vendor_override from "vendor" property setter. It's up-to cpu_model s

[Qemu-devel] [PATCH 10/22] target-i386: convert 'hv_relaxed' feature into property

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 7d45c6c..6331eab 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1227,6 +1227,26 @@ static void x86_set_hv_spinloc

[Qemu-devel] [PATCH 22/22] target-i386: cleanup cpu_x86_find_by_name(), only fill x86_def_t in it

2012-09-07 Thread Igor Mammedov
Do in cpu_x86_find_by_name() only what name implies. i.e. leave only cpudef search and copy/fill passed in x86_def_t structure. and move out of it cpu_model parsing and CPU initializing into cpu_x86_register(). Plus add hints to where blocks should go when cpu_x86_register() is disbanded. Signed-

[Qemu-devel] [PATCH 06/22] target-i386: xlevel should be more than 0x80000000, move fixup into setter

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ff8c78e..cac9024 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -973,8 +973,1

[Qemu-devel] [PATCH 14/22] target-i386: use visit_type_hz to parse tsc_freq property value

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov v2: * use visit_type_freq() which replaced visit_type_hz() --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 7ff9645..1e10388 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @

[Qemu-devel] [PATCH 18/22] target-i386: parse cpu_model string into set of stringified properties

2012-09-07 Thread Igor Mammedov
cpu_model string does represent features in following format: ([+-]feat)|(feat=foo)|(feat) which makes it impossible directly use property infrastructure to set features on CPU. This patch introduces parser that splits CPU name from cpu_model and converts legacy features string into canonized set

[Qemu-devel] [PATCH 20/22] target-i386: move init of "hypervisor" feature into CPU initializer from cpudef

2012-09-07 Thread Igor Mammedov
"hypervisor" CPU feature is unconditionally enabled/overridden even if it's cleared in cpudef. Moving it inside CPU initializer from cpudef will help to split cpu_x86_find_by_name() into default init and user settable properties. Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 4 ++-- 1 fi

[Qemu-devel] [PATCH 11/22] target-i386: convert 'hv_vapic' feature into property

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 6331eab..3b802ea 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1247,6 +1247,26 @@ static void x86_set_hv_relaxed

[Qemu-devel] [PATCH 00/22 v2] target-i386: convert CPU features into properties

2012-09-07 Thread Igor Mammedov
Build and run tested in FC17 host with x86_64-linux-user, x86_64-softmmu targets git tree for testing: https://github.com/imammedo/qemu/tree/x86-cpu-properties.v2 Igor Mammedov (22): target-i386: return Error from cpu_x86_find_by_name() target-i386: cpu_x86_register(): report error from pro

[Qemu-devel] [PATCH 02/22] target-i386: cpu_x86_register(): report error from property setter

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index a89bdc4..3f80069 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1415,6 +1415,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)

Re: [Qemu-devel] [PATCH] target-xtensa: fix missing errno codes for mingw32

2012-09-07 Thread Max Filippov
On Sat, Sep 8, 2012 at 12:22 AM, Stefan Weil wrote: > Am 06.09.2012 14:48, schrieb Max Filippov: > >> On Thu, Sep 6, 2012 at 8:45 AM, Stefan Weil wrote: >>> >>> Am 06.09.2012 02:36, schrieb Max Filippov: >>> Put the following errno value mappings under #ifdef: xtensa-semi.c: In fun

[Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Acked-by: Andreas Färber -- v2: * replaced _hz suffix for frequency visitor by _freq suffix suggested-by: Andreas Färber * fixed typo & extra space spotted-by: Andreas Färber --- qapi/qapi-visit-core.c | 11 +++ qapi/qapi-visit-core.h | 2 +

[Qemu-devel] [PATCH 17/22] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2012-09-07 Thread Igor Mammedov
Vendor property setter takes string as vendor value but cpudefs use uint32_t vendor[123] fields to define vendor value. It makes it difficult to unify and use property setter for values from cpudefs. To allow simplify code by using vendor property setter, vendor[123] fields are converted into vend

[Qemu-devel] [PATCH 04/22] target-i386: filter out not TCG features if running without kvm at realize time

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 3f80069..567ad69 100644 --- a/target-i386/cp

Re: [Qemu-devel] [PATCH 00/22 v2] target-i386: convert CPU features into properties

2012-09-07 Thread Igor Mammedov
On Fri, 7 Sep 2012 22:54:49 +0200 Igor Mammedov wrote: > git tree for testing: > https://github.com/imammedo/qemu/tree/x86-cpu-properties.v2 > here are series it depends on: [Qemu-devel] [PATCH 0/7] x86 CPU patches that didn't get into 1.2 http://www.mail-archive.com/qemu-devel@nongnu.org/ms

[Qemu-devel] [PATCH 03/22] target-i386: if x86_cpu_realize() failed report error and do cleanup

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Acked-by: Andreas Färber --- target-i386/helper.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 8a5da3d..a0e4c89 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -1151,6 +

[Qemu-devel] [PATCH 16/22] target-i386: use define for cpuid vendor string size

2012-09-07 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 6 +++--- target-i386/cpu.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 5362fe6..8b021a2 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1102,13 +1102,13 @@ stati

[Qemu-devel] [PATCH 21/22] target-i386: move default init of cpuid_kvm_features bitmap into CPU initializer from cpudef

2012-09-07 Thread Igor Mammedov
Moving it inside CPU initializer from cpudef will help to split cpu_x86_find_by_name() into default init and user settable properties. [ehabkost: rebase on top of latest qemu.git master, where the bitmap initialization is now different] [imammedo: fix whitespace Signed-off-by: Igor Mammedov Sign

Re: [Qemu-devel] [PATCH 2/3] g3beige: add a video card only when requested

2012-09-07 Thread Alexander Graf
On 07.09.2012, at 22:45, Aurelien Jarno wrote: > On Fri, Sep 07, 2012 at 08:58:06PM +0200, Alexander Graf wrote: >> >> >> On 07.09.2012, at 17:27, Aurelien Jarno wrote: >> >>> The g3beige machine always add a video card, even when the "-vga none" >>> is passed. Fix that by checking if it is e

Re: [Qemu-devel] [PATCH 2/3] g3beige: add a video card only when requested

2012-09-07 Thread Alexander Graf
On 07.09.2012, at 22:45, Aurelien Jarno wrote: > On Fri, Sep 07, 2012 at 08:58:06PM +0200, Alexander Graf wrote: >> >> >> On 07.09.2012, at 17:27, Aurelien Jarno wrote: >> >>> The g3beige machine always add a video card, even when the "-vga none" >>> is passed. Fix that by checking if it is e

Re: [Qemu-devel] [PATCH 2/3] g3beige: add a video card only when requested

2012-09-07 Thread Aurelien Jarno
On Fri, Sep 07, 2012 at 08:58:06PM +0200, Alexander Graf wrote: > > > On 07.09.2012, at 17:27, Aurelien Jarno wrote: > > > The g3beige machine always add a video card, even when the "-vga none" > > is passed. Fix that by checking if it is enabled or not before > > instanciating it. > > > > Cc:

[Qemu-devel] [PATCH v2] target-cris: Fix buffer overflow

2012-09-07 Thread Stefan Weil
Report from smatch: target-cris/translate.c:3464 cpu_dump_state(32) error: buffer overflow 'env->sregs' 4 <= 255 sregs is declared 'uint32_t sregs[4][16]', so the first index must be less than 4 or ARRAY_SIZE(env->sregs). Signed-off-by: Stefan Weil --- I did not fix tabs, therefore checkpatch

Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 21:23, Nicholas A. Bellinger ha scritto: >> > Please create a completely separate device vhost-scsi-pci instead (or >> > virtio-scsi-tcm-pci, or something like that). It is used completely >> > differently from virtio-scsi-pci, it does not make sense to conflate the >> > two. >> > >

Re: [Qemu-devel] [RFC v2] Migration thread

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 21:52, Juan Quintela ha scritto: > This is the breakpoint. > > buffered_file: Move from using a timer to use a thread > > Everything before this could be integrated Today, from there, it needs > still more 'thought". True, on the other hand, the split ramlist mutex etc. would be

Re: [Qemu-devel] [PATCH] target-xtensa: fix missing errno codes for mingw32

2012-09-07 Thread Stefan Weil
Am 06.09.2012 14:48, schrieb Max Filippov: On Thu, Sep 6, 2012 at 8:45 AM, Stefan Weil wrote: Am 06.09.2012 02:36, schrieb Max Filippov: Put the following errno value mappings under #ifdef: xtensa-semi.c: In function 'errno_h2g': xtensa-semi.c:113: error: 'ENOTBLK' undeclared (first use in t

Re: [Qemu-devel] [PATCH 2/3] g3beige: add a video card only when requested

2012-09-07 Thread Alexander Graf
On 07.09.2012, at 17:27, Aurelien Jarno wrote: > The g3beige machine always add a video card, even when the "-vga none" > is passed. Fix that by checking if it is enabled or not before > instanciating it. > > Cc: Alexander Graf > Signed-off-by: Aurelien Jarno > --- > hw/ppc_oldworld.c |4

Re: [Qemu-devel] [RFC v2] Migration thread

2012-09-07 Thread Juan Quintela
Paolo Bonzini wrote: > Il 07/09/2012 18:23, Juan Quintela ha scritto: >> >> Hi >> >> here is v2 of the migration thread series. There is still some "issues" >> with locking in the error paths (they are at 54 patches now). >> >> Changes from v1: >> - migration stats series are included >> - mig

[Qemu-devel] [PATCH] qxl: Ignore set_client_capabilities pre/post migrate

2012-09-07 Thread Hans de Goede
The recent introduction of set_client_capabilities has broken (seamless) migration by trying to call qxl_send_events pre (seamless incoming) and post (*) migration, triggering the following assert: qxl_send_events: Assertion `qemu_spice_display_is_running(&d->ssd)' failed. The solution is easy, pr

[Qemu-devel] [PULL for usb-next]: Add support for live-migration to usb-redir (v2)

2012-09-07 Thread Hans de Goede
Hi Gerd, I'm very happy to present to you a pull-request for usb-redir live-migration support. I've tested this combined with Spice seamless migration, and it can successful: 1) migrate a vm while running "dd if=/dev/zero of=/dev/sdb1 bs=32K" inside the guest with sdb being a redirect USB-2 mass

Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-07 Thread Nicholas A. Bellinger
On Fri, 2012-09-07 at 18:00 +0200, Paolo Bonzini wrote: > Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: > > Cc: Stefan Hajnoczi > > Cc: Zhi Yong Wu > > Cc: Michael S. Tsirkin > > Cc: Paolo Bonzini > > Signed-off-by: Nicholas Bellinger > > --- > > hw/virtio-pci.c |2 ++ > > hw/vi

Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller

2012-09-07 Thread Scott Wood
On 09/07/2012 03:08 AM, Alexander Graf wrote: > > > On 07.09.2012, at 01:15, Scott Wood wrote: > >> On 09/03/2012 01:44 AM, Bhushan Bharat-R65777 wrote: >>> >>> -Original Message- From: Wood Scott-B07421 Sent: Wednesday, August 15, 2012 6:59 AM To: Bhushan Bharat-R65777 Cc: >>

Re: [Qemu-devel] [PULL for usb-next]: Add support for live-migration to usb-redir

2012-09-07 Thread Hans de Goede
Hi, On 09/07/2012 01:47 PM, Hans de Goede wrote: Hi Gerd, I'm very happy to present to you a pull-request for usb-redir live-migration support. I've tested this combined with Spice seamless migration, and it can successful: 1) migrate a vm while running "dd if=/dev/zero of=/dev/sdb1 bs=32K" ins

Re: [Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to a generic block_job_cb

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 19:04, Jeff Cody ha scritto: > On 09/07/2012 12:27 PM, Paolo Bonzini wrote: >> Il 30/08/2012 20:47, Jeff Cody ha scritto: >>> @@ -53,6 +53,8 @@ static const int if_max_devs[IF_COUNT] = { >>> [IF_SCSI] = 7, >>> }; >>> >>> +static void block_job_cb(void *opaque, int ret); >>> +

Re: [Qemu-devel] [RFC v2] Migration thread

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 18:23, Juan Quintela ha scritto: > > Hi > > here is v2 of the migration thread series. There is still some "issues" > with locking in the error paths (they are at 54 patches now). > > Changes from v1: > - migration stats series are included > - migration bitmap sync trace-events t

Re: [Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to a generic block_job_cb

2012-09-07 Thread Jeff Cody
On 09/07/2012 12:27 PM, Paolo Bonzini wrote: > Il 30/08/2012 20:47, Jeff Cody ha scritto: >> @@ -53,6 +53,8 @@ static const int if_max_devs[IF_COUNT] = { >> [IF_SCSI] = 7, >> }; >> >> +static void block_job_cb(void *opaque, int ret); >> + >> /* >> * We automatically delete the drive when

Re: [Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to a generic block_job_cb

2012-09-07 Thread Paolo Bonzini
Il 30/08/2012 20:47, Jeff Cody ha scritto: > @@ -53,6 +53,8 @@ static const int if_max_devs[IF_COUNT] = { > [IF_SCSI] = 7, > }; > > +static void block_job_cb(void *opaque, int ret); > + > /* > * We automatically delete the drive when a device using it gets > * unplugged. Questionable

[Qemu-devel] [RFC v2] Migration thread

2012-09-07 Thread Juan Quintela
Hi here is v2 of the migration thread series. There is still some "issues" with locking in the error paths (they are at 54 patches now). Changes from v1: - migration stats series are included - migration bitmap sync trace-events to know how long it takes - file->last_error use almost removed

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-07 Thread Kevin Wolf
Am 07.09.2012 17:50, schrieb Paolo Bonzini: > Il 27/08/2012 17:00, Paolo Bonzini ha scritto: >> The part where I need >> a second opinion and/or ack is patch 12 and 13. They fix the case of >> a disk being unplugged while NBD export is active. To do this I add a >> NotifierList to a BlockDriverSt

[Qemu-devel] Linux KVM, Windows 7 guest choppy sound

2012-09-07 Thread Erik Lotspeich
Hi, I apologize if this isn't the right venue for this message, but this mailing list seems a bit more active than qemu-discuss. Background: I am running OpenSUSE 12.1. I fixed audio issues in VM guests by setting the following in qemu.conf: vnc_allow_host_audio = 1 I also set user= and group=

Re: [Qemu-devel] [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: > Cc: Stefan Hajnoczi > Cc: Zhi Yong Wu > Cc: Michael S. Tsirkin > Cc: Paolo Bonzini > Signed-off-by: Nicholas Bellinger > --- > hw/virtio-pci.c |2 ++ > hw/virtio-scsi.c | 49 + > hw

Re: [Qemu-devel] [RFC v2 PATCH 2/6] block: add live block commit functionality

2012-09-07 Thread Jeff Cody
On 09/06/2012 05:16 PM, Eric Blake wrote: > On 09/06/2012 02:37 PM, Jeff Cody wrote: >> On 09/06/2012 10:00 AM, Kevin Wolf wrote: >>> Am 30.08.2012 20:47, schrieb Jeff Cody: This adds the live commit coroutine. This iteration focuses on the commit only below the active layer, and not the

[Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-07 Thread Paolo Bonzini
Il 27/08/2012 17:00, Paolo Bonzini ha scritto: > The part where I need > a second opinion and/or ack is patch 12 and 13. They fix the case of > a disk being unplugged while NBD export is active. To do this I add a > NotifierList to a BlockDriverState. Does this look okay, or is it too > ad hoc?

Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

2012-09-07 Thread Aurelien Jarno
On Fri, Sep 07, 2012 at 04:04:16PM +0100, Peter Maydell wrote: > On 7 September 2012 15:56, Aurelien Jarno wrote: > > On Thu, Aug 23, 2012 at 05:39:39PM +0200, Aurelien Jarno wrote: > >> The lan9118 emulation tries to compute the multicast index by calling > >> directly the crc32() function from z

[Qemu-devel] [PATCH 3/3] mac99: add a video card only when requested

2012-09-07 Thread Aurelien Jarno
The mac99 machine always add a video card, even when the "-vga none" is passed. Fix that by checking if it is enabled or not before instanciating it. Cc: Alexander Graf Signed-off-by: Aurelien Jarno --- hw/ppc_newworld.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PATCH 1/3] sun4u: add a video card only when requested

2012-09-07 Thread Aurelien Jarno
The sun4u machine always add a video card, even when "-vga none" is passed. Fix that by checking if it is enabled or not before instanciating it. Cc: Blue Swirl Signed-off-by: Aurelien Jarno --- hw/sun4u.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/sun4u.c b/hw

[Qemu-devel] [PATCH 2/3] g3beige: add a video card only when requested

2012-09-07 Thread Aurelien Jarno
The g3beige machine always add a video card, even when the "-vga none" is passed. Fix that by checking if it is enabled or not before instanciating it. Cc: Alexander Graf Signed-off-by: Aurelien Jarno --- hw/ppc_oldworld.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-07 Thread Peter Maydell
On 7 September 2012 15:53, Jan Kiszka wrote: > On 2012-09-07 16:41, Peter Maydell wrote: >> On 7 September 2012 00:03, Jan Kiszka wrote: >>> +pflash_cfi02_register(0x1-MP_FLASH_SIZE_MAX, NULL, >> >> I don't think this will compile on a 32 bit system, will it? >> You probably want

Re: [Qemu-devel] [RFC v2 PATCH 1/6] block: add support functions for live commit, to find and delete images.

2012-09-07 Thread Jeff Cody
On 09/07/2012 06:19 AM, Kevin Wolf wrote: > Am 06.09.2012 16:59, schrieb Jeff Cody: >> On 09/06/2012 09:23 AM, Kevin Wolf wrote: >>> Am 30.08.2012 20:47, schrieb Jeff Cody: Add bdrv_find_child(), and bdrv_delete_intermediate(). bdrv_find_child(): given 'bs' and the active (topmost)

[Qemu-devel] [PATCH] target-sparc: fix fcmp{s, d, q} instructions wrt exception

2012-09-07 Thread Aurelien Jarno
fcmp{s,d,q} instructions are supposed to ignore quiet NaN (contrary to the fcmpe{s,d,q} instructions), but the current code is wrongly setting the NV exception in that case. Moreover the current code is duplicated: first the arguments are checked for NaN to generate an exception, and later in case

[Qemu-devel] [PATCH] pflash_cfi01: fix vendor specific extended query

2012-09-07 Thread Aurelien Jarno
pflash_cfi01 announces a version number of 1.1, which implies "Protection Register Information" and "Burst Read information" sections, which are not provided. Decrease the version number to 1.0 so that only the "Protection Register Information" section is needed. Set the number of protection fiel

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 17:06, Bharata B Rao ha scritto: > qemu_gluster_aio_event_reader() is the node->io_read in qemu_aio_wait(). > > qemu_aio_wait() calls node->io_read() which calls qemu_gluster_complete_aio(). > Before we return back to qemu_aio_wait(), many other things happen: > > bdrv_close() gets

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-07 Thread Bharata B Rao
On Thu, Sep 06, 2012 at 12:29:30PM +0200, Kevin Wolf wrote: > Am 06.09.2012 12:18, schrieb Paolo Bonzini: > > Il 06/09/2012 12:07, Kevin Wolf ha scritto: > >>> The AIOCB is already invalid at the time the callback is entered, so we > >>> could release it before the call. However, not all implement

Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

2012-09-07 Thread Peter Maydell
On 7 September 2012 15:56, Aurelien Jarno wrote: > On Thu, Aug 23, 2012 at 05:39:39PM +0200, Aurelien Jarno wrote: >> The lan9118 emulation tries to compute the multicast index by calling >> directly the crc32() function from zlib, but fails to get the correct >> result. >> >> Use the common compu

Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

2012-09-07 Thread Aurelien Jarno
On Thu, Aug 23, 2012 at 05:39:39PM +0200, Aurelien Jarno wrote: > The lan9118 emulation tries to compute the multicast index by calling > directly the crc32() function from zlib, but fails to get the correct > result. > > Use the common compute_mcast_idx() function instead, which gives the > corre

Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-07 Thread Jan Kiszka
On 2012-09-07 16:41, Peter Maydell wrote: > On 7 September 2012 00:03, Jan Kiszka wrote: >> The old arithmetic assumed 32 physical address bits which is no longer >> true for ARM since 3cc0cd61f4. >> >> Signed-off-by: Jan Kiszka >> --- >> hw/musicpal.c |4 ++-- >> 1 files changed, 2 insertio

Re: [Qemu-devel] qemu 1.2 : lsi controller + scsi-block don't boot.

2012-09-07 Thread Alexandre DERUMIER
Thanks, But Why does it work with lsi + scsi-hd and not scsi-block? For now I'll use scsi-hd for these (very old) guests, it's not a problem. - Mail original - De: "Paolo Bonzini" À: "Alexandre DERUMIER" Cc: qemu-devel@nongnu.org Envoyé: Vendredi 7 Septembre 2012 16:48:39 Objet: Re:

Re: [Qemu-devel] qemu 1.2 : lsi controller + scsi-block don't boot.

2012-09-07 Thread Paolo Bonzini
Il 07/09/2012 14:35, Alexandre DERUMIER ha scritto: > I'm trying to boot scsi-block device with lsi controller, and it doesn't > boot. (don't find devices). > > > lsi + scsi-block : don't boot > > lsi + scsi-hd : boot > > virtio-scsi + scsi-block : boot The LSI driver in SeaBIOS is really a

Re: [Qemu-devel] [PATCH 18/21] target-cris: switch to AREG0 free mode

2012-09-07 Thread Aurelien Jarno
On Fri, Sep 07, 2012 at 04:40:03PM +0200, Edgar E. Iglesias wrote: > On Fri, Sep 07, 2012 at 04:18:41PM +0200, Aurelien Jarno wrote: > > On Sun, Sep 02, 2012 at 05:33:47PM +, Blue Swirl wrote: > > > Add an explicit CPUState parameter instead of relying on AREG0 > > > and switch to AREG0 free mo

[Qemu-devel] [Bug 962880] Re: having a tr_TR.UTF-8 locale creates problems during compile

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/962880 Title: having a tr_TR.UTF-8 locale creates problems during compile Status in Q

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/957622 Title: kvm -kernel with grub multiboot kernel dumps core or exits Status in QE

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-07 Thread Aurelien Jarno
On Fri, Sep 07, 2012 at 04:30:51PM +0200, Andreas Färber wrote: > Am 07.09.2012 06:26, schrieb Alexander Graf: > > Quoting Richard Henderson : > > > >> On 09/06/2012 11:42 AM, Alexander Graf wrote: > >>> Richard, while at it, could you please check the s390x tcg target? > >>> Running any target on

Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-07 Thread Peter Maydell
On 7 September 2012 00:03, Jan Kiszka wrote: > The old arithmetic assumed 32 physical address bits which is no longer > true for ARM since 3cc0cd61f4. > > Signed-off-by: Jan Kiszka > --- > hw/musicpal.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/musicpal.

[Qemu-devel] [Bug 1022331] Re: -cpu ? causes confusion when directory has 1-character length filenames

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1022331 Title: -cpu ? causes confusion when directory has 1-character length filenam

Re: [Qemu-devel] [PATCH] configure: fix seccomp check

2012-09-07 Thread Andreas Färber
Am 06.09.2012 22:40, schrieb Yann E. MORIN: > Currently, if libseccomp is missing but the user explicitly requested > seccomp support using --enable-seccomp, configure silently ignores the > situation and disables seccomp support. > > This is unlike all other tests that explicitly fail in such sit

Re: [Qemu-devel] [PATCH 18/21] target-cris: switch to AREG0 free mode

2012-09-07 Thread Edgar E. Iglesias
On Fri, Sep 07, 2012 at 04:18:41PM +0200, Aurelien Jarno wrote: > On Sun, Sep 02, 2012 at 05:33:47PM +, Blue Swirl wrote: > > Add an explicit CPUState parameter instead of relying on AREG0 > > and switch to AREG0 free mode. > > > > Signed-off-by: Blue Swirl > > --- > > configure

[Qemu-devel] [Bug 584121] Re: migration always fails on 32bit qemu-kvm-0.12+ (sigsegv)

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/584121 Title: migration always fails on 32bit qemu-kvm-0.12+ (sigsegv) Status in QEMU

[Qemu-devel] [Bug 948675] Re: QEMU is crashing when called with "-vga none"

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/948675 Title: QEMU is crashing when called with "-vga none" Status in QEMU: Fix Rel

[Qemu-devel] [Bug 1044727] Re: -kernel does not work for multiboot ELF kernels

2012-09-07 Thread Aurelien Jarno
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1044727 Title: -kernel does not work for multiboot ELF kernels Status in QEMU: Fix Committed

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-07 Thread Andreas Färber
Am 07.09.2012 06:26, schrieb Alexander Graf: > Quoting Richard Henderson : > >> On 09/06/2012 11:42 AM, Alexander Graf wrote: >>> Richard, while at it, could you please check the s390x tcg target? >>> Running any target on there seems to break in the TLB code for me. >> >> I did successfully run a

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-09-07 Thread Corey Bryant
On 09/07/2012 06:40 AM, Kevin Wolf wrote: Am 06.09.2012 17:34, schrieb Corey Bryant: On 09/06/2012 05:23 AM, Kevin Wolf wrote: Am 05.09.2012 18:43, schrieb Jeff Cody: +} + +int fcntl_flags = O_APPEND | O_ASYNC | O_NONBLOCK; +#ifdef O_NOATIME +fcntl_flags |= O_NOATIME; +#endif +

Re: [Qemu-devel] [PATCH v2] qom: Reject attempts to add a property that already exists

2012-09-07 Thread Andreas Färber
Am 07.09.2012 15:55, schrieb Peter Maydell: > Reject attempts to add a property to an object if one of > that name already exists. This is always a bug in the caller; > this is merely diagnosing it gracefully rather than behaving > oddly later. > > Signed-off-by: Peter Maydell Looks fine to me,

Re: [Qemu-devel] [PATCH] fix entry pointer for ELF kernels loaded with -kernel option

2012-09-07 Thread Aurelien Jarno
On Wed, Sep 05, 2012 at 03:11:13PM +0200, Kevin Wolf wrote: > Am 05.09.2012 14:56, schrieb Henning Schild: > > Find a hopefully proper patch attached. Take it or leave it. > > > > Signed-off-by: Henning Schild > > Reviewed-by: Kevin Wolf > > Aurelien, I think in the past you committed some c

[Qemu-devel] [PATCH v2 3/9] tcg/optimize: simplify or/xor r, a, 0 cases

2012-09-07 Thread Aurelien Jarno
or/xor r, a, 0 is equivalent to a mov r, a. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/optimize.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 63f970d..0db849e 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -331,6

  1   2   >