On 2012-09-07 16:41, Peter Maydell wrote: > On 7 September 2012 00:03, Jan Kiszka <jan.kis...@web.de> wrote: >> The old arithmetic assumed 32 physical address bits which is no longer >> true for ARM since 3cc0cd61f4. >> >> Signed-off-by: Jan Kiszka <jan.kis...@web.de> >> --- >> hw/musicpal.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/hw/musicpal.c b/hw/musicpal.c >> index ad725b5..10c2c16 100644 >> --- a/hw/musicpal.c >> +++ b/hw/musicpal.c >> @@ -1583,7 +1583,7 @@ static void musicpal_init(ram_addr_t ram_size, >> * image is smaller than 32 MB. >> */ >> #ifdef TARGET_WORDS_BIGENDIAN >> - pflash_cfi02_register(0-MP_FLASH_SIZE_MAX, NULL, >> + pflash_cfi02_register(0x100000000-MP_FLASH_SIZE_MAX, NULL, > > I don't think this will compile on a 32 bit system, will it? > You probably want an ULL suffix.
It does as the result always fits in 32 bits. But I can add that if you prefer. Jan
signature.asc
Description: OpenPGP digital signature
