Re: [Qemu-devel] Network Passthrough configuration!

2012-08-24 Thread Stefan Hajnoczi
On Sat, Aug 25, 2012 at 5:35 AM, GaoYi wrote: > Hi all, > >I am trying to implement pci passthrough for network card according to > this guideline: > http://www.linux-kvm.org/page/How_to_assign_devices_with_VT-d_in_KVM. >The configuration steps were all ok. However, when I started the gues

[Qemu-devel] [Bug 1036363] Re: Major network performance problems on AMD hardware

2012-08-24 Thread Ziemowit Pierzycki
I ran another test and here is a recap: F16 KVM <-- 20gbps --> F16 VM F17 KVM <-- 4 gbps --> 16 VM F17 KVM <-- 4 gbps --> 17 VM I'll check F16 KVM with both F16 and F17 VMs. This is all done on my Intel core i3. -- You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] Network Passthrough configuration!

2012-08-24 Thread GaoYi
Hi all, I am trying to implement pci passthrough for network card according to this guideline: http://www.linux-kvm.org/page/How_to_assign_devices_with_VT-d_in_KVM. The configuration steps were all ok. However, when I started the guest by: qemu-img -boot c -hda readhat.img -devi

[Qemu-devel] [Bug 1036363] Re: Major network performance problems on AMD hardware

2012-08-24 Thread Ziemowit Pierzycki
Well this is embarrasing. Other Intel KVMs are having the same problem. The test where I got 20 gbps was actually on a Fedora 16 VM running on Fedora 16 KVM. I reinstalled both KVM and VM with Fedora 17 and best I got was 4 gbps. -- You received this bug notification because you are a member of

[Qemu-devel] How to add new architecture?

2012-08-24 Thread Michael Eager
Is there a description of how to add a new processor architecture to QEMU? I looked at the Wiki and at the QEMU-Buch, but there doesn't seem to be anything on topic. -- Michael Eagerea...@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077

[Qemu-devel] [RFC] Rewrite target-s390x

2012-08-24 Thread Richard Henderson
I wanted to add some new insns, so that I could start testing gcc changes for z10+, but found the more or less ad-hoc disassembly routines difficult and error prone. I've begun rewriting the translator into a more table-driven approach, which I have so far found much easier to manage. I'd hoped t

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread Peter Maydell
On 24 August 2012 19:43, Andreas Färber wrote: > Depends on what you mean with "disable"? Adding an #error would hurt our > arm build just like earlier the ppc build, and I would hope from my last > testing that the problems would only affect the AREG0 targets, > especially not ARM on ARM (or MIPS

[Qemu-devel] [PATCH 3/4] qxl: implement VirtIO QXL (dummy) device support

2012-08-24 Thread Erlon Cruz
From: Fabiano Fidêncio This commit introduces the devices stubs that use Virtio infrastructure to transport QXL commands. Signed-off-by: Erlon R. Cruz Signed-off-by: Fabiano Fidêncio Signed-off-by: Rafael F. Santos --- hw/i386/Makefile.objs |2 +- hw/pci.h |1 + hw/qxl-v

[Qemu-devel] [PATCH 4/4] qxl: introducing virtio-qxl

2012-08-24 Thread Erlon Cruz
From: Fabiano Fidêncio The VirtioQXL device is a graphical video device that makes possible to use of SPICE protocol over virtio transport. QXL commands are generated in the guest xf86 driver and pushed to host through in a single VQ. The commands are copied to device memory and then consumed by

[Qemu-devel] Implementing qxl-virtio on QEMU

2012-08-24 Thread Erlon Cruz
The following patches makes provides video support to non PCI architectures, please review!

Re: [Qemu-devel] [PATCH] linux-user: If loading fails, print error as string, not number

2012-08-24 Thread Andreas Färber
Am 24.08.2012 20:07, schrieb malc: > On Fri, 24 Aug 2012, Peter Maydell wrote: > >> If the attempt to load the guest executable fails, print the >> error message as a string, not a number. This requires us to >> fix a couple of places in loader_exec() where we were returning >> -1 instead of a val

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread Aurelien Jarno
On Fri, Aug 24, 2012 at 08:43:32PM +0200, Andreas Färber wrote: > Am 24.08.2012 20:05, schrieb Aurelien Jarno: > > On Fri, Aug 24, 2012 at 05:52:29PM +0200, Andreas Färber wrote: > >> Not opposed to changing the argument order, but given that we're inches > >> away from v1.2 (in Hard Freeze), it mi

Re: [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases

2012-08-24 Thread BALATON Zoltan
On Fri, 24 Aug 2012, Peter Maydell wrote: I think all this code needs careful auditing to (a) clearly define what "bpp" means and what "depth" means (assuming we need to distinguish; IME they are usually supposed to be synonyms!) and (b) make sure that everything that accesses one or the other is

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread Andreas Färber
Am 24.08.2012 20:05, schrieb Aurelien Jarno: > On Fri, Aug 24, 2012 at 05:52:29PM +0200, Andreas Färber wrote: >> Not opposed to changing the argument order, but given that we're inches >> away from v1.2 (in Hard Freeze), it might be better to first get AREG0 >> as first argument working for your f

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread Andreas Färber
Am 24.08.2012 18:26, schrieb malc: > On Fri, 24 Aug 2012, Andreas F?rber wrote: > >> Am 24.08.2012 17:35, schrieb malc: >>> On Fri, 24 Aug 2012, malc wrote: >>> On Fri, 24 Aug 2012, Aurelien Jarno wrote: > On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: >>> >>> [..snip..]

Re: [Qemu-devel] [PATCH] linux-user: If loading fails, print error as string, not number

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Peter Maydell wrote: > If the attempt to load the guest executable fails, print the > error message as a string, not a number. This requires us to > fix a couple of places in loader_exec() where we were returning > -1 instead of a valid negative errno. > > The change allows u

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread Aurelien Jarno
On Fri, Aug 24, 2012 at 05:52:29PM +0200, Andreas Färber wrote: > Am 24.08.2012 17:35, schrieb malc: > > On Fri, 24 Aug 2012, malc wrote: > > > >> On Fri, 24 Aug 2012, Aurelien Jarno wrote: > >> > >>> On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: > > > > [..snip..] > > > >>> - On 3

Re: [Qemu-devel] [PATCH v2][for 1.2?] msix: Drop tracking of used vectors

2012-08-24 Thread Cam Macdonell
On Fri, Aug 24, 2012 at 12:19 AM, Jan Kiszka wrote: > From: Jan Kiszka > > This optimization was once used in qemu-kvm to keep KVM route usage low. > But now we solved that problem via lazy updates. It also tried to handle > the case of vectors shared between different sources of the same device.

Re: [Qemu-devel] qemu-kvm 1.1.1 hangs using 100% CPU when using ES1370 emulation

2012-08-24 Thread Michael Tokarev
Hello Mike, Vassili. On 23.08.2012 20:16, Mike Gerber wrote: > Hi, > > I'm using a KVM guest to stream audio using darkice to an icecast2 server on > the > same guest. The guest uses an emulated ES1370 sound card to capture the host's > audio input (ASUS Xonar DX) using the ALSA backend. After 1

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier

2012-08-24 Thread Stefan Weil
Am 24.08.2012 13:56, schrieb Stefan Hajnoczi: On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell wrote: On 24 August 2012 11:54, Stefan Hajnoczi wrote: On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote: This allows using qemu_irq in the target specific cpu.h. Signed-off-by: Stefan W

[Qemu-devel] [PATCH] linux-user: If loading fails, print error as string, not number

2012-08-24 Thread Peter Maydell
If the attempt to load the guest executable fails, print the error message as a string, not a number. This requires us to fix a couple of places in loader_exec() where we were returning -1 instead of a valid negative errno. The change allows us to drop the "Unknown binary format" message because t

Re: [Qemu-devel] [PATCH v2] Fix copy&paste typos in documentation comments

2012-08-24 Thread Andreas Färber
Am 22.08.2012 17:18, schrieb BALATON Zoltan: > > Signed-off-by: BALATON Zoltan > --- > memory.h | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > v2: indented memory_region_init_ram_ptr > > diff --git a/memory.h b/memory.h > index bd1bbae..f6c8e32 100644 > --- a/memory

Re: [Qemu-devel] [RFC v2] ahci: Add support for migration

2012-08-24 Thread Jason Baron
On Thu, Aug 09, 2012 at 10:49:23AM -0400, Jason Baron wrote: > On Thu, Aug 09, 2012 at 02:59:54PM +0200, Andreas Färber wrote: > > Define generic VMState for AHCI and reuse it together with PCI for ICH > > and on its own for the SysBus version. > > > > Note: ICH9 initializes AHCI with 6 ports, whi

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Andreas F?rber wrote: > Am 24.08.2012 17:35, schrieb malc: > > On Fri, 24 Aug 2012, malc wrote: > > > >> On Fri, 24 Aug 2012, Aurelien Jarno wrote: > >> > >>> On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: > > > > [..snip..] > > > >>> - On 32 bit hosts, which u

Re: [Qemu-devel] [PATCH V5 8/8] smb: replace_register_ioport*

2012-08-24 Thread Jan Kiszka
On 2012-08-22 14:27, Julien Grall wrote: > This patch fix smb_ioport_* to be compliant with read/write memory callback. > Moreover it replaces all register_ioport* which use theses functions by > the new Memory API. > > Signed-off-by: Julien Grall > --- > hw/pm_smbus.c |7 --- > hw/pm_sm

Re: [Qemu-devel] [PATCH V5 1/8] isa: add isa_address_space_io

2012-08-24 Thread Andreas Färber
Am 22.08.2012 14:27, schrieb Julien Grall: > This function permits to retrieve ISA IO address space. > It will be usefull when we need to pass IO address space as argument. > > Signed-off-by: Julien Grall > --- > hw/isa-bus.c |5 + > hw/isa.h |1 + > 2 files changed, 6 insertions

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread Andreas Färber
Am 24.08.2012 17:35, schrieb malc: > On Fri, 24 Aug 2012, malc wrote: > >> On Fri, 24 Aug 2012, Aurelien Jarno wrote: >> >>> On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: > > [..snip..] > >>> - On 32 bit hosts, which usually need register alignments for 64-bit >>> values (at leas

Re: [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases

2012-08-24 Thread Peter Maydell
On 24 August 2012 16:24, BALATON Zoltan wrote: > The above > bits_per_pixel=16 for 15 bpp case was there already I just added a comment > marking it as suspicious but I'm not sure how to resolve that. It is certainly a bug somewhere, since ds_get_bits_per_pixel() just returns the pixelformat bits

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread malc
On Fri, 24 Aug 2012, malc wrote: > On Fri, 24 Aug 2012, Aurelien Jarno wrote: > > > On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: [..snip..] > > - On 32 bit hosts, which usually need register alignments for 64-bit > > values (at least on arm and mips), given AREG0 is a 32-bit va

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Aurelien Jarno wrote: > On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: > > Optionally, make memory access helpers take a parameter for CPUState > > instead of relying on global env. > > > > On most targets, perform simple moves to reorder registers. On i386, > >

Re: [Qemu-devel] [PATCH] Add guest-get-hostname to retrieve the guests current hostname

2012-08-24 Thread Guido Günther
On Wed, Aug 22, 2012 at 09:32:02AM +0100, Daniel P. Berrange wrote: > On Wed, Aug 22, 2012 at 10:04:33AM +0200, Guido Günther wrote: > > On Tue, Aug 21, 2012 at 07:31:17PM +0100, Daniel P. Berrange wrote: > > > On Tue, Aug 21, 2012 at 01:57:54PM +0200, Guido Günther wrote: > > [..snip..] > > > > >

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-24 Thread Luiz Capitulino
On Fri, 24 Aug 2012 07:34:51 -0700 Alexander Graf wrote: > > > Am 24.08.2012 um 07:18 schrieb Luiz Capitulino : > > > On Thu, 23 Aug 2012 17:09:25 -0400 > > Jason Baron wrote: > > > >> While testing q35, I found that windows 7 (specifically, windows 7 ultimate > >> with sp1 x64), wouldn't in

Re: [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases

2012-08-24 Thread BALATON Zoltan
On Fri, 24 Aug 2012, Stefan Hajnoczi wrote: +case 15: +pf.bits_per_pixel = 16; /* Is this correct? */ A trivial patch can't have "Is this correct?" parts :). I already applied the simple and correct v2 patch. Feel free to follow up with additional cleanups but with resolved "Is th

Re: [Qemu-devel] [PATCH uq/master] kvm: Rename irqchip_inject_ioctl to irq_set_ioctl

2012-08-24 Thread Marcelo Tosatti
On Fri, Aug 24, 2012 at 01:34:47PM +0200, Jan Kiszka wrote: > This variable is no longer bound to irqchip, and the IOCTL sets the IRQ > level, does not directly inject it. No functional changes. > > Signed-off-by: Jan Kiszka > --- > kvm-all.c | 10 +- > 1 files changed, 5 insertions(+)

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread Aurelien Jarno
On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: > Optionally, make memory access helpers take a parameter for CPUState > instead of relying on global env. > > On most targets, perform simple moves to reorder registers. On i386, > switch from regparm(3) calling convention to standard st

Re: [Qemu-devel] [PATCH V5 3/8] hw/cirrus_vga.c: replace register_ioport*

2012-08-24 Thread Jan Kiszka
On 2012-08-24 16:49, Julien Grall wrote: > On 08/24/2012 02:44 PM, Jan Kiszka wrote: >> On 2012-08-22 14:27, Julien Grall wrote: >> >>> This patch replaces all register_ioport* with portio_*. It permits to >>> use the new Memory stuff like listener. >>> >>> Signed-off-by: Julien Grall >>> --- >

Re: [Qemu-devel] [PATCH 05/10] qdev: finalize of qbus, qdev will not the right place to free children

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:49, Liu Ping Fan ha scritto: > From: Liu Ping Fan > > When breaking big lock, the child object can be hold by mmio-dispatch, > and it is not right to free them when their parent gone. > We will isolate and release the children by qdev_delete_subtree(), > and let each object manag

Re: [Qemu-devel] [PATCH 01/10] qom: add, remove of link property need to ref, unref its target

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:49, Liu Ping Fan ha scritto: > From: Liu Ping Fan > > Currently, link property's target is only managed by > object_set_link_property(). This will raise such issue that when > the property is finalized, its target has no opportunity to release. > > Fix this issue by introduce ob

Re: [Qemu-devel] [PATCH 03/10] qom: export object_property_is_child, object_property_is_link

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:49, Liu Ping Fan ha scritto: > From: Liu Ping Fan > > qdev will use them to judge how to remove the bus and device's > reference. So export them in object.h This series doesn't use them. Paolo > Signed-off-by: Liu Ping Fan > --- > include/qemu/object.h |3 +++ > qom/obje

Re: [Qemu-devel] [PATCH 08/10] qdev: rename qdev_unplug to qdev_unplug_req

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:49, Liu Ping Fan ha scritto: > From: Liu Ping Fan > > Unplug divides into two steps: request and complete > The name "req" show more clearly about its meaning But not enough. Let's make it "qdev_request_unplug", and change the method name in the DeviceClass too. > and as to th

Re: [Qemu-devel] [PATCH V5 3/8] hw/cirrus_vga.c: replace register_ioport*

2012-08-24 Thread Julien Grall
On 08/24/2012 02:44 PM, Jan Kiszka wrote: On 2012-08-22 14:27, Julien Grall wrote: This patch replaces all register_ioport* with portio_*. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall --- hw/cirrus_vga.c | 42 -

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 15/17] xl: support spawn/destroy on multiple device model

2012-08-24 Thread Ian Campbell
On Fri, 2012-08-24 at 15:37 +0100, Julien Grall wrote: > In case of Xen, it's hard to have a compatibility. We can > still spawn only one QEMU, but ioreq handling will not > send an io request if no device models registered it. > There is no more default QEMU. This means we've broken existing qemu

Re: [Qemu-devel] [PATCH 06/10] qom: expose object_property_del_child

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:49, Liu Ping Fan ha scritto: > From: Liu Ping Fan > > qmp and qdev need it. > > Signed-off-by: Liu Ping Fan > --- > include/qemu/object.h |3 +++ > qom/object.c |2 +- > 2 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/include/qemu/object.h b

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:49, Liu Ping Fan ha scritto: > With this patch, we can protect PCIIDEState from disappearing during > mmio-dispatch hold the IDEBus->ref. I don't see why MMIO dispatch should hold the IDEBus ref rather than the PCIIDEState. In the case of the PIIX, the BARs are set up by the PCII

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 15/17] xl: support spawn/destroy on multiple device model

2012-08-24 Thread Julien Grall
On 08/24/2012 03:09 PM, Ian Campbell wrote: On Fri, 2012-08-24 at 14:51 +0100, Julien Grall wrote: @@ -1044,7 +1044,8 @@ int libxl__wait_for_device_model(libxl__gc *gc, void *check_callback_userdata) { char *path; -path = libxl__sprintf(gc, "

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-24 Thread Alexander Graf
Am 24.08.2012 um 07:18 schrieb Luiz Capitulino : > On Thu, 23 Aug 2012 17:09:25 -0400 > Jason Baron wrote: > >> While testing q35, I found that windows 7 (specifically, windows 7 ultimate >> with sp1 x64), wouldn't install because it can't find the cdrom or disk >> drive. >> The failure messa

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-24 Thread Luiz Capitulino
On Thu, 23 Aug 2012 17:09:25 -0400 Jason Baron wrote: > While testing q35, I found that windows 7 (specifically, windows 7 ultimate > with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. > The failure message is: 'A required cd/dvd device driver is missing. If you > have

[Qemu-devel] [PATCH 2/3] net: fix usbnet_receive() packet drops

2012-08-24 Thread Stefan Hajnoczi
The USB network interface has a single buffer which the guest reads from. This patch prevents multiple calls to usbnet_receive() from clobbering the input buffer. Instead we queue packets until buffer space becomes available again. This is inspired by virtio-net and e1000 rxbuf handling. Signed

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 15/17] xl: support spawn/destroy on multiple device model

2012-08-24 Thread Ian Campbell
On Fri, 2012-08-24 at 14:51 +0100, Julien Grall wrote: > >> @@ -1044,7 +1044,8 @@ int libxl__wait_for_device_model(libxl__gc *gc, > >>void *check_callback_userdata) > >> { > >> char *path; > >> -path = libxl__sprintf(gc, "/local/domain/0/device-model/

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 15/17] xl: support spawn/destroy on multiple device model

2012-08-24 Thread Julien Grall
On 08/23/2012 02:56 PM, Ian Campbell wrote: On Wed, 2012-08-22 at 13:32 +0100, Julien Grall wrote: @@ -991,12 +1057,11 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, libxl__device_console_dispose(&console); if (need_qemu) { -d

[Qemu-devel] [PATCH 3/3] net: broadcast hub packets if at least one port can receive

2012-08-24 Thread Stefan Hajnoczi
In commit 60c07d933c66c4b30a83b7ccbc8a0cb3df1b2d0e ("net: fix qemu_can_send_packet logic") the "VLAN" broadcast behavior was changed to queue packets if any net client cannot receive. It turns out that this was not actually the right fix and just hides the real bug that hw/usb/dev-network.c:usbnet

Re: [Qemu-devel] [PATCH for 1.2] qemu-ga: Fix null pointer passed to unlink in failure branch

2012-08-24 Thread Luiz Capitulino
On Fri, 24 Aug 2012 07:03:03 +0200 Stefan Weil wrote: > Clang reports this warning: > > Null pointer passed as an argument to a 'nonnull' parameter > > Signed-off-by: Stefan Weil Reviewed-by: Luiz Capitulino > --- > qemu-ga.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread Peter Maydell
On 24 August 2012 14:39, Paolo Bonzini wrote: > Il 24/08/2012 09:19, Peter Maydell ha scritto: >>> > Err, does this comply with the -rcX process? Patch 6 alone has been on >>> > the list for less than a day. Only now I was able to comment on it, and >>> > I would prefer to not have it merged that

Re: [Qemu-devel] [PATCH V5 3/8] hw/cirrus_vga.c: replace register_ioport*

2012-08-24 Thread Jan Kiszka
On 2012-08-22 14:27, Julien Grall wrote: > This patch replaces all register_ioport* with portio_*. It permits to > use the new Memory stuff like listener. > > Signed-off-by: Julien Grall > --- > hw/cirrus_vga.c | 42 -- > 1 files changed, 24 insertions(+

[Qemu-devel] [PATCH 0/3] net: fix hub control flow (again)

2012-08-24 Thread Stefan Hajnoczi
Two networking issues have been observed: 1. When the USB network interface and dump net client are on the same "VLAN", the USB network interface drops packets. This was assumed to be because the dump net client can receive packets all the time, whereas the USB network interface has a si

[Qemu-devel] [PATCH 1/3] net: clean up usbnet_receive()

2012-08-24 Thread Stefan Hajnoczi
The USB network interface has two code paths depending on whether or not RNDIS mode is enabled. Refactor usbnet_receive() so that there is a common path throughout the function instead of duplicating everything across if (is_rndis(s)) ... else ... code paths. Clean up coding style and 80 characte

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 09:19, Peter Maydell ha scritto: >> > >> > Err, does this comply with the -rcX process? Patch 6 alone has been on >> > the list for less than a day. Only now I was able to comment on it, and >> > I would prefer to not have it merged that easily. > Adding a new command line option cert

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 12/17] xl: Add interface to handle qemu disaggregation

2012-08-24 Thread Julien Grall
On 08/24/2012 02:03 PM, Ian Campbell wrote: @@ -246,6 +246,20 @@ libxl_domain_sched_params = Struct("domain_sched_params",[ ("extratime",integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT'}), ]) +libxl_dm_cap = Enumeration("dm_cap", [ +(1, "UI"), # Emulate

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 14/17] xl-parsing: Parse new device_models option

2012-08-24 Thread Julien Grall
On 08/23/2012 02:35 PM, Ian Campbell wrote: On Wed, 2012-08-22 at 13:32 +0100, Julien Grall wrote: Add new option "device_models". The user can specify the capability of the QEMU (ui, vifs, ...). This option only works with QEMU upstream (qemu-xen). For instance: device_models= [ 'name=all,

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 12/17] xl: Add interface to handle qemu disaggregation

2012-08-24 Thread Ian Campbell
On Fri, 2012-08-24 at 13:56 +0100, Julien Grall wrote: > On 08/23/2012 02:30 PM, Ian Campbell wrote: > > On Wed, 2012-08-22 at 13:31 +0100, Julien Grall wrote: > > > >> This patch modifies libxl interface for qemu disaggregation. > >> > > I'd rather see the interfaces changes in the same

Re: [Qemu-devel] [QEMU][RFC V2 06/10] xen-pci: register PCI device in Xen and handle IOREQ_TYPE_PCI_CONFIG

2012-08-24 Thread Julien Grall
On 08/23/2012 03:41 PM, Stefano Stabellini wrote: On Wed, 22 Aug 2012, Julien Grall wrote: With QEMU disaggregation QEMU needs to specify which PCI device it's able to handle. It will use the device place in the topology (domain, bus, device, function). When Xen will trap an access for the c

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 12/17] xl: Add interface to handle qemu disaggregation

2012-08-24 Thread Julien Grall
On 08/23/2012 02:30 PM, Ian Campbell wrote: On Wed, 2012-08-22 at 13:31 +0100, Julien Grall wrote: This patch modifies libxl interface for qemu disaggregation. I'd rather see the interfaces changes in the same patch as the implementation of the new interfaces. For the moment, du

Re: [Qemu-devel] [PATCH 1/2] Usb: create the receive queue for the virtual USB NIC

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 8:56 AM, wrote: > From: Roy.Li > > The virtual USB NIC originally used a fixed buffer to receive packets which > only store 1 packet at a time, which is easy to overrun with packets if the > guest does not consume it quickly, and always lost packets at the below case: > >

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Jan Kiszka wrote: > On 2012-08-24 14:02, malc wrote: > > On Fri, 24 Aug 2012, Jan Kiszka wrote: > > > >> On 2012-08-24 05:58, malc wrote: > >>> On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > >>> > After applying this version 2 of this patch series, I can > successful

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Brad Smith
On Fri, Aug 24, 2012 at 02:02:57PM +0200, Paolo Bonzini wrote: > Il 24/08/2012 14:00, Brad Smith ha scritto: > > > >> > OpenBSD's uname works as expected with the -s flag so remove the > > > >> > special > > > >> > handling when determining the target OS. Use arch -s to retrieve > >>>

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread Jan Kiszka
On 2012-08-24 14:02, malc wrote: > On Fri, 24 Aug 2012, Jan Kiszka wrote: > >> On 2012-08-24 05:58, malc wrote: >>> On Thu, 23 Aug 2012, Matthew Ogilvie wrote: >>> After applying this version 2 of this patch series, I can successfully run "Micoport UNIX System V/386, v 2.1" (ca 1987) >>>

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 14:00, Brad Smith ha scritto: > > >> > OpenBSD's uname works as expected with the -s flag so remove the > > >> > special > > >> > handling when determining the target OS. Use arch -s to retrieve > > >> > the > > >> > hardware architecture as uname -m will return

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Jan Kiszka wrote: > On 2012-08-24 05:58, malc wrote: > > On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > > > >> After applying this version 2 of this patch series, I can > >> successfully run "Micoport UNIX System V/386, v 2.1" (ca 1987) > >> under qemu. (although not if I try

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Brad Smith
On Fri, Aug 24, 2012 at 01:56:31PM +0200, Paolo Bonzini wrote: > Il 24/08/2012 11:55, Peter Maydell ha scritto: > >> > OpenBSD's uname works as expected with the -s flag so remove the special > >> > handling when determining the target OS. Use arch -s to retrieve the > >> > hardware architecture as

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell wrote: > On 24 August 2012 11:54, Stefan Hajnoczi wrote: >> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote: >>> This allows using qemu_irq in the target specific cpu.h. >>> >>> Signed-off-by: Stefan Weil >>> --- >>> qemu-common.h |

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:55, Peter Maydell ha scritto: >> > OpenBSD's uname works as expected with the -s flag so remove the special >> > handling when determining the target OS. Use arch -s to retrieve the >> > hardware architecture as uname -m will return the meta architecture >> > instead of the hardwar

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 12:21 PM, Jan Kiszka wrote: > On 2012-08-24 13:20, Stefan Hajnoczi wrote: >> On Wed, Aug 22, 2012 at 06:44:08PM +0200, Jan Kiszka wrote: >>> On 2012-08-22 18:29, Stefan Weil wrote: Am 22.08.2012 17:32, schrieb Jan Kiszka: > On 2012-08-22 17:19, BALATON Zoltan wrote

Re: [Qemu-devel] [PATCH uq/master] kvm: Rename irqchip_inject_ioctl to irq_set_ioctl

2012-08-24 Thread Peter Maydell
On 24 August 2012 12:34, Jan Kiszka wrote: > This variable is no longer bound to irqchip, and the IOCTL sets the IRQ > level, does not directly inject it. No functional changes. > > Signed-off-by: Jan Kiszka Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH] megasas: Add 'hba_serial' property

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 12:36, Hannes Reinecke ha scritto: > Add a 'hba_serial' property to the megasas driver. Originally > it would be using a pointer value which would break migration. > > Reported-by: Stefan Weil > Signed-off-by: Hannes Reinecke > Cc: Paolo Bonzini > --- > hw/megasas.c |9 ++

Re: [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases

2012-08-24 Thread Peter Maydell
On 23 August 2012 01:08, BALATON Zoltan wrote: > Division with round up is the correct way to compute this even if the > only case where division with round down gives incorrect result is > probably 15 bpp. This case was explicitely patched up in one of these > functions but was unhandled in the o

[Qemu-devel] [PATCH uq/master] kvm: Rename irqchip_inject_ioctl to irq_set_ioctl

2012-08-24 Thread Jan Kiszka
This variable is no longer bound to irqchip, and the IOCTL sets the IRQ level, does not directly inject it. No functional changes. Signed-off-by: Jan Kiszka --- kvm-all.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index d1924db..d4d8a1

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.2] qemu-ga: Fix null pointer passed to unlink in failure branch

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 07:03:03AM +0200, Stefan Weil wrote: > Clang reports this warning: > > Null pointer passed as an argument to a 'nonnull' parameter > > Signed-off-by: Stefan Weil > --- > qemu-ga.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Nice, this looks like a legi

Re: [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases

2012-08-24 Thread Stefan Hajnoczi
On Thu, Aug 23, 2012 at 02:08:36AM +0200, BALATON Zoltan wrote: > Division with round up is the correct way to compute this even if the > only case where division with round down gives incorrect result is > probably 15 bpp. This case was explicitely patched up in one of these > functions but was un

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel

2012-08-24 Thread Jan Kiszka
On 2012-08-24 13:20, Stefan Hajnoczi wrote: > On Wed, Aug 22, 2012 at 06:44:08PM +0200, Jan Kiszka wrote: >> On 2012-08-22 18:29, Stefan Weil wrote: >>> Am 22.08.2012 17:32, schrieb Jan Kiszka: On 2012-08-22 17:19, BALATON Zoltan wrote: > Division with round up is the correct way to comput

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel

2012-08-24 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 06:44:08PM +0200, Jan Kiszka wrote: > On 2012-08-22 18:29, Stefan Weil wrote: > > Am 22.08.2012 17:32, schrieb Jan Kiszka: > >> On 2012-08-22 17:19, BALATON Zoltan wrote: > >>> Division with round up is the correct way to compute this even if the > >>> only case where divisi

Re: [Qemu-devel] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel

2012-08-24 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 05:19:42PM +0200, BALATON Zoltan wrote: > Division with round up is the correct way to compute this even if the > only case where division with round down gives incorrect result is > probably 15 bpp. This case was explicitely patched up in one of these > functions but was un

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] Fix copy&paste typos in documentation comments

2012-08-24 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 05:18:38PM +0200, BALATON Zoltan wrote: > > Signed-off-by: BALATON Zoltan > --- > memory.h | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > v2: indented memory_region_init_ram_ptr Thanks, applied to the trivial patches tree: https://github.com/

Re: [Qemu-devel] [PATCH] vmware_vga: Cleanup and allow simple drivers to work without the fifo

2012-08-24 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 05:23:49PM +0200, Jan Kiszka wrote: > On 2012-08-22 12:19, BALATON Zoltan wrote: > > On Wed, 22 Aug 2012, Jan Kiszka wrote: > >> This is a rather big patch. I strongly suspect you can break it up into > >> smaller pieces that address separate aspects one-by-one. Also, it is

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier

2012-08-24 Thread Peter Maydell
On 24 August 2012 11:54, Stefan Hajnoczi wrote: > On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote: >> This allows using qemu_irq in the target specific cpu.h. >> >> Signed-off-by: Stefan Weil >> --- >> qemu-common.h |3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) > >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Remove #if 0'd cpu_get_real_ticks() definition

2012-08-24 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 02:03:36PM +0100, Peter Maydell wrote: > Remove the cpu_get_real_ticks() definition from linux-user/main.c. > This has been disabled via #if 0 and unused since commit 1dce7c3c22 > in 2006; the definitions we actually use are in qemu-timer.h. > > Signed-off-by: Peter Maydell

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier

2012-08-24 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote: > This allows using qemu_irq in the target specific cpu.h. > > Signed-off-by: Stefan Weil > --- > qemu-common.h |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) I'm not sure if there's a reason why qemu_irq was previousl

Re: [Qemu-devel] What's the proper type of guest pde address, target_ulong or target_phys_addr_t?

2012-08-24 Thread Wei-Ren Chen
> In principle, yes, but you need to check the code carefully to make > sure your type change doesn't change any of the results. (Or if it > does, you then need to confirm against the specs that this was a bug > that is being fixed, not a new one being introduced). The thing you have > to remember

Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast

2012-08-24 Thread Hannes Reinecke
On 08/24/2012 10:16 AM, Paolo Bonzini wrote: > Il 24/08/2012 10:31, Hannes Reinecke ha scritto: >> >>> Type casts from pointer to integer values must use uintptr_t >>> instead of unsigned long. Otherwise the compiler complains on >>> hosts with sizeof(pointer) != sizeof(long). >>> >>> The patch als

[Qemu-devel] [PATCH] megasas: Add 'hba_serial' property

2012-08-24 Thread Hannes Reinecke
Add a 'hba_serial' property to the megasas driver. Originally it would be using a pointer value which would break migration. Reported-by: Stefan Weil Signed-off-by: Hannes Reinecke Cc: Paolo Bonzini --- hw/megasas.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 11/17] xc: modify save/restore to support multiple device models

2012-08-24 Thread Ian Campbell
On Fri, 2012-08-24 at 11:27 +0100, Julien Grall wrote: > On 08/23/2012 08:52 PM, Ian Campbell wrote: > > On Thu, 2012-08-23 at 20:13 +0100, Julien Grall wrote: > > > >> On 08/23/2012 02:27 PM, Ian Campbell wrote: > >> > >>> > @@ -103,6 +103,9 @@ static ssize_t rdexact(xc_inte

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 01/17] hvm: Modify interface to support multiple ioreq server

2012-08-24 Thread Julien Grall
On 08/23/2012 02:26 PM, Keir Fraser wrote: On 23/08/2012 14:18, "Ian Campbell" wrote: diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h index 4022a1d..87aacd3 100644 --- a/xen/include/public/hvm/ioreq.h +++ b/xen/include/public/hvm/ioreq.h @@ -34,6 +34,7 @@ #d

Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-24 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 09:17:51AM +0200, Markus Armbruster wrote: > Stefan Weil writes: > > > Am 17.08.2012 17:02, schrieb Luiz Capitulino: > >> On Fri, 17 Aug 2012 16:41:34 +0200 > >> Markus Armbruster wrote: > >> > >>> Luiz Capitulino writes: > >>> > On Fri, 17 Aug 2012 16:10:12 +0200 >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ui: Fix spelling in comment (ressource -> resource)

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 17, 2012 at 03:20:00PM +0200, Stefan Weil wrote: > The function is called interface_release_resource. > > Signed-off-by: Stefan Weil > --- > ui/spice-display.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https://github.com/

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 11/17] xc: modify save/restore to support multiple device models

2012-08-24 Thread Julien Grall
On 08/23/2012 08:52 PM, Ian Campbell wrote: On Thu, 2012-08-23 at 20:13 +0100, Julien Grall wrote: On 08/23/2012 02:27 PM, Ian Campbell wrote: @@ -103,6 +103,9 @@ static ssize_t rdexact(xc_interface *xch, struct restore_ctx *ctx, #else #define RDEXACT read_exact #end

[Qemu-devel] [PATCH 03/10] qom: export object_property_is_child, object_property_is_link

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan qdev will use them to judge how to remove the bus and device's reference. So export them in object.h Signed-off-by: Liu Ping Fan --- include/qemu/object.h |3 +++ qom/object.c |4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/qe

[Qemu-devel] [PATCH 08/10] qdev: rename qdev_unplug to qdev_unplug_req

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan Unplug divides into two steps: request and complete The name "req" show more clearly about its meaning and as to the complete, it is qdev_delete_subtree() Also adding ret to indicate the request can be eject or not Signed-off-by: Liu Ping Fan --- hw/pci-hotplug.c |4

Re: [Qemu-devel] [PATCH 07/10] unplug: using new intf qdev_delete_subtree in acpi_piix_eject_slot

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:49, Liu Ping Fan ha scritto: > From: Liu Ping Fan > > We are not long to force to delete the obj at that place, just > let its refcnt handle this issue. This seems wrong. If anything, unplug requests should propagate down the tree and the top device should only acknowledge it h

[Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan Scene: obja lies in objA, when objA's ref->0, it will be freed, but at that time obja can still be in use. The real example is: typedef struct PCIIDEState { PCIDevice dev; IDEBus bus[2]; --> create in place . } When without big lock protection for mmio-dispa

Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 11:08 AM, Aurelien Jarno wrote: > On Fri, Aug 24, 2012 at 10:47:47AM +0100, Stefan Hajnoczi wrote: >> On Thu, Aug 23, 2012 at 4:39 PM, Aurelien Jarno wrote: >> > The lan9118 emulation tries to compute the multicast index by calling >> > directly the crc32() function from z

Re: [Qemu-devel] [PATCH 2/2] hub: change hub can_receive() strategy

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 9:33 AM, Rongqing Li wrote: > > > On 2012年08月24日 16:20, Paolo Bonzini wrote: >> >> A link-down NIC should always return 1 from can_receive (and will drop >> the packet). Is that the real bug here? >> > > A link-down NIC always return 0 from can_receive. > > Yes, it is a bu

  1   2   >