Re: [Qemu-devel] Qemu crashed with lsi booting

2012-07-26 Thread Paolo Bonzini
Il 26/07/2012 10:31, Frediano Ziglio ha scritto: > sudo ./x86_64-softmmu/qemu-system-x86_64 -m 1024 -hda test.qcow > -device lsi -drive file=/dev/sdb,if=none,id=XXX -device > scsi-block,drive=XXX -enable-kvm -bios ~/seabios/out/bios.bin -serial > file:out.txt > lsi_scsi: error: Multiple IO pending

[Qemu-devel] [Bug-Report] KVM failed to support netbsd-based kernel!

2012-07-26 Thread GaoYi
Hi all, I am running a netbsd kernel in KVM, using Intel VT. However, the OS failed to start up with the following outputs: KVM internal error. Suberror: 1 emulation failure. EAX=0001EBX=ECX=0005 EDX=0001 ESI=0001 EDI=001c4bd2 EBP=0011a72c

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-26 Thread Corey Bryant
On 07/26/2012 09:16 AM, Kevin Wolf wrote: Am 26.07.2012 15:13, schrieb Eric Blake: On 07/25/2012 09:21 PM, Corey Bryant wrote: On 07/25/2012 03:25 PM, Eric Blake wrote: On 07/25/2012 02:22 AM, Kevin Wolf wrote: Hm, not a nice interface where qemu_close() needs the filename and (worse) cou

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-26 Thread Corey Bryant
On 07/26/2012 05:07 AM, Kevin Wolf wrote: Am 26.07.2012 05:57, schrieb Corey Bryant: On 07/25/2012 03:43 PM, Eric Blake wrote: On 07/23/2012 07:08 AM, Corey Bryant wrote: +int monitor_fdset_get_fd(Monitor *mon, int64_t fdset_id, int flags) +{ +mon_fdset_t *mon_fdset; +mon_fdset_fd_t

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-26 Thread Corey Bryant
On 07/26/2012 05:07 AM, Kevin Wolf wrote: Am 26.07.2012 05:57, schrieb Corey Bryant: On 07/25/2012 03:43 PM, Eric Blake wrote: On 07/23/2012 07:08 AM, Corey Bryant wrote: +int monitor_fdset_get_fd(Monitor *mon, int64_t fdset_id, int flags) +{ +mon_fdset_t *mon_fdset; +mon_fdset_fd_t

[Qemu-devel] [Bug 1007269] Re: Can’t install or boot up 32bit win8 guest.

2012-07-26 Thread Yongjie Ren
qemu64 cpu model has PAE/NX/SSE2 Support by default. Also, after I used "-cpu qemu64,+3dnow", 32bit Win8 also can't be installed and had a BSOD with "Error code: 0x005D". -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bu

[Qemu-devel] [PATCH v2 0/2] Probe the guest memory space when using -R

2012-07-26 Thread Meador Inge
Hi, This patch series fixes an issue that was discussed here [1] where using -R can cause QEMU to fail to setup the guest address space because the guest base validation fails. I fixed this issue by (1) refactoring the guest space probing code into a single function for initializing the guest spa

[Qemu-devel] [PATCH v2 2/2] linux-user: Use init_guest_space when -R and -B are specified

2012-07-26 Thread Meador Inge
Roll the code used to initialize the guest memory space when -R or -B is used into 'init_guest_space' and then call 'init_guest_space' from the driver. This way the reserved guest memory space can be probed for. Calling 'mmap' just once as is currently done is not guaranteed to succeed since the

[Qemu-devel] [PATCH v2 1/2] linux-user: Factor out guest space probing into a function

2012-07-26 Thread Meador Inge
Signed-off-by: Meador Inge --- linux-user/elfload.c | 110 +++--- linux-user/qemu.h| 13 ++ 2 files changed, 90 insertions(+), 33 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index f3b1552..7d8d866 100644 --- a/linux

Re: [Qemu-devel] Qemu crashed with lsi booting

2012-07-26 Thread Kevin O'Connor
On Thu, Jul 26, 2012 at 09:31:29AM +0100, Frediano Ziglio wrote: > I always get an assert launching this command > > sudo ./x86_64-softmmu/qemu-system-x86_64 -m 1024 -hda test.qcow > -device lsi -drive file=/dev/sdb,if=none,id=XXX -device > scsi-block,drive=XXX -enable-kvm -bios ~/seabios/out/bios

Re: [Qemu-devel] [PATCH 31/47] qemu-iotests: add mirroring test case

2012-07-26 Thread Eric Blake
On 07/24/2012 05:04 AM, Paolo Bonzini wrote: > The tests are not meant to offer full coverage; in particular, there is > no concurrent I/O going on from the guest. However, especially in the > case of blkdebug-based tests (introduced later in the series) they do > cover some paths that will usuall

[Qemu-devel] [RFC-v5] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hello KVM + QEMU folks, This is -v5 of the in-flight tcm_vhost fabric driver for KVM host virtualized target support using the in-kernel storage stack with for-3.6 code. The changes since -v4 have been pretty minimal. A new GET_ABI_VERSION ioctl has been added as reque

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-26 Thread Eric Blake
On 07/24/2012 05:04 AM, Paolo Bonzini wrote: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 133 > -- > hmp-commands.hx | 21 + > hmp.c| 28 +

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-07-26 Thread Eric Blake
On 07/25/2012 08:50 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > +++ b/qapi-schema.json > @@ -273,6 +273,26 @@ > { 'type': 'MigrationStats', >'d

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Anthony Liguori
Luiz Capitulino writes: > On Thu, 26 Jul 2012 16:08:54 -0500 > Anthony Liguori wrote: > >> Luiz Capitulino writes: >> >> > On Thu, 26 Jul 2012 15:43:58 -0300 >> > Luiz Capitulino wrote: >> > >> >> On Thu, 26 Jul 2012 13:22:15 -0500 >> >> anth...@codemonkey.ws wrote: >> >> >> >> > >> >> > Hi

Re: [Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

2012-07-26 Thread Eric Blake
On 07/25/2012 08:50 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > +++ b/qapi-schema.json > @@ -264,11 +264,15 @@ > #migration has ended, it r

Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cachesize command

2012-07-26 Thread Eric Blake
On 07/25/2012 08:50 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2, it will be > rounded down to the nearest power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Sva

Re: [Qemu-devel] [PATCH 07/11] Add XBZRLE to ram_save_block and ram_save_live

2012-07-26 Thread Eric Blake
On 07/25/2012 08:50 AM, Orit Wasserman wrote: > In the outgoing migration check to see if the page is cached and > changed than send compressed page by using save_xbrle_page function. s/changed than/changed, then/ > In the incoming migration check to see if RAM_SAVE_FLAG_XBZRLE is set > and decom

Re: [Qemu-devel] [PATCH 06/11] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-26 Thread Eric Blake
On 07/25/2012 08:50 AM, Orit Wasserman wrote: > For performance we are encoding long word at a time. > For nzrun we use long-word-at-a-time NULL-detection tricks from strcmp(): [Technically, 'NUL' is the byte with value 0x00, 'NULL' is the pointer with typical value 0x or 0x000

Re: [Qemu-devel] [PATCH 04/11] Add cache handling functions

2012-07-26 Thread Eric Blake
On 07/25/2012 08:50 AM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > + > +PageCache *cache_init(int64_t num_pages

Re: [Qemu-devel] [RFC 00/27] Migration thread (WIP)

2012-07-26 Thread Michael Roth
On Tue, Jul 24, 2012 at 08:36:25PM +0200, Juan Quintela wrote: > Hi > > This series are on top of the migration-next-v5 series just posted. > > First of all, this is an RFC/Work in progress. Just a lot of people > asked for it, and I would like review of the design. > > It does: > - get a new b

Re: [Qemu-devel] Fwd: [RFC 00/27] Migration thread (WIP)

2012-07-26 Thread Chegu Vinod
On 7/26/2012 11:41 AM, Chegu Vinod wrote: Original Message Subject:[Qemu-devel] [RFC 00/27] Migration thread (WIP) Date: Tue, 24 Jul 2012 20:36:25 +0200 From: Juan Quintela To: qemu-devel@nongnu.org Hi This series are on top of the migration-next-v5 serie

Re: [Qemu-devel] [PATCH v5 6/6] qapi: convert sendkey

2012-07-26 Thread Eric Blake
On 07/25/2012 10:49 PM, Amos Kong wrote: > Convert 'sendkey' to use QAPI. > > Keys' indexes in the enmu are same as keycodes' indexes in the s/enmu/enum/ > key_defs[], index_from_code() and index_from_key() will return > Q_KEY_CODE_MAX if the code/key is invalid. > > For qmp, QAPI would check i

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Richard W.M. Jones
On Thu, Jul 26, 2012 at 01:22:15PM -0500, anth...@codemonkey.ws wrote: > We had a violent^Wheated discussion on IRC about how to move forward > with Luiz's proposed error series. I think we reached consensus. This > note attempts to outline that. > > Principles > -- > 1. Errors should be

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 16:08:54 -0500 Anthony Liguori wrote: > Luiz Capitulino writes: > > > On Thu, 26 Jul 2012 15:43:58 -0300 > > Luiz Capitulino wrote: > > > >> On Thu, 26 Jul 2012 13:22:15 -0500 > >> anth...@codemonkey.ws wrote: > >> > >> > > >> > Hi, > >> > > >> > We had a violent^Wheated

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Anthony Liguori
Luiz Capitulino writes: > On Thu, 26 Jul 2012 15:43:58 -0300 > Luiz Capitulino wrote: > >> On Thu, 26 Jul 2012 13:22:15 -0500 >> anth...@codemonkey.ws wrote: >> >> > >> > Hi, >> > >> > We had a violent^Wheated discussion on IRC about how to move forward >> > with Luiz's proposed error series.

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Eric Blake
On 07/26/2012 12:22 PM, anth...@codemonkey.ws wrote: > > Hi, > > We had a violent^Wheated discussion on IRC about how to move forward > with Luiz's proposed error series. I think we reached consensus. This > note attempts to outline that. > > Principles > -- > 1. Errors should be free

Re: [Qemu-devel] [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION

2012-07-26 Thread Nicholas A. Bellinger
On Thu, 2012-07-26 at 11:58 +0300, Avi Kivity wrote: > On 07/26/2012 05:34 AM, Nicholas A. Bellinger wrote: > > > > In that case, respinning a -v5 for tcm_vhost to start from ABI=0 and > > will post an updated patch shortly. > > > >> The main thing I would like to confirm is that this only versio

[Qemu-devel] [PATCH 0/2] ahci: fix cdrom read corruption

2012-07-26 Thread Jason Baron
Hi, While testing q35 I found data corruption on reads from the cdrom on the ahci controller. The first patch addresses this issue. I also notice that there is a memory leak in the ahci code, which is addressed in the second patch. Thanks, -Jason Jason Baron (2): ahci: Fix ahci cdrom read cor

[Qemu-devel] [PATCH 2/2] ahci: Fix sglist memleak in ahci_dma_rw_buf()

2012-07-26 Thread Jason Baron
I noticed that in hw/ide/ahci:ahci_dma_rw_buf() does not appear to free the sglist. Thus, I've added a call to qemu_sglist_destroy() to fix this memory leak. I'm wondering though if 'ahci_populate_sglist()' can return 0, and not populate the sglist, thus causing us to call free on NULL pointer. Ho

[Qemu-devel] [PATCH 1/2] ahci: Fix ahci cdrom read corruptions for reads > 128k

2012-07-26 Thread Jason Baron
While testing q35, which has its cdrom attached to the ahci controller, I found that the Fedora 17 install would panic on boot. The panic occurs while squashfs is trying to read from the cdrom. The errors are: [8.622711] SQUASHFS error: xz_dec_run error, data probably corrupt [8.625180] SQ

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Alex Williamson
On Thu, 2012-07-26 at 19:40 +0300, Avi Kivity wrote: > On 07/26/2012 07:33 PM, Alex Williamson wrote: > >> > >> In the common case, on x86 (but I'm repeating myself), the iommu group > >> includes just one device, yes? Could we make pci-stub an alias for the > >> corresponding vfio steps? > > >

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 15:43:58 -0300 Luiz Capitulino wrote: > On Thu, 26 Jul 2012 13:22:15 -0500 > anth...@codemonkey.ws wrote: > > > > > Hi, > > > > We had a violent^Wheated discussion on IRC about how to move forward > > with Luiz's proposed error series. I think we reached consensus. This >

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Avi Kivity
On 07/26/2012 07:33 PM, Alex Williamson wrote: >> >> In the common case, on x86 (but I'm repeating myself), the iommu group >> includes just one device, yes? Could we make pci-stub an alias for the >> corresponding vfio steps? > > PCI bridges masking devices is not as uncommon as you'd like, tha

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Alex Williamson
On Thu, 2012-07-26 at 19:06 +0300, Avi Kivity wrote: > On 07/26/2012 05:56 PM, Alex Williamson wrote: > > > > Both KVM and VFIO do strive to make the device in the guest look as much > > like it does on bare metal as possible, but we don't guarantee they're > > identical and we don't guarantee to

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Avi Kivity
On 07/26/2012 07:40 PM, Alex Williamson wrote: > On Thu, 2012-07-26 at 19:06 +0300, Avi Kivity wrote: >> On 07/26/2012 05:56 PM, Alex Williamson wrote: >> > >> > Both KVM and VFIO do strive to make the device in the guest look as much >> > like it does on bare metal as possible, but we don't guara

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Alex Williamson
On Thu, 2012-07-26 at 19:34 +0300, Avi Kivity wrote: > On 07/25/2012 08:03 PM, Alex Williamson wrote: > > > +/* > > + * Resource setup > > + */ > > +static void vfio_unmap_bar(VFIODevice *vdev, int nr) > > +{ > > +VFIOBAR *bar = &vdev->bars[nr]; > > +uint64_t size; > > + > > +if (!memo

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 13:22:15 -0500 anth...@codemonkey.ws wrote: > > Hi, > > We had a violent^Wheated discussion on IRC about how to move forward > with Luiz's proposed error series. I think we reached consensus. This > note attempts to outline that. This looks great to me, violent^W heated di

Re: [Qemu-devel] Fwd: [RFC 00/27] Migration thread (WIP)

2012-07-26 Thread Chegu Vinod
Original Message Subject:[Qemu-devel] [RFC 00/27] Migration thread (WIP) Date: Tue, 24 Jul 2012 20:36:25 +0200 From: Juan Quintela To: qemu-devel@nongnu.org Hi This series are on top of the migration-next-v5 series just posted. First of all, this is an RF

Re: [Qemu-devel] [PATCH 02/47] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 17:41:01 +0200 Paolo Bonzini wrote: > Il 26/07/2012 17:26, Kevin Wolf ha scritto: > >> The DeviceNotActive error is not a particularly good match, add > >> > a separate one. > >> > > >> > Signed-off-by: Paolo Bonzini > > Luiz, what do you think about this one? It seems to co

Re: [Qemu-devel] [PATCH 10/11] qerror: switch to qapi generated error macros and table

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 18:05:45 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 26 Jul 2012 13:56:00 +0200 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > Previous commits added qapi infrastructure to automatically generate > >> > qerror macros a

Re: [Qemu-devel] [PATCH 02/47] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE

2012-07-26 Thread Paolo Bonzini
Il 26/07/2012 18:49, Luiz Capitulino ha scritto: > On Thu, 26 Jul 2012 17:41:01 +0200 > Paolo Bonzini wrote: > >> Il 26/07/2012 17:26, Kevin Wolf ha scritto: The DeviceNotActive error is not a particularly good match, add > a separate one. > > Signed-off-by: Paolo Bonzini >>> Lu

[Qemu-devel] ISA device and shared memory

2012-07-26 Thread Albin Kauffmann
Hello, I'm trying to add the support for an old com90c65 ISA card (a network device using the old ARCnet protocol and handled by the com90xx Linux module). This device is using both IO ports and IO memory. The I/O ports are working and the code is largely inspired from the ne2k_isa support.

[Qemu-devel] [GIT PULL (PATCH 0/4) v2] VFIO driver for v3.6

2012-07-26 Thread Alex Williamson
On Wed, 2012-07-25 at 08:53 -0600, Alex Williamson wrote: > Hi Linus, > > This series includes the VFIO userspace driver interface for the > 3.6 kernel merge window. This driver is intended to provide a > secure interface for device access using IOMMU protection for > applications like assignment

[Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread anthony
Hi, We had a violent^Wheated discussion on IRC about how to move forward with Luiz's proposed error series. I think we reached consensus. This note attempts to outline that. Principles -- 1. Errors should be free formed strings with a class code 2. There should be a small number of cl

Re: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 26 Jul 2012 13:50:24 +0200 > Markus Armbruster wrote: > >> Paolo, Eric, I got a make puzzle for you below. >> >> Luiz Capitulino writes: >> >> > This script generates two files from qapi-schema-errors.json: >> > >> > o qapi-errors.h: contains error macro def

Re: [Qemu-devel] [PATCH] fixup! qapi: qapi.py: allow the "'" character be escaped

2012-07-26 Thread Peter Maydell
On 26 July 2012 18:09, Markus Armbruster wrote: > Support escaping the escape character, and make more robust (don't die > for '', handle ' without matching '. > > Signed-off-by: Markus Armbruster Yeah, let's do this the right way. Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Alex Williamson
On Thu, 2012-07-26 at 18:59 +0300, Avi Kivity wrote: > On 07/26/2012 05:56 PM, Alex Williamson wrote: > >> >> Let's use the same syntax as for kvm device assignment. Then we can > >> >> fall back on kvm when vfio is not available. We can also have an > >> >> optional parameter kernel-driver to ex

Re: [Qemu-devel] [PATCH 02/47] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 18:59:30 +0200 Paolo Bonzini wrote: > Il 26/07/2012 18:49, Luiz Capitulino ha scritto: > > On Thu, 26 Jul 2012 17:41:01 +0200 > > Paolo Bonzini wrote: > > > >> Il 26/07/2012 17:26, Kevin Wolf ha scritto: > The DeviceNotActive error is not a particularly good match, add

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Jul 25, 2012 at 09:43:55PM -0500, Anthony Liguori wrote: >> Luiz Capitulino writes: >> >> > Basically, this series changes a call like: >> > >> > error_set(errp, QERR_DEVICE_NOT_FOUND, device); >> > >> > to: >> > >> > error_set(errp, QERR_DEVICE_NOT_FOUN

[Qemu-devel] [PATCH] fixup! qapi: qapi.py: allow the "'" character be escaped

2012-07-26 Thread Markus Armbruster
Support escaping the escape character, and make more robust (don't die for '', handle ' without matching '. Signed-off-by: Markus Armbruster --- Luiz made me do this. Fixes up his 07/11. Generates identical qmp-commands.h qapi-types.h qapi-visit.h qapi-errors.h tests/test-qapi-types.h tests/tes

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 18:03:20 +0200 Paolo Bonzini wrote: > Il 26/07/2012 17:54, Markus Armbruster ha scritto: > > Unlike Anthony, I think this is a move in the right direction. > > Me too, but I would like to understand how it fits with the > qapi-schema-errors.json. Do we actually need a schema

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Avi Kivity
On 07/25/2012 08:03 PM, Alex Williamson wrote: > +/* > + * Resource setup > + */ > +static void vfio_unmap_bar(VFIODevice *vdev, int nr) > +{ > +VFIOBAR *bar = &vdev->bars[nr]; > +uint64_t size; > + > +if (!memory_region_size(&bar->mem)) { > +return; > +} > + > +size =

Re: [Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

2012-07-26 Thread Eduardo Habkost
On Thu, Jul 26, 2012 at 07:08:19PM +0300, Avi Kivity wrote: > On 07/26/2012 06:07 PM, Eduardo Habkost wrote: > > On Thu, Jul 26, 2012 at 05:55:09PM +0300, Avi Kivity wrote: > >> On 07/26/2012 05:16 PM, Eduardo Habkost wrote: > >> >> > > >> >> > It's possible to replace the atomic read of CountCPUs

[Qemu-devel] [PATCH] block: Add -drive detect_zero=on|off option to detect all zero writes.

2012-07-26 Thread Richard W.M. Jones
From: "Richard W.M. Jones" This change adds a new block device option, "detect_zero=on|off". If "detect_zero=on" then when a guest writes sectors that contain all zero bytes, we call the internal "bdrv_co_write_zeroes" function instead of the standard "bdrv_co_writev". Some drivers, notably qed

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Daniel P. Berrange
On Wed, Jul 25, 2012 at 09:43:55PM -0500, Anthony Liguori wrote: > Luiz Capitulino writes: > > > Basically, this series changes a call like: > > > > error_set(errp, QERR_DEVICE_NOT_FOUND, device); > > > > to: > > > > error_set(errp, QERR_DEVICE_NOT_FOUND, > >"Device 'device=%s' not

Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 26 Jul 2012 13:22:00 +0200 > Markus Armbruster wrote: > >> Peter Maydell writes: >> >> > On 25 July 2012 20:18, Luiz Capitulino wrote: >> >> Peter Maydell wrote: >> >>> On 25 July 2012 17:54, Luiz Capitulino wrote: >> >>> > --- a/scripts/qapi.py >> >>> > ++

Re: [Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

2012-07-26 Thread Avi Kivity
On 07/26/2012 06:07 PM, Eduardo Habkost wrote: > On Thu, Jul 26, 2012 at 05:55:09PM +0300, Avi Kivity wrote: >> On 07/26/2012 05:16 PM, Eduardo Habkost wrote: >> >> > >> >> > It's possible to replace the atomic read of CountCPUs with the bitmap >> >> > weight >> >> > calculation on the loop, but:

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Avi Kivity
On 07/26/2012 05:56 PM, Alex Williamson wrote: > > Both KVM and VFIO do strive to make the device in the guest look as much > like it does on bare metal as possible, but we don't guarantee they're > identical and we don't guarantee to match each other. btw, this is somewhat problematic, conceivab

Re: [Qemu-devel] [PATCH 10/11] qerror: switch to qapi generated error macros and table

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 26 Jul 2012 13:56:00 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > Previous commits added qapi infrastructure to automatically generate >> > qerror macros and the qerror table from qapi-schema-errors.json. >> > >> > This commit drops th

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Paolo Bonzini
Il 26/07/2012 17:54, Markus Armbruster ha scritto: > Unlike Anthony, I think this is a move in the right direction. Me too, but I would like to understand how it fits with the qapi-schema-errors.json. Do we actually need a schema if the messages are flat? Paolo

[Qemu-devel] [PATCH] Detect zero writes (for discussion only, not to be applied)

2012-07-26 Thread Richard W.M. Jones
[Applies against qemu 1.1.0, not HEAD, because qemu from git seems to be broken at the moment. But the patch is easy to rebase.] This patch adds a -drive detect_zero=on|off flag (defaults to "off"). Setting this on causes the write path to detect all zero byte writes and, for block device driver

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Avi Kivity
On 07/26/2012 05:56 PM, Alex Williamson wrote: >> >> Let's use the same syntax as for kvm device assignment. Then we can >> >> fall back on kvm when vfio is not available. We can also have an >> >> optional parameter kernel-driver to explicitly select vfio or kvm. >> > >> > This seems confusing

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Markus Armbruster
Unlike Anthony, I think this is a move in the right direction.

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Markus Armbruster
Anthony Liguori writes: > Luiz Capitulino writes: > >> On Thu, 26 Jul 2012 07:41:07 -0500 >> Anthony Liguori wrote: >> >>> Kevin Wolf writes: >>> >>> > Am 26.07.2012 04:43, schrieb Anthony Liguori: >>> >> Luiz Capitulino writes: >>> >> >>> >>> Basically, this series changes a call like: >>>

Re: [Qemu-devel] [PATCH 03/47] block: move job APIs to separate files

2012-07-26 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini The commit message is not only short, but it even lies. This is not pure code motion. I didn't really review in detail what the Makefile changes do besides including a new blockjob.o, but I expect that either it is explai

Re: [Qemu-devel] [PATCH 02/47] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE

2012-07-26 Thread Paolo Bonzini
Il 26/07/2012 17:26, Kevin Wolf ha scritto: >> The DeviceNotActive error is not a particularly good match, add >> > a separate one. >> > >> > Signed-off-by: Paolo Bonzini > Luiz, what do you think about this one? It seems to contradict the idea > of having only few error classes and free form err

[Qemu-devel] [BUG] BSOD on Win2003 Server when 64bit PCI resource is present

2012-07-26 Thread Alexey Korolev
HI, Current version of Seabios is causing blue screen on Windows2003 when 64bit PCI resource is present and occupies high memory. BSOD Error code is: 0x00A5 (0x02, 0xfADF6A446880, 0x1, 0xFADFAA34690) The issue is localized, it is related to presence of 64bit resource in _CRS metho

Re: [Qemu-devel] [PATCH v2 3/7] docs: add lazy refcounts bit to qcow2 specification

2012-07-26 Thread Stefan Hajnoczi
On Thu, Jul 26, 2012 at 1:57 PM, Kevin Wolf wrote: > Am 25.07.2012 14:21, schrieb Stefan Hajnoczi: >> The lazy refcounts bit indicates that this image can take advantage of >> the dirty bit and that refcount updates can be postponed. >> >> Signed-off-by: Stefan Hajnoczi >> --- >> docs/specs/qcow

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Anthony Liguori
Kevin Wolf writes: > Am 26.07.2012 14:41, schrieb Anthony Liguori: >> Kevin Wolf writes: >> >>> Am 26.07.2012 04:43, schrieb Anthony Liguori: Luiz Capitulino writes: > Basically, this series changes a call like: > > error_set(errp, QERR_DEVICE_NOT_FOUND, device); > >

Re: [Qemu-devel] [PATCH 02/47] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE

2012-07-26 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > The DeviceNotActive error is not a particularly good match, add > a separate one. > > Signed-off-by: Paolo Bonzini Luiz, what do you think about this one? It seems to contradict the idea of having only few error classes and free form error descriptio

[Qemu-devel] [PATCH v2 4/7] kvm: Decouple 'irqfds usable' from 'kernel irqchip'

2012-07-26 Thread Peter Maydell
Instead of assuming that we can use irqfds if and only if kvm_irqchip_in_kernel(), add a bool to the KVMState which indicates this, and is set only on x86 and only if the irqchip is in the kernel. The kernel documentation implies that the only thing you need to use KVM_IRQFD is that KVM_CAP_IRQFD

[Qemu-devel] [PATCH v2 7/7] kvm: Add documentation comment for kvm_irqchip_in_kernel()

2012-07-26 Thread Peter Maydell
Now we've cleared out the architecture-independent uses of kvm_irqchip_in_kernel(), we can add a doc comment describing what it means. Signed-off-by: Peter Maydell --- kvm.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/kvm.h b/kvm.h index 444ed2e..5b8f588 1

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Alex Williamson
On Wed, 2012-07-25 at 11:03 -0600, Alex Williamson wrote: > This adds PCI based device assignment to Qemu using the Linux VFIO > userspace driver interface. After setting up VFIO device access, > devices can be added to Qemu guests using the vfio-pci device > option: > > -device vfio-pci,host=1:

Re: [Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

2012-07-26 Thread Eduardo Habkost
On Thu, Jul 26, 2012 at 05:55:09PM +0300, Avi Kivity wrote: > On 07/26/2012 05:16 PM, Eduardo Habkost wrote: > >> > > >> > It's possible to replace the atomic read of CountCPUs with the bitmap > >> > weight > >> > calculation on the loop, but: is it really worth it? > >> > > >> Why not? This eli

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Anthony Liguori
Luiz Capitulino writes: > On Thu, 26 Jul 2012 07:41:07 -0500 > Anthony Liguori wrote: > >> Kevin Wolf writes: >> >> > Am 26.07.2012 04:43, schrieb Anthony Liguori: >> >> Luiz Capitulino writes: >> >> >> >>> Basically, this series changes a call like: >> >>> >> >>> error_set(errp, QERR_DEVIC

[Qemu-devel] [PATCH v2 6/7] kvm: Decouple 'GSI routing' from 'kernel irqchip'

2012-07-26 Thread Peter Maydell
Don't assume having an in-kernel irqchip means that GSI routing is enabled. Signed-off-by: Peter Maydell --- kvm-all.c |3 ++- kvm-stub.c|1 + kvm.h | 10 ++ target-i386/kvm.c |3 ++- 4 files changed, 15 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 03/14] qerror: drop qerror_abort()

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 14:33:23 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Previously, developers had to create error dicts manually and also enter > > the matching desc table entry. Thus, qerro_abort() was added to help > > s/qerro_/qerror_/ > > > catching bad error dicts. >

[Qemu-devel] [PATCH v2 2/7] kvm: Rename kvm_irqchip_set_irq() to kvm_set_irq()

2012-07-26 Thread Peter Maydell
Rename the function kvm_irqchip_set_irq() to kvm_set_irq(), since it can be used for sending (asynchronous) interrupts whether there is a full irqchip model in the kernel or not. (We don't include 'async' in the function name since asynchronous is the normal case.) Signed-off-by: Peter Maydell --

[Qemu-devel] [PATCH v2 1/7] kvm: Decouple 'async interrupt delivery' from 'kernel irqchip'

2012-07-26 Thread Peter Maydell
On x86 userspace delivers interrupts to the kernel asynchronously (and therefore VCPU idle management is done in the kernel) if and only if there is an in-kernel irqchip. On other architectures this isn't necessarily true (they may always send interrupts asynchronously), so define a new kvm_async_i

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Alex Williamson
On Thu, 2012-07-26 at 11:35 +0300, Avi Kivity wrote: > On 07/25/2012 10:53 PM, Alex Williamson wrote: > > On Wed, 2012-07-25 at 22:30 +0300, Avi Kivity wrote: > >> On 07/25/2012 08:03 PM, Alex Williamson wrote: > >> > This adds PCI based device assignment to Qemu using the Linux VFIO > >> > userspa

Re: [Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

2012-07-26 Thread Avi Kivity
On 07/26/2012 05:16 PM, Eduardo Habkost wrote: >> > >> > It's possible to replace the atomic read of CountCPUs with the bitmap >> > weight >> > calculation on the loop, but: is it really worth it? >> > >> Why not? This eliminates one more global state. > > Maybe we can simply make it stop being

Re: [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names & compatibility aliases

2012-07-26 Thread Eduardo Habkost
On Thu, Jul 26, 2012 at 04:33:36PM +0200, Jiri Denemark wrote: > On Wed, Jul 25, 2012 at 15:18:43 -0300, Eduardo Habkost wrote: > > This adds version number to CPU model names on the "pc-" > > machine-types, so we can create new models with bug fixes while keeping > > compatibility when using older

Re: [Qemu-devel] [PATCH 10/11] qerror: switch to qapi generated error macros and table

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 13:56:00 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Previous commits added qapi infrastructure to automatically generate > > qerror macros and the qerror table from qapi-schema-errors.json. > > > > This commit drops the current error macros from qerror.h

Re: [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names & compatibility aliases

2012-07-26 Thread Eduardo Habkost
On Thu, Jul 26, 2012 at 04:31:45PM +0200, Andreas Färber wrote: > Am 26.07.2012 16:24, schrieb Eduardo Habkost: > > On Thu, Jul 26, 2012 at 12:52:33AM +0200, Andreas Färber wrote: > >> Am 25.07.2012 20:18, schrieb Eduardo Habkost: > >>> This adds version number to CPU model names on the "pc-" > >>>

Re: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 14:12:50 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > This script generates two files from qapi-schema-errors.json: > > > > o qapi-errors.h: contains error macro definitions, eg. QERR_BASE_NOT_FOUND, > > corresponds to most of today's qer

[Qemu-devel] [PATCH v2 5/7] kvm: Decouple 'MSI routing via irqfds' from 'kernel irqchip'

2012-07-26 Thread Peter Maydell
Decouple another x86-specific assumption about what irqchips imply. Signed-off-by: Peter Maydell --- hw/virtio-pci.c |4 ++-- kvm-all.c |1 + kvm-stub.c|1 + kvm.h | 11 +++ target-i386/kvm.c |4 +++- 5 files changed, 18 insertions(+), 3 de

Re: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 13:55:29 +0200 Paolo Bonzini wrote: > Il 26/07/2012 13:50, Markus Armbruster ha scritto: > >> > +qapi-errors.h qapi-errors.c :\ > >> > +$(SRC_PATH)/qapi-schema-errors.json $(SRC_PATH)/scripts/qapi-errors.py > >> > +$(call quiet-command,$(PYTHON) > >> > $(SRC_PATH)/scr

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Kevin Wolf
Am 26.07.2012 14:41, schrieb Anthony Liguori: > Kevin Wolf writes: > >> Am 26.07.2012 04:43, schrieb Anthony Liguori: >>> Luiz Capitulino writes: >>> Basically, this series changes a call like: error_set(errp, QERR_DEVICE_NOT_FOUND, device); to: error_set(err

Re: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 13:50:24 +0200 Markus Armbruster wrote: > Paolo, Eric, I got a make puzzle for you below. > > Luiz Capitulino writes: > > > This script generates two files from qapi-schema-errors.json: > > > > o qapi-errors.h: contains error macro definitions, eg. QERR_BASE_NOT_FOUND, > >

[Qemu-devel] [PATCH v2 3/7] kvm: Move kvm_allows_irq0_override() to target-i386, fix return type

2012-07-26 Thread Peter Maydell
kvm_allows_irq0_override() is a totally x86 specific concept: move it to the target-specific source file where it belongs. This means we need a new header file for the prototype: kvm_i386.h, in line with the existing kvm_ppc.h. While we are moving it, fix the return type to be 'bool' rather than '

[Qemu-devel] [PATCH v2 0/7] split out uses of kvm_irqchip_in_kernel()

2012-07-26 Thread Peter Maydell
This patch series removes all uses of kvm_irqchip_in_kernel() from architecture-independent code, by creating a set of more specific functions instead to test for the particular aspects of behaviour that the calling code is actually interested in. The uses in x86-specific code could in theory be f

Re: [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names & compatibility aliases

2012-07-26 Thread Jiri Denemark
On Wed, Jul 25, 2012 at 15:18:43 -0300, Eduardo Habkost wrote: > This adds version number to CPU model names on the "pc-" > machine-types, so we can create new models with bug fixes while keeping > compatibility when using older machine-types. > > When naming the existing models, I used the last Q

Re: [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names & compatibility aliases

2012-07-26 Thread Andreas Färber
Am 26.07.2012 16:24, schrieb Eduardo Habkost: > On Thu, Jul 26, 2012 at 12:52:33AM +0200, Andreas Färber wrote: >> Am 25.07.2012 20:18, schrieb Eduardo Habkost: >>> This adds version number to CPU model names on the "pc-" >>> machine-types, so we can create new models with bug fixes while keeping >

Re: [Qemu-devel] [QEMU PATCH 0/3] versioned CPU models / per-machine-type aliases

2012-07-26 Thread Eduardo Habkost
On Thu, Jul 26, 2012 at 04:06:03PM +0200, Andreas Färber wrote: > Am 26.07.2012 15:53, schrieb Eduardo Habkost: > > On Wed, Jul 25, 2012 at 06:43:25PM -0500, Anthony Liguori wrote: > >> Eduardo Habkost writes: > >> > >>> Hi, > >>> > >>> This is the first try at a simple system to make the CPU mode

Re: [Qemu-devel] [PATCH 0/3] Introduce virtqueue_get_avail_bytes()

2012-07-26 Thread Amit Shah
On (Fri) 06 Jul 2012 [16:07:06], Amit Shah wrote: > The current virtqueue_avail_bytes() is a weird API: it's oddly-named: > doesn't tell us what the API is going to do, and also suits just one > use-case (that in virtio-net.c). > > Introduce virtqueue_get_avail_bytes(), which returns the number of

Re: [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names & compatibility aliases

2012-07-26 Thread Eduardo Habkost
On Thu, Jul 26, 2012 at 12:52:33AM +0200, Andreas Färber wrote: > Am 25.07.2012 20:18, schrieb Eduardo Habkost: > > This adds version number to CPU model names on the "pc-" > > machine-types, so we can create new models with bug fixes while keeping > > compatibility when using older machine-types.

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-26 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Thu, Jul 26, 2012 at 01:47:23PM +0100, Daniel P. Berrange wrote: >> On Wed, Jul 25, 2012 at 02:47:57PM -0500, Anthony Liguori wrote: >> > The help output is going to change dramatically for 0.13. We've spent too >> > long >> > waiting for a perfect solution to

Re: [Qemu-devel] [PATCH] configure: Fix xen probe with Xen 4.2 and later.

2012-07-26 Thread Stefano Stabellini
On Thu, 26 Jul 2012, Andreas Färber wrote: > Am 26.07.2012 12:09, schrieb Anthony PERARD: > > The xs.h header is now deprecated and produce a warning. This prevent the > > produces, prevents > > Stefano, can you fix in your queue? Yep, I'll submit a pull request with the fixup.

Re: [Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

2012-07-26 Thread Eduardo Habkost
On Thu, Jul 26, 2012 at 09:08:40AM +0300, Gleb Natapov wrote: > On Wed, Jul 25, 2012 at 03:42:21PM -0300, Eduardo Habkost wrote: > > On Mon, Jul 23, 2012 at 03:20:14PM +0300, Gleb Natapov wrote: > > > On Fri, Jul 20, 2012 at 02:04:50PM -0300, Eduardo Habkost wrote: > > > > Extract Local APIC IDs di

  1   2   3   >