Il 26/07/2012 18:49, Luiz Capitulino ha scritto: > On Thu, 26 Jul 2012 17:41:01 +0200 > Paolo Bonzini <pbonz...@redhat.com> wrote: > >> Il 26/07/2012 17:26, Kevin Wolf ha scritto: >>>> The DeviceNotActive error is not a particularly good match, add >>>>> a separate one. >>>>> >>>>> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> >>> Luiz, what do you think about this one? It seems to contradict the idea >>> of having only few error classes and free form error descriptions. >> >> I agree, but that's what we have to live with for now... > > Why don't you add QERR_INVALID_STATE then?
Because I do want a meaningful error message. Paolo >> >>> What's the error class that we should really have here? A general >>> QERR_NOT_ACTIVE? >> >> See my proposal here: >> http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg00061.html >> (totally ignored ;)). >> >> This would be QERR_INVALID_STATE (quoting from that message: >> "InvalidStateError is generally caused by the interaction with other >> commands, could be fixed by sending some commands and retrying"). >> >> Paolo >> >
