Re: [Qemu-devel] [PATCH] hw/virtio-scsi: Set max_target=0 during vhost-scsi operation

2012-07-11 Thread Zhi Yong Wu
thanks, it is applied to my vhost_scsi git tree git://github.com/mdroth/qemu.git vhost-scsi On Thu, Jul 12, 2012 at 4:55 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This QEMU patch sets VirtIOSCSIConfig->max_target=0 for vhost-scsi operation > to restrict virtio-scsi LLD gue

[Qemu-devel] [PATCH] SCSI: improve the lba-out-of-range tests for read/write/verify

2012-07-11 Thread Ronnie Sahlberg
Improve the tests for the LBA to cover more cases, the new test looks like this if (r->req.cmd.lba > r->req.cmd.lba + len || r->req.cmd.lba + len > s->qdev.max_lba) { For the 16 byte opcodes, the lba is a uint64, so the first check is to make sure that we do not wrap. For example

[Qemu-devel] [PATCH] SCSI improved LBA-out-of-range checks

2012-07-11 Thread Ronnie Sahlberg
Paolo, List Please find a small patch to the scsi emulation. This patch improves the checkign that the requested lbas are all available. We check both that lba+len is not going past the end of the device but also iflba+len < lba This second condition could occur for deviously crafted scsi pa

Re: [Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-07-11 Thread Gleb Natapov
On Tue, Jul 10, 2012 at 03:15:51PM +0200, Igor Mammedov wrote: > /* pc.c */ > -int cpu_is_bsp(CPUX86State *env); Why remove it instead of modifying it to check BSP bit in apic base? I think it will make the patch smaller and open code the check does not look nice. -- Gleb

Re: [Qemu-devel] [PATCH] SCSI: rd/wr/vr-protect !=0 is an error

2012-07-11 Thread Paolo Bonzini
Il 12/07/2012 02:19, Ronnie Sahlberg ha scritto: > The QEMU SCSI emulation does not support protection information, > so any READ/WRITE/VERIFY commands that has the protect bits set to > non-zero should fail with ILLEGAL_REQUEST/INVALID_FIELD_IN_CDB > > From SCSI SBC : > If the logical unit does n

Re: [Qemu-devel] [PATCH] hw/virtio-scsi: Set max_target=0 during vhost-scsi operation

2012-07-11 Thread Paolo Bonzini
Il 12/07/2012 07:34, Zhi Yong Wu ha scritto: > HI, > > Do we need to maintain one QEMU branch to collect all useful latest > patches for tcm_vhost support? You know, those patches will not get > merged into qemu.git/master. Never say never, but the answer to your question is yes: please apply th

Re: [Qemu-devel] [PATCH 0/2] RFC: powerpc-vfio: adding support

2012-07-11 Thread Alexey Kardashevskiy
On 12/07/12 15:29, Alex Williamson wrote: > On Thu, 2012-07-12 at 14:58 +1000, Alexey Kardashevskiy wrote: >> On 12/07/12 14:43, Alex Williamson wrote: >>> On Thu, 2012-07-12 at 14:38 +1000, Alexey Kardashevskiy wrote: On 12/07/12 14:31, Alex Williamson wrote: > On Thu, 2012-07-12 at 14:16

Re: [Qemu-devel] [PATCH] hw/virtio-scsi: Set max_target=0 during vhost-scsi operation

2012-07-11 Thread Zhi Yong Wu
HI, Do we need to maintain one QEMU branch to collect all useful latest patches for tcm_vhost support? You know, those patches will not get merged into qemu.git/master. On Thu, Jul 12, 2012 at 4:55 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This QEMU patch sets VirtIOSCSI

Re: [Qemu-devel] [PATCH 0/2] RFC: powerpc-vfio: adding support

2012-07-11 Thread Alex Williamson
On Thu, 2012-07-12 at 14:58 +1000, Alexey Kardashevskiy wrote: > On 12/07/12 14:43, Alex Williamson wrote: > > On Thu, 2012-07-12 at 14:38 +1000, Alexey Kardashevskiy wrote: > >> On 12/07/12 14:31, Alex Williamson wrote: > >>> On Thu, 2012-07-12 at 14:16 +1000, Alexey Kardashevskiy wrote: > On

Re: [Qemu-devel] [PATCH 0/2] RFC: powerpc-vfio: adding support

2012-07-11 Thread Alexey Kardashevskiy
On 12/07/12 14:43, Alex Williamson wrote: > On Thu, 2012-07-12 at 14:38 +1000, Alexey Kardashevskiy wrote: >> On 12/07/12 14:31, Alex Williamson wrote: >>> On Thu, 2012-07-12 at 14:16 +1000, Alexey Kardashevskiy wrote: On 12/07/12 12:54, Alex Williamson wrote: > On Wed, 2012-07-11 at 12:25

Re: [Qemu-devel] [PATCH 0/2] RFC: powerpc-vfio: adding support

2012-07-11 Thread Alex Williamson
On Thu, 2012-07-12 at 14:38 +1000, Alexey Kardashevskiy wrote: > On 12/07/12 14:31, Alex Williamson wrote: > > On Thu, 2012-07-12 at 14:16 +1000, Alexey Kardashevskiy wrote: > >> On 12/07/12 12:54, Alex Williamson wrote: > >>> On Wed, 2012-07-11 at 12:25 +1000, Alexey Kardashevskiy wrote: > On

Re: [Qemu-devel] [PATCH 0/2] RFC: powerpc-vfio: adding support

2012-07-11 Thread Alexey Kardashevskiy
On 12/07/12 14:31, Alex Williamson wrote: > On Thu, 2012-07-12 at 14:16 +1000, Alexey Kardashevskiy wrote: >> On 12/07/12 12:54, Alex Williamson wrote: >>> On Wed, 2012-07-11 at 12:25 +1000, Alexey Kardashevskiy wrote: On 11/07/12 02:57, Alex Williamson wrote: > On Tue, 2012-07-10 at 15:51

Re: [Qemu-devel] [PATCH 0/2] RFC: powerpc-vfio: adding support

2012-07-11 Thread Alex Williamson
On Thu, 2012-07-12 at 14:16 +1000, Alexey Kardashevskiy wrote: > On 12/07/12 12:54, Alex Williamson wrote: > > On Wed, 2012-07-11 at 12:25 +1000, Alexey Kardashevskiy wrote: > >> On 11/07/12 02:57, Alex Williamson wrote: > >>> On Tue, 2012-07-10 at 15:51 +1000, Alexey Kardashevskiy wrote: > Th

Re: [Qemu-devel] [PATCH 0/2] RFC: powerpc-vfio: adding support

2012-07-11 Thread Alexey Kardashevskiy
On 12/07/12 12:54, Alex Williamson wrote: > On Wed, 2012-07-11 at 12:25 +1000, Alexey Kardashevskiy wrote: >> On 11/07/12 02:57, Alex Williamson wrote: >>> On Tue, 2012-07-10 at 15:51 +1000, Alexey Kardashevskiy wrote: The two patches in this set are supposed to add VFIO support for POWER. >>>

Re: [Qemu-devel] qemu softmmu inlined lookup sequence

2012-07-11 Thread Wei-Ren Chen
On Sat, Apr 21, 2012 at 05:28:36PM -0400, Xin Tong wrote: > On Mon, Apr 16, 2012 at 10:51 PM, 陳韋任 wrote: > >> what does the inline sequence look like ? what kind of things (other > >> than refill tlb) performed in callout but not the inlined sequence ? > > > > What do you mean by the inline seque

[Qemu-devel] [PATCH v2] qemu-img: correct help message

2012-07-11 Thread Dong Xu Wang
qemu-img not only suports k/K/M/G/T/b, but also supports m/g/t/B. So correct it in help message. Signed-off-by: Dong Xu Wang CC: riegama...@gmail.com --- v1->v2: also correct error reporting. qemu-img.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qemu-img.c

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-11 Thread Alex Williamson
On Wed, 2012-07-11 at 12:54 +1000, Alexey Kardashevskiy wrote: > On 11/07/12 02:55, Alex Williamson wrote: > > On Tue, 2012-07-10 at 15:51 +1000, Alexey Kardashevskiy wrote: > >> The patch enables VFIO on POWER. > >> > >> It literally does the following: > >> > >> 1. POWERPC IOMMU support (the kern

Re: [Qemu-devel] [PATCH] qemu-img: correct help message

2012-07-11 Thread Dunrong Huang
2012/7/12 Dong Xu Wang : > qemu-img not only suports k/K/M/G/T/b, but also supports m/g/t/B. So correct > it in help message. > > Signed-off-by: Dong Xu Wang > --- > qemu-img.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 80cfb9

Re: [Qemu-devel] [PATCH 0/2] RFC: powerpc-vfio: adding support

2012-07-11 Thread Alex Williamson
On Wed, 2012-07-11 at 12:25 +1000, Alexey Kardashevskiy wrote: > On 11/07/12 02:57, Alex Williamson wrote: > > On Tue, 2012-07-10 at 15:51 +1000, Alexey Kardashevskiy wrote: > >> The two patches in this set are supposed to add VFIO support for POWER. > >> > >> The first one adds one more step in th

[Qemu-devel] [PATCH] qemu-img: correct help message

2012-07-11 Thread Dong Xu Wang
qemu-img not only suports k/K/M/G/T/b, but also supports m/g/t/B. So correct it in help message. Signed-off-by: Dong Xu Wang --- qemu-img.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 80cfb9b..533eac2 100644 --- a/qemu-img.c +++ b/qe

Re: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized.

2012-07-11 Thread liu ping fan
On Wed, Jul 11, 2012 at 8:27 PM, Igor Mammedov wrote: > On 07/11/2012 09:35 AM, liu ping fan wrote: >> >> On Tue, Jul 10, 2012 at 9:35 PM, Igor Mammedov >> wrote: >>> >>> On 07/09/2012 02:57 PM, Andreas Färber wrote: Am 09.07.2012 12:59, schrieb igor: > > > On 06/20/201

Re: [Qemu-devel] [PATCH v2] device_tree: Add support for reading device tree properties

2012-07-11 Thread Peter Crosthwaite
On Tue, Jul 10, 2012 at 11:32 PM, Peter Maydell wrote: > Add support for reading device tree properties (both generic > and single-cell ones) to QEMU's convenience wrapper layer. > > Signed-off-by: Peter Maydell > --- > Here's a v2: > * added qemu_devtree_get_one_cell_from_prop() which reads a s

[Qemu-devel] [PATCH] SCSI: rd/wr/vr-protect !=0 is an error

2012-07-11 Thread Ronnie Sahlberg
The QEMU SCSI emulation does not support protection information, so any READ/WRITE/VERIFY commands that has the protect bits set to non-zero should fail with ILLEGAL_REQUEST/INVALID_FIELD_IN_CDB >From SCSI SBC : If the logical unit does not support protection information, then the device server sh

[Qemu-devel] [PATCH] SCSI rd/wr/vr protect != 0 is an error

2012-07-11 Thread Ronnie Sahlberg
List, Paolo, Please find a small patch for the scsi emulation in qemu. Since QEMU scsi emulation does not implement/support protection information any READ/WRITE/VERIFY command that specifies a non-zero value for the rd/vr/wr-protect field in the CDB should fail with ILLEGAL_REQUEST/INVALID_FIEL

Re: [Qemu-devel] [PATCH v2] ahci: add -drive support

2012-07-11 Thread Alexander Graf
On 09.07.2012, at 10:50, Markus Armbruster wrote: > Alexander Graf writes: > >> We've had support for creating AHCI devices using -device for a while now, >> but it's cumbersome to users. We really should provide an easier way for >> them to leverage the power of AHCI! >> >> So let's introduce

Re: [Qemu-devel] [PATCH] linux-user: fix segmentation fault passing with g2h(x) != x

2012-07-11 Thread Alexander Graf
On 25.06.2012, at 19:32, Alexander Graf wrote: > When forwarding a segmentation fault into the guest process, we were passing > the host's address directly into the guest process's signal descriptor. > > That obviously confused the guest process, since it didn't know what to make > of the (usual

[Qemu-devel] [PATCH] hw/virtio-scsi: Set max_target=0 during vhost-scsi operation

2012-07-11 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This QEMU patch sets VirtIOSCSIConfig->max_target=0 for vhost-scsi operation to restrict virtio-scsi LLD guest scanning to max_id=0 (a single target ID instance) when connected to individual tcm_vhost endpoints as requested by Paolo. This ensures that virtio-scsi LLD onl

Re: [Qemu-devel] [PATCH 06/13] Add spent time for migration

2012-07-11 Thread Juan Quintela
Luiz Capitulino wrote: > On Wed, 11 Jul 2012 12:25:38 -0600 > Eric Blake wrote: > >> On 07/11/2012 12:08 PM, Luiz Capitulino wrote: >> > On Fri, 29 Jun 2012 18:43:57 +0200 >> > Juan Quintela wrote: >> > >> >> We add time spent for migration to the output of "info migrate" >> >> command. 'total

Re: [Qemu-devel] [PATCH v4 2/7] qapi: Convert getfd and closefd

2012-07-11 Thread Luiz Capitulino
On Fri, 22 Jun 2012 14:36:09 -0400 Corey Bryant wrote: > Signed-off-by: Corey Bryant I've cherry-picked this one into the qmp tree. > --- > v2: > -Convert getfd and closefd to QAPI (lcapitul...@redhat.com) > -Remove changes that returned fd from getfd (lcapitul...@redhat.com) > -Wrap hmp_*

Re: [Qemu-devel] [RFC PATCH 25/36] mirror: add support for on_source_error/on_target_error

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 23:12, Eric Blake ha scritto: >> > +# >> > # Returns: nothing on success >> > # If @device is not a valid block device, DeviceNotFound >> > # If @target can't be opened, OpenFileFailed >> > @@ -1389,7 +1393,8 @@ >> > { 'command': 'drive-mirror', >> >'data': {

Re: [Qemu-devel] [RFC PATCH 30/36] add hierarchical bitmap data type and test cases

2012-07-11 Thread Paolo Bonzini
Il 16/06/2012 01:02, Eric Blake ha scritto: >> > +unsigned long *levels[HBITMAP_LEVELS]; > and at this point, I decided reading the .h first makes more sense. > Also, this is a high-level first-impressions review, not a line-by-line > algorithmic accuracy review. Did you invent this yourself,

Re: [Qemu-devel] [PATCH 06/13] Add spent time for migration

2012-07-11 Thread Luiz Capitulino
On Wed, 11 Jul 2012 12:25:38 -0600 Eric Blake wrote: > On 07/11/2012 12:08 PM, Luiz Capitulino wrote: > > On Fri, 29 Jun 2012 18:43:57 +0200 > > Juan Quintela wrote: > > > >> We add time spent for migration to the output of "info migrate" > >> command. 'total_time' means time since the start f

Re: [Qemu-devel] [PATCH 02/12] savevm: Live migration handlers register the struct directly

2012-07-11 Thread Juan Quintela
Orit Wasserman wrote: > On 07/01/2012 01:20 PM, Juan Quintela wrote: >> Orit Wasserman wrote: >>> On 06/28/2012 10:22 PM, Juan Quintela wrote: Notice that the live migration users never unregister, so no problem about freeing the ops structure. void unregister_savevm(DeviceState *

[Qemu-devel] [Bug 602336] Re: bad network performance with 10Gbit

2012-07-11 Thread zerocoolx
At the moment i'm using version qemu 0.12.3+noroms-0ubuntu9.18 of my ubuntu distribution. I'm triing to compile the latest upstream version during the next two weeks to verify if this is still an issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is sub

Re: [Qemu-devel] [PATCH 06/13] Add spent time for migration

2012-07-11 Thread Eric Blake
On 07/11/2012 12:08 PM, Luiz Capitulino wrote: > On Fri, 29 Jun 2012 18:43:57 +0200 > Juan Quintela wrote: > >> We add time spent for migration to the output of "info migrate" >> command. 'total_time' means time since the start fo migration if >> migration is 'active', and total time of migratio

Re: [Qemu-devel] [PATCH] msi/msix: added API to set MSI message address and data

2012-07-11 Thread Alexander Graf
On 06.07.2012, at 17:58, Jan Kiszka wrote: > On 2012-07-06 17:36, Alexander Graf wrote: >> >> On 02.07.2012, at 09:24, Jan Kiszka wrote: >> >>> On 2012-07-02 06:28, Alexey Kardashevskiy wrote: Ping? On 22/06/12 11:15, Alexey Kardashevskiy wrote: > Added (msi|msix)_set_

Re: [Qemu-devel] [PATCH 06/13] Add spent time for migration

2012-07-11 Thread Luiz Capitulino
On Fri, 29 Jun 2012 18:43:57 +0200 Juan Quintela wrote: > We add time spent for migration to the output of "info migrate" > command. 'total_time' means time since the start fo migration if > migration is 'active', and total time of migration if migration is > completed. As we are also intereste

Re: [Qemu-devel] [PATCH v5 3/3] Change driftfix default value to slew

2012-07-11 Thread Anthony Liguori
Crístian Viana writes: > Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as > the time source. If driftfix is not enabled, Windows is prone to > blue screening. > > Signed-off-by: Crístian Viana Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/mc

Re: [Qemu-devel] [PATCH v5 2/3] Force driftfix=none on previous machines

2012-07-11 Thread Anthony Liguori
Crístian Viana writes: > The current value for the -rtc driftfix option is 'none'. This patch > makes sure that the old machines configuration will work the same way > even after that option changes its default value. > > Signed-off-by: Crístian Viana Reviewed-by: Anthony Liguori Regards, An

Re: [Qemu-devel] [PATCH v5 1/3] Check if GlobalProperty exists before registering

2012-07-11 Thread Anthony Liguori
Crístian Viana writes: > If a GlobalProperty has already been registered, it won't have its > value overwritten. > > Signed-off-by: Crístian Viana > --- > > Changes since v4: > - Only register a GlobalProperty if it hasn't already been registered. That > avoids the property values to be overw

Re: [Qemu-devel] [PATCH 02/12] savevm: Live migration handlers register the struct directly

2012-07-11 Thread Orit Wasserman
On 07/11/2012 08:01 PM, Juan Quintela wrote: > Orit Wasserman wrote: >> On 07/01/2012 01:20 PM, Juan Quintela wrote: >>> Orit Wasserman wrote: On 06/28/2012 10:22 PM, Juan Quintela wrote: > Notice that the live migration users never unregister, so no problem > about freeing the ops s

Re: [Qemu-devel] [PATCH] megasas: Replace trace_megasas_dcmd_dump_frame()

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 13:35, Hannes Reinecke ha scritto: > trace_megasas_dcmd_dump_frame() takes 9 arguments, which is > rather much. Plus the trace infrastructure doesn't support > it anymore. > As we can get the information via other means it's pointless > to have it in the driver, so rather use some pro

Re: [Qemu-devel] [RFC PATCH v2 20/21] Implement -dimms, -dimmspop command line options

2012-07-11 Thread Vasilis Liaskovitis
Hi, On Wed, Jul 11, 2012 at 05:55:25PM +0300, Avi Kivity wrote: > On 07/11/2012 01:32 PM, Vasilis Liaskovitis wrote: > > Implement batch dimm creation command line options. These could be useful > > for > > not bloating the command line with a large number of dimms. > > IMO this is unneeded. Wi

Re: [Qemu-devel] [RFC PATCH v2 19/21] Implement "info memtotal" and "query-memtotal"

2012-07-11 Thread Vasilis Liaskovitis
Hi, On Wed, Jul 11, 2012 at 09:14:29AM -0600, Eric Blake wrote: > On 07/11/2012 04:32 AM, Vasilis Liaskovitis wrote: > > Returns total memory of guest in bytes, including hotplugged memory. > > > > Signed-off-by: Vasilis Liaskovitis > > Should this instead be merged with query-balloon output, s

Re: [Qemu-devel] [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value

2012-07-11 Thread Vasilis Liaskovitis
Hi, On Wed, Jul 11, 2012 at 01:56:19PM +0200, Gerd Hoffmann wrote: > On 07/11/12 12:31, Vasilis Liaskovitis wrote: > > In order to hotplug memory between RamSize and BUILD_PCIMEM_START, the pci > > window needs to start at BUILD_PCIMEM_START (0xe000). > > Otherwise, the guest cannot online new

Re: [Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists

2012-07-11 Thread Vasilis Liaskovitis
Hi, On Wed, Jul 11, 2012 at 08:59:03AM -0600, Eric Blake wrote: > On 07/11/2012 04:31 AM, Vasilis Liaskovitis wrote: > > Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. > > This patch implements a tail queue to store guest notifications for memory > > hot-add and hot-remove

Re: [Qemu-devel] [RFC PATCH v2 04/21][SeaBIOS] acpi: generate hotplug memory devices

2012-07-11 Thread Vasilis Liaskovitis
Hi, On Wed, Jul 11, 2012 at 06:48:38PM +0800, Wen Congyang wrote: > > +if (enabled) > > +add_e820(mem_base, mem_len, E820_RAM); > > add_e820() is declared in memmap.h. You should include this header file, > otherwise, seabios cannot be built. thanks. you had the same comment

Re: [Qemu-devel] [RFC PATCH 23/36] qmp: add drive-mirror command

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 22:12, Eric Blake ha scritto: > On 06/15/2012 09:05 AM, Paolo Bonzini wrote: >> > This adds the monitor commands that start the mirroring job. >> > >> > Signed-off-by: Paolo Bonzini >> > --- >> > blockdev.c | 120 >> > -- >

Re: [Qemu-devel] [RFC PATCH 26/36] block: live snapshot documentation tweaks

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 23:14, Eric Blake ha scritto: > On 06/15/2012 09:05 AM, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> qapi-schema.json |4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 2ee988b..250edf2 100644 >> --- a/qa

Re: [Qemu-devel] [RFC PATCH 14/36] stream: add on_error argument

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 19:58, Eric Blake ha scritto: > On 06/15/2012 09:05 AM, Paolo Bonzini wrote: >> This patch adds support for error management to streaming. >> >> Signed-off-by: Paolo Bonzini >> --- >> block/stream.c | 28 +++- >> block_int.h |3 ++- >> blockdev.c

Re: [Qemu-devel] [RFC PATCH 13/36] block: introduce block job error

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 19:50, Eric Blake ha scritto: >> > { 'type': 'BlockJobInfo', >> >'data': {'type': 'str', 'device': 'str', 'len': 'int', >> > - 'offset': 'int', 'paused': 'bool', 'speed': 'int'} } >> > + 'offset': 'int', 'paused': 'bool', 'speed': 'int', >> > + 'io-s

Re: [Qemu-devel] [RFC PATCH 12/36] block: sort BlockDeviceIoStatus errors by severity

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 19:45, Eric Blake ha scritto: >> > +++ b/qapi-schema.json >> > @@ -429,7 +429,7 @@ >> > # >> > # Since: 1.0 >> > ## >> > -{ 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'failed', 'nospace' ] } >> > +{ 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'nospace', 'failed' ] } > Isn't

Re: [Qemu-devel] [RFC PATCH 06/36] qmp: add block-job-pause and block-job-resume

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 19:32, Eric Blake ha scritto: > Just so I'm clear, am I right that: > > calling block-job-pause multiple times means the subsequent calls are > successful no-ops; likewise, calling block-job-resume on a job not > paused (whether by calling multiple times, or if the job never paused i

Re: [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs

2012-07-11 Thread Michael Roth
On Wed, Jul 11, 2012 at 05:28:26PM +0200, Paolo Bonzini wrote: > Il 11/07/2012 17:25, Michael Roth ha scritto: > > > No reason to leave them out, and it will ensure that the dependencies > > > are picked up. Later we can perhaps move the files to another > > > directory to avoid ../ usage. > > >

Re: [Qemu-devel] [RFC PATCH 01/36] qapi: generalize documentation of streaming commands

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 18:45, Eric Blake ha scritto: > Pre-existing, but do we have any policy on US (canceled) vs. UK > (cancelled) spelling? Obviously, our API spelling is locked into UK > spelling, but if the docs generally prefer US spelling, do we need to > adjust things here? But any such adjustment

Re: [Qemu-devel] [PATCH v3 00/29] Disk geometry cleanup

2012-07-11 Thread Kevin Wolf
Am 10.07.2012 11:12, schrieb Markus Armbruster: > 29 patches may look discouraging, but most patches are small, and the > ones that aren't just move code around. > > Goals of this series: > > 1. One more step towards a clean separation block device host and >guest part. > > 2. Purge CHS geom

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Corey Bryant
On 07/11/2012 10:57 AM, Paolo Bonzini wrote: Il 11/07/2012 16:56, Fabien Chouteau ha scritto: So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were inclined to do so... Unfortunately I don't have time to go deep into the code. It's not a feature I plan to use, so the quicke

Re: [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 17:25, Michael Roth ha scritto: > > No reason to leave them out, and it will ensure that the dependencies > > are picked up. Later we can perhaps move the files to another > > directory to avoid ../ usage. > > Couldn't we accomplish that by just adding the dependencies to qga-obj-y

Re: [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs

2012-07-11 Thread Michael Roth
On Wed, Jul 11, 2012 at 04:40:20PM +0200, Paolo Bonzini wrote: > No reason to leave them out, and it will ensure that the dependencies > are picked up. Later we can perhaps move the files to another > directory to avoid ../ usage. Couldn't we accomplish that by just adding the dependencies to qga

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 16:56, Fabien Chouteau ha scritto: >>> So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were >>> inclined to do so... >>> >>> >> >>> >> Unfortunately I don't have time to go deep into the code. It's not a >>> >> feature I plan to use, so the quickest so

Re: [Qemu-devel] [RFC PATCH v2 19/21] Implement "info memtotal" and "query-memtotal"

2012-07-11 Thread Eric Blake
On 07/11/2012 04:32 AM, Vasilis Liaskovitis wrote: > Returns total memory of guest in bytes, including hotplugged memory. > > Signed-off-by: Vasilis Liaskovitis Should this instead be merged with query-balloon output, so that we have a single command that shows all aspects of memory usage (both

Re: [Qemu-devel] [PATCH] Fix ping issue for linux-user guest

2012-07-11 Thread Dunrong Huang
2012/7/11 Jing Huang : > This patch fix ping issues for linux-user guest. > > * The do_setsockopts function in linux-user does not support SOL_RAW > socket which is used in ping net tool. > > * The recvmsg in main_loop of ping could not fetch > sockaddr_in struct. That is because do_sendrecvmsg in

Re: [Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists

2012-07-11 Thread Eric Blake
On 07/11/2012 04:31 AM, Vasilis Liaskovitis wrote: > Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. > This patch implements a tail queue to store guest notifications for memory > hot-add and hot-remove requests. > > Guest responses for memory hotplug command on a per-dimm b

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Fabien Chouteau
On 07/11/2012 04:22 PM, Corey Bryant wrote: > > > On 07/10/2012 09:37 AM, Fabien Chouteau wrote: >> On 07/10/2012 01:06 PM, Paolo Bonzini wrote: >>> Il 10/07/2012 13:02, Fabien Chouteau ha scritto: Bridge helper uses ioctl's not available on old Linux versions, we add this flag

Re: [Qemu-devel] [RFC PATCH v2 20/21] Implement -dimms, -dimmspop command line options

2012-07-11 Thread Avi Kivity
On 07/11/2012 01:32 PM, Vasilis Liaskovitis wrote: > Implement batch dimm creation command line options. These could be useful for > not bloating the command line with a large number of dimms. IMO this is unneeded. With a management tool there is no problem generating a long command line; from th

Re: [Qemu-devel] [PATCH] Fix ping issue for linux-user guest

2012-07-11 Thread Peter Maydell
Thanks for this patch. Review comments below... (cc'ing the linux-user maintainer) On 11 July 2012 14:56, Jing Huang wrote: > This patch fix ping issues for linux-user guest. > > * The do_setsockopts function in linux-user does not support SOL_RAW > socket which is used in ping net tool. > > * T

[Qemu-devel] [PATCH 2/2] build: get dependency file directories from object file names

2012-07-11 Thread Paolo Bonzini
After commit dcff25f2cd8c11a9368cc2369aeb0319c32d9e26, Dependency file are taken from the directories that have a Makefile.objs file. This is not enough, since files can be included from other directories. So, pick them from directories that have an object file in them. Signed-off-by: Paolo Bonzi

[Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs

2012-07-11 Thread Paolo Bonzini
No reason to leave them out, and it will ensure that the dependencies are picked up. Later we can perhaps move the files to another directory to avoid ../ usage. Signed-off-by: Paolo Bonzini --- Makefile |2 +- qga/Makefile.objs |2 ++ 2 files changed, 3 insertions(+), 1 deleti

[Qemu-devel] [PATCH 0/2] build: get all *.d files

2012-07-11 Thread Paolo Bonzini
Avi and Jan experienced more problem with dependencies. This series should fix them. Paolo Bonzini (2): build: include qapi-generated/ files in qga/Makefile.objs build: get dependency file directories from object file names build: do not use hw/kvm/ Makefile |4 ++-- Make

Re: [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c

2012-07-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.07.2012 11:12, schrieb Markus Armbruster: >> Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, >> except it was put into block.c. Device-specific functionality should >> be kept in device code, not the block layer. Move it to >> hw/hd-geometry.c, and m

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Corey Bryant
On 07/10/2012 09:37 AM, Fabien Chouteau wrote: On 07/10/2012 01:06 PM, Paolo Bonzini wrote: Il 10/07/2012 13:02, Fabien Chouteau ha scritto: Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Which ioctls? Please detect them, so that we c

Re: [Qemu-devel] [v1 Patch 3/10]Qemu: Cmd "block_set_hostcache" for dynamic cache change

2012-07-11 Thread Luiz Capitulino
On Sat, 16 Jun 2012 02:17:30 +0530 Supriya Kannery wrote: > New command "block_set_hostcache" added for dynamically changing > host pagecache setting of a block device. > > Usage: > block_set_hostcache > = block device > = on/off > > Example: > (qemu) block_set_hostcache ide0-hd0

[Qemu-devel] [PATCH V3] Add --disable-bridge-helper configure flag

2012-07-11 Thread Fabien Chouteau
Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Signed-off-by: Fabien Chouteau --- Makefile |2 +- configure | 42 ++ 2 files changed, 43 insertions(+), 1 deletion(-) diff --git a/Makefile b/Ma

Re: [Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-07-11 Thread Avi Kivity
On 07/06/2012 08:11 AM, Markus Armbruster wrote: > > It seems there could be more knobs to control than just "dump guest > state yes/no". Therefore, extensible command line syntax like > "--core-dump guest-ram=off" seems to be advisable. We have too many > -dont-do-FOO options already. -m 2T,du

Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting

2012-07-11 Thread Luiz Capitulino
On Mon, 09 Jul 2012 16:43:40 +0200 Kevin Wolf wrote: > Am 15.06.2012 23:07, schrieb Eric Blake: > > On 06/15/2012 02:47 PM, Supriya Kannery wrote: > >> Enhance "info block" to display hostcache setting for each > >> block device. > >> > > > >> ## > >> { 'type': 'BlockInfo', > >>'data': {'d

[Qemu-devel] [PATCH] Fix ping issue for linux-user guest

2012-07-11 Thread Jing Huang
This patch fix ping issues for linux-user guest. * The do_setsockopts function in linux-user does not support SOL_RAW socket which is used in ping net tool. * The recvmsg in main_loop of ping could not fetch sockaddr_in struct. That is because do_sendrecvmsg in linux-user does not pass the msg->m

Re: [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c

2012-07-11 Thread Kevin Wolf
Am 10.07.2012 11:12, schrieb Markus Armbruster: > Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, > except it was put into block.c. Device-specific functionality should > be kept in device code, not the block layer. Move it to > hw/hd-geometry.c, and make stylistic changes requi

Re: [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage)

2012-07-11 Thread Anthony Liguori
On 07/11/2012 08:15 AM, Paolo Bonzini wrote: Il 11/07/2012 14:39, Kevin Wolf ha scritto: Am 11.07.2012 07:25, schrieb Michael Tokarev: On 11.07.2012 09:09, Stefan Weil wrote: Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW) because it partially replaced "ret" by "count". It

[Qemu-devel] [PATCH 4/4] hw/block-common: Factor out fall back to legacy -drive cyls=...

2012-07-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/block-common.c | 40 hw/block-common.h |2 ++ hw/ide/core.c | 24 hw/ide/qdev.c | 19 ++- hw/scsi-disk.c| 31 +++ hw/virti

Re: [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage)

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 14:39, Kevin Wolf ha scritto: > Am 11.07.2012 07:25, schrieb Michael Tokarev: >> On 11.07.2012 09:09, Stefan Weil wrote: >>> Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW) >>> because it partially replaced "ret" by "count". >>> >>> It also changed the handling of E

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-11 Thread Wei-Ren Chen
On Wed, Jul 11, 2012 at 02:09:53PM +0100, Peter Maydell wrote: > On 11 July 2012 13:54, Kevin Wolf wrote: > > Does this patch improve anything? Last time I checked, qemu only > > compiled on gcc anyway. > > It would be nice to be able to compile with LLVM/Clang; however > since Clang supports the

Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255

2012-07-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 05.07.2012 18:39, schrieb Markus Armbruster: >> Markus Armbruster writes: >> >>> Kevin Wolf writes: >>> Am 29.06.2012 17:34, schrieb Markus Armbruster: > New limits straight from ATA4 6.2 Register delivered data transfer > command sector addressing. > >

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-11 Thread Peter Maydell
On 11 July 2012 13:54, Kevin Wolf wrote: > Does this patch improve anything? Last time I checked, qemu only > compiled on gcc anyway. It would be nice to be able to compile with LLVM/Clang; however since Clang supports the ?: gcc extension this patch doesn't move us any further in that direction.

[Qemu-devel] [PATCH 2/4] hw/block-common: Factor out fall back to legacy -drive serial=...

2012-07-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/Makefile.objs |2 +- hw/block-common.c| 24 hw/block-common.h|3 +++ hw/ide/qdev.c| 12 ++-- hw/scsi-disk.c |8 +--- hw/usb/dev-storage.c | 10 ++ hw/virtio-blk.c

[Qemu-devel] [PATCH 1/4] hw/block-common: Move BlockConf & friends from block.h

2012-07-11 Thread Markus Armbruster
This stuff doesn't belong to block layer, and was put there only because a better home didn't exist then. Now it does. Signed-off-by: Markus Armbruster --- block.h | 45 - hw/block-common.h | 45 ++

[Qemu-devel] [PATCH 0/4] Cleanups around hw/block-common.h

2012-07-11 Thread Markus Armbruster
Applies on top of "[PATCH v3 00/29] Disk geometry cleanup". Markus Armbruster (4): hw/block-common: Move BlockConf & friends from block.h hw/block-common: Factor out fall back to legacy -drive serial=... blockdev: Don't limit DriveInfo serial to 20 characters hw/block-common: Factor out fa

[Qemu-devel] [PATCH 3/4] blockdev: Don't limit DriveInfo serial to 20 characters

2012-07-11 Thread Markus Armbruster
All current users (IDE, SCSI and virtio-blk) happen to share this 20 characters limit. Still, it should be left to device models. They already enforce their limits. They have to, as the DriveInfo limit only affects legacy -drive serial=..., not the qdev properties. usb-storage, which doesn't li

Re: [Qemu-devel] [PATCH v4] sheepdog: do not blindly memset all read buffers

2012-07-11 Thread Kevin Wolf
Am 10.07.2012 20:06, schrieb MORITA Kazutaka: > At Tue, 10 Jul 2012 16:12:27 +0200, > Christoph Hellwig wrote: >> >> Only buffers that map to unallocated blocks need to be zeroed. >> >> Signed-off-by: Christoph Hellwig >> >> --- >> block/sheepdog.c | 37 ++--- >>

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-11 Thread Kevin Wolf
Am 08.07.2012 14:09, schrieb Andreas Schwab: > blauwir...@gmail.com writes: > >> +pstrcpy(bs->backing_format, sizeof(bs->backing_format), >> +backing_fmt ? backing_file : ""); > > s/backing_file/backing_fmt/ Which is why such changes are probably a bad idea. Even more so if they

Re: [Qemu-devel] [PATCH 1/5] qemu-option: add alias support

2012-07-11 Thread Luiz Capitulino
On Wed, 11 Jul 2012 09:00:59 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > It allows for specifying an alias for each option name, see next commits > > examples. > > > > Signed-off-by: Luiz Capitulino > > --- > > qemu-option.c | 9 - > > qemu-option.h | 1 + > > 2 fil

Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types

2012-07-11 Thread Kevin Wolf
Am 08.07.2012 21:22, schrieb blauwir...@gmail.com: > From: Blue Swirl > > Use 'unsigned int' for bit numbers instead of 'unsigned long' or > 'int'. Adjust asserts. > > Signed-off-by: Blue Swirl I haven't followed the original discussion and therefore don't know what the controversy is about (n

Re: [Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 14:08, Avi Kivity ha scritto: > specific command line or guest? >>> >>> qemu-system-x86_64 >>> >> >>> >> Just did the same, but it's all fine here. >> > >> > Ok, I'll debug it. Probably something stupid like a miscompile. > Indeed, a simple clean build fixed it up.

Re: [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage)

2012-07-11 Thread Kevin Wolf
Am 11.07.2012 07:25, schrieb Michael Tokarev: > On 11.07.2012 09:09, Stefan Weil wrote: >> Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW) >> because it partially replaced "ret" by "count". >> >> It also changed the handling of EINTR in a wrong way. >> >> The patch restores the o

Re: [Qemu-devel] [PATCH 4/5] qom-cpu: during cpu reset, it will reset its child

2012-07-11 Thread Igor Mammedov
On 07/11/2012 03:17 AM, liu ping fan wrote: On Tue, Jul 10, 2012 at 6:12 PM, Andreas Färber wrote: Am 10.07.2012 10:41, schrieb Paolo Bonzini: Il 10/07/2012 08:16, Liu Ping Fan ha scritto: This will give the embeded logic module, such as apic has the opportunity to reset. Signed-off-by: Liu

Re: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized.

2012-07-11 Thread Igor Mammedov
On 07/11/2012 09:35 AM, liu ping fan wrote: On Tue, Jul 10, 2012 at 9:35 PM, Igor Mammedov wrote: On 07/09/2012 02:57 PM, Andreas Färber wrote: Am 09.07.2012 12:59, schrieb igor: On 06/20/2012 03:35 PM, Andreas Färber wrote: Am 20.06.2012 14:59, schrieb Igor Mammedov: It's not correct t

[Qemu-devel] [RFC PATCH v2 15/21] acpi_piix4: _OST dimm support

2012-07-11 Thread Vasilis Liaskovitis
This allows qemu to receive notifications from the guest OS on success or failure of a memory hotplug request. The guest OS needs to implement the _OST functionality for this to work (linux-next: http://lkml.org/lkml/2012/6/25/321) Also add new _OST registers in docs/specs/acpi_hotplug.txt Signed-

[Qemu-devel] [RFC PATCH v2 14/21][SeaBIOS] acpi_dsdt: Support _OST dimm method

2012-07-11 Thread Vasilis Liaskovitis
Add support for _OST method. _OST method will write into the correct I/O byte to signal success / failure of hot-add or hot-remove to qemu. Signed-off-by: Vasilis Liaskovitis --- src/acpi-dsdt.dsl | 46 ++ src/ssdt-mem.dsl |4 2 files chan

[Qemu-devel] [RFC PATCH v2 00/21] ACPI memory hotplug

2012-07-11 Thread Vasilis Liaskovitis
This is v2 of the ACPI memory hotplug prototype for x86_64 target. Changes v1->v2 - memory map is automatically calculated for hotplug dimms. Dimms are added from top-of-memory skipping the pci hole at [PCI_HOLE_START, 4G). - Renamed from "-memslot" to "-dimm". Commands changed to "dimm_add", "d

Re: [Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Avi Kivity
On 07/11/2012 02:55 PM, Jan Kiszka wrote: > On 2012-07-11 13:46, Avi Kivity wrote: >> Current qemu-kvm master merged with latest upstream fails on startup: >> >> (gdb) bt >> #0 0x7fdcd4a047a0 in kvm_vcpu_ioctl (env=0x0, type=-1071075694) at >> /home/tlv/akivity/qemu/kvm-all.c:1602 >> #1 0x00

[Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists

2012-07-11 Thread Vasilis Liaskovitis
Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. This patch implements a tail queue to store guest notifications for memory hot-add and hot-remove requests. Guest responses for memory hotplug command on a per-dimm basis can be detected with the new hmp command "info memhp" or

  1   2   >