On 07/11/2012 04:22 PM, Corey Bryant wrote: > > > On 07/10/2012 09:37 AM, Fabien Chouteau wrote: >> On 07/10/2012 01:06 PM, Paolo Bonzini wrote: >>> Il 10/07/2012 13:02, Fabien Chouteau ha scritto: >>>>>>>> Bridge helper uses ioctl's not available on old Linux versions, we add >>>>>>>> this flag to disable the build. >>>>>> >>>>>> Which ioctls? Please detect them, so that we can also work around them >>>>>> perhaps. >>>>>> >>>> There SIOCBRADDIF at least, maybe it's the only one. >>> >>> So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were >>> inclined to do so... >>> >> >> Unfortunately I don't have time to go deep into the code. It's not a >> feature I plan to use, so the quickest solution for me is to disable it. >> >> Corey, I can see that you developed the bridge helper, can you please >> take a look at this issue? >> > > Apologies, I was out yesterday. I see your new patch series is progressing. > I'll take over if/when you want. >
Beside the --enable/--disable patch, there's another question for you. Is it possible to implement qemu-bridge-adapter without SIOCBRADDIF? Thanks, -- Fabien Chouteau
