On 07/11/2012 08:15 AM, Paolo Bonzini wrote:
Il 11/07/2012 14:39, Kevin Wolf ha scritto:
Am 11.07.2012 07:25, schrieb Michael Tokarev:
On 11.07.2012 09:09, Stefan Weil wrote:
Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW)
because it partially replaced "ret" by "count".
It also changed the handling of EINTR in a wrong way.
The patch restores the old code for these two changes.
Signed-off-by: Stefan Weil<s...@weilnetz.de>
Signed-off-by: Michael Tokarev<m...@tls.msk.ru>
Granted, I never _ever_ tested or even compiled this
part. Should have been. Thank you Stefan!
Then I guess you should not have sent a pull request. :-)
Not that Anthony would have tested mingw...
Nope. It's not efficient to rely on the maintainer to do your testing for you.
If you modify code in a non-trivial way, you should attempt to test it.
Anyway, I'll apply this patch ASAP.
Regards,
Anthony Liguori
Paolo
