Re: [Qemu-devel] [PATCH 1/2] ide: convert ide_sector_read() to asynchronous I/O

2012-03-28 Thread Michael Tokarev
On 28.03.2012 19:43, Stefan Hajnoczi wrote: ... > void ide_sector_read(IDEState *s) > { ... > +s->iov.iov_base = s->io_buffer; > +s->iov.iov_len = n * BDRV_SECTOR_SIZE; > +qemu_iovec_init_external(&s->qiov, &s->iov, 1); > +bdrv_aio_readv(s->bs, sector_num, &s->qiov, n, > +

Re: [Qemu-devel] [PATCH 1/2] ide: convert ide_sector_read() to asynchronous I/O

2012-03-28 Thread Michael Tokarev
On 28.03.2012 19:43, Stefan Hajnoczi wrote: > void ide_sector_read(IDEState *s) > { [] > +s->iov.iov_base = s->io_buffer; > +s->iov.iov_len = n * BDRV_SECTOR_SIZE; > +qemu_iovec_init_external(&s->qiov, &s->iov, 1); > + > +bdrv_acct_start(s->bs, &s->acct, n * BDRV_SECTOR_SIZE, BDR

Re: [Qemu-devel] [PATCH] pci: Factor out bounds checking on config space accesses

2012-03-28 Thread David Gibson
On Wed, Mar 28, 2012 at 11:30:56AM +0200, Michael S. Tsirkin wrote: > On Wed, Mar 28, 2012 at 12:11:52PM +1100, David Gibson wrote: > > Michael, > > > > Any chance of an ack or nack on this one? > > > > On Mon, Mar 19, 2012 at 03:58:11PM +1100, David Gibson wrote: > > > There are several paths in

[Qemu-devel] [PATCH] qemu tcg: Remove one entry of INDEX_op_ld_i64 from ppc_op_defs

2012-03-28 Thread David Gibson
From: Li Zhang There two entries of INDEX_op_ld_i64 in the ppc_op_defs. That causes an assertion failure in tcg_add_target_add_op_defs() when --enable-debug is used on a ppc64 backend (that's ppc64 host, not target). Signed-off-by: Li Zhang Signed-off-by: David Gibson --- tcg/ppc64/tcg-targe

Re: [Qemu-devel] [PATCH v1 0/2] Xilinx Zynq PL330 support

2012-03-28 Thread Peter Crosthwaite
Sorry should be RFC On Thu, Mar 29, 2012 at 12:54 PM, Peter A. G. Crosthwaite wrote: > Hi, > > These patches add support for the Primcell PL330 DMA controller and add it to > the Xilinx Zynq machine model. Patch 1 is the device model. Patch 2 is the > machine model update. > > Thw Device model

Re: [Qemu-devel] [Xen-devel] [PATCH V10 4/8] pci.c: Add opaque argument to pci_for_each_device.

2012-03-28 Thread Konrad Rzeszutek Wilk
On Wed, Mar 28, 2012 at 12:41:43PM +0100, Anthony PERARD wrote: What is purpose of it? Can you give more details please? > Signed-off-by: Anthony PERARD > Acked-by: Stefano Stabellini > --- > hw/pci.c | 11 +++ > hw/pci.h |4 +++- > hw/xen_platform.c |8

Re: [Qemu-devel] [Xen-devel] [PATCH V10 2/8] configure: Introduce --enable-xen-pci-passthrough.

2012-03-28 Thread Konrad Rzeszutek Wilk
On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > Acked-by: Stefano Stabellini Reviewed-by: me. > --- > configure | 25 + > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > ind

[Qemu-devel] [PATCH v1 1/2] pl330: initial version

2012-03-28 Thread Peter A. G. Crosthwaite
Device model for Primecell PL330 dma controller. Signed-off-by: Peter A. G. Crosthwaite --- MAINTAINERS |1 + Makefile.target |1 + hw/pl330.c | 1395 +++ 3 files changed, 1397 insertions(+), 0 deletions(-) create mode 100644

[Qemu-devel] [PATCH v1 2/2] xilinx_zynq: added pl330 to machine model

2012-03-28 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_zynq.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index 7290c64..033ba09 100644 --- a/hw/xilinx_zynq.c +++ b/hw/xilinx_zynq.c @@ -61,6 +61,9 @@ static void zynq

[Qemu-devel] [PATCH v1 0/2] Xilinx Zynq PL330 support

2012-03-28 Thread Peter A. G. Crosthwaite
Hi, These patches add support for the Primcell PL330 DMA controller and add it to the Xilinx Zynq machine model. Patch 1 is the device model. Patch 2 is the machine model update. Thw Device model was originally contributed by Kirill Batuzov / Samsung, as indicated by the (C) notice in hw/pl330

[Qemu-devel] [Bug 614958] Re: copy-paste between client and host

2012-03-28 Thread Steve White
Hi Michel, It may be out of scope for qemu -- the scope is for the developers to decide. My point remains though: If this functionality isn't there when the user installs qemu, they will find another solution. It won't be hard to find. I have watched this happen. Perhaps there's some synthesis

Re: [Qemu-devel] [Xen-devel] [PATCH V10 1/8] pci_ids: Add INTEL_82599_SFP_VF id.

2012-03-28 Thread Konrad Rzeszutek Wilk
On Wed, Mar 28, 2012 at 12:41:40PM +0100, Anthony PERARD wrote: You really should say why this is added.. It is so odd just to have 'add this' without any justification. Can you at least say: "We are using this in our quirk lookup provided by patch titled: XXXYYY" ? > Signed-off-by: Anthony PERA

Re: [Qemu-devel] [SeaBIOS] [PATCH 1/4] Add basic linked list operations

2012-03-28 Thread Kevin O'Connor
On Wed, Mar 28, 2012 at 04:39:07PM +0200, Gerd Hoffmann wrote: > On 03/28/12 06:28, Alexey Korolev wrote: > > This linked list implementation is partially based on kernel code. So it > > should be quite stable > > How about just copying the file? > > I've used the linux kernel list implementation

Re: [Qemu-devel] [PATCH 0/2] ide: convert pio code path to asynchronous I/O

2012-03-28 Thread Zhi Yong Wu
On Wed, Mar 28, 2012 at 11:43 PM, Stefan Hajnoczi wrote: > IDE PIO mode is currently implemented using synchronous I/O functions.   > There's > no need to do this because the IDE interface is actually designed with polling > and interrupts in mind - we can do asynchronous I/O and let the guest kno

Re: [Qemu-devel] [Xen-devel] [PATCH V10 2/8] configure: Introduce --enable-xen-pci-passthrough.

2012-03-28 Thread Konrad Rzeszutek Wilk
On Wed, Mar 28, 2012 at 04:02:04PM -0500, Anthony Liguori wrote: > On 03/28/2012 01:52 PM, Konrad Rzeszutek Wilk wrote: > >On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote: > >>Signed-off-by: Anthony PERARD > >>Acked-by: Stefano Stabellini > > > > > >Reviewed-by: me. > > FYI, the scr

Re: [Qemu-devel] [Xen-devel] [PATCH V10 3/8] Introduce XenHostPCIDevice to access a pci device on the host.

2012-03-28 Thread Konrad Rzeszutek Wilk
> +static int xen_host_pci_sysfs_path(const XenHostPCIDevice *d, > + const char *name, char *buf, ssize_t size) > +{ > +int rc; > + > +rc = snprintf(buf, size, "/sys/bus/pci/devices/%04x:%02x:%02x.%x/%s", The format is actually " %04x:%02x:%02x.%d" > +

Re: [Qemu-devel] [SeaBIOS] [PATCH 1/4] Add basic linked list operations

2012-03-28 Thread Alexey Korolev
>> This linked list implementation is partially based on kernel code. So it >> should be quite stable > How about just copying the file? > > I've used the linux kernel list implementation elsewhere too and it > worked just fine with only minor tweaks (remove some likely()/unlikely() > macros IIRC)

Re: [Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris

2012-03-28 Thread Andreas Färber
Am 27.03.2012 19:24, schrieb Blue Swirl: > On Tue, Mar 27, 2012 at 13:56, Andreas Färber wrote: >> [...] While the MAINTAINER host support >> sections do not list me (they're still new in there), Solaris patches >> have traditionally gone through me, so that is not a particular reaction >> to the

[Qemu-devel] [PATCH] w32/slirp: Undefine error constants before their redefinition

2012-03-28 Thread Jan Kiszka
Less warnings for your console. Signed-off-by: Jan Kiszka --- I'll carry this in my queue. slirp/slirp.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index 2098b20..46bfe46 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -15,6 +1

[Qemu-devel] [PATCH 7/7] qdev: switch property accessors to fixed-width visitor interfaces

2012-03-28 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/qdev-addr.c |4 +- hw/qdev-properties.c | 140 ++ 2 files changed, 87 insertions(+), 57 deletions(-) diff --git a/hw/qdev-addr.c b/hw/qdev-addr.c index 0bb16c7..b711b6b 100644 --- a/hw/qdev-addr.c +++

[Qemu-devel] [PATCH 1/7] qapi: add Visitor interfaces for uint*_t and int*_t

2012-03-28 Thread Michael Roth
This adds visitor interfaces for fixed-width integers types. Implementing these in visitors is optional, otherwise we fall back to visit_type_int() (int64_t) with some additional bounds checking to avoid integer overflows for cases where the value fetched exceeds the bounds of our target C type. S

[Qemu-devel] [PATCH 3/7] qapi: QMP input visitor, handle floats parsed as ints

2012-03-28 Thread Michael Roth
JSON numbers can be interpreted as either integers or floating point values depending on their representation. As a result, QMP input visitor might visit a QInt when it was expecting a QFloat, so add handling to account for this. Signed-off-by: Michael Roth --- qapi/qmp-input-visitor.c |9 ++

[Qemu-devel] [PATCH 2/2] qapi: convert device_del

2012-03-28 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c |9 + hmp.h |1 + hw/qdev-monitor.c | 15 +++ qapi-schema.json | 20 qmp-commands.hx |5 + 6 files changed

Re: [Qemu-devel] [Xen-devel] [PATCH V10 2/8] configure: Introduce --enable-xen-pci-passthrough.

2012-03-28 Thread Anthony Liguori
On 03/28/2012 01:52 PM, Konrad Rzeszutek Wilk wrote: On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote: Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini Reviewed-by: me. FYI, the scripts that I use to manage patches will collect Reviewed-by's and put them in the comm

[Qemu-devel] [PATCH 1/2] qdev: qdev_unplug(): Use error_set()

2012-03-28 Thread Luiz Capitulino
It currently uses qerror_report(), but next commits will convert the drive_del command to the QAPI and this requires using error_set(). One particularity of qerror_report() is that it knows when it's running on monitor context or command-line context and prints the error message accordingly. error

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Implement RTAS system-reboot call

2012-03-28 Thread David Gibson
On Wed, Mar 28, 2012 at 06:15:18PM +0200, Andreas Färber wrote: > Am 28.03.2012 03:05, schrieb David Gibson: > > This patch adds the PAPR defined RTAS system-reboot call to the pseries > > machine emulation, providing the guest with a way to trigger a reboot. > > This exposes a bug in the pseries V

[Qemu-devel] [PATCH v4 0/7] add fixed-width visitors and serialization tests

2012-03-28 Thread Michael Roth
These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git visitor-fixed-width-v4 CHANGES SINCE V3: - Rebased on master and re-tested CHANGES SINCE V2: - Fix qemu-test errors due to now-strict bounds-checking we doing assignment between sig

[Qemu-devel] [PATCH 2/3] pseries: Fix bug with reset of VIO CRQs

2012-03-28 Thread David Gibson
PAPR specifies a Command Response Queue (CRQ) mechanism used for virtual IO, which we implement. However, we don't correctly clean up registered CRQs when we reset the system. This patch adds a reset handler to fix this bug. While we're at it, add in some of the extra debug messages that were us

[Qemu-devel] [PATCH 4/7] qapi: add String visitor coverage to serialization unit tests

2012-03-28 Thread Michael Roth
Signed-off-by: Michael Roth --- test-visitor-serialization.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/test-visitor-serialization.c b/test-visitor-serialization.c index 6ef57d0..b8ad16f 100644 --- a/test-visitor-serialization

[Qemu-devel] [PATCH 1/3] pseries: Clean up hcall_dprintf() debugging messages

2012-03-28 Thread David Gibson
The pseries machine code has a number of debug messages for debugging PAPR hypercalls, dependent on DEBUG_SPAPR_HCALLS. This patch cleans these messages up a bit, by adding __func__ to the hcall_dprintf() macro and simplifying up a number of the individual messages accordingly. Signed-off-by: Dav

[Qemu-devel] [PATCH 3/3] pseries: Implement RTAS system-reboot call

2012-03-28 Thread David Gibson
This patch adds the PAPR defined RTAS system-reboot call to the pseries machine emulation, providing the guest with a way to trigger a reboot. This exposes a bug in the pseries VIO code which means CRQs are not properly reset on a system reset. This patch also fixes that bug by adding a suitable r

Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path

2012-03-28 Thread Michael Roth
On Thu, Mar 22, 2012 at 04:12:12PM +0100, Andreas Färber wrote: > Am 22.03.2012 15:37, schrieb Gerd Hoffmann: > >>> +.driver = "USB", > >>> +.property = "full-path", > >>> +.value= "no", > >> > >> This touches on our "favorite" bit/bool topic again. While I

[Qemu-devel] [PATCH 2/7] qapi: unit tests for visitor-based serialization

2012-03-28 Thread Michael Roth
Currently we test our visitors individually, and seperately for input vs. output. This is useful for validating internal representations against the native C types and vice-versa, and other visitor-specific testing, but it doesn't cover the potential use-case of using visitor pairs for serializatio

[Qemu-devel] [PATCH 6/7] qdev: use int32_t container for devfn property

2012-03-28 Thread Michael Roth
Valid range for devfn is -1 to 255 (-1 for automatic assignment). We do not currently validate this due to devfn being stored as a uint32_t. This can lead to segfaults and other strange behavior. We could technically just cast it to int32_t to implement the checking, but this will not work for vis

[Qemu-devel] [PATCH 5/7] qapi: String visitor, use %f represenation for floats

2012-03-28 Thread Michael Roth
Currently string-output-visitor formats floats as %g, which is nice in that trailing 0's are automatically truncated, but otherwise this causes some issues: - it 6 uses significant figures instead of 6 decimal places, which means something like 155777.5 (which even has an exact floating point

[Qemu-devel] [PATCH 0/2]: convert device_del to the qapi

2012-03-28 Thread Luiz Capitulino
Please, check individual patches for details. hmp-commands.hx |3 +-- hmp.c|9 + hmp.h|1 + hw/pci-hotplug.c | 15 --- hw/qdev-monitor.c| 18 +- hw/qdev.c|5 +++-- hw/qdev.h

[Qemu-devel] [PATCH] w32: Undefine error constants before their redefinition

2012-03-28 Thread Jan Kiszka
Avoids lots of warnings. Signed-off-by: Jan Kiszka --- qemu_socket.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu_socket.h b/qemu_socket.h index fe4cf6c..51ad210 100644 --- a/qemu_socket.h +++ b/qemu_socket.h @@ -8,7 +8,9 @@ #include #define socket_error()

Re: [Qemu-devel] [PATCH] kvm: set gsi_bits and max_gsi correctly

2012-03-28 Thread Jan Kiszka
On 2012-03-28 20:20, Alex Williamson wrote: > On Wed, 2012-03-28 at 14:18 -0400, Jason Baron wrote: >> The current kvm_init_irq_routing() doesn't set up the used_gsi_bitmap >> correctly, and as a consequence pins max_gsi to 32 when it really >> should be 1024. I ran into this limitation while testi

Re: [Qemu-devel] [PATCH 0/2] slirp: remove fd_block/fd_nonblock

2012-03-28 Thread Jan Kiszka
On 2012-03-22 01:02, Paolo Bonzini wrote: > Of these two functions, one is unused and the other is a dup of > socket_set_nonblock. Unfortunately, there are some conflicts > with system headers that need to be sorted out first. > > Paolo Bonzini (2): > slirp: clean up conflicts with system heade

[Qemu-devel] [PATCH] usb-ehci: frindex always is a 14 bits counter

2012-03-28 Thread Hans de Goede
frindex always is a 14 bits counter, and not a 13 bits one as we were emulating. There are some subtle hints to this in the spec, first of all "Table 2-12. FRINDEX - Frame Index Register" says: "Bit 13:0 Frame Index. The value in this register increments at the end of each time frame (e.g. micro-fr

Re: [Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris

2012-03-28 Thread Andreas Färber
Am 27.03.2012 19:24, schrieb Blue Swirl: > On Tue, Mar 27, 2012 at 13:56, Andreas Färber wrote: >> Am 27.03.2012 15:06, schrieb Stefan Hajnoczi: >>> On Tue, Mar 27, 2012 at 1:01 PM, Lee Essen >>> wrote: On 27/03/2012 12:31, Andreas Färber wrote: > > Am 27.03.2012 09:23, schrieb Stef

Re: [Qemu-devel] [PATCH] kvm: set gsi_bits and max_gsi correctly

2012-03-28 Thread Alex Williamson
On Wed, 2012-03-28 at 14:18 -0400, Jason Baron wrote: > The current kvm_init_irq_routing() doesn't set up the used_gsi_bitmap > correctly, and as a consequence pins max_gsi to 32 when it really > should be 1024. I ran into this limitation while testing pci > passthrough, where I consistently got an

[Qemu-devel] [PATCH] kvm: set gsi_bits and max_gsi correctly

2012-03-28 Thread Jason Baron
The current kvm_init_irq_routing() doesn't set up the used_gsi_bitmap correctly, and as a consequence pins max_gsi to 32 when it really should be 1024. I ran into this limitation while testing pci passthrough, where I consistently got an -ENOSPC return from kvm_get_irq_route_gsi() called from assig

Re: [Qemu-devel] [PATCH 3/3] sparc64: implement PCI and ISA irqs

2012-03-28 Thread Artyom Tarasenko
On 3/27/12, Blue Swirl wrote: > On Tue, Mar 27, 2012 at 18:19, Artyom Tarasenko wrote: >> On Sun, Mar 11, 2012 at 12:02 PM, Blue Swirl wrote: >>> Generate correct trap for external interrupts. Map PCI and ISA IRQs to >>> RIC/UltraSPARC-IIi interrupt vectors. >>> >>> Signed-off-by: Blue Swirl >>

Re: [Qemu-devel] [PATCH V15 0/7] Qemu Trusted Platform Module (TPM) integration

2012-03-28 Thread Stefan Berger
On 03/27/2012 05:43 PM, Anthony Liguori wrote: On 03/27/2012 03:24 PM, Stefan Berger wrote: The following series of patches adds TPM (Trusted Platform Module) support to Qemu. An emulator for the TIS (TPM Interface Spec) interface is added that provides the basis for accessing a 'backend' imple

Re: [Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris

2012-03-28 Thread Andreas Färber
Am 27.03.2012 19:06, schrieb Blue Swirl: > On Tue, Mar 27, 2012 at 13:14, Andreas Färber wrote: >> Am 27.03.2012 14:01, schrieb Lee Essen: >>> On 27/03/2012 12:31, Andreas Färber wrote: Am 27.03.2012 09:23, schrieb Stefan Hajnoczi: > On Sat, Mar 24, 2012 at 04:26:27PM +, Lee Essen wro

Re: [Qemu-devel] [PATCH v4 0/7] new test infrastructure + qtest

2012-03-28 Thread Anthony Liguori
On 03/28/2012 08:42 AM, Paolo Bonzini wrote: This is a rebase of qtest. I split the gtester infrastructure into its own patch, and reorganized the tests by moving everything into tests/. Also, libqtest now has bindings for the clock management commands, and I am using them in rtc-test. Finally

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Jan Kiszka
On 2012-03-28 19:06, Michael S. Tsirkin wrote: > On Wed, Mar 28, 2012 at 06:53:01PM +0200, Jan Kiszka wrote: >> On 2012-03-28 18:30, Michael S. Tsirkin wrote: >>> On Wed, Mar 28, 2012 at 06:00:03PM +0200, Jan Kiszka wrote: On 2012-03-28 17:43, Michael S. Tsirkin wrote: > On Wed, Mar 28, 20

Re: [Qemu-devel] [PATCH stable-0.15 00/36] Preparing 0.15.2

2012-03-28 Thread Stefan Weil
Am 28.03.2012 14:52, schrieb Andreas Färber: Hello Anthony and Justin, As announced last year, SUSE is shipping a patched qemu-kvm 0.15.1 with our recently released SLES 11 SP2. We are therefore very interested in cutting 0.15.2 releases for QEMU and later on qemu-kvm. This series contains on

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Michael S. Tsirkin
On Wed, Mar 28, 2012 at 06:53:01PM +0200, Jan Kiszka wrote: > On 2012-03-28 18:30, Michael S. Tsirkin wrote: > > On Wed, Mar 28, 2012 at 06:00:03PM +0200, Jan Kiszka wrote: > >> On 2012-03-28 17:43, Michael S. Tsirkin wrote: > >>> On Wed, Mar 28, 2012 at 01:36:15PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Jan Kiszka
On 2012-03-28 18:30, Michael S. Tsirkin wrote: > On Wed, Mar 28, 2012 at 06:00:03PM +0200, Jan Kiszka wrote: >> On 2012-03-28 17:43, Michael S. Tsirkin wrote: >>> On Wed, Mar 28, 2012 at 01:36:15PM +0200, Jan Kiszka wrote: On 2012-03-28 13:31, Michael S. Tsirkin wrote: > Also, how woul

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] PPC: Fix TLB invalidation bug within the PPC interrupt handler.

2012-03-28 Thread Andreas Färber
Am 28.03.2012 02:45, schrieb David Gibson: > On Tue, Mar 27, 2012 at 04:41:55PM +0100, Mark Cave-Ayland wrote: >> Commit 41557447d30eeb944e42069513df13585f5e6c7f also introduced a subtle TLB >> flush bug. By applying a mask to the interrupt MSR which cleared the IR/DR >> bits at the start of the in

Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words

2012-03-28 Thread Peter Maydell
2012/3/28 Alon Levy : > -        # 'limit' is a reserved keyword > -        if [ "$arg" = "limit" ]; then > -          arg="_limit" > +        # 'limit', 'in' and 'next' are reserved keywords > +        if [ "$arg" = "limit" -o "$arg" = "in" -o "$arg" = "next" ]; then > +          arg="_$arg" >    

Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words

2012-03-28 Thread Eric Blake
On 03/28/2012 10:26 AM, Lee Essen wrote: >> +# 'limit', 'in' and 'next' are reserved keywords >> +if [ "$arg" = "limit" -o "$arg" = "in" -o "$arg" = "next" ]; then [ ... -o ... ] is not portable. POSIX says you must break it into: [ ... ] || [ ... ] or, more efficiently for this

Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words

2012-03-28 Thread Lee Essen
On 28 Mar 2012, at 15:26, Alon Levy wrote: > Signed-off-by: Alon Levy > --- > scripts/tracetool |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/tracetool b/scripts/tracetool > index 65bd0a1..e7cebf3 100755 > --- a/scripts/tracetool > +++ b/scripts/tracet

Re: [Qemu-devel] [PATCH 00/12 v11] introducing a new, dedicated guest memory dump mechanism

2012-03-28 Thread Luiz Capitulino
On Wed, 28 Mar 2012 13:17:43 +0800 Wen Congyang wrote: > Hi, Luiz, Anthony, Jan > > do you have any comments about this patchset? As far as QMP is concerned: Acked-by: Luiz Capitulino This can go through me tree, but I'd like an ACK from Jan and/or Anthony.

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Michael S. Tsirkin
On Wed, Mar 28, 2012 at 06:00:03PM +0200, Jan Kiszka wrote: > On 2012-03-28 17:43, Michael S. Tsirkin wrote: > > On Wed, Mar 28, 2012 at 01:36:15PM +0200, Jan Kiszka wrote: > >> On 2012-03-28 13:31, Michael S. Tsirkin wrote: > >>> Also, how would this support irqfd in the future? Will we have t

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Jan Kiszka
On 2012-03-28 17:43, Michael S. Tsirkin wrote: > On Wed, Mar 28, 2012 at 01:36:15PM +0200, Jan Kiszka wrote: >> On 2012-03-28 13:31, Michael S. Tsirkin wrote: >>> Also, how would this support irqfd in the future? Will we have to >>> rip it all out and replace with per-device tracking that w

Re: [Qemu-devel] [PATCH] pseries: Implement RTAS system-reboot call

2012-03-28 Thread Andreas Färber
Am 28.03.2012 03:05, schrieb David Gibson: > This patch adds the PAPR defined RTAS system-reboot call to the pseries > machine emulation, providing the guest with a way to trigger a reboot. > This exposes a bug in the pseries VIO code which means CRQs are not > properly reset on a system reset. Th

Re: [Qemu-devel] [PATCH 0/2] ide: convert pio code path to asynchronous I/O

2012-03-28 Thread Paolo Bonzini
Il 28/03/2012 17:43, Stefan Hajnoczi ha scritto: > IDE PIO mode is currently implemented using synchronous I/O functions. > There's > no need to do this because the IDE interface is actually designed with polling > and interrupts in mind - we can do asynchronous I/O and let the guest know > when

Re: [Qemu-devel] [PATCH 0/2] ide: convert pio code path to asynchronous I/O

2012-03-28 Thread Chris Webb
Stefan Hajnoczi writes: > The second aim of this conversion is to avoid calling bdrv_read()/bdrv_write() > since they do not work with I/O throttling. This means guests should now boot > IDE drives successfully when I/O throttling is enabled. [...] > Chris and Richard: Please test this to confir

Re: [Qemu-devel] [RFC][PATCH 1/2] kvm: Introduce basic MSI support in-kernel irqchips

2012-03-28 Thread Michael S. Tsirkin
On Wed, Mar 28, 2012 at 01:44:41PM +0200, Avi Kivity wrote: > On 03/28/2012 01:33 PM, Jan Kiszka wrote: > > On 2012-03-28 13:09, Avi Kivity wrote: > > > On 03/22/2012 01:17 AM, Jan Kiszka wrote: > > >> From: Jan Kiszka > > >> > > >> This patch basically adds kvm_irqchip_send_msi, a service for sen

[Qemu-devel] [PATCH 2/2] ide: convert ide_sector_write() to asynchronous I/O

2012-03-28 Thread Stefan Hajnoczi
The IDE PIO write sector code path uses bdrv_write() and hence can make the guest unresponsive while the I/O request is in progress. This patch converts ide_sector_write() to use bdrv_aio_writev() by using the BUSY_STAT bit to tell the guest that the request is in progress. Signed-off-by: Stefan

[Qemu-devel] [PATCH 0/2] ide: convert pio code path to asynchronous I/O

2012-03-28 Thread Stefan Hajnoczi
IDE PIO mode is currently implemented using synchronous I/O functions. There's no need to do this because the IDE interface is actually designed with polling and interrupts in mind - we can do asynchronous I/O and let the guest know when the operation has completed. The benefit of asynchronous I/

[Qemu-devel] [PATCH 1/2] ide: convert ide_sector_read() to asynchronous I/O

2012-03-28 Thread Stefan Hajnoczi
The IDE PIO interface currently uses bdrv_read() to perform reads synchronously. Synchronous I/O in the vcpu thread is bad because it prevents the guest from executing code - it makes the guest unresponsive. This patch converts IDE PIO to use bdrv_aio_readv(). We simply need to use the BUSY_STAT

Re: [Qemu-devel] [RFC][PATCH 0/2] uq/master: Basic MSI support for in-kernel irqchip mode

2012-03-28 Thread Michael S. Tsirkin
On Wed, Mar 28, 2012 at 01:36:15PM +0200, Jan Kiszka wrote: > On 2012-03-28 13:31, Michael S. Tsirkin wrote: > > Also, how would this support irqfd in the future? Will we have to > > rip it all out and replace with per-device tracking that we > > have today? > > Irqfd and kvm

Re: [Qemu-devel] [PATCH V15 5/7] Add a TPM Passthrough backend driver implementation

2012-03-28 Thread Stefan Berger
On 03/27/2012 05:41 PM, Anthony Liguori wrote: On 03/27/2012 03:24 PM, Stefan Berger wrote: From Andreas Niederl's original posting with adaptations where necessary: This patch is based of off version 9 of Stefan Berger's patch series "Qemu Trusted Platform Module (TPM) integration" and ad

Re: [Qemu-devel] [PATCH RFC] piix: fix up/down races

2012-03-28 Thread Michael S. Tsirkin
On Tue, Mar 27, 2012 at 07:59:07PM +0200, Michael S. Tsirkin wrote: > piix acpi interface suffers from the following 2 issues: > > 1. > - delete device a > - quickly add device b in another slot > > if we do this before guest reads the down register, > the down event is discarded and device will

Re: [Qemu-devel] [PATCH V15 1/7] Support for TPM command line options

2012-03-28 Thread Stefan Berger
On 03/27/2012 05:35 PM, Anthony Liguori wrote: On 03/27/2012 03:24 PM, Stefan Berger wrote: This patch adds support for TPM command line options. The command line options supported here are [...] Monitor support for 'info tpm' has been added. It for example prints the following: (qemu) info

Re: [Qemu-devel] [PATCH] ARM: Permit any ARMv6K CPU to read the MVFR0 and MVFR1 VFP registers.

2012-03-28 Thread Peter Maydell
On 28 March 2012 15:37, Andrew Towers wrote: > From: Andrew Towers > > Replaces the ARM_FEATURE_VFP3 check when reading MVFR0/1 with a check for > ARM_FEATURE_V6K. Rationale: MVFR0/1 were introduced in the ARM1136 at the > same time as ARMv6K, and a survey of TRMs indicates support in later model

Re: [Qemu-devel] [PATCH v2 4/4] qdev: put all devices under /machine

2012-03-28 Thread Paolo Bonzini
Il 28/03/2012 17:10, Andreas Färber ha scritto: >> > if (dev == NULL) { >> > -dev = container_get("/peripheral"); >> > +dev = container_get("/machine/peripheral"); > I was kinda hoping we could even do something like this in 1/4: > container_get_relative(qdev_get_machine(), "pe

[Qemu-devel] [PATCH stable-0.15 04/36] e1000: Don't set the Capabilities List bit

2012-03-28 Thread Andreas Färber
From: dann frazier [Originally sent to qemu-kvm list, but I was redirected here] The Capabilities Pointer is NULL, so this bit shouldn't be set. The state of this bit doesn't appear to change any behavior on Linux/Windows versions we've tested, but it does cause Windows' PCI/PCI Express Complian

[Qemu-devel] [PATCH v4 6/7] rtc: split out macros into a header file and use in test case

2012-03-28 Thread Paolo Bonzini
From: Anthony Liguori Signed-off-by: Anthony Liguori Signed-off-by: Paolo Bonzini --- hw/mc146818rtc.c | 33 -- hw/mc146818rtc.h |3 +- hw/mc146818rtc_regs.h | 62 + 3 files changed, 63 insertions(+), 35

[Qemu-devel] [PATCH stable-0.15 06/36] compatfd.c: Don't pass NULL pointer to SYS_signalfd

2012-03-28 Thread Andreas Färber
From: Peter Maydell Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available(): this isn't valid and Valgrind complains about it. Signed-off-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Signed-off-by: Andrzej Zaborowski (cherry picked from commit 7f84c1272b601be88daeb828ec189

[Qemu-devel] [PATCH stable-0.15 25/36] block: Fix vpc initialization of the Dynamic Disk Header

2012-03-28 Thread Andreas Färber
From: Charles Arnold The Data Offset field in the Dynamic Disk Header is an 8 byte field. Although the specification (2006-10-11) gives an example of initializing only the first 4 bytes, images generated by Microsoft on Windows initialize all 8 bytes. Failure to initialize all 8 bytes results in

[Qemu-devel] [PATCH stable-0.15 30/36] pc: Fix floppy drives with if=none

2012-03-28 Thread Andreas Färber
From: Kevin Wolf Commit 63ffb564 broke floppy devices specified on the command line like -drive file=...,if=none,id=floppy -global isa-fdc.driveA=floppy because it relies on drive_get() which works only with -fda/-drive if=floppy. This patch resembles what we're already doing for IDE, i.e. remem

Re: [Qemu-devel] [PATCH v2 4/4] qdev: put all devices under /machine

2012-03-28 Thread Andreas Färber
Am 28.03.2012 16:34, schrieb Paolo Bonzini: > Avoid cluttering too much the QOM root. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: add qdev_get_machine() and use it. Thanks, > > hw/piix_pci.c |2 +- > hw/ppc_prep.c |2 +- > hw/qdev-monitor.c |4 ++-- > hw/qdev.c

[Qemu-devel] [PATCH stable-0.15 02/36] qdev: Reset hot-plugged devices

2012-03-28 Thread Andreas Färber
From: Jan Kiszka Device models rely on the core invoking their reset handlers after init. We do this in the cold-plug case, but so far we miss this step after hot-plug. Signed-off-by: Jan Kiszka Signed-off-by: Anthony Liguori (cherry picked from commit 5ab28c8340f683121c081a181adfd9f72ab85cba)

[Qemu-devel] [PATCH stable-0.15 07/36] kvm: avoid reentring kvm_flush_coalesced_mmio_buffer()

2012-03-28 Thread Andreas Färber
From: Avi Kivity mmio callbacks invoked by kvm_flush_coalesced_mmio_buffer() may themselves indirectly call kvm_flush_coalesced_mmio_buffer(). Prevent reentering the function by checking a flag that indicates we're processing coalesced mmio requests. Signed-off-by: Avi Kivity (cherry picked fro

[Qemu-devel] [PATCH stable-0.15 19/36] hda: do not mix output and input streams, RHBZ #740493

2012-03-28 Thread Andreas Färber
From: Marc-André Lureau Windows 7 may use the same stream number for input and output. That will result in lot of garbage on playback. The hardcoded value of 4 needs to be in sync with GCAP streams description and IN/OUT registers. Signed-off-by: Marc-Andr? Lureau Signed-off-by: malc (cherry

[Qemu-devel] [PATCH stable-0.15 28/36] qxl: stride fixup

2012-03-28 Thread Andreas Färber
From: Gerd Hoffmann spice uses negative stride value to signal the bitmap is upside down. The qxl renderer (used for scl, vnc and screenshots) wants a positive value because it is easier to work with. The positive value is then stored in the very same variable, which has the drawback that the up

[Qemu-devel] [PATCH stable-0.15 35/36] Add missing trace call to oslib-posix.c:qemu_vmalloc()

2012-03-28 Thread Andreas Färber
From: Jes Sorensen Acked-by: Stefan Hajnoczi Signed-off-by: Jes Sorensen Signed-off-by: Anthony Liguori (cherry picked from commit c7f4111a06208b46c6d05934d2a1e5cfbebc0180) Signed-off-by: Andreas Färber --- oslib-posix.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff -

Re: [Qemu-devel] [Bug 954099] Re: Assertion failed arp_table.c line 41 on raspberry pi fedora image boot up

2012-03-28 Thread Joe Deller
Hi Peter, many thanks for the update, I'll give it another shot with later binaries and a more accurate CPU :-) Thanks again, Joe > Date: Fri, 16 Mar 2012 15:51:24 + > From: peter.mayd...@linaro.org > To: joedel...@live.co.uk > Subject: [Bug 954099] Re: Assertion failed arp_table.c line 41

[Qemu-devel] [PATCH] ARM: Permit any ARMv6K CPU to read the MVFR0 and MVFR1 VFP registers.

2012-03-28 Thread Andrew Towers
From: Andrew Towers Replaces the ARM_FEATURE_VFP3 check when reading MVFR0/1 with a check for ARM_FEATURE_V6K. Rationale: MVFR0/1 were introduced in the ARM1136 at the same time as ARMv6K, and a survey of TRMs indicates support in later models. According to reference documentation on arm.com, MV

[Qemu-devel] [PATCH stable-0.15 05/36] e1000: bounds packet size against buffer size

2012-03-28 Thread Andreas Färber
From: Anthony Liguori Otherwise we can write beyond the buffer and corrupt memory. This is tracked as CVE-2012-0029. Signed-off-by: Anthony Liguori (cherry picked from commit 65f82df0d7a71ce1b10cd4c5ab0d176ac840) Signed-off-by: Bruce Rogers [AF: stable-0.15 does not have pci_dma_read().

[Qemu-devel] [PATCH v4 3/7] qtest: IRQ interception infrastructure

2012-03-28 Thread Paolo Bonzini
Since /i440fx/piix3 is being removed from the composition tree, the IO-APIC is placed under /i440fx. This is wrong and should be changed as soon as the /i440fx/piix3 path is put back. Signed-off-by: Paolo Bonzini Signed-off-by: Anthony Liguori --- hw/irq.c | 17 +++ hw/irq.h

[Qemu-devel] [PATCH stable-0.15 13/36] Fix X86 CPU topology in KVM mode

2012-03-28 Thread Andreas Färber
From: Bharata B Rao apic id returned to guest kernel in ebx for cpuid(function=1) depends on CPUX86State->cpuid_apic_id which gets populated after the cpuid information is cached in the host kernel. This results in broken CPU topology in guest. Fix this by setting cpuid_apic_id before cpuid info

[Qemu-devel] [PATCH stable-0.15 34/36] pc: fix event_idx compatibility for virtio devices

2012-03-28 Thread Andreas Färber
From: Anthony Liguori event_idx was introduced in 0.15 and must be disabled for all virtio-pci devices (including virtio-balloon-pci). Signed-off-by: Anthony Liguori (cherry picked from commit ea830ebb74461c5ad6d199857fb000d2e0284c69) [BR: bnc#741460] Signed-off-by: Bruce Rogers Signed-off-by

[Qemu-devel] [PATCH stable-0.15 18/36] block/curl: Implement a flush function on the fd handlers

2012-03-28 Thread Andreas Färber
From: Nick Thomas Signed-off-by: Nick Thomas Signed-off-by: Kevin Wolf (cherry picked from commit c84dcdc1d6583ebe5841907c99d95deb8c40a6e0) Signed-off-by: Bruce Rogers Signed-off-by: Andreas Färber --- block/curl.c | 26 ++ 1 files changed, 22 insertions(+), 4 dele

[Qemu-devel] [PATCH stable-0.15 33/36] pc: add pc-0.15

2012-03-28 Thread Andreas Färber
From: Anthony Liguori Signed-off-by: Anthony Liguori (cherry picked from commit ce01a508e8053350544c88ba68a3f90c44b6bb93) [BR: bnc#741460] Signed-off-by: Bruce Rogers [AF: backported] Signed-off-by: Andreas Färber --- hw/pc_piix.c | 26 +++--- 1 files changed, 23 insert

Re: [Qemu-devel] [SeaBIOS] [PATCH 1/4] Add basic linked list operations

2012-03-28 Thread Gerd Hoffmann
On 03/28/12 06:28, Alexey Korolev wrote: > This linked list implementation is partially based on kernel code. So it > should be quite stable How about just copying the file? I've used the linux kernel list implementation elsewhere too and it worked just fine with only minor tweaks (remove some li

[Qemu-devel] [PATCH stable-0.15 03/36] e1000: use MII status register for link up/down

2012-03-28 Thread Andreas Färber
From: Bjørn Mork Some guests will use the standard MII status register to verify link state. They will not notice link changes unless this register is updated. Verified with Linux 3.0 and Windows XP guests. Without this patch, ethtool will report speed and duplex as unknown when the link is do

[Qemu-devel] [PATCH stable-0.15 20/36] hda: do not mix output and input stream states, RHBZ #740493

2012-03-28 Thread Andreas Färber
From: Marc-André Lureau Windows 7 may use the same stream number for input and output. Current code will confuse streams. Changes since v1: - keep running_compat[] for migration version 1 - add running_real[] for migration version 2 Signed-off-by: Marc-Andr? Lureau Signed-off-by: malc (cherry

[Qemu-devel] [PATCH v2 4/4] qdev: put all devices under /machine

2012-03-28 Thread Paolo Bonzini
Avoid cluttering too much the QOM root. Signed-off-by: Paolo Bonzini --- v1->v2: add qdev_get_machine() and use it. hw/piix_pci.c |2 +- hw/ppc_prep.c |2 +- hw/qdev-monitor.c |4 ++-- hw/qdev.c | 13 - hw/qdev.h |2 ++ 5 files chang

[Qemu-devel] [PATCH stable-0.15 08/36] vmdk: vmdk_read_cid returns garbage if p_name is NULL

2012-03-28 Thread Andreas Färber
From: Pavel Borzenkov Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov Signed-off-by: Stefan Hajnoczi (cherry picked from commit 8379e46d1fd681b8aa4714382e2cdab05e5d0575) Signed-off-by: Bruce Rogers Signed-off-by: Andreas Färber --- block/vmdk.c |2 +- 1 files changed, 1 insert

Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

2012-03-28 Thread Peter Maydell
On 28 March 2012 14:46, Andreas Färber wrote: > Am 28.03.2012 15:40, schrieb Peter Maydell: >> On 26 March 2012 18:28, Andreas Färber wrote: >> >>> +static void arm_cpu_reset(CPUState *c) >>> +{ >>> +    ARMCPU *cpu = ARM_CPU(c); >>> +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu); >>> + >>> +  

[Qemu-devel] [PATCH stable-0.15 14/36] hw/lan9118.c: Add missing 'break' to fix buffer overrun

2012-03-28 Thread Andreas Färber
From: Peter Maydell Add a missing 'break' statement to fix a buffer overrun when executing the EEPROM write-all command. Spotted by Coverity (see bug 887883). Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi (cherry picked from commit 0e3b800e71cb7759d099eabbd8ad4c4fe848e381) Signe

[Qemu-devel] [PATCH v4 2/7] qtest: add test framework

2012-03-28 Thread Paolo Bonzini
From: Anthony Liguori The idea behind qtest is pretty simple. Instead of executing a CPU via TCG or KVM, rely on an external process to send events to the device model that the CPU would normally generate. qtest presents itself as an accelerator. In addition, a new option is added to establish

[Qemu-devel] [PATCH 2/2] tracetool: dtrace: warn on reserved word usage

2012-03-28 Thread Alon Levy
Signed-off-by: Alon Levy --- scripts/tracetool |1 + 1 file changed, 1 insertion(+) diff --git a/scripts/tracetool b/scripts/tracetool index e7cebf3..d011bb7 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -496,6 +496,7 @@ EOF do # 'limit', 'in' and 'next' are reserve

[Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words

2012-03-28 Thread Alon Levy
Signed-off-by: Alon Levy --- scripts/tracetool |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..e7cebf3 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -494,9 +494,9 @@ EOF i=1 for arg in $arglist

  1   2   >