Re: [Qemu-devel] [PATCH 2/3] slirp: Fix requeuing of batchq packets in if_start

2012-02-28 Thread Jan Kiszka
On 2012-02-28 23:52, Jan Kiszka wrote: > On 2012-02-28 23:18, Stefan Weil wrote: >> Am 17.02.2012 16:45, schrieb Jan Kiszka: >>> In case we requeued a packet that was the head of a longer session >>> queue, we failed to restore this ordering. Also, we did not properly >>> deal with changes to Slirp

Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-02-28 Thread Gerd Hoffmann
Hi, >> There is a hang possible with the current screendump command, qxl, a >> spice client using libvirt and spice-gtk such as virt-viewer / >> remote-viewer, where you have: >> 1. libvirt waiting for screendump to complete >> 2. screendump waiting for spice server thread to render >> 3. spice

Re: [Qemu-devel] QOM: why "klass" used instead of "class" ?

2012-02-28 Thread Michael Tokarev
On 29.02.2012 09:52, Evgeny Voevodin wrote: > include/qemu/object.h: [] > * void my_device_class_init(ObjectClass *klass, void *class_data) > * { > * DeviceClass *dc = DEVICE_CLASS(klass); > * dc->reset = my_device_reset; > * } > * > > Why to use "klass", not "class"? Because in C++

Re: [Qemu-devel] [PATCH 09/15] target-mips: Clean includes

2012-02-28 Thread Stefan Weil
Am 29.02.2012 00:51, schrieb Johnson, Eric: You may want to just put those includes inside an '#ifdef MIPS_DEBUG_DISAS' instead of removing them. Although I suppose we could just add back the minimum needed along with the patches to fix the compile when MIPS_DEBUG_DISAS is defined. Hi Eric,

[Qemu-devel] QOM: why "klass" used instead of "class" ?

2012-02-28 Thread Evgeny Voevodin
include/qemu/object.h: * Once all of the parent classes have been initialized, #TypeInfo::class_init * is called to let the class being instantiated provide default initialize for * it's virtual functions. Here is how the above example might be modified * to introduce an overridden virtual

Re: [Qemu-devel] [PATCH v2] TCG: Convert global variables to be TLS.

2012-02-28 Thread 陳韋任
> Certainly would :) Also I've studied COREMU: > http://ppi.fudan.edu.cn/_media/publications%3Bcoremu-ppopp11.pdf > But they are based on v0.14 as I can remember and seems that this > project is not going to come upstream. > Anyway, thee are a lot of useful approaches they done while facing > di

Re: [Qemu-devel] [PATCH v2] TCG: Convert global variables to be TLS.

2012-02-28 Thread 陳韋任
On Tue, Feb 28, 2012 at 08:10:58AM +, Peter Maydell wrote: > On 28 February 2012 03:13, Evgeny Voevodin wrote: > > I wanted to get some feedback and points to show up a direction to move in > > this field. > > And qomification of translation caches is an interesting suggestion I think. > > If

Re: [Qemu-devel] [PATCH v2] TCG: Convert global variables to be TLS.

2012-02-28 Thread Evgeny Voevodin
On 29.02.2012 07:46, 陳韋任 wrote: Certainly would :) Also I've studied COREMU: http://ppi.fudan.edu.cn/_media/publications%3Bcoremu-ppopp11.pdf But they are based on v0.14 as I can remember and seems that this project is not going to come upstream. Anyway, thee are a lot of useful approaches they d

Re: [Qemu-devel] [PATCH v2] TCG: Convert global variables to be TLS.

2012-02-28 Thread Evgeny Voevodin
On 29.02.2012 07:26, 陳韋任 wrote: On Tue, Feb 28, 2012 at 08:10:58AM +, Peter Maydell wrote: On 28 February 2012 03:13, Evgeny Voevodin wrote: I wanted to get some feedback and points to show up a direction to move in this field. And qomification of translation caches is an interesting sugge

Re: [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large kernel page size

2012-02-28 Thread David Gibson
On Wed, Feb 29, 2012 at 12:32:51AM +0100, Alexander Graf wrote: > > On 24.02.2012, at 01:23, David Gibson wrote: > > > From: Benjamin Herrenschmidt > > > > If the kernel page size is larger than TARGET_PAGE_SIZE, which > > happens for example on ppc64 with kernels compiled for 64K pages, > > th

[Qemu-devel] [PATCH] Fix typo in i400FX chipset init code

2012-02-28 Thread Alexey Korolev
Hi, There is a typo in i440FX init code. This is causing problems when somebody wants to access 64bit PCI range. Signed-off-by: Alexey Korolev --- hw/piix_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 3ed3d90..aab8188 10064

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-28 Thread Wen Congyang
At 02/28/2012 07:23 PM, Avi Kivity Wrote: > On 02/27/2012 05:01 AM, Wen Congyang wrote: >> We can know the guest is paniced when the guest runs on xen. >> But we do not have such feature on kvm. This patch implemnts >> this feature, and the implementation is the same as xen: >> register panic notif

Re: [Qemu-devel] [PATCH 09/15] target-mips: Clean includes

2012-02-28 Thread Johnson, Eric
You may want to just put those includes inside an '#ifdef MIPS_DEBUG_DISAS' instead of removing them. Although I suppose we could just add back the minimum needed along with the patches to fix the compile when MIPS_DEBUG_DISAS is defined. -Original Message- From: qemu-devel-bounces+eric

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-28 Thread Wen Congyang
At 02/28/2012 06:45 PM, Gleb Natapov Wrote: > On Tue, Feb 28, 2012 at 11:19:47AM +0100, Jan Kiszka wrote: >> On 2012-02-28 10:42, Wen Congyang wrote: >>> At 02/28/2012 05:34 PM, Jan Kiszka Wrote: On 2012-02-28 09:23, Wen Congyang wrote: > At 02/27/2012 11:08 PM, Jan Kiszka Wrote: >> On

[Qemu-devel] [PATCH 2/3] Combine bdrv_aio_readv and bdrv_aio_writev into bdrv_aio_rw_vector

2012-02-28 Thread Michael Tokarev
iscsi block driver may receive some additional work. For now, some common code has been moved out of iscsi_aio_writev() and iscsi_aio_readv() into iscsi_aio_rw_vector(). Leftovers there can be optimized further, and consolidated into the rw_vector too. Read and write callbacks are consolidated a

[Qemu-devel] [PATCH 1/3] Combine bdrv_read and bdrv_write to bdrv_rw

2012-02-28 Thread Michael Tokarev
More or less trivial conversion. This also fixes a few bugs in several block drivers which provide only read but not write or the reverse. The code allowed to use such drivers in readwrite mode. Affected drivers: bochs, cloop, dmg, parallels, vvfat_write_target. Some block drivers gained multip

[Qemu-devel] [PATCH 3/3] Combine bdrv_co_readv and bdrv_co_writev into bdrv_co_rw_vector

2012-02-28 Thread Michael Tokarev
In block.c, we combine bdrv_co_do_readv(), bdrv_co_do_writev() and bdrv_co_do_write_zeroes() into single routine, bdrv_co_do_rw_vector(), and remove lots of now unneded helper functions. sheepdog driver already had sd_co_rw_vector() which half-combined read and write paths. qcow and qcow2 block d

[Qemu-devel] RFC: block: combine read and write routines into rw_vector

2012-02-28 Thread Michael Tokarev
The following 3-patch series performs conversion of read and write methods of block drivers into bdrv_rw_vector with additional is_write argument. Current I/O request path is twisted so much that it becomes very difficult to follow. A read or write request goes from common io routine to individu

Re: [Qemu-devel] [PATCH] VMXNET3 paravirtual NIC device implementation

2012-02-28 Thread Andreas Färber
Hello, Am 28.02.2012 20:57, schrieb Izik Eidus: > On Tue, Feb 28, 2012 at 2:50 PM, Yan Vugenfirer > wrote: >> On Tue, Feb 28, 2012 at 6:43 PM, malc wrote: >>> On Tue, 28 Feb 2012, Yan Vugenfirer wrote: @@ -0,0 +1,146 @@ +/* + * QEMU VMWARE paravirtual devices - auxiliary code >>>

Re: [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large kernel page size

2012-02-28 Thread Alexander Graf
On 24.02.2012, at 01:23, David Gibson wrote: > From: Benjamin Herrenschmidt > > If the kernel page size is larger than TARGET_PAGE_SIZE, which > happens for example on ppc64 with kernels compiled for 64K pages, > the dirty tracking doesn't work. > > Cc: Avi Kivity > Cc: Marcelo Tossatti > >

Re: [Qemu-devel] [PATCH 2/3] slirp: Fix requeuing of batchq packets in if_start

2012-02-28 Thread Jan Kiszka
On 2012-02-28 23:18, Stefan Weil wrote: > Am 17.02.2012 16:45, schrieb Jan Kiszka: >> In case we requeued a packet that was the head of a longer session >> queue, we failed to restore this ordering. Also, we did not properly >> deal with changes to Slirp::next_m. >> >> Instead of a cumbersome roll

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2012 at 01:20:47PM -0600, Anthony Liguori wrote: > On 02/28/2012 01:17 PM, Avi Kivity wrote: > >On 02/28/2012 09:14 PM, Anthony Liguori wrote: > >>On 02/28/2012 12:15 PM, Avi Kivity wrote: > >>>On 02/28/2012 08:13 PM, Anthony Liguori wrote: > > FWIW, I'm processing this PUL

[Qemu-devel] [PATCH 07/15] target-m68k: Clean includes

2012-02-28 Thread Stefan Weil
config.h was missing in cpu.h. Signed-off-by: Stefan Weil --- target-m68k/cpu.h |1 + target-m68k/helper.c|5 - target-m68k/translate.c |6 -- 3 files changed, 1 insertions(+), 11 deletions(-) diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h index 0667f82..4cc3a3

[Qemu-devel] [PATCH 14/15] target-xtensa: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Acked-by: Max Filippov Signed-off-by: Stefan Weil --- target-xtensa/core-dc232b.c |1 - target-xtensa/core-fsf.c|1 - target-xtensa/helper.c |1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git a/target-xten

[Qemu-devel] [PATCH 04/15] target-cris: Clean includes

2012-02-28 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Cc: Edgar E. Iglesias Signed-off-by: Stefan Weil --- target-cris/cpu.h |3 +++ target-cris/helper.c|4 target-cris/mmu.c |5 - target-cris/translate.c |7 --- 4 files chan

[Qemu-devel] [PATCH 02/15] target-alpha: Clean includes

2012-02-28 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Cc: Richard Henderson Signed-off-by: Stefan Weil --- target-alpha/cpu.h |1 + target-alpha/translate.c |5 - 2 files changed, 1 insertions(+), 5 deletions(-) diff --git a/target-alpha/cpu.h b/targe

[Qemu-devel] [PATCH 06/15] target-lm32: Clean includes

2012-02-28 Thread Stefan Weil
config.h was missing in cpu.h. Acked-by: Michael Walle Signed-off-by: Stefan Weil --- target-lm32/cpu.h |1 + target-lm32/helper.c|5 - target-lm32/translate.c |8 3 files changed, 1 insertions(+), 13 deletions(-) diff --git a/target-lm32/cpu.h b/target-lm32/

[Qemu-devel] [PATCH 12/15] target-sh4: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Cc: Aurelien Jarno Signed-off-by: Stefan Weil --- target-sh4/translate.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index aacf96d..dd0ee4b 100644 --- a/target-

[Qemu-devel] [PULL] Patch queue

2012-02-28 Thread Stefan Weil
Hi, please pull these patches from January. Thanks, Stefan Weil The following changes since commit b55c952aea6de024bf1a06357b49367fba045443: Merge remote-tracking branch 'aneesh/for-upstream' into staging (2012-02-27 11:19:27 -0600) are available in the git repository at: git://qemu.w

Re: [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large kernel page size

2012-02-28 Thread Benjamin Herrenschmidt
On Tue, 2012-02-28 at 14:32 +0200, Avi Kivity wrote: > What if TARGET_PAGE_SIZE > getpagesize()? Or is that impossible? We have yet to encounter such a case. It's not currently possible on power (some old embedded chips could do 1K and 2K page sizes in the TLB iirc but we never supported that in

[Qemu-devel] [PATCH 13/15] target-unicore32: Clean includes

2012-02-28 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Signed-off-by: Stefan Weil --- target-unicore32/cpu.h|2 ++ target-unicore32/helper.c |4 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h

[Qemu-devel] [PATCH 11/15] target-s390x: Clean includes

2012-02-28 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Signed-off-by: Stefan Weil --- target-s390x/cpu.h |3 +++ target-s390x/helper.c|5 - target-s390x/translate.c |5 - 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/target-

Re: [Qemu-devel] [PATCH 2/3] slirp: Fix requeuing of batchq packets in if_start

2012-02-28 Thread Stefan Weil
Am 17.02.2012 16:45, schrieb Jan Kiszka: In case we requeued a packet that was the head of a longer session queue, we failed to restore this ordering. Also, we did not properly deal with changes to Slirp::next_m. Instead of a cumbersome roll back, this fix simply avoids any changes until we know

[Qemu-devel] [PATCH 08/15] target-microblaze: Clean includes

2012-02-28 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Signed-off-by: Stefan Weil --- target-microblaze/cpu.h |3 +++ target-microblaze/helper.c|5 - target-microblaze/mmu.c |4 target-microblaze/translate.c |8 4 files ch

[Qemu-devel] [PATCH 15/15] Move definition of HOST_LONG_BITS to qemu-common.h

2012-02-28 Thread Stefan Weil
Like the related macro TCG_TARGET_LONG, HOST_LONG_BITS can be determined by the C preprocessor. It is also not used in Makefiles. So there is no need to calculate it in configure, and it can be defined in qemu-common.h. Signed-off-by: Stefan Weil --- configure | 12 qemu-comm

[Qemu-devel] [PATCH 05/15] target-i386: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Signed-off-by: Stefan Weil --- target-i386/helper.c|6 -- target-i386/op_helper.c |1 - 2 files changed, 0 insertions(+), 7 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 2586aff..87c6a8f 100644 --

[Qemu-devel] [PATCH 09/15] target-mips: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Cc: Aurelien Jarno Signed-off-by: Stefan Weil --- target-mips/translate.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index d5b1c76..8361d88 100644 --- a/tar

[Qemu-devel] [PATCH 03/15] target-arm: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Reviewed-by: Peter Maydell Signed-off-by: Stefan Weil --- target-arm/helper.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 4929372..abe1c30 100644 --- a/target-ar

[Qemu-devel] [PATCH 01/15] Remove macro HOST_LONG_SIZE

2012-02-28 Thread Stefan Weil
HOST_LONG_SIZE is simply the size of a pointer value. There is no need for this macro. Signed-off-by: Stefan Weil --- cpu-defs.h |2 -- thunk.h|4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cpu-defs.h b/cpu-defs.h index 57a709b..4527cbf 100644 --- a/cpu-defs.

[Qemu-devel] [PATCH 10/15] target-ppc: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Acked-by: Alexander Graf Signed-off-by: Stefan Weil --- target-ppc/helper.c|6 -- target-ppc/translate.c |6 -- 2 files changed, 0 insertions(+), 12 deletions(-) diff --git a/target-ppc/helper.c b/target-ppc/helper.c inde

[Qemu-devel] [PATCH v5 2/2] QMP: Add qmp command for blockdev-group-snapshot-sync

2012-02-28 Thread Jeff Cody
This adds the QMP command for blockdev-group-snapshot-sync. It takes an array in as the input, for the argument devlist. The array consists of the following elements: + device:device to snapshot. e.g. "ide-hd0", "virtio0" + snapshot-file: path & file for the snapshot image. e.g. "

[Qemu-devel] [PATCH v5 1/2] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-28 Thread Jeff Cody
This is a QAPI/QMP only command to take a snapshot of a group of devices. This is similar to the blockdev-snapshot-sync command, except blockdev-group-snapshot-sync accepts a list devices, filenames, and formats. It is attempted to keep the snapshot of the group atomic; if the creation or open of

[Qemu-devel] [PATCH v5 0/2] Group Live Snapshots

2012-02-28 Thread Jeff Cody
This patchset adds the ability to take a snapshot of a group of devices, rather than each device individually. Upon failure of any snapshot, all snapshots taken by the command will be abandoned, and the appropriate failure code returned. All the changes from v4 to v5 are in patch 1/2. This differ

Re: [Qemu-devel] [PATCH 3/4] monitor, console: add QEVENT_SCREEN_DUMP_COMPLETE

2012-02-28 Thread Alon Levy
On Tue, Feb 28, 2012 at 05:01:13PM -0300, Luiz Capitulino wrote: > On Fri, 24 Feb 2012 23:22:04 +0200 > Alon Levy wrote: > > > Signed-off-by: Alon Levy > > --- > > QMP/qmp-events.txt | 14 ++ > > console.c | 18 ++ > > console.h |1 + > > mo

Re: [Qemu-devel] [PATCH 2/4] qjson.h: include compiler.h for GCC_FMT_ATTR

2012-02-28 Thread Alon Levy
On Tue, Feb 28, 2012 at 04:58:46PM -0300, Luiz Capitulino wrote: > On Fri, 24 Feb 2012 23:22:03 +0200 > Alon Levy wrote: > > > Signed-off-by: Alon Levy > > Acked-by: Luiz Capitulino > > Or, I can apply it in my queue if you allow me to cherry pick. > Sure. > > > --- > > qjson.h |1 +

Re: [Qemu-devel] [PATCH] qmp: Fix spelling fourty -> forty

2012-02-28 Thread Luiz Capitulino
On Sat, 25 Feb 2012 13:47:10 +0100 Stefan Weil wrote: > This was found by codespell. > > Signed-off-by: Stefan Weil Acked-by: Luiz Capitulino > --- > test-qmp-output-visitor.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/test-qmp-output-visitor.c b/test-

Re: [Qemu-devel] [RFC PATCH v4 00/14] Tracing Improvements, Simpletrace v2

2012-02-28 Thread Lluís Vilanova
Harsh Prateek Bora writes: > This patchset introduces 2 major updates: > 1) Tracetool Improvements (Conversion from shell script to python) > 2) Simpletrace v2 log format (Support for variable args, strings) ping Lluis -- "And it's much the same thing with knowledge, for whenever you learn

Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-02-28 Thread Luiz Capitulino
On Sat, 25 Feb 2012 10:46:07 +0200 Alon Levy wrote: > On Fri, Feb 24, 2012 at 04:40:15PM -0600, Anthony Liguori wrote: > > On 02/24/2012 03:22 PM, Alon Levy wrote: > > >This is an across the board change since I wanted to keep the existing > > >(good imo) single graphic_console_init callback sett

Re: [Qemu-devel] [PATCH] VMXNET3 paravirtual NIC device implementation

2012-02-28 Thread Izik Eidus
On Tue, Feb 28, 2012 at 3:01 PM, Daniel P. Berrange wrote: > On Tue, Feb 28, 2012 at 02:57:32PM -0500, Izik Eidus wrote: >> On Tue, Feb 28, 2012 at 2:50 PM, Yan Vugenfirer >> wrote: >> > Adding Izik from Ravello. >> > >> > Best regards, >> > Yan. >> > >> > On Tue, Feb 28, 2012 at 6:43 PM, malc

Re: [Qemu-devel] [PATCH] VMXNET3 paravirtual NIC device implementation

2012-02-28 Thread Izik Eidus
On 02/28/2012 03:01 PM, Daniel P. Berrange wrote: On Tue, Feb 28, 2012 at 02:57:32PM -0500, Izik Eidus wrote: On Tue, Feb 28, 2012 at 2:50 PM, Yan Vugenfirer wrote: Adding Izik from Ravello. Best regards, Yan. On Tue, Feb 28, 2012 at 6:43 PM, malc wrote: On Tue, 28 Feb 2012, Yan Vugenfirer

Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-02-28 Thread Luiz Capitulino
On Fri, 24 Feb 2012 23:22:05 +0200 Alon Levy wrote: > This is an across the board change since I wanted to keep the existing > (good imo) single graphic_console_init callback setter, instead of > introducing a new cb that isn't set by it but instead by a second > initialization function. > > Sig

Re: [Qemu-devel] [PATCH 3/4] monitor, console: add QEVENT_SCREEN_DUMP_COMPLETE

2012-02-28 Thread Luiz Capitulino
On Fri, 24 Feb 2012 23:22:04 +0200 Alon Levy wrote: > Signed-off-by: Alon Levy > --- > QMP/qmp-events.txt | 14 ++ > console.c | 18 ++ > console.h |1 + > monitor.c |2 ++ > monitor.h |1 + > 5 files changed, 36 in

Re: [Qemu-devel] [PATCH] VMXNET3 paravirtual NIC device implementation

2012-02-28 Thread Daniel P. Berrange
On Tue, Feb 28, 2012 at 02:57:32PM -0500, Izik Eidus wrote: > On Tue, Feb 28, 2012 at 2:50 PM, Yan Vugenfirer > wrote: > > Adding Izik from Ravello. > > > > Best regards, > > Yan. > > > > On Tue, Feb 28, 2012 at 6:43 PM, malc wrote: > >> On Tue, 28 Feb 2012, Yan Vugenfirer wrote: > >> > >>> From

Re: [Qemu-devel] [PATCH 2/4] qjson.h: include compiler.h for GCC_FMT_ATTR

2012-02-28 Thread Luiz Capitulino
On Fri, 24 Feb 2012 23:22:03 +0200 Alon Levy wrote: > Signed-off-by: Alon Levy Acked-by: Luiz Capitulino Or, I can apply it in my queue if you allow me to cherry pick. > --- > qjson.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/qjson.h b/qjson.h > index 6

Re: [Qemu-devel] [PATCH] VMXNET3 paravirtual NIC device implementation

2012-02-28 Thread Izik Eidus
On Tue, Feb 28, 2012 at 2:50 PM, Yan Vugenfirer wrote: > Adding Izik from Ravello. > > Best regards, > Yan. > > On Tue, Feb 28, 2012 at 6:43 PM, malc wrote: >> On Tue, 28 Feb 2012, Yan Vugenfirer wrote: >> >>> From: Dmitry Fleytman >>> >>> Implementation of VMWare VMXNET3 paravirtual NIC device.

Re: [Qemu-devel] [PATCH 1/4] qapi-schema: fix typos and explain 'spice' auth

2012-02-28 Thread Luiz Capitulino
On Fri, 24 Feb 2012 23:22:02 +0200 Alon Levy wrote: > Signed-off-by: Alon Levy > --- > qapi-schema.json | 18 ++ > 1 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index d0b6792..72b17f1 100644 > --- a/qapi-schema.json >

Re: [Qemu-devel] [PATCH RESEND v5 1/6] cirrus_vga: do not reset videoram

2012-02-28 Thread Anthony PERARD
On 28/02/12 15:51, Stefano Stabellini wrote: There is no need to set the videoram to 0xff in cirrus_reset, because it is the BIOS' job. Signed-off-by: Stefano Stabellini Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-28 Thread Martin Mailand
Hi Stefan, I was bisecting qemu-kvm.git. git remote show origin * remote origin Fetch URL: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git Push URL: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git The bisect log is: git bisect start # good: [b8095f24f24e50a7d4be33d8a79474aff3324295]

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-28 Thread Martin Mailand
Hi, I could reproduce it and I bisected it down to this commit. 12d4536f7d911b6d87a766ad7300482ea663cea2 is the first bad commit commit 12d4536f7d911b6d87a766ad7300482ea663cea2 Author: Anthony Liguori Date: Mon Aug 22 08:24:58 2011 -0500 -martin On 22.02.2012 20:53, Stefan Hajnoczi wrote:

Re: [Qemu-devel] [PATCH] VMXNET3 paravirtual NIC device implementation

2012-02-28 Thread Yan Vugenfirer
Adding Izik from Ravello. Best regards, Yan. On Tue, Feb 28, 2012 at 6:43 PM, malc wrote: > On Tue, 28 Feb 2012, Yan Vugenfirer wrote: > >> From: Dmitry Fleytman >> >> Implementation of VMWare VMXNET3 paravirtual NIC device. >> Supports of all the device features including offload capabilties,

Re: [Qemu-devel] [PATCH RESEND v5 3/6] Set runstate to INMIGRATE earlier

2012-02-28 Thread Anthony PERARD
On 28/02/12 15:51, Stefano Stabellini wrote: Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Anthony Liguori
On 02/28/2012 01:17 PM, Avi Kivity wrote: On 02/28/2012 09:14 PM, Anthony Liguori wrote: On 02/28/2012 12:15 PM, Avi Kivity wrote: On 02/28/2012 08:13 PM, Anthony Liguori wrote: FWIW, I'm processing this PULL request right now and I'm seeing a SEGV too. The backtrace is a malloc failure in Q

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Avi Kivity
On 02/28/2012 09:14 PM, Anthony Liguori wrote: > On 02/28/2012 12:15 PM, Avi Kivity wrote: >> On 02/28/2012 08:13 PM, Anthony Liguori wrote: >>> >>> FWIW, I'm processing this PULL request right now and I'm seeing a SEGV >>> too. The backtrace is a malloc failure in QOM. >>> >> >> How do we reprodu

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Anthony Liguori
On 02/28/2012 12:15 PM, Avi Kivity wrote: On 02/28/2012 08:13 PM, Anthony Liguori wrote: FWIW, I'm processing this PULL request right now and I'm seeing a SEGV too. The backtrace is a malloc failure in QOM. How do we reproduce this? I don't trust this bisect completely, but here are the r

Re: [Qemu-devel] [PATCH RESEND v5 2/6] Introduce "save_devices"

2012-02-28 Thread Anthony PERARD
On 28/02/12 15:51, Stefano Stabellini wrote: - add an "is_ram" flag to SaveStateEntry; - add an "is_ram" parameter to register_savevm_live; - introduce a "save_devices" monitor command that can be used to save the state of non-ram devices. Signed-off-by: Stefano Stabellini --- block-migratio

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Anthony Liguori
On 02/28/2012 12:15 PM, Avi Kivity wrote: On 02/28/2012 08:13 PM, Anthony Liguori wrote: FWIW, I'm processing this PULL request right now and I'm seeing a SEGV too. The backtrace is a malloc failure in QOM. How do we reproduce this? The guest never gets to run so I don't think the initrd/

Re: [Qemu-devel] [PATCH 1/2] qdev: accept empty string properties

2012-02-28 Thread Gerhard Wiesinger
Works well, Tested-by: Gerhard Wiesinger Ciao, Gerhard -- http://www.wiesinger.com/ On Tue, 28 Feb 2012, Paolo Bonzini wrote: These were stored as NULL due to wrong cut-and-paste from set_pointer. Reported-by: Gerhard Wiesinger Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c |

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Anthony Liguori
On 02/28/2012 12:15 PM, Avi Kivity wrote: On 02/28/2012 08:13 PM, Anthony Liguori wrote: FWIW, I'm processing this PULL request right now and I'm seeing a SEGV too. The backtrace is a malloc failure in QOM. How do we reproduce this? It looks like just repeatedly running QEMU with a -devic

Re: [Qemu-devel] [PATCH] sdl: Add QEMU mascot icon for use with SDL

2012-02-28 Thread Stefan Weil
Am 28.02.2012 19:19, schrieb Stefan Weil: This is a bitmap file (32x32x4) derived from the official QEMU mascot (which was designed by Benoît Canet). I stripped the text from the SVG to get a nearly square image and converted the result to BMP without any manual optimization. The bitmap is curre

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-28 Thread Federico Simoncelli
- Original Message - > From: "Paolo Bonzini" > To: qemu-devel@nongnu.org > Sent: Tuesday, February 28, 2012 7:02:40 PM > Subject: Re: [Qemu-devel] Live Block Migration using Mirroring > > Il 28/02/2012 18:46, Federico Simoncelli ha scritto: > > > > Thank you for getting this. Being able t

[Qemu-devel] [PATCH] sdl: Add QEMU mascot icon for use with SDL

2012-02-28 Thread Stefan Weil
This is a bitmap file (32x32x4) derived from the official QEMU mascot (which was designed by Benoît Canet). I stripped the text from the SVG to get a nearly square image and converted the result to BMP without any manual optimization. The bitmap is currently used by QEMU's SDL interface and replac

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Avi Kivity
On 02/28/2012 08:13 PM, Anthony Liguori wrote: > > FWIW, I'm processing this PULL request right now and I'm seeing a SEGV > too. The backtrace is a malloc failure in QOM. > How do we reproduce this? -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Anthony Liguori
On 02/28/2012 11:59 AM, Michael S. Tsirkin wrote: On Tue, Feb 28, 2012 at 02:25:42PM +0200, Avi Kivity wrote: [repost with pull info, brain not yet back up to speed] This is the current memory queue (posted as two separate series before my vacation). When applied, the overhead of 16 bytes/page

[Qemu-devel] [PATCH 06/11] qxl: introduce QXLCookie

2012-02-28 Thread Gerd Hoffmann
From: Alon Levy Will be used in the next patch. Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c|2 +- hw/qxl.c | 61 hw/qxl.h |2 +- ui/spice-display.c | 22 -- u

[Qemu-devel] [PATCH 01/11] qxl: fix spice+sdl no cursor regression

2012-02-28 Thread Gerd Hoffmann
From: Alon Levy regression introduced by 075360945860ad9bdd491921954b383bf762b0e5, v2: lock around qemu_spice_cursor_refresh_unlocked Reported-by: Fabiano Fidêncio Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl.c |4 ui/spice-display.c | 23 +++

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-28 Thread Paolo Bonzini
Il 28/02/2012 18:46, Federico Simoncelli ha scritto: > > > Thank you for getting this. Being able to have a bogus backing file > > > was a bonus but it's not really required for the mirrored live block > > > migration. We can add the support for switching the backing file in the > > > drive-reopen

Re: [Qemu-devel] [PULL] Memory core space reduction

2012-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2012 at 02:25:42PM +0200, Avi Kivity wrote: > [repost with pull info, brain not yet back up to speed] > > This is the current memory queue (posted as two separate series before > my vacation). When applied, the overhead of 16 bytes/page is reduced to > basically nil. > > Please p

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-28 Thread Federico Simoncelli
- Original Message - > From: "Paolo Bonzini" > To: "Federico Simoncelli" > Cc: "Stefan Hajnoczi" , qemu-devel@nongnu.org, > kw...@redhat.com, mtosa...@redhat.com > Sent: Tuesday, February 28, 2012 6:36:57 PM > Subject: Re: [Qemu-devel] Live Block Migration using Mirroring > > Il 28/02/2

Re: [Qemu-devel] [PATCH v5] qemu-ga: Add guest-network-info command

2012-02-28 Thread Ryan Harper
* Michal Privoznik [2012-02-28 09:38]: > This command returns an array of: > > [ifname, hwaddr, [ipaddr, ipaddr_family, prefix] ] > > for each interface in the system. > Currently, only IPv4 and IPv6 are supported. What about vlans and bonding info? > > Signed-off-by: Michal Privoznik > --

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-28 Thread Luiz Capitulino
On Tue, 28 Feb 2012 11:09:38 -0600 Michael Roth wrote: > On Tue, Feb 28, 2012 at 11:22:22AM -0300, Luiz Capitulino wrote: > > On Mon, 27 Feb 2012 20:07:28 -0600 > > Michael Roth wrote: > > > > > What about something like this instead: > > > > > > { 'enum': 'GuestIpAddressType', > > > 'data':

[Qemu-devel] [PATCH 08/11] qxl: add optinal 64bit vram bar

2012-02-28 Thread Gerd Hoffmann
This patch adds an 64bit pci bar for vram. It is turned off by default. It can be enabled by setting the size of the 64bit bar to be larger than the 32bit bar. Both 32bit and 64bit bar refer to the same memory. Only the first part of the memory is available via 32bit bar. The intention is to al

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-28 Thread Paolo Bonzini
Il 28/02/2012 18:15, Federico Simoncelli ha scritto: > Thank you for getting this. Being able to have a bogus backing file was > a bonus but it's not really required for the mirrored live block migration. > We can add the support for switching the backing file in the drive-reopen > part. Wait, it'

[Qemu-devel] [PATCH V8 3/8] Introduce HostPCIDevice to access a pci device on the host.

2012-02-28 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- Makefile.target |3 + hw/host-pci-device.c | 278 ++ hw/host-pci-device.h | 75 ++ 3 files changed, 356 insertions(+), 0 deletions(-) create mode 100644 hw/host-pci-device.c create mode 100

[Qemu-devel] [PATCH V8 5/8] Introduce Xen PCI Passthrough, qdevice (1/3)

2012-02-28 Thread Anthony PERARD
From: Allen Kay A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Allen Kay Signed-off-by: Guy Zana Signed-off-by: Anthony PERARD --- Makefile.target |2 + hw/xen_common.h |3 + hw/xen

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-28 Thread Paolo Bonzini
Il 28/02/2012 16:47, Stefan Hajnoczi ha scritto: > At this stage we have dst/hd0snap1 opened with BDRV_O_NO_BACKING. If > it has no backing file and the guest issues a write request that is > smaller than a cluster in the image file, the untouched areas of that > cluster will be populated with zer

[Qemu-devel] [PATCH 05/11] qxl: remove flipped

2012-02-28 Thread Gerd Hoffmann
From: Alon Levy Tested on linux and windows guests. For negative stride, qxl_flip copies directly to vga->ds->surface->data, for positive it's reallocated to share qxl->guest_primary.data Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c | 66

[Qemu-devel] [PATCH 10/11] Error out when tls-channel option is used without TLS

2012-02-28 Thread Gerd Hoffmann
From: Christophe Fergeau It's currently possible to setup spice channels using TLS when no TLS port has been specified (ie TLS is disabled). This cannot work, so better to error out in such a situation. Signed-off-by: Gerd Hoffmann --- ui/spice-core.c |8 +++- 1 files changed, 7 insert

[Qemu-devel] [PATCH 03/11] qxl: drop qxl_spice_update_area_async definition

2012-02-28 Thread Gerd Hoffmann
From: Alon Levy It was never used. Introduced in 5ff4e36c804157bd84af43c139f8cd3a59722db9 qxl: async io support using new spice api But not used even then. Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl.h |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff

[Qemu-devel] noob seeking someone, preferably in new york city, to talk shop with

2012-02-28 Thread nweissma
might you know someone who is willing to spend time with a noob in new york city. the person need not live in nyc: skype is excellent. Thanks. /s/ Neal Weissman

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-28 Thread Federico Simoncelli
- Original Message - > From: "Stefan Hajnoczi" > To: "Federico Simoncelli" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com > Sent: Tuesday, February 28, 2012 4:47:48 PM > Subject: Re: [Qemu-devel] Live Block Migration using Mirroring > > On Wed, Feb 22, 2012 at 5:13 PM,

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-28 Thread Michael Roth
On Tue, Feb 28, 2012 at 11:22:22AM -0300, Luiz Capitulino wrote: > On Mon, 27 Feb 2012 20:07:28 -0600 > Michael Roth wrote: > > > What about something like this instead: > > > > { 'enum': 'GuestIpAddressType', > > 'data': [ 'ipv4', 'ipv6' ] } > > > > { 'type': 'GuestIpAddress', > > 'data':

Re: [Qemu-devel] virtio-blk performance regression and qemu-kvm

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 4:39 PM, Martin Mailand wrote: > I could reproduce it and I bisected it down to this commit. > > 12d4536f7d911b6d87a766ad7300482ea663cea2 is the first bad commit > commit 12d4536f7d911b6d87a766ad7300482ea663cea2 > Author: Anthony Liguori > Date:   Mon Aug 22 08:24:58 2011

[Qemu-devel] [PATCH 07/11] qxl: make qxl_render_update async

2012-02-28 Thread Gerd Hoffmann
From: Alon Levy RHBZ# 747011 Removes the last user of QXL_SYNC when using update drivers that use the _ASYNC io ports. The last user is qxl_render_update, it is called both by qxl_hw_update which is the vga_hw_update_ptr passed to graphic_console_init, and by qxl_hw_screen_dump. At the same ti

[Qemu-devel] [PATCH 04/11] qxl: require spice >= 0.8.2

2012-02-28 Thread Gerd Hoffmann
From: Alon Levy drop all ifdefs on SPICE_INTERFACE_QXL_MINOR >= 1 as a result, any check for SPICE_SERVER_VERSION that is now always satisfied, and SPICE_INTERFACE_CORE_MINOR >= 3 tests, because 0.8.2 has SPICE_INTERFACE_QXL_MINOR == 1 and SPICE_INTERFACE_CORE_MINOR == 3. Signed-off-by: Alon Lev

[Qemu-devel] [PATCH V8 6/8] Introduce Xen PCI Passthrough, PCI config space helpers (2/3)

2012-02-28 Thread Anthony PERARD
From: Allen Kay A more complete history can be found here: git://xenbits.xensource.com/qemu-xen-unstable.git Signed-off-by: Allen Kay Signed-off-by: Guy Zana Signed-off-by: Anthony PERARD --- hw/xen_pci_passthrough.c | 10 + hw/xen_pci_passthrough.h |2 + hw/xen

[Qemu-devel] [PATCH V8 1/8] pci_ids: Add INTEL_82599_VF id.

2012-02-28 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index e8235a7..943106a 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -118,6 +118,7 @@ #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939 #define PCI

[Qemu-devel] [PATCH 09/11] spice: use error_report to report errors

2012-02-28 Thread Gerd Hoffmann
From: Christophe Fergeau Error message reporting during spice startup wasn't consistent, it was done with fprintf(stderr, "") but sometimes the message didn't have a trailing \n. Using error_report make the intent of the message clearer and deal with the final \n for us. Signed-off-by: Gerd Hoff

[Qemu-devel] [PATCH 11/11] qxl: properly handle upright and non-shared surfaces

2012-02-28 Thread Gerd Hoffmann
Although qxl creates a shared displaysurface when the qxl surface is upright and doesn't need to be flipped there is no guarantee that the surface doesn't become unshared for some reason. Rename qxl_flip to qxl_blit and fix it to handle both flip and non-flip cases. Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH] VMXNET3 paravirtual NIC device implementation

2012-02-28 Thread malc
On Tue, 28 Feb 2012, Yan Vugenfirer wrote: > From: Dmitry Fleytman > > Implementation of VMWare VMXNET3 paravirtual NIC device. > Supports of all the device features including offload capabilties, > VLANs and etc. > The device is tested on different OSes: [..snip..] > @@ -0,0 +1,146 @@ > +/* >

[Qemu-devel] [PULL] spice patch queue

2012-02-28 Thread Gerd Hoffmann
Hi, Here comes the spice patch queue. For the most part this brings the async local rendering (for vnc, sdl and screenshots) work done by Alon. Also a few bug fixes. please pull, Gerd The following changes since commit b4bd0b168e9f4898b98308f4a8a089f647a86d16: audio: Add some fall throug

  1   2   3   >