Am 29.02.2012 00:51, schrieb Johnson, Eric:
You may want to just put those includes inside an '#ifdef
MIPS_DEBUG_DISAS' instead of removing them.
Although I suppose we could just add back the minimum needed along
with the patches to fix the compile when MIPS_DEBUG_DISAS is defined.
Hi Eric,
those includes are redundant. I removed them here, but they are still
included
(cpu.h includes qemu-common.h which includes the standard includes).
So there is no need for #ifdef MIPS_DEBUG_DISAS.
Compilation with MIPS_DEBUG_DISAS nevertheless fails, but it also fails with
current git master. This is a problem which is not related to my patch
series.
Cheers,
Stefan W.
-----Original Message-----
From: qemu-devel-bounces+ericj=mips....@nongnu.org
[mailto:qemu-devel-bounces+ericj=mips....@nongnu.org] On Behalf Of
Stefan Weil
Sent: Tuesday, February 28, 2012 1:47 PM
To: Anthony Liguori
Cc: Stefan Weil; qemu-devel@nongnu.org; Aurelien Jarno
Subject: [Qemu-devel] [PATCH 09/15] target-mips: Clean includes
Remove some include statements which are not needed.
Cc: Aurelien Jarno <aurel...@aurel32.net>
Signed-off-by: Stefan Weil <s...@weilnetz.de>
---
target-mips/translate.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/target-mips/translate.c b/target-mips/translate.c index
d5b1c76..8361d88 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -20,16 +20,9 @@
* License along with this library; if not, see
<http://www.gnu.org/licenses/>.
*/
-#include <stdarg.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <inttypes.h>
-
#include "cpu.h"
#include "disas.h"
#include "tcg-op.h"
-#include "qemu-common.h"
#include "helper.h"
#define GEN_HELPER 1
--
1.7.9
