Re: [Qemu-devel] [PATCH v11 0/9] ARM: Samsung Exynos4210-based boards support.

2012-02-02 Thread Evgeny Voevodin
On 02/03/2012 09:24 AM, Evgeny Voevodin wrote: On 02/02/2012 10:43 PM, Peter Maydell wrote: On 30 January 2012 07:38, Evgeny Voevodin wrote: This set of patches adds support for Samsung Exynos4210-based boards NURI and SMDKC210. Tested on Linux kernel v3.x series. Usage: "-smp 2" option is man

Re: [Qemu-devel] [PATCH v11 0/9] ARM: Samsung Exynos4210-based boards support.

2012-02-02 Thread Evgeny Voevodin
On 02/02/2012 10:43 PM, Peter Maydell wrote: On 30 January 2012 07:38, Evgeny Voevodin wrote: This set of patches adds support for Samsung Exynos4210-based boards NURI and SMDKC210. Tested on Linux kernel v3.x series. Usage: "-smp 2" option is mandatory for now. If it is then the board shoul

Re: [Qemu-devel] [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-02-02 Thread Charles . Tsai-蔡清海-研究發展部
Vadim, I downloaded the latest Windows guest driver code from (https://github.com/YanVugenfirer/) and built the test binary driver code. When I tested the release build Vioserial driver on 64-bit Windows 7, the driver seemed to wait for something to happen and the update driver Windows dialog s

[Qemu-devel] [PATCH RFC v3 04/21] target-arm: Introduce QOM CPU and use it for CPUID lookup

2012-02-02 Thread Andreas Färber
Create a CPU subclass, and register classes matching all CPU models except for "pxa270", which is an alias for "pxa270-a0". Make arm_cpu_list() enumerate CPU subclasses. Replace cpu_arm_find_by_name()'s string -> CPUID lookup by storing the CPUID in the class. NB: CPUIDs were first introduced by

[Qemu-devel] [PATCH RFC v3 15/21] target-arm: Store VFP FPSID register in ARMCPUClass

2012-02-02 Thread Andreas Färber
Signed-off-by: Andreas Färber Cc: Peter Maydell --- target-arm/cpu-core.h |3 +++ target-arm/cpu.c | 11 +++ target-arm/cpu.h |1 - target-arm/helper.c | 12 4 files changed, 14 insertions(+), 13 deletions(-) diff --git a/target-arm/cpu-core.h b/targ

[Qemu-devel] [PATCH RFC v3 18/21] target-arm: Store CCSIDRs in ARMCPUClass

2012-02-02 Thread Andreas Färber
Signed-off-by: Andreas Färber Cc: Peter Maydell --- target-arm/cpu-core.h |1 + target-arm/cpu.c | 18 ++ target-arm/helper.c | 14 -- 3 files changed, 19 insertions(+), 14 deletions(-) diff --git a/target-arm/cpu-core.h b/target-arm/cpu-core.h index 0

[Qemu-devel] [FYI v3 21/21] target-arm: Just for testing!

2012-02-02 Thread Andreas Färber
Add the CPU as child<> of / so that it can be inspected with qom-get. --- target-arm/cpu.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index 4dfec15..ad8e317 100644 --- a/target-arm/cpu.c +++ b/target-arm/cpu.c @@ -564,6 +564,8 @@ s

[Qemu-devel] [PATCH RFC v3 05/21] target-arm: Embed CPUARMState in QOM ARMCPU

2012-02-02 Thread Andreas Färber
We g_malloc0()'ed CPUARMState ourself, and exec.c's cpu_copy() runs through cpu_init() as well, so we are at liberty to supply the CPUState any way we see fit. Having CPUARMState as field in the QOM CPU allows both to access env from an ARMCPU object and to access the QOM Object and its ObjectClass

[Qemu-devel] [PATCH RFC v3 19/21] target-arm: Kill off cpu_reset_model_id()

2012-02-02 Thread Andreas Färber
Move last remaining TI925T bits to ti925t_reset(). This reduces cpu_reset() to triviality and lets us reset the CPU directly from arm_cpu_initfn(). Signed-off-by: Andreas Färber Cc: Peter Maydell --- target-arm/cpu.c|4 target-arm/helper.c | 20 2 files chan

[Qemu-devel] [PATCH v3 01/21] qom: Register QOM infrastructure early

2012-02-02 Thread Andreas Färber
QOM TYPE_INTERFACE was registered with device_init(), whose constructors are executed rather late in vl.c's main(). Rename the module init type from DEVICE to QOM and call it very early so that QOM can safely be used for machines and CPUs. device_init() is left for legacy types. New ones should u

[Qemu-devel] [PATCH RFC v3 11/21] target-arm: Store cp15 c0_cachetype register in ARMCPUClass

2012-02-02 Thread Andreas Färber
Signed-off-by: Andreas Färber Cc: Peter Maydell --- target-arm/cpu-core.h |1 + target-arm/cpu.c | 18 ++ target-arm/helper.c | 12 3 files changed, 19 insertions(+), 12 deletions(-) diff --git a/target-arm/cpu-core.h b/target-arm/cpu-core.h index bb5

[Qemu-devel] [PATCH RFC v3 00/21] Introduce QOM CPU and use it for ARM

2012-02-02 Thread Andreas Färber
Hello, Here's an improved and extended series on incrementally converting CPUState to QOM, rebased onto Anthony's qom-upstream.14 plus some master updates. The general idea behind the series is to cease having CPU-dependent code in generic functions, in favor of storing constant data in CPU class

[Qemu-devel] [PATCH RFC v3 16/21] target-arm: Store VFP MVFR0 and MVFR1 in ARMCPUClass

2012-02-02 Thread Andreas Färber
Signed-off-by: Andreas Färber Cc: Peter Maydell --- target-arm/cpu-core.h |1 + target-arm/cpu.c | 11 +++ target-arm/helper.c | 29 - 3 files changed, 12 insertions(+), 29 deletions(-) diff --git a/target-arm/cpu-core.h b/target-arm/cpu-core.h

[Qemu-devel] [PATCH RFC v3 14/21] target-arm: Move the PXA270's iwMMXt reset to pxa270_reset()

2012-02-02 Thread Andreas Färber
No other emulated CPU uses this at this time. Signed-off-by: Andreas Färber Cc: Peter Maydell Cc: Andrzej Zaborowski --- target-arm/cpu.c| 14 ++ target-arm/cpu.h|6 -- target-arm/helper.c |8 3 files changed, 14 insertions(+), 14 deletions(-) diff -

[Qemu-devel] [PATCH RFC v3 20/21] target-arm: Prepare halted property for CPU

2012-02-02 Thread Andreas Färber
Read-only and ARM-specific for now. Signed-off-by: Andreas Färber Cc: Peter Maydell Cc: Anthony Liguori --- target-arm/cpu.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index 74f4e9b..4dfec15 100644 --- a/target-arm/c

[Qemu-devel] [PATCH RFC v3 09/21] target-arm: No longer abort on unhandled CPUIDs on reset

2012-02-02 Thread Andreas Färber
Having moved the reset code for some CPUs to class_init, we can drop some of the cases in the switch. Signed-off-by: Andreas Färber Cc: Peter Maydell --- target-arm/cpu.h|2 -- target-arm/helper.c |5 - 2 files changed, 0 insertions(+), 7 deletions(-) diff --git a/target-arm/cp

[Qemu-devel] [PATCH RFC v3 12/21] target-arm: Move cp15 c1_sys register to ARMCPUClass

2012-02-02 Thread Andreas Färber
Signed-off-by: Andreas Färber Cc: Peter Maydell --- target-arm/cpu-core.h |1 + target-arm/cpu.c | 19 +++ target-arm/cpu.h |3 --- target-arm/helper.c | 17 - 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/target-arm/cpu-

[Qemu-devel] [Bug 912612] Re: rhel5u5 guest panic when booting up

2012-02-02 Thread Yongjie Ren
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/912612 Title: rhel5u5 guest panic when booting up Status in QEMU: Fix Released Bug descripti

[Qemu-devel] [PATCH RFC v3 17/21] target-arm: Store CLIDR in ARMCPUClass

2012-02-02 Thread Andreas Färber
Signed-off-by: Andreas Färber Cc: Peter Maydell --- target-arm/cpu-core.h |1 + target-arm/cpu.c |6 ++ target-arm/helper.c |3 --- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/target-arm/cpu-core.h b/target-arm/cpu-core.h index 53fac1a..0ed92ce 100644 --

[Qemu-devel] [PATCH RFC v3 08/21] target-arm: Move CPU feature flags out of CPUState

2012-02-02 Thread Andreas Färber
The internal CPU feature flags were only ever set in cpu_reset_model_id(). Therefore move their initialization into ARMCPUClass. We might want to tweak them in the future though (e.g., -cpu cortex-r4,+fpu), so keep a copy in ARMCPU. This in turn means we need to infer features for both ARMCPUClass

[Qemu-devel] [PATCH RFC v3 07/21] target-arm: Overwrite reset handler for ti925t

2012-02-02 Thread Andreas Färber
The OMAPCP feature allows to switch between TI915T and TI925T via cp15 c15_ticonfig register. Move reset into ti925t-specific callback. Signed-off-by: Andreas Färber Cc: Peter Maydell --- target-arm/cpu.c| 18 ++ target-arm/helper.c |1 - 2 files changed, 18 insertions

[Qemu-devel] [PATCH RFC v3 10/21] target-arm: Store cp15 c0_c1 and c0_c2 in ARMCPUClass

2012-02-02 Thread Andreas Färber
For now set them in the reset function. Signed-off-by: Andreas Färber Cc: Peter Maydell --- target-arm/cpu-core.h |2 + target-arm/cpu.c | 64 + target-arm/helper.c | 51 --- 3 files changed, 66 i

[Qemu-devel] [PATCH RFC v3 13/21] target-arm: Store JTAG_ID in ARMCPUClass

2012-02-02 Thread Andreas Färber
That way we can remove some more CPUID cases without losing info. Signed-off-by: Andreas Färber Cc: Peter Maydell Cc: Andrzej Zaborowski --- target-arm/cpu-core.h |1 + target-arm/cpu.c |2 ++ target-arm/cpu.h |5 - target-arm/helper.c |8 4 files chang

[Qemu-devel] [PATCH RFC v3 03/21] qom: Introduce CPU class

2012-02-02 Thread Andreas Färber
It's abstract and derived directly from TYPE_OBJECT. Prepare a virtual reset method. Signed-off-by: Andreas Färber Cc: Anthony Liguori Cc: Peter Maydell --- include/qemu/cpu.h | 73 qom/Makefile |1 + qom/cpu.c | 50 ++

[Qemu-devel] [PATCH RFC v3 06/21] target-arm: Prepare model-specific class_init function

2012-02-02 Thread Andreas Färber
This allows to share initialization between CPU models. Signed-off-by: Andreas Färber --- target-arm/cpu.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index 43231c9..b794ec1 100644 --- a/target-arm/cpu.c +++ b/target-arm/cpu.c

[Qemu-devel] [PATCH RFC v3 02/21] qom: Add QOM support to user emulators

2012-02-02 Thread Andreas Färber
Link the Object base class and the module infrastructure for class registration. Call QOM module init. Signed-off-by: Andreas Färber Cc: Anthony Liguori --- Makefile.objs |6 ++ Makefile.user |1 + bsd-user/main.c|2 ++ configure |2 ++ darwin-user/mai

[Qemu-devel] libqemu for use in parallel-language based simulator

2012-02-02 Thread Sean Halle
Hi, We’re trying to use QEMU as a library in our research. We have created a parallel language for simulating parallel activities. The language controls the suspension and re-animation of threads it creates, in such a way that physical memory contents remains consistent with the order of

Re: [Qemu-devel] [PATCH] rtl8139: honor RxOverflow flag in can_receive method

2012-02-02 Thread Fernando Luis Vázquez Cao
On 02/02/2012 07:11 AM, Anthony Liguori wrote: On 01/29/2012 08:17 PM, Fernando Luis Vázquez Cao wrote: Some drivers (Linux' 8139too among them) rely on the NIC injecting an interrupt in the event of a receive buffer overflow and, accordingly, set the RxOverflow bit in the interrupt mask. Unfor

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-02 Thread Anthony Liguori
On 02/02/2012 10:09 AM, Avi Kivity wrote: The kvm api has been accumulating cruft for several years now. This is due to feature creep, fixing mistakes, experience gained by the maintainers and developers on how to do things, ports to new architectures, and simply as a side effect of a code base

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-02 Thread Charles Arnold
Next version of the patch with fixes, cleanups, and suggestions. - Charles The Virtual Hard Disk Image Format Specification allows for three types of hard disk formats, Fixed, Dynamic, and Differencing. Qemu currently only supports Dynamic disks. This patch adds support for the Fixed Disk form

Re: [Qemu-devel] [PATCH 03/15] target-arm: Clean includes

2012-02-02 Thread Peter Maydell
On 2 February 2012 21:12, Stefan Weil wrote: > Remove some include statements which are not needed. > > Cc: Peter Maydell > Signed-off-by: Stefan Weil > --- >  target-arm/helper.c |    5 - >  1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/target-arm/helper.c b/target-arm/h

Re: [Qemu-devel] [PATCH 10/15] target-ppc: Clean includes

2012-02-02 Thread Alexander Graf
On 02.02.2012, at 23:46, Stefan Weil wrote: > Am 02.02.2012 22:26, schrieb Alexander Graf: >> >> On 02.02.2012, at 22:12, Stefan Weil wrote: >> >>> Remove some include statements which are not needed. >> >> Are these redundant or do they just happen to be unnecessary because of >> unused debu

Re: [Qemu-devel] [PATCH 10/15] target-ppc: Clean includes

2012-02-02 Thread Stefan Weil
Am 02.02.2012 22:26, schrieb Alexander Graf: On 02.02.2012, at 22:12, Stefan Weil wrote: Remove some include statements which are not needed. Are these redundant or do they just happen to be unnecessary because of unused debug #ifdefs? Alex They are redundant because cpu.h includes qem

Re: [Qemu-devel] [PATCH 07/16] qdev: allow reusing get/set for legacy property

2012-02-02 Thread Andreas Färber
Am 02.02.2012 17:45, schrieb Paolo Bonzini: > In some cases, a legacy property does need a special print method > but not a special parse method. In this case, we can reuse the get/set > from the static (non-legacy) property. > > If neither parse nor print is needed, though, do not register the >

[Qemu-devel] [Bug 740014] Re: The Multiboot information data structure contains the wrong address to the module structure

2012-02-02 Thread Stefan Lankes
Bug already fixed... ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/740014 Title: The Multiboot information data structure contains the wrong

[Qemu-devel] [PATCH 03/15] target-arm: Clean includes

2012-02-02 Thread Stefan Weil
Remove some include statements which are not needed. Cc: Peter Maydell Signed-off-by: Stefan Weil --- target-arm/helper.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index ea4f35f..e9e2a27 100644 --- a/target-arm/helper.

[Qemu-devel] [PATCH 00/15] Clean some includes and definitions

2012-02-02 Thread Stefan Weil
Hi, I tried to move the definition of HOST_LONG_BITS from configure to qemu-common.h. While doing this, I noticed that the different QEMU targets use includes in non-uniform ways. So the simple goal resulted in quite a lot of patches. Patch 1 simply removes a derived macro. This patch is indepen

[Qemu-devel] [PATCH 01/15] Remove macro HOST_LONG_SIZE

2012-02-02 Thread Stefan Weil
HOST_LONG_SIZE is simply the size of a pointer value. There is no need for this macro. Signed-off-by: Stefan Weil --- cpu-defs.h |2 -- thunk.h|4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cpu-defs.h b/cpu-defs.h index 57a709b..4527cbf 100644 --- a/cpu-defs.

[Qemu-devel] [PATCH 07/15] target-m68k: Clean includes

2012-02-02 Thread Stefan Weil
config.h was missing in cpu.h. Signed-off-by: Stefan Weil --- target-m68k/cpu.h |1 + target-m68k/helper.c|5 - target-m68k/translate.c |6 -- 3 files changed, 1 insertions(+), 11 deletions(-) diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h index 0667f82..4cc3a3

[Qemu-devel] [PATCH 12/15] target-sh4: Clean includes

2012-02-02 Thread Stefan Weil
Remove some include statements which are not needed. Cc: Aurelien Jarno Signed-off-by: Stefan Weil --- target-sh4/translate.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index aacf96d..dd0ee4b 100644 --- a/target-

Re: [Qemu-devel] [PATCH 14/15] target-xtensa: Clean includes

2012-02-02 Thread Max Filippov
> Remove some include statements which are not needed. > > Cc: Max Filippov > Signed-off-by: Stefan Weil Acked-by: Max Filippov Thanks. -- Max

[Qemu-devel] [PATCH 06/15] target-lm32: Clean includes

2012-02-02 Thread Stefan Weil
config.h was missing in cpu.h. Cc: Michael Walle Signed-off-by: Stefan Weil --- target-lm32/cpu.h |1 + target-lm32/helper.c|5 - target-lm32/translate.c |8 3 files changed, 1 insertions(+), 13 deletions(-) diff --git a/target-lm32/cpu.h b/target-lm32/cpu.h

Re: [Qemu-devel] [PATCH 10/15] target-ppc: Clean includes

2012-02-02 Thread Alexander Graf
On 02.02.2012, at 22:12, Stefan Weil wrote: > Remove some include statements which are not needed. Are these redundant or do they just happen to be unnecessary because of unused debug #ifdefs? Alex > > Cc: Alexander Graf > Signed-off-by: Stefan Weil > --- > target-ppc/helper.c|6 -

[Qemu-devel] [PATCH 04/15] target-cris: Clean includes

2012-02-02 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Cc: Edgar E. Iglesias Signed-off-by: Stefan Weil --- target-cris/cpu.h |3 +++ target-cris/helper.c|4 target-cris/mmu.c |5 - target-cris/translate.c |7 --- 4 files chan

[Qemu-devel] [PATCH 13/15] target-unicore32: Clean includes

2012-02-02 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Signed-off-by: Stefan Weil --- target-unicore32/cpu.h|2 ++ target-unicore32/helper.c |4 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h

[Qemu-devel] [PATCH 08/15] target-microblaze: Clean includes

2012-02-02 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Signed-off-by: Stefan Weil --- target-microblaze/cpu.h |3 +++ target-microblaze/helper.c|5 - target-microblaze/mmu.c |4 target-microblaze/translate.c |8 4 files ch

[Qemu-devel] [PATCH 10/15] target-ppc: Clean includes

2012-02-02 Thread Stefan Weil
Remove some include statements which are not needed. Cc: Alexander Graf Signed-off-by: Stefan Weil --- target-ppc/helper.c|6 -- target-ppc/translate.c |6 -- 2 files changed, 0 insertions(+), 12 deletions(-) diff --git a/target-ppc/helper.c b/target-ppc/helper.c index 5847

[Qemu-devel] [PATCH 14/15] target-xtensa: Clean includes

2012-02-02 Thread Stefan Weil
Remove some include statements which are not needed. Cc: Max Filippov Signed-off-by: Stefan Weil --- target-xtensa/core-dc232b.c |1 - target-xtensa/core-fsf.c|1 - target-xtensa/helper.c |1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git a/target-xtensa/cor

[Qemu-devel] [PATCH 11/15] target-s390x: Clean includes

2012-02-02 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Signed-off-by: Stefan Weil --- target-s390x/cpu.h |3 +++ target-s390x/helper.c|5 - target-s390x/translate.c |5 - 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/target-

[Qemu-devel] [PATCH 05/15] target-i386: Clean includes

2012-02-02 Thread Stefan Weil
Remove some include statements which are not needed. Signed-off-by: Stefan Weil --- target-i386/helper.c|6 -- target-i386/op_helper.c |1 - 2 files changed, 0 insertions(+), 7 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 2586aff..87c6a8f 100644 --

[Qemu-devel] [PATCH 09/15] target-mips: Clean includes

2012-02-02 Thread Stefan Weil
Remove some include statements which are not needed. Cc: Aurelien Jarno Signed-off-by: Stefan Weil --- target-mips/translate.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index d5b1c76..8361d88 100644 --- a/tar

[Qemu-devel] [PATCH 15/15] Move definition of HOST_LONG_BITS to qemu-common.h

2012-02-02 Thread Stefan Weil
Like the related macro TCG_TARGET_LONG, HOST_LONG_BITS can be determined by the C preprocessor. It is also not used in Makefiles. So there is no need to calculate it in configure, and it can be defined in qemu-common.h. Signed-off-by: Stefan Weil --- configure | 12 qemu-comm

[Qemu-devel] [PATCH 02/15] target-alpha: Clean includes

2012-02-02 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Cc: Richard Henderson Signed-off-by: Stefan Weil --- target-alpha/cpu.h |1 + target-alpha/translate.c |5 - 2 files changed, 1 insertions(+), 5 deletions(-) diff --git a/target-alpha/cpu.h b/targe

Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

2012-02-02 Thread Anthony Liguori
On 02/02/2012 02:08 PM, Paolo Bonzini wrote: On 02/02/2012 08:36 PM, Anthony Liguori wrote: The only types that matter are int and string so the variant visitor is pretty simple. Sure, only ~150 lines of code. I also do not disagree with the goals (mine and yours), just with the priorities. :)

Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

2012-02-02 Thread Anthony Liguori
On 02/02/2012 01:21 PM, Andreas Färber wrote: Am 02.02.2012 20:06, schrieb Anthony Liguori: On 02/02/2012 10:45 AM, Paolo Bonzini wrote: Move the creation of QmpInputVisitor and QmpOutputVisitor from qmp.c to qom/object.c, since it's the only practical way to access object properties. Signed-o

[Qemu-devel] [PATCH v2 5/8] qemu-ga: fixes for win32 build of qemu-ga

2012-02-02 Thread Michael Roth
Various stubs and #ifdefs to compile for Windows using mingw cross-build. Still has 1 linker error due to a dependency on the forthcoming win32 versions of the GAChannel/transport class. Signed-off-by: Michael Roth --- Makefile |2 +- Makefile.objs|9 +++-- configure

[Qemu-devel] [PATCH v2 7/8] qemu-ga: add Windows service integration

2012-02-02 Thread Michael Roth
This allows qemu-ga to function as a Windows service: - to install the service (will auto-start on boot): qemu-ga --service install - to start the service: net start qemu-ga - to stop the service: net stop qemu-ga - to uninstall service: qemu-ga --service uninstall Origina

[Qemu-devel] [PATCH v2 4/8] qemu-ga: rename guest-agent-commands.c -> commands-posix.c

2012-02-02 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile.objs |2 +- qga/commands-posix.c | 528 qga/guest-agent-commands.c | 528 3 files changed, 529 insertions(+), 529 deletions(-) create mode

[Qemu-devel] [PATCH v2 6/8] qemu-ga: add initial win32 support

2012-02-02 Thread Michael Roth
This adds a win32 channel implementation that makes qemu-ga functional on Windows using virtio-serial (unix-listen/isa-serial not currently implemented). Unlike with the posix implementation, we do not use GIOChannel for the following reasons: - glib calls stat() on an fd to check whether S_IFCHR

Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug

2012-02-02 Thread Alexander Graf
On 02.02.2012, at 21:03, Anthony Liguori wrote: > On 02/02/2012 01:07 PM, Alexander Graf wrote: >> >> On 02.02.2012, at 20:01, Anthony Liguori wrote: >> >>> On 02/02/2012 11:29 AM, Paolo Bonzini wrote: On 02/02/2012 06:03 PM, Anthony Liguori wrote: >> > > Is this still needed

[Qemu-devel] [PATCH v2 3/8] qemu-ga: separate out common commands from posix-specific ones

2012-02-02 Thread Michael Roth
Many of the current RPC implementations are very much POSIX-specific and require complete re-writes for Windows. There are however a small set of core guest agent commands that are common to both, and other commands such as guest-file-* which *may* be portable. So we introduce commands.c for the la

[Qemu-devel] [PATCH v2 8/8] qemu-ga: add win32 guest-shutdown command

2012-02-02 Thread Michael Roth
Implement guest-shutdown RPC for Windows. Functionally this should be equivalent to the posix implementation. Original patch by Gal Hammer Signed-off-by: Michael Roth --- qga/commands-win32.c | 41 - 1 files changed, 40 insertions(+), 1 deletions(-) d

Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer

2012-02-02 Thread Paolo Bonzini
On 02/02/2012 09:07 PM, Anthony Liguori wrote: Signed-off-by: Paolo Bonzini Isn't this a compatibility breaker? Won't this break libvirt's usage of -device addr=0.2 ? Nope, the legacy property still keeps the dd.f format. This is only for QOM (and internal use by qdev). Paolo

Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

2012-02-02 Thread Paolo Bonzini
On 02/02/2012 08:36 PM, Anthony Liguori wrote: The only types that matter are int and string so the variant visitor is pretty simple. Sure, only ~150 lines of code. I also do not disagree with the goals (mine and yours), just with the priorities. :) Paolo

Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer

2012-02-02 Thread Anthony Liguori
On 02/02/2012 10:45 AM, Paolo Bonzini wrote: PCI addresses are set with qdev_prop_uint32. Thus we make the QOM property accept a device and function encoded in an 8-bit integer, instead of the magic dd.f hex string. Signed-off-by: Paolo Bonzini Isn't this a compatibility breaker? Won't this

Re: [Qemu-devel] [PATCH 09/16] qdev: remove parse/print methods for mac properties

2012-02-02 Thread Anthony Liguori
On 02/02/2012 10:45 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 61 ++--- 1 files changed, 42 insertions(+), 19 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 0a293af..4fb5cf8 10064

Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug

2012-02-02 Thread Anthony Liguori
On 02/02/2012 01:07 PM, Alexander Graf wrote: On 02.02.2012, at 20:01, Anthony Liguori wrote: On 02/02/2012 11:29 AM, Paolo Bonzini wrote: On 02/02/2012 06:03 PM, Anthony Liguori wrote: Is this still needed with qom-upstream.14? I fixed a bug on .14 that involved child properties that was

Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

2012-02-02 Thread Anthony Liguori
On 02/02/2012 01:29 PM, Paolo Bonzini wrote: On 02/02/2012 08:24 PM, Paolo Bonzini wrote: 1) We shouldn't use generic interfaces to read/write properties from objects. We should use type-safe accessors provided by the types themselves. That doesn't change the fact that we need simple wrappers

[Qemu-devel] [PATCH v2 1/8] qemu-ga: Add schema documentation for types

2012-02-02 Thread Michael Roth
Document guest agent schema types in similar fashion as qmp schema types. Signed-off-by: Michael Roth --- qapi-schema-guest.json | 118 +++- 1 files changed, 97 insertions(+), 21 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.js

[Qemu-devel] [PATCH v2 2/8] qemu-ga: move channel/transport functionality into wrapper class

2012-02-02 Thread Michael Roth
This is mostly in preparation for the win32 port, which won't use GIO channels for reasons that will be made clearer later. Here the GAChannel class is just a loose wrapper around GIOChannel calls/callbacks, but we also roll in the logic/configuration for various channel types and managing unix soc

[Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

2012-02-02 Thread Michael Roth
These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git qga-win32-v2 Luiz/Gal, I decided not to roll the suspend/hibernate stuff into this series since the s3 situation isn't fully sorted out yet. The file structure is a little different now,

[Qemu-devel] [PULL] w32 patch queue

2012-02-02 Thread Stefan Weil
Hi, here are some w32 related patches which were already published and reviewed on qemu-devel: http://patchwork.ozlabs.org/patch/132797/ http://patchwork.ozlabs.org/patch/138690/ Regards, Stefan Weil The following changes since commit d34e8f6e9d3a396c3327aa9807c83f9e1f4a7bd7: main-loop: F

Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

2012-02-02 Thread Anthony Liguori
On 02/02/2012 01:24 PM, Paolo Bonzini wrote: On 02/02/2012 08:06 PM, Anthony Liguori wrote: I don't want object.h to have a dependency on QObject. We need to phase out QObject. The header doesn't. Couple things: 1) We shouldn't use generic interfaces to read/write properties from objects. W

Re: [Qemu-devel] Get only TCG code without execution

2012-02-02 Thread Rajat Goyal
Hi, I have modified QEMU to act as a TCG compiler and give me the TCG code for the whole binary. However, I cannot find a way to obtain the last address in the binary. The symbol table loaded into syminfos contains only the address of the last symbol. Not the address of the last machine instructio

Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

2012-02-02 Thread Paolo Bonzini
On 02/02/2012 08:24 PM, Paolo Bonzini wrote: 1) We shouldn't use generic interfaces to read/write properties from objects. We should use type-safe accessors provided by the types themselves. That doesn't change the fact that we need simple wrappers using C types (at various levels: object_pro

Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

2012-02-02 Thread Andreas Färber
Am 02.02.2012 20:06, schrieb Anthony Liguori: > On 02/02/2012 10:45 AM, Paolo Bonzini wrote: >> Move the creation of QmpInputVisitor and QmpOutputVisitor from >> qmp.c to qom/object.c, since it's the only practical way to access >> object properties. >> >> Signed-off-by: Paolo Bonzini >> --- >> i

Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

2012-02-02 Thread Paolo Bonzini
On 02/02/2012 08:06 PM, Anthony Liguori wrote: I don't want object.h to have a dependency on QObject. We need to phase out QObject. The header doesn't. Couple things: 1) We shouldn't use generic interfaces to read/write properties from objects. We should use type-safe accessors provided by

Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug

2012-02-02 Thread Alexander Graf
On 02.02.2012, at 20:01, Anthony Liguori wrote: > On 02/02/2012 11:29 AM, Paolo Bonzini wrote: >> On 02/02/2012 06:03 PM, Anthony Liguori wrote: >>> >>> Is this still needed with qom-upstream.14? I fixed a bug on .14 that >>> involved child properties that was making device-del sometimes f

Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

2012-02-02 Thread Anthony Liguori
On 02/02/2012 10:45 AM, Paolo Bonzini wrote: Move the creation of QmpInputVisitor and QmpOutputVisitor from qmp.c to qom/object.c, since it's the only practical way to access object properties. Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 24 qmp.c

Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug

2012-02-02 Thread Anthony Liguori
On 02/02/2012 11:29 AM, Paolo Bonzini wrote: On 02/02/2012 06:03 PM, Anthony Liguori wrote: Is this still needed with qom-upstream.14? I fixed a bug on .14 that involved child properties that was making device-del sometimes fail. Not sure, I tried with .13 but, from the look of it, it shoul

Re: [Qemu-devel] [PATCH v11 0/9] ARM: Samsung Exynos4210-based boards support.

2012-02-02 Thread Peter Maydell
On 30 January 2012 07:38, Evgeny Voevodin wrote: > This set of patches adds support for Samsung Exynos4210-based boards NURI and > SMDKC210. > Tested on Linux kernel v3.x series. > > Usage: > "-smp 2" option is mandatory for now. If it is then the board should complain about -smp 1. As it is, yo

[Qemu-devel] [PATCH] usb: Resolve warnings about unassigned bus on usb device creation

2012-02-02 Thread Jan Kiszka
When creating an USB device the old way, there is no way to specify the target bus. Thus the warning issued by usb_create makes no sense and rather confuses our users. Resolve this by passing a bus reference to the usbdevice_init handler and letting those handlers forward it to usb_create. Signed

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2012-02-02 Thread Rick Vernam
well, the link in the redhat bug, comment 33, is no good apparently. I will follow that bug, and test when I see Vadim has posted a new driver to test. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/8

[Qemu-devel] [PATCH 11/16] qdev: remove parse/print methods for pointer properties

2012-02-02 Thread Paolo Bonzini
Pointer properties (except for PROP_PTR of course) should not need a legacy counterpart. In the future, relative paths will ensure that QEMU will support the same syntax as now for drives etc.. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 128

[Qemu-devel] [PATCH 06/16] qdev: remove direct calls to print/parse

2012-02-02 Thread Paolo Bonzini
There's no need to call into ->parse and ->print manually. The QOM legacy properties do that for us. Furthermore, in some cases legacy and static properties have exactly the same behavior, and we could drop the legacy properties right away. Add an appropriate fallback to prepare for this. Signed

[Qemu-devel] [PATCH 05/16] qom: add property get/set wrappers for C types

2012-02-02 Thread Paolo Bonzini
Add more wrappers that create a QObject and free it around a property set, and that convert a QObject to a C type for a property get. Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 70 ++ qom/object.c | 115 +++

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2012-02-02 Thread Rick Vernam
Yes, I would say it is the same bug. I will test the driver that Vadim linked in Comment 33 (https://bugzilla.redhat.com/show_bug.cgi?id=771390#c33) and report back. Thanks, Mike, for posting here. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

[Qemu-devel] [PATCH 03/16] qom: do not include qdev header file

2012-02-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qom/object.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index de6484d..299e146 100644 --- a/qom/object.c +++ b/qom/object.c @@ -13,8 +13,6 @@ #include "qemu/object.h" #include "qemu-common.h" #include "

[Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

2012-02-02 Thread Paolo Bonzini
Move the creation of QmpInputVisitor and QmpOutputVisitor from qmp.c to qom/object.c, since it's the only practical way to access object properties. Signed-off-by: Paolo Bonzini --- include/qemu/object.h | 24 qmp.c | 17 ++--- qom/object.

[Qemu-devel] [PATCH 13/16] qdev: fix off-by-one

2012-02-02 Thread Paolo Bonzini
Integer properties did not work. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 7efcc78..30abae2 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@

Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug

2012-02-02 Thread Paolo Bonzini
On 02/02/2012 06:03 PM, Anthony Liguori wrote: Is this still needed with qom-upstream.14? I fixed a bug on .14 that involved child properties that was making device-del sometimes fail. Not sure, I tried with .13 but, from the look of it, it should still be there. Regarding the .13->.14 di

[Qemu-devel] [PATCH 16/16] qdev: initialize properties via QOM

2012-02-02 Thread Paolo Bonzini
Similarly, use the object properties also to set the default values of the qdev properties. This requires reordering registration and initialization. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 20 +++- hw/qdev.c|4 ++-- hw/qdev.h| 11

[Qemu-devel] [PATCH 09/16] qdev: remove parse/print methods for mac properties

2012-02-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 61 ++--- 1 files changed, 42 insertions(+), 19 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 0a293af..4fb5cf8 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-prope

[Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer

2012-02-02 Thread Paolo Bonzini
PCI addresses are set with qdev_prop_uint32. Thus we make the QOM property accept a device and function encoded in an 8-bit integer, instead of the magic dd.f hex string. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 25 +++-- 1 files changed, 7 insertions(+), 18

[Qemu-devel] [PATCH 08/16] qdev: remove parse method for string properties

2012-02-02 Thread Paolo Bonzini
We need the print method to put double quotes, but parsing is not special. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 11 --- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 16f9b22..0a293af 100644 --- a/hw/

Re: [Qemu-devel] [PATCH 02/16] qom: store object with correct type in interface links

2012-02-02 Thread Anthony Liguori
On 02/02/2012 10:45 AM, Paolo Bonzini wrote: When a link property's type is an interface, the code expects the implementation object (not the parent object) to be stored in the variable. The parent object does not contain the right vtable. Signed-off-by: Paolo Bonzini --- qom/object.c |3

Re: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug

2012-02-02 Thread Anthony Liguori
On 02/02/2012 10:45 AM, Paolo Bonzini wrote: The reference that is returned by qdev_device_add is never given back, so that device_del does not cause the refcount to go to zero (and thus does nothing). Signed-off-by: Paolo Bonzini --- vl.c |1 + 1 files changed, 1 insertions(+), 0 deletio

[Qemu-devel] [PATCH 15/16] qdev: inline qdev_prop_set into qdev_prop_set_ptr

2012-02-02 Thread Paolo Bonzini
qdev_prop_set is not needed anymore except for hacks, simplify it and inline it. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 26 +++--- 1 files changed, 7 insertions(+), 19 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index ab7f522..d7e

[Qemu-devel] [PATCH 14/16] qdev: access properties via QOM

2012-02-02 Thread Paolo Bonzini
Do not poke anymore in the struct when accessing qdev properties. Instead, ask the object to set the right value. Signed-off-by: Paolo Bonzini --- hw/qdev-addr.c |5 +++- hw/qdev-properties.c | 67 ++--- hw/qdev.h|1 - 3 fil

[Qemu-devel] [PATCH 07/16] qdev: allow reusing get/set for legacy property

2012-02-02 Thread Paolo Bonzini
In some cases, a legacy property does need a special print method but not a special parse method. In this case, we can reuse the get/set from the static (non-legacy) property. If neither parse nor print is needed, though, do not register the legacy property at all. The previous patch ensures tha

  1   2   >