Hi,
I have post a HOWTO document about windows guest debugging on:
http://www.linux-kvm.org/page/WindowsGuestDrivers/UpdatedGuestDebugging
It include more details as a complement of
http://www.linux-kvm.org/page/WindowsGuestDrivers/GuestDebugging.
Please be free to edit it and
On 10 November 2011 22:10, Anthony Liguori wrote:
> To submit an icon, just sent an email to qemu-devel with the icon and
> include an [ICON] tag in the subject. The only real rules are that the
> license must be an open license that allows redistribution of derived works.
> SVG images are certa
Am 10.11.2011 23:10, schrieb Anthony Liguori:
Hi
We're long over due for a mascot for QEMU. Our wiki is nice, but is
missing that bit of pizzazz that a spiffy logo brings. I can't think
of a better time than the 1.0 release to create one either.
Having given it some thought and discussing
New command "block_set_hostcache" added for dynamically changing
host pagecache setting of a block device.
Usage:
block_set_hostcache
= block device
= on/off
Example:
(qemu) block_set_hostcache ide0-hd0 off
Signed-off-by: Supriya Kannery
---
block.c | 54 +
On 11/11/2011 08:11 AM, Anthony Liguori wrote:
I did a brain dump of my understanding of the various storage
requirements for live migration. I think it's accurate but I may have
misunderstand some details so I would appreciate review.
I think given sections (1) and (2), the only viable thing
raw-posix driver changes for bdrv_reopen_xx functions to
safely reopen image files. Reopening of image files while
changing hostcache dynamically is handled here.
Signed-off-by: Supriya Kannery
Index: qemu/block/raw.c
===
--- qemu.
Struct BDRVReopenState along with three reopen related functions
introduced for handling reopen state of images safely. This can be
extended by each of the block drivers to reopen respective
image files.
Signed-off-by: Supriya Kannery
Index: qemu/block.c
=
qemu command option 'hostcache' added to -drive for block devices.
While starting a VM from qemu commandline, this option can be used
for setting host cache usage for block data access.
Signed-off-by: Supriya Kannery
---
blockdev.c | 13 +
qemu-config.c |4
qemu-o
New error classes defined for file reopen failure and data
sync error
Signed-off-by: Supriya Kannery
---
qerror.c |8
qerror.h |6 ++
2 files changed, 14 insertions(+)
Index: qemu/qerror.c
===
--- qemu.orig/qe
Enhance "info block" to display hostcache setting for each
block device.
Example:
(qemu) info block
ide0-hd0: removable=0 file=../rhel6-32.raw ro=0 drv=raw encrypted=0
Enhanced to display "hostcache" setting:
(qemu) info block
ide0-hd0: removable=0 hostcache=1 file=../rhel6-32.raw ro=0 drv=raw en
Following patchset is for enabling dynamic change of
host pagecache setting of block devices through qemu
monitor.
This patchset introduces
a. monitor command 'block_set_hostcache' using which host
pagecache setting for a block device can be changed
dynamically.
b. a new option for set
On Fri, Nov 11, 2011 at 12:01 AM, Paolo Bonzini wrote:
> This patch includes a bunch of fixes for problems reported by Thomas
> Schmitt.
Have the patchsets fixed that CDROM issue with drive if=scsi? If yes,
i would like to do some test against it next week.
>
> I only tested CD-RW DAO burning of
On Fri, Nov 11, 2011 at 1:32 AM, Kevin Wolf wrote:
> qcow2 has a writeback metadata cache, so flushing a qcow2 image actually
> consists of writing back that cache to the protocol and only then flushes the
> protocol in order to get everything stable on disk.
>
> This introduces a separate bdrv_co
In the function cpu_get_phys_page_debug()(In the file target-i386/helper.c):
I find the following codes:
page_offset = (addr & TARGET_PAGE_MASK) & (page_size - 1);
paddr = (pte & TARGET_PAGE_MASK) + page_offset;
The page_offset is always 4K aligned
From: Liu Ping Fan
Introduce a new structure CPUS as the controller of ICC (INTERRUPT
CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead
of sysbus. So we can support APIC hot-plug feature.
Signed-off-by: liu ping fan
---
Makefile.target |1 +
hw/apic.c | 24
I did a brain dump of my understanding of the various storage requirements for
live migration. I think it's accurate but I may have misunderstand some details
so I would appreciate review.
I think given sections (1) and (2), the only viable thing is to require
cache=none unless we get new int
On 10 November 2011 20:26, Pavel Borzenkov wrote:
> 'sed -i' is not defined in POSIX. It doesn't work on Mac OS X the way
> it's used in configure (without suffix argument). This patch implements
> Peter Maydell's idea of xattr.h detection.
>
> Cc: Peter Maydell
> Signed-off-by: Pavel Borzenkov
On Fri, Oct 28, 2011 at 04:07:36PM +0100, Anthony PERARD wrote:
> From: Jiang Yunhong
>
> Signed-off-by: Jiang Yunhong
> Signed-off-by: Shan Haitao
> Signed-off-by: Anthony PERARD
> ---
> Makefile.target |1 +
> hw/apic-msidef.h |2 +
> hw/xen_
Hi
We're long over due for a mascot for QEMU. Our wiki is nice, but is missing
that bit of pizzazz that a spiffy logo brings. I can't think of a better time
than the 1.0 release to create one either.
Having given it some thought and discussing it with a few people, there seems to
be an obv
On 11/10/2011 12:27 PM, Anthony Liguori wrote:
On 11/10/2011 02:55 AM, Avi Kivity wrote:
If we have to delay the release for a month to get it right, we should.
Not that I think we have to.
Adding libvirt to the discussion.
What does libvirt actually do in the monitor prior to migration comp
On Fri, Oct 28, 2011 at 04:07:33PM +0100, Anthony PERARD wrote:
> From: Allen Kay
>
This is going to be a bit lame review..
> +static uint32_t pt_pci_read_config(PCIDevice *d, uint32_t address, int len)
> +{
> +XenPCIPassthroughState *s = DO_UPCAST(XenPCIPassthroughState, dev, d);
> +ui
'sed -i' is not defined in POSIX. It doesn't work on Mac OS X the way
it's used in configure (without suffix argument). This patch implements
Peter Maydell's idea of xattr.h detection.
Cc: Peter Maydell
Signed-off-by: Pavel Borzenkov
---
configure |6 +-
1 files changed, 5 insertions(+)
On 11/10/2011 02:06 PM, Daniel P. Berrange wrote:
On Thu, Nov 10, 2011 at 01:11:42PM -0600, Anthony Liguori wrote:
On 11/10/2011 12:42 PM, Daniel P. Berrange wrote:
On Thu, Nov 10, 2011 at 12:27:30PM -0600, Anthony Liguori wrote:
What does libvirt actually do in the monitor prior to migration
On 11/10/2011 06:36 AM, Stefan Hajnoczi wrote:
The last trivial-patches pull on top of 1.0-rc1. I have tried to include only
bug or user-visible fixes.
The following changes since commit 4f61927a41a098d06e642ffdea5fc285dc3a0e6b:
hpet: fix infinite loop in qemu_run_timers with -icount enable
On Thu, Nov 10, 2011 at 01:11:42PM -0600, Anthony Liguori wrote:
> On 11/10/2011 12:42 PM, Daniel P. Berrange wrote:
> >On Thu, Nov 10, 2011 at 12:27:30PM -0600, Anthony Liguori wrote:
> >>What does libvirt actually do in the monitor prior to migration
> >>completing on the destination? The least
On 11/10/2011 02:55 AM, Avi Kivity wrote:
On 11/09/2011 07:35 PM, Anthony Liguori wrote:
On 11/09/2011 11:02 AM, Avi Kivity wrote:
On 11/09/2011 06:39 PM, Anthony Liguori wrote:
Migration with qcow2 is not a supported feature for 1.0. Migration is
only supported with raw images using coheren
On 11/10/2011 06:32 PM, Kevin Wolf wrote:
Paolo, does this implement what you were suggesting?
Kevin Wolf (3):
block: Rename bdrv_co_flush to bdrv_co_flush_to_disk
block: Introduce bdrv_co_flush_to_os
block: Make cache=unsafe flush to the OS
block.c | 23 +
On 10 November 2011 18:59, Pavel Borzenkov wrote:
> On Nov 10, 2011, at 10:18 PM, Peter Maydell wrote:
>> sed -i isn't POSIX; it would be nicer not to use it at all really.
>
> I was trying to do minimal changes to the code.
> Do you know sed implementations that do not support '-i'?
busybox sed
On 11/10/2011 12:42 PM, Daniel P. Berrange wrote:
On Thu, Nov 10, 2011 at 12:27:30PM -0600, Anthony Liguori wrote:
What does libvirt actually do in the monitor prior to migration
completing on the destination? The least invasive way of doing
delayed open of block devices is probably to make -in
On Nov 10, 2011, at 10:18 PM, Peter Maydell wrote:
> On 10 November 2011 18:03, Pavel Borzenkov wrote:
>> diff --git a/configure b/configure
>> index 401d9a6..b83640e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1968,7 +1968,7 @@ EOF
>> if compile_prog "" "" ; then
>> attr=yes
>>
On Thu, Nov 10, 2011 at 12:27:30PM -0600, Anthony Liguori wrote:
> What does libvirt actually do in the monitor prior to migration
> completing on the destination? The least invasive way of doing
> delayed open of block devices is probably to make -incoming create a
> monitor and run a main loop b
When SDL support is disabled, there is no way to build QEMU without
Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
allows to build QEMU without both SDL and Cocoa frontends.
Signed-off-by: Pavel Borzenkov
---
configure |7 ++-
1 files changed, 6 insertions(+), 1 d
It was commented out since the initial import from svn.
Signed-off-by: Pavel Borzenkov
---
block/raw-posix.c | 18 --
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index a3de373..17e1c6f 100644
--- a/block/raw-posix.c
+++
Use __APPLE__ and __MACH__ macros instead of CONFIG_COCOA to detect Mac
OS X host. The patch is based on the Ben Leslie's patch:
http://patchwork.ozlabs.org/patch/97859/
Signed-off-by: Pavel Borzenkov
---
block/raw-posix.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff -
After applying this small patch series, you'll be able to build QEMU on Mac OS
X without both SDL and Cocoa frontends. First two patches deal with raw-posix,
which is the only CONFIG_COCOA user not related to GUI. The third patch adds
'--disable-cocoa' switch to configure.
Pavel Borzenkov (3):
On 10 November 2011 18:03, Pavel Borzenkov wrote:
> diff --git a/configure b/configure
> index 401d9a6..b83640e 100755
> --- a/configure
> +++ b/configure
> @@ -1968,7 +1968,7 @@ EOF
> if compile_prog "" "" ; then
> attr=yes
> # Older distros have , and need -lattr:
> - elif sed -i s,sys/
Hi,
> I only tested CD-RW DAO burning of an ISO image, plus invoking a bunch
> of commands from Thomas's logs). The burning succeeded but reading
> the resulting medium failed consistently at 26 MB. However, the same
> happened even when doing CD passthrough via virtio, so it may be due to
> a d
BSD sed always requires a suffix to be passed when '-i' switch is used.
In GNU sed this suffix is optional. Due to this, configure prints the
following error when runs on Mac OS X:
sed: 1: "/var/folders/r_/1g8ws8s ...": invalid command code f
Signed-off-by: Pavel Borzenkov
---
configure |2
On 11/10/2011 04:41 AM, Kevin Wolf wrote:
Am 09.11.2011 22:01, schrieb Anthony Liguori:
On 11/09/2011 03:00 PM, Michael S. Tsirkin wrote:
On Wed, Nov 09, 2011 at 02:22:02PM -0600, Anthony Liguori wrote:
On 11/09/2011 02:18 PM, Michael S. Tsirkin wrote:
On Wed, Nov 09, 2011 at 11:35:54AM -0600
On 11/10/2011 10:50 AM, Juan Quintela wrote:
Kevin Wolf wrote:
What I took from the feedback was that Kevin wanted to defer open until the
device model started. That eliminates the need to reopen or have a invalidation
callback.
I think it would be good for Kevin to comment here though becau
On 11/10/2011 02:55 AM, Avi Kivity wrote:
On 11/09/2011 07:35 PM, Anthony Liguori wrote:
On 11/09/2011 11:02 AM, Avi Kivity wrote:
On 11/09/2011 06:39 PM, Anthony Liguori wrote:
Migration with qcow2 is not a supported feature for 1.0. Migration is
only supported with raw images using coheren
Avi Kivity wrote:
> On 11/09/2011 07:35 PM, Anthony Liguori wrote:
>> On 11/09/2011 11:02 AM, Avi Kivity wrote:
>>> On 11/09/2011 06:39 PM, Anthony Liguori wrote:
Migration with qcow2 is not a supported feature for 1.0. Migration is
only supported with raw images using coherent sha
qcow2 has a writeback metadata cache, so flushing a qcow2 image actually
consists of writing back that cache to the protocol and only then flushes the
protocol in order to get everything stable on disk.
This introduces a separate bdrv_co_flush_to_os to reflect the split.
Signed-off-by: Kevin Wolf
There are two different types of flush that you can do: Flushing one level up
to the OS (i.e. writing data to the host page cache) or flushing it all the way
down to the disk. The existing functions flush to the disk, reflect this in the
function name.
Signed-off-by: Kevin Wolf
---
block.c
cache=unsafe completely ignored bdrv_flush, because flushing the host disk
costs a lot of performance. However, this means that qcow2 images (and
potentially any other format) can lose data even after the guest has issued a
flush if the qemu process crashes/is killed. In case of a host crash, data
Paolo, does this implement what you were suggesting?
Kevin Wolf (3):
block: Rename bdrv_co_flush to bdrv_co_flush_to_disk
block: Introduce bdrv_co_flush_to_os
block: Make cache=unsafe flush to the OS
block.c | 23 +++
block/cow.c | 22 ---
Hi.
The same issue from here.
-
me@host:~$ qemu-system-ppc -cdrom FreeBSD-8.2-RELEASE-powerpc-disc1.iso \
-hda freebsd8.2-ppc.img -m 94 -boot d -bios /usr/share/openbios/openbios-ppc
-nographic
qemu: warning: could not load VGA bios 'video.x'
>> =
Trying the following and can¹t seem to make it work ? This is with qemu-kvm
15 . What am I doing wrong here ? I get this id1 not found error.
qemu-system-x86_64 \
-enable-kvm -cpu qemu64,+vmx -boot c -m 16000M \
-drive file=my.disk,if=virtio \
-netdev user,id=id0 -device virtio-net-pci,netdev=
On 11/01/2011 08:57 PM, Nishanth Aravamudan wrote:
On 31.10.2011 [15:14:12 +1100], David Gibson wrote:
Good points below. I forgot to CC Nish, the original patch author on
my post, so I've added him to the list now.
Nish, can you correct these problems and resend the patch please?
When run wi
On 08/10/2011 01:41 PM, Sebastian Bauer wrote:
When using gdb to single step a ppc interrupt routine, the execution
flow passes
the rfi instruction without actually returning from the interrupt. The
patch
fixes this by avoiding to update the nip when the debug exception is
raised
and a previous
Kevin Wolf wrote:
>> What I took from the feedback was that Kevin wanted to defer open until the
>> device model started. That eliminates the need to reopen or have a
>> invalidation
>> callback.
>>
>> I think it would be good for Kevin to comment here though because I might
>> have
>> mis
Kevin Wolf wrote:
> Am 09.11.2011 20:16, schrieb Juan Quintela:
>> Linux allows to invalidate block devices. This is needed for the incoming
>> migration part.
>>
>> Signed-off-by: Juan Quintela
>
> I think Christoph said that this ioctl kills ramdisks? Or was that
> something different?
On pa
Mode page 2A of emulated ATAPI DVD-ROM should have page length 0x14
like SCSI CD-ROM, rather than 0x12.
Mode page length is off by 8, as it should contain the length of the
payload after the first two bytes.
MODE SENSE(6) should be thrown out of ATAPI DVD-ROM emulation. It is
not specified in th
- several MMC commands were parsed wrong by QEMU because their allocation
length/parameter list length is placed in a non-standard position in
the CDB (i.e. it is different from most commands with the same value in
bits 5-7).
- SEND VOLUME TAG length was multiplied by 40 which is not in SMC. The
On 10 November 2011 10:32, Andreas Färber wrote:
> + {
> + static const struct {
> + uint8_t r;
> + uint8_t p;
> + uint8_t value;
> + } fpsid_revs[] = {
> + { 1, 0, 0x3 },
> + { 1, 1, 0x4 },
> +
On Sun, Oct 23, 2011 at 05:39:47PM +0200, Vadim Rozenfeld wrote:
> With the following series of patches we are starting to implement
> some basic Microsoft Hyper-V Enlightenment functionality. This series
> is mostly about adding support for relaxed timing, spinlock,
> and virtual apic.
>
> For mo
On Wed, Oct 26, 2011 at 01:09:45PM +0200, Jan Kiszka wrote:
> The latter was already commented out, the former is redundant as well.
> We always get the latest changes after return from the guest via
> kvm_arch_post_run.
>
> Signed-off-by: Jan Kiszka
Applied, thanks.
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c |4 +++--
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 0e60de1..19e846c 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -987,8 +987,9 @@ static int scsi_disk_emulate_mode_sense(SCSIDisk
Add more commands and their names, and remove SEEK(6) which is obsolete.
Instead, use SET_POSITION which is still in SSC.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c | 25 +++--
hw/scsi-defs.h | 10 +-
hw/scsi-disk.c |4 +---
3 files changed, 29 insertions
CD burning commands do strange things including writing beyond the
maximum LBA and even to negative blocks for the lead-in.
WRITE(6), WRITE(16), WRITE AND VERIFY(16) are not in MMC.
WRITE AND VERIFY(12) is not in MMC but it seemed a good idea to
treat it like WRITE(12).
Also detect blanking of a
This patch includes a bunch of fixes for problems reported by Thomas
Schmitt.
I only tested CD-RW DAO burning of an ISO image, plus invoking a bunch
of commands from Thomas's logs). The burning succeeded but reading
the resulting medium failed consistently at 26 MB. However, the same
happened ev
machine defaults to find_default_machine(),
then gets overridden via -M and machine_parse().
If no -M is specified and find_default_machine() returns NULL
(when no machine compiled in), exit with an error.
Avoids a segfault when setting machine->max_cpus.
Signed-off-by: Andreas Färber
---
vl.c
On 22 October 2011 12:00, Andreas Färber wrote:
> Previously the CPUID register was set in cpu_arm_init() based on -cpu
> model. The CPU was then reset, requiring to save the CPUID and restore
> it afterwards.
>
> Change the storage location of c0_cpuid so that it does not get cleared.
I think th
From: Markus Armbruster
Spotted by Coverity.
Signed-off-by: Markus Armbruster
Signed-off-by: Stefan Hajnoczi
---
hw/qdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 50976dd..106407f 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -186,7 +1
From: 陳韋任
Signed-off-by: Chen Wen-Ren (陳韋任)
Signed-off-by: Stefan Hajnoczi
---
configure |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 401d9a6..8d85d23 100755
--- a/configure
+++ b/configure
@@ -1037,6 +1037,7 @@ echo " --fmod-lib
From: Markus Armbruster
Fixes protocol_client_auth_sasl_mechname() not to crash when malloc()
fails. Spotted by Coverity.
Signed-off-by: Markus Armbruster
Signed-off-by: Stefan Hajnoczi
---
ui/vnc-auth-sasl.c | 19 +--
1 files changed, 5 insertions(+), 14 deletions(-)
diff
On 10.11.2011, at 12:29, Andreas Färber wrote:
> Am 10.11.2011 11:32, schrieb Alexander Graf:
>>
>> On 10.11.2011, at 10:53, Andreas Färber wrote:
>>
>>> Is there a known issue with running multiple instances of
>>> qemu-system-s390x? I got a hang on openSUSE 12.1 RC2 x86_64 host:
>>>
>>> 0x
On 10 November 2011 10:31, Andreas Färber wrote:
> Here's a rebased version of my ARM feature inference series. It's based on
> my CPUID preservation patch, which hasn't received any comments yet.
Oops. I'll go back and dig that out of the archive.
> These inference rules are based on your comme
This is what qemu_fclose() expects.
Changes v1 -> v2:
- On success, keep returning pclose() return value, instead of always 0.
Changes v2 -> v3:
- Add braces on if statements to match coding style
Signed-off-by: Eduardo Habkost
---
savevm.c |3 +++
1 files changed, 3 insertions(+), 0 del
Comments for v3:
I am still not sure if this is 1.0 material, but I am more inclined to delay
this for post-1.0.
Changes v2 -> v3:
- Only coding style changes for issues detected by checkpatch.pl:
- Avoid "//" comments;
- Use braces on if statements.
Comments for v2:
I am not sur
In case close() fails, we want to report the error back.
Changes v1 -> v2:
- Use braces on if statement to match coding style
Signed-off-by: Eduardo Habkost
---
migration-unix.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/migration-unix.c b/migration-unix.c
i
This will make sure no error will be missed as long as callers always
check for qemu_fclose() return value. For reference, this is the
complete list of qemu_fclose() callers:
- exec_close(): already fixed to check for negative values, not -1
- migrate_fd_cleanup(): already fixed to consider only
The last trivial-patches pull on top of 1.0-rc1. I have tried to include only
bug or user-visible fixes.
The following changes since commit 4f61927a41a098d06e642ffdea5fc285dc3a0e6b:
hpet: fix infinite loop in qemu_run_timers with -icount enabled (2011-11-09
12:06:20 -0600)
are available in t
From: Peter Maydell
Add a missing 'break' statement to fix a buffer overrun when
executing the EEPROM write-all command. Spotted by Coverity
(see bug 887883).
Signed-off-by: Peter Maydell
Signed-off-by: Stefan Hajnoczi
---
hw/lan9118.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-
From: Markus Armbruster
To reproduce the leak, put two name options into the same [cpudef]
section of target-x86_64.conf.
Signed-off-by: Markus Armbruster
Signed-off-by: Stefan Hajnoczi
---
target-i386/cpuid.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i38
From: Markus Armbruster
Spotted by Coverity.
Signed-off-by: Markus Armbruster
Signed-off-by: Stefan Hajnoczi
---
target-i386/cpuid.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index 99cff65..21e5896 100644
--- a/target
All qemu_fclose() callers were already changed to accept any negative
value as error, so we now can change it to return -errno.
When the process exits with a non-zero exit code, we return -EIO to as a
fake errno value.
Changes v1 -> v2:
- Don't use "//" comments, to make checkpatch.pl happy
Sig
2011/11/10 Stefan Hajnoczi :
> On Thu, Nov 10, 2011 at 04:23:22PM +0800, Dong Xu Wang wrote:
>> From: Dong Xu Wang
>>
>> Looks better when reviewing these source files.
>>
>> Signed-off-by: Dong Xu Wang
>> ---
>> block/qcow.c | 4 ++--
>> block/qcow2.c | 6 +++---
>> block/sheepdog.
On 11/09/2011 07:03 PM, Richard Henderson wrote:
This is the direction in which I believe we should fix the s390
compilation failure. I've cross-compiled --target-list=i386-softmmu
for every tcg host to make sure that they all build.
The second patch cannot be split into per-host patches, lest
From: Markus Armbruster
Fixes missing error checking.
Signed-off-by: Markus Armbruster
Signed-off-by: Stefan Hajnoczi
---
target-i386/cpuid.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index edac377..352c390 100644
qemu_fclose() and QEMUFile->close will return -errno on error, and any
positive value on success.
We need the positive non-zero success values because
migration-exec.c:exec_close() relies on non-zero return values to get
the process exit code.
Changes v1 -> v2:
- Cosmetic spelling change on comm
Some code uses qemu_file_set_error() already, so use it everywhere
when setting last_error, for consistency.
Signed-off-by: Eduardo Habkost
---
savevm.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index bee16c0..2dab5dc 100644
--- a/savevm.c
++
From: 陳韋任
Update the document since the default code cache size is 32 MB now.
Signed-off-by: chenwj
Signed-off-by: Stefan Hajnoczi
---
qemu-tech.texi |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-tech.texi b/qemu-tech.texi
index 397b070..62afe45 100644
--- a
On 11/09/2011 08:21 PM, Sasha Levin wrote:
> On Wed, 2011-11-09 at 20:00 +0200, Avi Kivity wrote:
> > On 11/09/2011 07:56 PM, Anthony Liguori wrote:
> > > On 11/09/2011 07:44 AM, Avi Kivity wrote:
> > >> The fact that a host cpu supports a feature doesn't mean that QEMU
> > >> and KVM
> > >> will a
Note that we don't return the unchanged return value back yet, because
we need to change all qemu_fclose() callers to accept any positive value
as success.
Signed-off-by: Eduardo Habkost
---
migration-exec.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/migration-exec
Am 10.11.2011 09:23, schrieb Dong Xu Wang:
> From: Dong Xu Wang
>
> Looks better when reviewing these source files.
>
> Signed-off-by: Dong Xu Wang
Thanks, applied to the block branch (for 1.1)
Kevin
Am 09.11.2011 22:59, schrieb Peter Maydell:
> Fix a use-while-uninitialized of the fd_type[] array (introduced
> in commit 34d4260e1, noticed by Coverity). This is more theoretical
> than practical, since it's quite hard to get here with floppy==NULL
> (the qdev_try_create() of the isa-fdc device h
This is what qemu_fclose() expects.
Changes v1 -> v2:
- Add braces to if statement to match coding style
Signed-off-by: Eduardo Habkost
---
savevm.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index a870b3f..4ccbc1c 100644
--- a/savevm.c
+
In case close() fails, we want to report the error back.
Changes v1 -> v2:
- Use braces on if statement to match coding style
Signed-off-by: Eduardo Habkost
---
migration-tcp.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/migration-tcp.c b/migration-tcp.c
inde
Also, we now return the qemu_fclose() value unchanged to the caller. For
reference, the migrate_fd_cleanup() callers are the following:
- migrate_fd_completed(): any negative value is considered an
error, so the change is OK.
- migrate_fd_error(): doesn't check the migrate_fd_cleanup() return va
I will send v3 of this series with changes to comply with coding style,
fixing warnings detected by checkpatch.pl.
--
Eduardo
On Thu, Nov 10, 2011 at 04:21:46PM +0800, Dong Xu Wang wrote:
> > if (s->fd != -1) {
> > - close(s->fd);
> > + if (close(s->fd) < 0)
> > + r = -errno;
> Braces {} are necessary, or checkpatch.pl will give warnings, also in
> other patches in your series.
>
> No mistake
On 10 November 2011 11:54, Pavel Borzenkov wrote:
> On Thu, Nov 10, 2011 at 2:44 PM, Peter Maydell
> wrote:
>> On 10 November 2011 10:41, Andreas Färber wrote:
>>> I remember there was a similar patch once but some issue with it kept us
>>> from applying it - something unrelated to the frontend
On Wed, Nov 09, 2011 at 07:57:35PM -0600, Anthony Liguori wrote:
> On 11/09/2011 04:03 PM, Eduardo Habkost wrote:
> >I am not sure if this is appropriate post-freeze, I will let the maintainers
> >decide this. Personally I think the code is more reliable with these changes,
> >but on the other hand
On Thu, Nov 10, 2011 at 2:41 PM, Andreas Färber wrote:
> Am 09.11.2011 19:54, schrieb Pavel Borzenkov:
>> When SDL support is disabled, there is no way to build QEMU without
>> Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
>> allows to build QEMU without both SDL and Cocoa
On Thu, Nov 10, 2011 at 2:44 PM, Peter Maydell wrote:
> On 10 November 2011 10:41, Andreas Färber wrote:
>> I remember there was a similar patch once but some issue with it kept us
>> from applying it - something unrelated to the frontend was influenced by
>> it I think... block layer?
>
> Yeah,
With -icount, The vm_clock is updated with help from TCG (it counts
instructions at 2^ICOUNT ns/instructions). With KVM, the instruction
count is not available so KVM cannot provide this help.
Signed-off-by: Max Filippov
Acked-by: Paolo Bonzini
---
v1 -> v2 changes:
- cover both kvm and xen;
- a
On Wed, Nov 09, 2011 at 07:45:38PM +, Peter Maydell wrote:
> Signed-off-by: Peter Maydell
> ---
> If anything qualifies as a trivial patch, this does :-)
>
> MAINTAINERS |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Normally I wouldn't touch MAINTAINERS but this really is tr
On Wed, Nov 09, 2011 at 07:34:28PM +, Peter Maydell wrote:
> Remove a check for g_malloc failing: this never happens.
> Also use g_malloc rather than g_malloc0 as we immediately
> memset the entire region and so zero-initialising it is pointless.
> Spotted by Coverity (see bug 887883).
>
> Sig
On Wed, Nov 09, 2011 at 06:59:54PM +, Peter Maydell wrote:
> Add a missing 'break' statement to fix a buffer overrun when
> executing the EEPROM write-all command. Spotted by Coverity
> (see bug 887883).
>
> Signed-off-by: Peter Maydell
> ---
> hw/lan9118.c |1 +
> 1 files changed, 1 ins
1 - 100 of 132 matches
Mail list logo
