On Wed, Nov 09, 2011 at 07:57:35PM -0600, Anthony Liguori wrote: > On 11/09/2011 04:03 PM, Eduardo Habkost wrote: > >I am not sure if this is appropriate post-freeze, I will let the maintainers > >decide this. Personally I think the code is more reliable with these changes, > >but on the other hand the only bugs it fixes are on the error paths. > > What bug does this fix?
This one: > >- qemu_fclose() calls qemu_fflush() > >- Writes done by qemu_fflush() can fail > >- Those errors are lost after qemu_fclose() returns (The fix for that is on patch 05/10, the rest are related cleanups or dependencies for the actual fix). Also, errno values were being lost in the call chain as most functions were returning just -1 instead of -errno. I don't have any specific bug report that this fixes, but we already had multiple reports on RHEL of errors during migration (e.g. interrupted network connection) causing hangs. This is only part of the changes required to make migration error handling reliable. -- Eduardo
