On Thu, Nov 10, 2011 at 2:41 PM, Andreas Färber <andreas.faer...@web.de> wrote: > Am 09.11.2011 19:54, schrieb Pavel Borzenkov: >> When SDL support is disabled, there is no way to build QEMU without >> Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and >> allows to build QEMU without both SDL and Cocoa frontends. >> >> Signed-off-by: Pavel Borzenkov <pavel.borzen...@gmail.com> > > This is a new feature and therefore too late for 1.0. Only bugfixes now. > > I remember there was a similar patch once but some issue with it kept us > from applying it - something unrelated to the frontend was influenced by > it I think... block layer? > >> --- >> configure | 11 ++++++----- >> 1 files changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/configure b/configure >> index 9e5da44..ba3a830 100755 >> --- a/configure >> +++ b/configure > >> @@ -1424,10 +1429,6 @@ EOF >> if compile_prog "$sdl_cflags" "$sdl_libs" ; then >> if test "$_sdlversion" -lt 121 ; then >> sdl_too_old=yes >> - else >> - if test "$cocoa" = "no" ; then >> - sdl=yes >> - fi > > Without looking at the context, this hunk looks weird. You sure you're > not breaking the SDL default for other platforms?
Yeah, I did break it, at least for Linux. I'll fix this in the next version. -- Pavel > >> fi >> >> # static link with sdl ? (note: sdl.pc's --static --libs is broken) > > > Anyway, I would much more appreciate a bugfix or suggestion how to make > Cocoa build than to disable it altogether (and then only based on a > configure option). > > Andreas >
