[Qemu-devel] [PATCH v11 2/4] block: add I/O throttling algorithm

2011-11-01 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- block.c | 233 +++-- block.h |1 + block_int.h |1 + qemu-coroutine-lock.c |8 ++ qemu-coroutine.h |6 ++ 5 files changed, 242 ins

Re: [Qemu-devel] [PATCH v11 5/5] lsllsls

2011-11-01 Thread Zhi Yong Wu
Sorry, pls ignore this. On Wed, Nov 2, 2011 at 2:01 PM, Zhi Yong Wu wrote: > Signed-off-by: Zhi Yong Wu > --- >  block.c           |    2 +- >  block/qed-table.c |    6 +++--- >  2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/block.c b/block.c > index 8ff522c..9936d7f 100644 >

[Qemu-devel] [PATCH v11 5/5] lsllsls

2011-11-01 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- block.c |2 +- block/qed-table.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 8ff522c..9936d7f 100644 --- a/block.c +++ b/block.c @@ -2838,7 +2838,7 @@ typedef struct BlockDriverAIOCBCoroutine {

[Qemu-devel] [PATCH v11 4/4] block: perf testing data based on block I/O throttling

2011-11-01 Thread Zhi Yong Wu
The file 1mbps.dat is based on bps=1024*1024 I/O throttling; and the file 10mbps.dat is based on bps=10*1024*1024 I/O throttling. Signed-off-by: Zhi Yong Wu --- 10mbps.dat | 334 ++ 1mbps.dat | 341 ++

[Qemu-devel] [PATCH v11 3/4] hmp/qmp: add block_set_io_throttle

2011-11-01 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- block.c | 15 + blockdev.c | 59 ++ blockdev.h |2 + hmp-commands.hx | 15 + hmp.c| 10 + qapi-schema.js

[Qemu-devel] [PATCH v11 1/4] block: add the blockio limits command line support

2011-11-01 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- block.c | 40 block.h |4 block_int.h | 29 + blockdev.c | 44 qemu-config.c |

[Qemu-devel] [PATCH v11 0/4] The intro to QEMU block I/O throttling

2011-11-01 Thread Zhi Yong Wu
The main goal of the patch is to effectively cap the disk I/O speed or counts of one single VM.It is only one draft, so it unavoidably has some drawbacks, if you catch them, please let me know. The patch will mainly introduce one block I/O throttling algorithm, one timer and one block queue for

Re: [Qemu-devel] [PATCH v10 1/3] block: add the command line support

2011-11-01 Thread Zhi Yong Wu
On Wed, Nov 2, 2011 at 6:43 AM, Ryan Harper wrote: > * Zhi Yong Wu [2011-11-01 02:44]: >> Signed-off-by: Zhi Yong Wu >> --- >>  block.c         |   40 >>  block.h         |    4 >>  block_int.h     |   29 + >>  blockdev.c

Re: [Qemu-devel] [PATCH] virtio: Add PCI memory BAR in addition to PIO BAR

2011-11-01 Thread Rusty Russell
On Tue, 01 Nov 2011 17:20:06 -0500, Anthony Liguori wrote: > On 09/30/2011 12:26 AM, David Gibson wrote: > > Currently, virtio devices are usually presented to the guest as an > > emulated PCI device, virtio_pci. Although the actual IO operations > > are done through system memory, the configurat

[Qemu-devel] [PATCH] pseries: Fix initialization of sPAPREnvironment structure

2011-11-01 Thread David Gibson
Since we added PCI support to the pseries machine, we include a qlist of PCI host bridges in the sPAPREnvironment structure. However this list was never properly initialized it. Somehow we got away with this until some other recent change broke it, and we now segfault immediately on startup. Thi

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-11-01 Thread Wen Congyang
At 11/02/2011 10:15 AM, Isaku Yamahata Write: > On Tue, Nov 01, 2011 at 04:49:08PM +0800, Wen Congyang wrote: >> At 11/01/2011 04:44 PM, Michael S. Tsirkin Write: >>> On Tue, Nov 01, 2011 at 09:27:25AM +0800, Wen Congyang wrote: Hi, Michael S. Tsirkin At 09/26/2011 03:08 PM, Michael

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-11-01 Thread Isaku Yamahata
On Tue, Nov 01, 2011 at 04:49:08PM +0800, Wen Congyang wrote: > At 11/01/2011 04:44 PM, Michael S. Tsirkin Write: > > On Tue, Nov 01, 2011 at 09:27:25AM +0800, Wen Congyang wrote: > >> Hi, Michael S. Tsirkin > >> > >> At 09/26/2011 03:08 PM, Michael S. Tsirkin Write: > >>> On Mon, Sep 26, 2011 at 0

Re: [Qemu-devel] http://git.qemu.org/git/qemu.git/ is inaccessible

2011-11-01 Thread Roy Tam
Hi, 2011/11/2 shu ming : > You may try: > http://repo.or.cz/w/qemu.git > Thanks. > On 2011-11-2 9:01, Roy Tam wrote: >> >> Hi all, >> >> http://git.qemu.org/git/qemu.git/ is listed in http://git.qemu.org/ >> but it is inaccessible (HTTP 403). >> Where is mirror of it? As I can't access git:// pr

Re: [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()

2011-11-01 Thread Jun Koi
On Tue, Nov 1, 2011 at 11:05 PM, Anthony Liguori wrote: > On 11/01/2011 12:11 AM, Jun Koi wrote: >> >> This patch removes unused function argument xfds from >> qemu_iohandler_poll() and qemu_iohandler_fill() >> >> Signed-off-by: Jun Koi >> > > Your mailer is munging the patch.  Please use git-send

Re: [Qemu-devel] [PATCH V2] Introduce a new bus "ICC" to connect APIC

2011-11-01 Thread liu ping fan
On Tue, Nov 01, 2011 at 02:47:58PM +0100, Jan Kiszka wrote: > On 2011-11-01 08:41, pingf...@linux.vnet.ibm.com wrote: > > From: Liu Ping Fan > > > > Introduce a new structure CPUS as the controller of ICC (INTERRUPT > > CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead > > of sys

[Qemu-devel] [patch] add auto-generated files into .gitignore

2011-11-01 Thread Jun Koi
This patch adds some auto-generated files into .gitignore Signed-off-by: Jun Koi diff --git a/.gitignore b/.gitignore index 6d2acab..62679d8 100644 --- a/.gitignore +++ b/.gitignore @@ -72,3 +72,9 @@ cscope.* tags TAGS *~ +qapi-types.c +qapi-types.h +qapi-visit.c +qapi-visit.h +qmp-commands.

Re: [Qemu-devel] http://git.qemu.org/git/qemu.git/ is inaccessible

2011-11-01 Thread shu ming
You may try: http://repo.or.cz/w/qemu.git On 2011-11-2 9:01, Roy Tam wrote: Hi all, http://git.qemu.org/git/qemu.git/ is listed in http://git.qemu.org/ but it is inaccessible (HTTP 403). Where is mirror of it? As I can't access git:// protocol here and I need accessing http:// repo instead. Be

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-11-01 Thread Wen Congyang
At 11/01/2011 07:48 PM, Michael S. Tsirkin Write: > On Tue, Nov 01, 2011 at 04:49:08PM +0800, Wen Congyang wrote: >> At 11/01/2011 04:44 PM, Michael S. Tsirkin Write: >>> On Tue, Nov 01, 2011 at 09:27:25AM +0800, Wen Congyang wrote: Hi, Michael S. Tsirkin At 09/26/2011 03:08 PM, Mich

Re: [Qemu-devel] [PATCH] virtio: Add PCI memory BAR in addition to PIO BAR

2011-11-01 Thread David Gibson
On Tue, Nov 01, 2011 at 05:20:06PM -0500, Anthony Liguori wrote: > On 09/30/2011 12:26 AM, David Gibson wrote: > >Currently, virtio devices are usually presented to the guest as an > >emulated PCI device, virtio_pci. Although the actual IO operations > >are done through system memory, the configur

[Qemu-devel] We have now entered 1.0 hard freeze

2011-11-01 Thread Anthony Liguori
Hi, I've just pushed the VERSION update so we are officially in hard freeze. I've cleared out my patch and pull request queues and processed everything I intend on processing for 1.0. If you're a contributor and have a question about a patch that didn't make the hard freeze, please feel free

Re: [Qemu-devel] [PATCH] spapr: fix build

2011-11-01 Thread David Gibson
On Tue, Nov 01, 2011 at 03:16:14PM -0700, Alexander Graf wrote: > > > > > On 01.11.2011, at 14:51, Anthony Liguori wrote: > > > Signed-off-by: Anthony Liguori > > If that's what it takes to make it compile for you, please apply > it. i'm currently not anywhere close to a box to test it on m

Re: [Qemu-devel] [PATCH] virtio: Add PCI memory BAR in addition to PIO BAR

2011-11-01 Thread Anthony Liguori
On 11/01/2011 07:16 PM, David Gibson wrote: On Tue, Nov 01, 2011 at 05:20:06PM -0500, Anthony Liguori wrote: On 09/30/2011 12:26 AM, David Gibson wrote: Currently, virtio devices are usually presented to the guest as an emulated PCI device, virtio_pci. Although the actual IO operations are don

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/22] ppc patch queue 2011-10-30

2011-11-01 Thread David Gibson
On Tue, Nov 01, 2011 at 03:28:05PM -0700, Alexander Graf wrote: > > On 01.11.2011, at 15:16, Anthony Liguori wrote: > > > On 11/01/2011 05:14 PM, Alexander Graf wrote: > >>> And specifically: > >>> > >>>QLIST_FOREACH(qdev,&phb->host_state.bus->qbus.children, sibling) { > >>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH 18/22] PPC: Fail configure when libfdt is not available

2011-11-01 Thread David Gibson
On Tue, Nov 01, 2011 at 07:28:45PM +, Blue Swirl wrote: > On Sun, Oct 30, 2011 at 20:23, Alexander Graf wrote: > > We have several targets in the PPC tree now that basically require libfdt > > to function properly, namely the pseries and the e500 targets. This > > dependency > > will rather i

[Qemu-devel] [Bug 884401] Re: PCI Passthrough for Digium TCE400P Codec Card Not working

2011-11-01 Thread Alex Williamson
This is a distro bug, not an upstream bug. The error message indicates the version of qemu-kvm you're using doesn't support sub-4k MMIO BARs. This has already been fixed in RHEL6.1. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. htt

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-01 Thread Chris Johns
On 1/11/11 9:05 PM, Gerd Hoffmann wrote: Adding a device is simply a matter of dropping a file into the tree and a line into the Makefile and you are done. The device is available to be used via -device. So the cost of maintaining stuff out-of-tree isn't that big as you almost never have patch

Re: [Qemu-devel] [PATCH v10 1/3] block: add the command line support

2011-11-01 Thread Ryan Harper
* Zhi Yong Wu [2011-11-01 02:44]: > Signed-off-by: Zhi Yong Wu > --- > block.c | 40 > block.h |4 > block_int.h | 29 + > blockdev.c | 32 > qemu-config.

Re: [Qemu-devel] [PATCH] arm_gic: handle banked enable bits for per-cpu interrupts

2011-11-01 Thread Peter Maydell
On 1 November 2011 22:31, Peter Maydell wrote: > On 28 October 2011 18:40, Rabin Vincent wrote: >> The first enable set/clear register (which controls the PPIs and SGIs) >> is supposed to be banked for each processor.  Currently it is just >> handled globally and this prevents recent SMP Linux ke

Re: [Qemu-devel] [PULL 0/3] Cocoa fixes for 1.0

2011-11-01 Thread Anthony Liguori
On 11/01/2011 02:56 PM, Andreas Färber wrote: Hello Anthony, Please pull these Cocoa-related patches for 1.0. For our long-standing uint16 compilation issue we are still in need of a fully correct solution. Depending on what we come up with, we'll try to squeeze it in between RCs or defer it to

Re: [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30

2011-11-01 Thread Anthony Liguori
On 11/01/2011 05:28 PM, Alexander Graf wrote: On 01.11.2011, at 15:16, Anthony Liguori wrote: On 11/01/2011 05:14 PM, Alexander Graf wrote: And specifically: QLIST_FOREACH(qdev,&phb->host_state.bus->qbus.children, sibling) { PCIDevice *dev = (PCIDevice *)qdev;

Re: [Qemu-devel] [PATCH] arm_gic: handle banked enable bits for per-cpu interrupts

2011-11-01 Thread Peter Maydell
On 28 October 2011 18:40, Rabin Vincent wrote: > The first enable set/clear register (which controls the PPIs and SGIs) > is supposed to be banked for each processor.  Currently it is just > handled globally and this prevents recent SMP Linux kernels from > booting, because CPU0 stops receiving lo

Re: [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30

2011-11-01 Thread Alexander Graf
On 01.11.2011, at 15:16, Anthony Liguori wrote: > On 11/01/2011 05:14 PM, Alexander Graf wrote: >>> And specifically: >>> >>>QLIST_FOREACH(qdev,&phb->host_state.bus->qbus.children, sibling) { >>>PCIDevice *dev = (PCIDevice *)qdev; >>>if (dev->devfn == devfn) { >>

Re: [Qemu-devel] [PATCH] ui/vnc: Fix use of free() instead of g_free()

2011-11-01 Thread Anthony Liguori
On 10/07/2011 02:15 PM, Stefan Weil wrote: Please note that mechlist still uses malloc / strdup / free. Signed-off-by: Stefan Weil Applied. Thanks. Regards, Anthony Liguori --- ui/vnc-auth-sasl.c |8 ui/vnc-enc-hextile.c |4 ++-- ui/vnc-tls.c |2 +- ui/v

Re: [Qemu-devel] [PATCH] configure: Suppress messages from pkg_config probe for check

2011-11-01 Thread Anthony Liguori
On 11/01/2011 01:32 PM, Peter Maydell wrote: Suppress confusing messages from pkg_config when probing for 'check' by sending them to /dev/null as we do with other similar probes. Signed-off-by: Peter Maydell Applied. Thanks. Regards, Anthony Liguori --- We didn't notice this before becaus

Re: [Qemu-devel] [PATCH 01/14] Define DMA address and direction types

2011-11-01 Thread Anthony Liguori
On 10/31/2011 01:06 AM, David Gibson wrote: As a preliminary to adding more extensive DMA and IOMMU infrastructure support into qemu, this patch defines a dma_addr_t for storing DMA bus addresses and a DMADirection enum which describes whether a DMA is from an external device to main memory or fr

Re: [Qemu-devel] [PATCH v4] ps2: migrate ledstate

2011-11-01 Thread Anthony Liguori
On 10/17/2011 06:37 AM, Juan Quintela wrote: From: Christophe Fergeau Make the ps2 device track its ledstate so that we can migrate it. Otherwise it gets lost across migration, and spice-server gets confused about the actual keyboard state and sends bogus caps/scroll/num key events. This fixes R

Re: [Qemu-devel] [PATCH v3] Sort the help info shown in monitor at runtime

2011-11-01 Thread Anthony Liguori
On 10/11/2011 10:32 PM, Wayne Xia wrote: This patch would try sort the command list in monitor at runtime. As a result, command help and help info would show a more friendly sorted command list. For eg: (qemu)help acl_add acl_policy acl_remove acl_reset acl_show balloon block_passwd ... the comma

Re: [Qemu-devel] [PATCH] virtio: Add PCI memory BAR in addition to PIO BAR

2011-11-01 Thread Anthony Liguori
On 09/30/2011 12:26 AM, David Gibson wrote: Currently, virtio devices are usually presented to the guest as an emulated PCI device, virtio_pci. Although the actual IO operations are done through system memory, the configuration of the virtio device is done through the one PCI IO space BAR that v

Re: [Qemu-devel] [PATCH] pcnet: Add link state support

2011-11-01 Thread Anthony Liguori
On 10/07/2011 05:27 AM, Jan Kiszka wrote: Update lnkst on link state changes so that guests can obtain this information via reading back the LED output pin. Works for Linux but not for guests that depend on the missing PHY. Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] checkpatch: remove rule on non-indented labels

2011-11-01 Thread Anthony Liguori
On 10/07/2011 08:59 AM, Paolo Bonzini wrote: There are 508 non-indented (non-default) labels, and 511 that are indented. So the rule is debatable at least. Actually, in the common case of labels at the outermost scope, there is really just one place where to put the label, so the rule is just w

Re: [Qemu-devel] [PATCH v2] Move filedescriptor parsing code from net.c into qemu_parse_fd()

2011-11-01 Thread Anthony Liguori
On 09/28/2011 05:41 AM, Stefan Berger wrote: Move the parsing of a filedescriptor into a common function qemu_parse_fd() so others can use it as well. Have net.c call this function. v2: - moving qemu_parse_fd into cutils.c Signed-off-by: Stefan Berger Applied. Thanks. Regards, Anthony Li

Re: [Qemu-devel] [PATCH 1/2] pcnet: Move BCR defines to header

2011-11-01 Thread Anthony Liguori
On 09/26/2011 12:01 PM, Jan Kiszka wrote: This moves BCR defines to the common header and immediately makes use of them to add BCR_APROMWE, replacing the open-coded write check in pcnet_aprom_writeb. Signed-off-by: Jan Kiszka Applied both. Thanks. Regards, Anthony Liguori --- hw/pcnet-p

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-01 Thread Anthony Liguori
On 09/27/2011 09:26 AM, Avi Kivity wrote: Has no business in hw/. Signed-off-by: Avi Kivity Applied. Thanks. Regards, Anthony Liguori --- hw/event_notifier.c => event_notifier.c |1 - hw/event_notifier.h => event_notifier.h |0 2 files changed, 0 insertions(+), 1 deletions(-

Re: [Qemu-devel] [PATCH 1/2] tcg: Fix regression in tcg_gen_deposit_i64.

2011-11-01 Thread malc
On Tue, 1 Nov 2011, Richard Henderson wrote: > The error being caused by the failure to copy the other half of > the input to the output after having narrowed the deposit operation. Thanks, applied. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.h |2 ++ > 1 files changed, 2 inse

Re: [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30

2011-11-01 Thread Anthony Liguori
On 11/01/2011 05:14 PM, Alexander Graf wrote: >> And specifically: >> >> QLIST_FOREACH(qdev,&phb->host_state.bus->qbus.children, sibling) { >> PCIDevice *dev = (PCIDevice *)qdev; >> if (dev->devfn == devfn) { >> return dev; >> } >>

Re: [Qemu-devel] [PATCH] spapr: fix build

2011-11-01 Thread Alexander Graf
On 01.11.2011, at 14:51, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori If that's what it takes to make it compile for you, please apply it. i'm currently not anywhere close to a box to test it on myself (and figure out what went wrong). Reviewed-by: Alexander Graf Alex > ---

Re: [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30

2011-11-01 Thread Alexander Graf
On 01.11.2011, at 14:41, Anthony Liguori wrote: > On 11/01/2011 04:05 PM, Blue Swirl wrote: >> Thanks, pulled and reverted libfdt patch. > > Er, this broke the build: > > CCppc64-softmmu/spapr_pci.o > /home/anthony/git/qemu/hw/spapr_pci.c: In function ‘find_dev’: > /home/anthony/git/qemu/

[Qemu-devel] [PATCH 1/2] tcg: Fix regression in tcg_gen_deposit_i64.

2011-11-01 Thread Richard Henderson
The error being caused by the failure to copy the other half of the input to the output after having narrowed the deposit operation. Signed-off-by: Richard Henderson --- tcg/tcg-op.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index 24ec7

[Qemu-devel] [PATCH 2/2] tcg: Fix whitespace in tcg-op.h.

2011-11-01 Thread Richard Henderson
Removing the only tabs in the file. Signed-off-by: Richard Henderson --- tcg/tcg-op.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index 8637fe8..82e04e7 100644 --- a/tcg/tcg-op.h +++ b/tcg/tcg-op.h @@ -2042,8 +2042,8 @@ static inlin

[Qemu-devel] [PATCH] spapr: fix build

2011-11-01 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/spapr_pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c index 2a5e637..7162588 100644 --- a/hw/spapr_pci.c +++ b/hw/spapr_pci.c @@ -51,7 +51,7 @@ static PCIDevice *find_dev(sPAPREnvironment *spap

Re: [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30

2011-11-01 Thread Anthony Liguori
On 11/01/2011 04:05 PM, Blue Swirl wrote: Thanks, pulled and reverted libfdt patch. Er, this broke the build: CCppc64-softmmu/spapr_pci.o /home/anthony/git/qemu/hw/spapr_pci.c: In function ‘find_dev’: /home/anthony/git/qemu/hw/spapr_pci.c:54:9: error: ‘struct ChildrenHead’ has no member

[Qemu-devel] [Bug 884942] [NEW] hw/usb.c:336: usb_packet_complete: Assertion `p->owner != ((void *)0)' failed.

2011-11-01 Thread Alon Bar-Lev
Public bug reported: qemu-system-x86_64 -no-quit -drive file=disk1.img -net nic -net tap,ifname=vm0,script=/bin/true,vhost=on -m 512 -monitor tcp:127.0.0.1:4445,server,nowait -localtime -usb -usbdevice host:054C:0268 Last usbmon I got: 88006d6096c0 1064575963 S Ii:3:013:1 -115:1 64 < 8800

[Qemu-devel] [Bug 884942] Re: hw/usb.c:336: usb_packet_complete: Assertion `p->owner != ((void *)0)' failed.

2011-11-01 Thread Alon Bar-Lev
Host: Gentoo linux-3.1.0 app-emulation/qemu-kvm-0.15.1-r1 Guest: Window XP Device: DualShock Clone -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/884942 Title: hw/usb.c:336: usb_packet_complete: A

Re: [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30

2011-11-01 Thread Blue Swirl
Thanks, pulled and reverted libfdt patch. On Sun, Oct 30, 2011 at 20:22, Alexander Graf wrote: > Hi Blue, > > This is my current patch queue for ppc. Please pull. > > Alex > > > The following changes since commit 375847a6c0330e3de0fd1589eeb5a364692b791e: >  Max Filippov (1): >        MAINTAINERS:

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-01 Thread Thomas Schmitt
Hi, Stefan Hajnoczi wrote: > In the future I think it's appropriate to CC qemu-devel since others > in the community may be interested in virtio-scsi discussions too. Ok. I'll forward my original mail and this reply to qemu-devel. > The current state is that CD-ROM passthrough with virtio-scsi

Re: [Qemu-devel] [PATCH 18/22] PPC: Fail configure when libfdt is not available

2011-11-01 Thread Alexander Graf
On 01.11.2011, at 12:28, Blue Swirl wrote: > On Sun, Oct 30, 2011 at 20:23, Alexander Graf wrote: >> We have several targets in the PPC tree now that basically require libfdt >> to function properly, namely the pseries and the e500 targets. This >> dependency >> will rather increase than decre

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-01 Thread Anthony Liguori
On 10/31/2011 11:45 AM, Stefan Weil wrote: Am 31.10.2011 07:06, schrieb David Gibson: From: Eduard - Gabriel Munteanu This updates the eepro100 device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Andreas Färber
Am 01.11.2011 20:45, schrieb Eric Sunshine: > On Nov 1, 2011, at 3:25 PM, Andreas Färber wrote: >> Am 01.11.2011 20:06, schrieb Eric Sunshine: >>> >>> On Nov 1, 2011, at 2:52 PM, Andreas Färber wrote: >>> Am 01.11.2011 19:47, schrieb Eric Sunshine: > On Nov 1, 2011, at 12:37 PM, Andreas Fä

Re: [Qemu-devel] [PATCH 2/2] Drop obsolete nographic timer

2011-11-01 Thread Anthony Liguori
On 11/01/2011 03:15 PM, Blue Swirl wrote: On Tue, Nov 1, 2011 at 20:10, Anthony Liguori wrote: On 10/13/2011 07:05 PM, David Gibson wrote: On Fri, Sep 30, 2011 at 12:31:18PM +0200, Jan Kiszka wrote: We flush coalesced MMIO in the device models now, and VNC - for which this was once introduc

Re: [Qemu-devel] [PATCH 2/2] Drop obsolete nographic timer

2011-11-01 Thread Blue Swirl
On Tue, Nov 1, 2011 at 20:10, Anthony Liguori wrote: > On 10/13/2011 07:05 PM, David Gibson wrote: >> >> On Fri, Sep 30, 2011 at 12:31:18PM +0200, Jan Kiszka wrote: >>> >>> We flush coalesced MMIO in the device models now, and VNC - for which >>> this was once introduced - is also fine without it

[Qemu-devel] [RFC PATCH 00/11] qemu_fclose() error handling fixes

2011-11-01 Thread Eduardo Habkost
Summary of the problem: - qemu_fclose() calls qemu_fflush() - Writes done by qemu_fflush() can fail - Those errors are lost after qemu_fclose() returns So, this series change qemu_fclose() to return last_error. But to do that we need to make sure all involve code use the -errno convention, hence

Re: [Qemu-devel] [PATCH 2/2] Drop obsolete nographic timer

2011-11-01 Thread Anthony Liguori
On 10/13/2011 07:05 PM, David Gibson wrote: On Fri, Sep 30, 2011 at 12:31:18PM +0200, Jan Kiszka wrote: We flush coalesced MMIO in the device models now, and VNC - for which this was once introduced - is also fine without it as it has its own refresh timer. These don't seem to have gone in yet

[Qemu-devel] [RFC PATCH 06/11] stdio_pclose: return -errno on error

2011-11-01 Thread Eduardo Habkost
This is what qemu_fclose() expects. Signed-off-by: Eduardo Habkost --- savevm.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/savevm.c b/savevm.c index 3c746a6..63dd719 100644 --- a/savevm.c +++ b/savevm.c @@ -233,8 +233,9 @@ static int stdio_get_buffer(void *opaqu

[Qemu-devel] [PATCH 2/3] vl.c: Guard against GThread double-initialization

2011-11-01 Thread Andreas Färber
GThread-ERROR **: GThread system may only be initialized once. aborting... Making the g_thread_init() call in vl.c conditional resolves an abort on Mac OS X, where coroutine-gthread.c seems to call it before vl.c. Reported-by: Juan Pineda Signed-off-by: Andreas Färber Cc: Daniel P. Berrange --

[Qemu-devel] [PATCH 3/3] cocoa: Close sheet after image file selection

2011-11-01 Thread Andreas Färber
If no disk image is specified, the Cocoa frontend displays a modal sheet to let the user select an image file to boot from. This sheet is never closed and it permanently obscures the emulator window. Close it after obtaining the file name in case the user did select a file. Otherwise we exit imme

[Qemu-devel] [PATCH v2] monitor: add ability to dump SLB entries

2011-11-01 Thread Nishanth Aravamudan
On 31.10.2011 [15:14:12 +1100], David Gibson wrote: > Good points below. I forgot to CC Nish, the original patch author on > my post, so I've added him to the list now. > > Nish, can you correct these problems and resend the patch please? When run with a PPC Book3S (server) CPU Currently 'info t

[Qemu-devel] [PATCH 1/3] MAINTAINERS: Add Cocoa maintainer

2011-11-01 Thread Andreas Färber
Degrade cocoa.m from Maintained to Odd Fixes. Signed-off-by: Andreas Färber Cc: Anthony Liguori --- MAINTAINERS |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index bccdd4f..7ee301e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -451,6 +451

[Qemu-devel] [PULL 0/3] Cocoa fixes for 1.0

2011-11-01 Thread Andreas Färber
Hello Anthony, Please pull these Cocoa-related patches for 1.0. For our long-standing uint16 compilation issue we are still in need of a fully correct solution. Depending on what we come up with, we'll try to squeeze it in between RCs or defer it to next. Regards, Andreas The following changes

[Qemu-devel] [RFC PATCH 11/11] unix_close(): check for close() errors too

2011-11-01 Thread Eduardo Habkost
In case close() fails, we want to report the error back. Signed-off-by: Eduardo Habkost --- migration-unix.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/migration-unix.c b/migration-unix.c index 8596353..197285c 100644 --- a/migration-unix.c +++ b/migration-unix

[Qemu-devel] [RFC PATCH 05/11] qemu_fclose: return last_error if set

2011-11-01 Thread Eduardo Habkost
This will make sure no error will be missed as long as callers always check for qemu_fclose() return value. For reference, this is the complete list of qemu_fclose() callers: - exec_close(): already fixed to check for negative values, not -1 - migrate_fd_cleanup(): already fixed to consider only

Re: [Qemu-devel] [PATCH] Raise 9pfs mount_tag limit from 32 to 255 bytes

2011-11-01 Thread Anthony Liguori
On 11/01/2011 01:48 PM, Daniel P. Berrange wrote: On Tue, Nov 01, 2011 at 01:27:56PM -0500, Anthony Liguori wrote: On 10/20/2011 10:13 AM, Daniel P. Berrange wrote: On Fri, Oct 07, 2011 at 04:49:13PM +0530, Aneesh Kumar K.V wrote: On Fri, 7 Oct 2011 10:27:56 +0100, "Daniel P. Berrange" wrot

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Eric Sunshine
On Nov 1, 2011, at 3:25 PM, Andreas Färber wrote: Am 01.11.2011 20:06, schrieb Eric Sunshine: On Nov 1, 2011, at 2:52 PM, Andreas Färber wrote: Am 01.11.2011 19:47, schrieb Eric Sunshine: On Nov 1, 2011, at 12:37 PM, Andreas Färber wrote: Am 01.11.2011 09:09, schrieb Eric Sunshine: Perhaps

[Qemu-devel] [RFC PATCH 02/11] QEMUFileCloseFunc: add return value documentation

2011-11-01 Thread Eduardo Habkost
qemu_fclose() and QEMUFile->close will return -errno on error, and any positive value on success. We need the positive non-zero success values because migration-exec.c:exec_close() relies on non-zero return values to get the process exit code. Signed-off-by: Eduardo Habkost --- hw/hw.h |8 +

[Qemu-devel] [RFC PATCH 03/11] exec_close(): accept any negative value as qemu_fclose() error

2011-11-01 Thread Eduardo Habkost
Note that we don't return the unchanged return value back yet, because we need to change all qemu_fclose() callers to accept any positive value as success. Signed-off-by: Eduardo Habkost --- migration-exec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/migration-exec

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Peter Maydell
On 1 November 2011 19:25, Andreas Färber wrote: > Feel free to refactor fpu/* instead to not use uint16 in the first > place. I did so once and it was rejected, so I'm not too inclined to do > that again unless we decide on how exactly to proceed with that! I think we could probably resolve that

[Qemu-devel] [RFC PATCH 10/11] tcp_close(): check for close() errors too

2011-11-01 Thread Eduardo Habkost
In case close() fails, we want to report the error back. Signed-off-by: Eduardo Habkost --- migration-tcp.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index 5aa742c..fd5fd56 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Andreas Färber
Am 01.11.2011 20:25, schrieb Eric Sunshine: > I forgot to mention that with your patch, only cocoa.m is seeing > Darwin's definition of uint16. The rest of qemu is seeing the definition > from softfloat.h. This inconsistency hopefully is not harmful in the > short-term, which is why I asked about t

Re: [Qemu-devel] [PULL] tcg/interpreter: Add TCG + interpreter for bytecode

2011-11-01 Thread Blue Swirl
On Mon, Oct 31, 2011 at 22:06, Anthony Liguori wrote: > On 10/31/2011 05:02 PM, Stefan Weil wrote: >> >> Am 31.10.2011 22:38, schrieb Anthony Liguori: >>> >>> I'll defer to Blue and/or Aurelien here as I don't know enough about TCG >>> to >>> really review this series. >>> >>> But I'd recommend wa

Re: [Qemu-devel] [PATCH 18/22] PPC: Fail configure when libfdt is not available

2011-11-01 Thread Blue Swirl
On Sun, Oct 30, 2011 at 20:23, Alexander Graf wrote: > We have several targets in the PPC tree now that basically require libfdt > to function properly, namely the pseries and the e500 targets. This dependency > will rather increase than decrease in the future, so I want to make sure > that people

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Andreas Färber
Am 01.11.2011 20:06, schrieb Eric Sunshine: > > On Nov 1, 2011, at 2:52 PM, Andreas Färber wrote: > >> Am 01.11.2011 19:47, schrieb Eric Sunshine: >>> On Nov 1, 2011, at 12:37 PM, Andreas Färber wrote: Am 01.11.2011 09:09, schrieb Eric Sunshine: > Perhaps the following alternative soluti

Re: [Qemu-devel] [PATCH] tcg: Optimize some forms of deposit.

2011-11-01 Thread Blue Swirl
On Mon, Oct 31, 2011 at 03:47, Alexander Graf wrote: > > On 27.10.2011, at 23:15, Richard Henderson wrote: > >> If the deposit replaces the entire word, optimize to a move. >> >> If we're inserting to the top of the word, avoid the mask of arg2 >> as we'll be shifting out all of the garbage and sh

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Eric Sunshine
On Nov 1, 2011, at 3:06 PM, Eric Sunshine wrote: On Nov 1, 2011, at 2:52 PM, Andreas Färber wrote: Am 01.11.2011 19:47, schrieb Eric Sunshine: On Nov 1, 2011, at 12:37 PM, Andreas Färber wrote: Am 01.11.2011 09:09, schrieb Eric Sunshine: Perhaps the following alternative solution would be mor

[Qemu-devel] [RFC PATCH 08/11] exec_close(): return -errno on errors

2011-11-01 Thread Eduardo Habkost
All qemu_fclose() callers were already changed to accept any negative value as error, so we now can change it to return -errno. When the process exits with a non-zero exit code, we return -EIO to as a fake errno value. Signed-off-by: Eduardo Habkost --- migration-exec.c |9 +++-- 1 file

[Qemu-devel] [RFC PATCH 01/11] savevm: use qemu_file_set_error() instead of setting last_error directly

2011-11-01 Thread Eduardo Habkost
Some code uses qemu_file_set_error() already, so use it everywhere when setting last_error, for consistency. Signed-off-by: Eduardo Habkost --- savevm.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/savevm.c b/savevm.c index f01838f..dc3311b 100644 --- a/savevm.c ++

[Qemu-devel] [RFC PATCH 07/11] stdio_fclose: return -errno on errors

2011-11-01 Thread Eduardo Habkost
This is what qemu_fclose() expects. Signed-off-by: Eduardo Habkost --- savevm.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/savevm.c b/savevm.c index 63dd719..7fbc4ca 100644 --- a/savevm.c +++ b/savevm.c @@ -243,9 +243,11 @@ static int stdio_pclose(void *opaque)

[Qemu-devel] [RFC PATCH 09/11] fd_close(): check for close() errors too

2011-11-01 Thread Eduardo Habkost
In case close() fails, we want to report the error back. Signed-off-by: Eduardo Habkost --- migration-fd.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/migration-fd.c b/migration-fd.c index d0aec89..4d86d43 100644 --- a/migration-fd.c +++ b/migration-fd.c @@ -42,

[Qemu-devel] [RFC PATCH 04/11] migrate_fd_cleanup: accept any negative qemu_fclose() value as error

2011-11-01 Thread Eduardo Habkost
Also, we now return the qemu_fclose() value unchanged to the caller. For reference, the migrate_fd_cleanup() callers are the following: - migrate_fd_completed(): any negative value is considered an error, so the change is OK. - migrate_fd_error(): doesn't check the migrate_fd_cleanup() return va

Re: [Qemu-devel] [PATCH v3 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Andreas Färber
Am 01.11.2011 19:55, schrieb Eric Sunshine: > On Nov 1, 2011, at 2:05 PM, Andreas Färber wrote: >> Am 01.11.2011 19:01, schrieb Peter Maydell: >>> On 1 November 2011 17:59, Andreas Färber wrote: Apple's FSEvents.h has #include , which wants /usr/include/Block.h but due to case-insensitiv

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Eric Sunshine
On Nov 1, 2011, at 2:52 PM, Andreas Färber wrote: Am 01.11.2011 19:47, schrieb Eric Sunshine: On Nov 1, 2011, at 12:37 PM, Andreas Färber wrote: Am 01.11.2011 09:09, schrieb Eric Sunshine: Perhaps the following alternative solution would be more palatable? It's still tremendously ugly, but

Re: [Qemu-devel] [PATCH v3 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Eric Sunshine
On Nov 1, 2011, at 2:05 PM, Andreas Färber wrote: Am 01.11.2011 19:01, schrieb Peter Maydell: On 1 November 2011 17:59, Andreas Färber wrote: Apple's FSEvents.h has #include , which wants /usr/include/Block.h but due to case-insensitive file system and include path jungle gets QEMU's ./block.

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Andreas Färber
Am 01.11.2011 19:47, schrieb Eric Sunshine: > On Nov 1, 2011, at 12:37 PM, Andreas Färber wrote: >> Am 01.11.2011 09:09, schrieb Eric Sunshine: >>> Perhaps the following alternative solution would be more palatable? It's >>> still tremendously ugly, but is localized to cocoa.m, thus less >>> intrus

Re: [Qemu-devel] [PATCH] Raise 9pfs mount_tag limit from 32 to 255 bytes

2011-11-01 Thread Daniel P. Berrange
On Tue, Nov 01, 2011 at 01:27:56PM -0500, Anthony Liguori wrote: > On 10/20/2011 10:13 AM, Daniel P. Berrange wrote: > >On Fri, Oct 07, 2011 at 04:49:13PM +0530, Aneesh Kumar K.V wrote: > >>On Fri, 7 Oct 2011 10:27:56 +0100, "Daniel P. > >>Berrange" wrote: > >>>On Thu, Sep 29, 2011 at 04:22:16PM

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Eric Sunshine
On Nov 1, 2011, at 12:37 PM, Andreas Färber wrote: Am 01.11.2011 09:09, schrieb Eric Sunshine: Perhaps the following alternative solution would be more palatable? It's still tremendously ugly, but is localized to cocoa.m, thus less intrusive. -- >8 -- Subject: [PATCH] softfloat: Avoid uint1

Re: [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X

2011-11-01 Thread Andreas Färber
Am 01.11.2011 10:39, schrieb Eric Sunshine: > qemu-barrier.h tests if macro __powerpc__ is defined, however, the > preprocessor on PowerPC Mac OS X defines only __POWERPC__, not > __powerpc__. > Resolve by testing instead for qemu-provided _ARCH_PPC. This part is actually wrong: _ARCH_PPC is comp

[Qemu-devel] [PATCH] configure: Suppress messages from pkg_config probe for check

2011-11-01 Thread Peter Maydell
Suppress confusing messages from pkg_config when probing for 'check' by sending them to /dev/null as we do with other similar probes. Signed-off-by: Peter Maydell --- We didn't notice this before because we only recently changed the default for whether configure probed for this. I think that make

Re: [Qemu-devel] [PATCH] Raise 9pfs mount_tag limit from 32 to 255 bytes

2011-11-01 Thread Anthony Liguori
On 10/20/2011 10:13 AM, Daniel P. Berrange wrote: On Fri, Oct 07, 2011 at 04:49:13PM +0530, Aneesh Kumar K.V wrote: On Fri, 7 Oct 2011 10:27:56 +0100, "Daniel P. Berrange" wrote: On Thu, Sep 29, 2011 at 04:22:16PM +0100, Daniel P. Berrange wrote: On Thu, Sep 29, 2011 at 08:23:49PM +0530, Ane

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2011-11-01 Thread Anthony Liguori
On 11/01/2011 09:19 AM, Stefan Hajnoczi wrote: The last tracing tree patch for QEMU 1.0! The following changes since commit ff74c5a9a91c6dbf1017195462aa4176f7381240: Merge remote-tracking branch 'riku/linux-user-for-upstream' into staging (2011-10-31 15:05:40 -0500) are available in the gi

Re: [Qemu-devel] [PULL] usb patch queue

2011-11-01 Thread Anthony Liguori
On 11/01/2011 09:56 AM, Gerd Hoffmann wrote: Hi, Three little usb patches for 1.0. please pull, Gerd The following changes since commit ff74c5a9a91c6dbf1017195462aa4176f7381240: Merge remote-tracking branch 'riku/linux-user-for-upstream' into staging (2011-10-31 15:05:40 -0500) Pu

Re: [Qemu-devel] [PATCH v3 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-11-01 Thread Andreas Färber
Am 01.11.2011 18:59, schrieb Andreas Färber: > On Mac OS X we get: > > In file included from ./bswap.h:7, > from ./qemu-common.h:106, > from ./qemu-aio.h:17, > from ./Block.h:4, > from > /System/Library/Frameworks/CoreServices.fr

Re: [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X

2011-11-01 Thread Anthony Liguori
On 11/01/2011 04:39 AM, Eric Sunshine wrote: qemu-barrier.h tests if macro __powerpc__ is defined, however, the preprocessor on PowerPC Mac OS X defines only __POWERPC__, not __powerpc__. Resolve by testing instead for qemu-provided _ARCH_PPC. Signed-off-by: Eric Sunshine Applied. Thanks. R

  1   2   3   >