On 11/01/2011 05:28 PM, Alexander Graf wrote:

On 01.11.2011, at 15:16, Anthony Liguori<anth...@codemonkey.ws>  wrote:

On 11/01/2011 05:14 PM, Alexander Graf wrote:
And specifically:

        QLIST_FOREACH(qdev,&phb->host_state.bus->qbus.children, sibling) {
            PCIDevice *dev = (PCIDevice *)qdev;
            if (dev->devfn == devfn) {
                return dev;
            }
        }

QBus::children is a QTAILQ, not a QLIST.

Was this code tested at all?

Uh, yeah. Compile and execution tested O_o.

Do you not have libfdt installed?

I have libfdt installed on all boxes. I also verified that I could see a PCI 
device in the guest, so the code worked.

Maybe the list type was changed between the pullreq and now?

Yes.  The patch that did it was old but only recently got into the tree.

Regards,

Anthony Liguori


Alex


Regards,

Anthony Liguori


Alex






Reply via email to