Am 20.05.2011 um 23:40 schrieb Andreas Färber :
> Am 20.05.2011 um 22:24 schrieb Alexander Graf:
>
>> Am 20.05.2011 um 21:10 schrieb Andreas Färber :
>>
>>> Next breakage... :(
>>>
>>> Am 10.05.2011 um 00:15 schrieb Alexander Graf:
>>>
Most of the code to support e500 style MMUs is alrea
Am 21.05.2011 um 00:37 schrieb Andreas Färber :
> Am 20.05.2011 um 09:40 schrieb Alexander Graf:
>
>> On 20.05.2011, at 05:34, David Gibson wrote:
>>
>>> Early ppc64 CPUs include a hack to partially simulate the ppc32 segment
>>> registers, by translating writes to them into writes to the SLB.
On Friday 20 May 2011 23:59:25 Amirali Shambayati wrote:
> Mouse doesn't work on guest ubuntu.
You need to debug it, as if it was real hardware.
> But none of them worked for me. any help is appreciated.
This isn't a very in-depth problem description. Remember that we can't see
your screen.
Does
Am 20.05.2011 um 21:37 schrieb Aurelien Jarno:
On Fri, May 20, 2011 at 10:50:49AM -0700, Richard Henderson wrote:
On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
This series implements some basic machine-independent
optimizations. They
simplify code and allow liveness analysis do it's work be
Hello qemu-devel
Would you like to earn an extra $200 everyday?, for just 45 minutes work? You
could quit your job and make double the money at home working for yourself.
visit->http:tinyurl.com/42e38u9
Regards,
Carmille Burns
Survey Human Resources Dept.
Am 20.05.2011 um 09:40 schrieb Alexander Graf:
On 20.05.2011, at 05:34, David Gibson wrote:
Early ppc64 CPUs include a hack to partially simulate the ppc32
segment
registers, by translating writes to them into writes to the SLB.
This is
not used by any current Linux kernel, but it is used
On 05/20/2011 02:30 PM, Max Filippov wrote:
> - cycles fed into advance_ccount may (and on real hardware actually
> do) depend on executed commands/pipeline/cache hits. Most of this
> stuff may be counted at the translation time;
Since CCOUNT, as seen by any one thread of execution, on real hw dep
On 05/20/2011 05:59 AM, Stefan Hajnoczi wrote:
To run automated tests for coroutines:
make check-coroutine
./check-coroutine
On success the program terminates with exit status 0. On failure an
error message is written to stderr and the program exits with exit
status 1.
Signed-off-by: St
Am 20.05.2011 um 22:24 schrieb Alexander Graf:
Am 20.05.2011 um 21:10 schrieb Andreas Färber
:
Next breakage... :(
Am 10.05.2011 um 00:15 schrieb Alexander Graf:
Most of the code to support e500 style MMUs is already in place, but
we're missing on some of the special TLB0-TLB1 handling co
> > By the way, do I understand it right that if I chain TBs than I need
> > to periodically check for pending interrupts myself, otherwise e.g.
> > "j $" will create uninterruptible infinite loop?
>
> No, it won't. It'll create a loop, but it'll be broken by the host
> signal handler. Notice no
On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote:
> Your patch won't accept negative numbers, correct?
'strtoull' works OK with negative numbers.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual
Am 15.05.2011 um 12:36 schrieb Aurelien Jarno:
On Sun, May 15, 2011 at 11:38:04AM +0200, Stefan Weil wrote:
ulong is undefined for w32 (and maybe other) compilations.
Darwin
Replace it by uintptr_t (which also fixes compilation for w64
and is a better choice for pointer to integer conversio
On 05/20/2011 01:05 PM, Max Filippov wrote:
> By the way, do I understand it right that if I chain TBs than I need
> to periodically check for pending interrupts myself, otherwise e.g.
> "j $" will create uninterruptible infinite loop?
No, it won't. It'll create a loop, but it'll be broken by the
When QEMU was configured with --enable-debug-tcg,
compilation fails in spr_write_booke206_mmucsr0() and in
spr_write_booke_pid(). Similar changes are also needed
in conditional code which is normally unused.
Cc: Alexander Graf
Signed-off-by: Stefan Weil
---
target-ppc/translate_init.c | 12 ++
Am 20.05.2011 um 21:10 schrieb Andreas Färber :
> Hey Alex,
>
> Next breakage... :(
>
> Am 10.05.2011 um 00:15 schrieb Alexander Graf:
>
>> Most of the code to support e500 style MMUs is already in place, but
>> we're missing on some of the special TLB0-TLB1 handling code and slightly
>> diffe
ulong is undefined on Darwin. Use uintptr_t instead.
Cc: Alexander Graf
Signed-off-by: Andreas Färber
---
target-ppc/cpu.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
index 7a6a7df..8e4582f 100644
--- a/target-ppc/cpu.h
+++ b/t
> > +if (xtensa_option_enabled(env->config, XTENSA_OPTION_TIMER_INTERRUPT))
> > {
> > +int i;
> > +for (i = 0; i < env->config->nccompare; ++i) {
> > +if (env->sregs[CCOMPARE + i] - old_ccount <= d) {
> > +env->halted = 0;
> > +xtensa
On Fri, May 20, 2011 at 10:45 PM, Paolo Bonzini wrote:
> On 05/20/2011 09:38 PM, Blue Swirl wrote:
>>
>> On Thu, May 19, 2011 at 4:47 PM, Paolo Bonzini
>> wrote:
>> > Most definitions in softfloat.h are really target-independent. Split
>> > the few that stand out as target-dependent, to allow
On Fri, May 20, 2011 at 10:42 PM, Anthony Liguori wrote:
> On 05/20/2011 02:25 PM, Blue Swirl wrote:
>>
>> On Fri, May 20, 2011 at 9:48 PM, Corey Bryant wrote:
>>>
>>> sVirt provides SELinux MAC isolation for Qemu guest processes and their
>>> corresponding resources (image files). sVirt provides
On 05/20/2011 09:38 PM, Blue Swirl wrote:
On Thu, May 19, 2011 at 4:47 PM, Paolo Bonzini wrote:
> Most definitions in softfloat.h are really target-independent. Split
> the few that stand out as target-dependent, to allow including
> softfloat.h from files that are not compiled per-target.
On 05/20/2011 02:25 PM, Blue Swirl wrote:
On Fri, May 20, 2011 at 9:48 PM, Corey Bryant wrote:
sVirt provides SELinux MAC isolation for Qemu guest processes and their
corresponding resources (image files). sVirt provides this support
by labeling guests and resources with security labels that ar
On Fri, May 20, 2011 at 04:39:29PM +0400, Kirill Batuzov wrote:
> Make tcg_constant_folding do copy and constant propagation. It is a
> preparational work before actual constant folding.
>
> Signed-off-by: Kirill Batuzov
> ---
> tcg/optimize.c | 123
> ++
On Thu, May 19, 2011 at 4:47 PM, Paolo Bonzini wrote:
> Most definitions in softfloat.h are really target-independent. Split
> the few that stand out as target-dependent, to allow including
> softfloat.h from files that are not compiled per-target.
Maybe the next step should be (or in place of t
On Fri, May 20, 2011 at 10:50:49AM -0700, Richard Henderson wrote:
> On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
> > This series implements some basic machine-independent optimizations. They
> > simplify code and allow liveness analysis do it's work better.
> >
> > Suppose we have following ARM
On Fri, May 20, 2011 at 04:39:27PM +0400, Kirill Batuzov wrote:
> This series implements some basic machine-independent optimizations. They
> simplify code and allow liveness analysis do it's work better.
>
> Suppose we have following ARM code:
>
> movwr12, #0xb6db
> movtr12, #0xdb6d
>
On Fri, May 20, 2011 at 9:48 PM, Corey Bryant wrote:
> sVirt provides SELinux MAC isolation for Qemu guest processes and their
> corresponding resources (image files). sVirt provides this support
> by labeling guests and resources with security labels that are stored
> in file system extended attr
Hey Alex,
Next breakage... :(
Am 10.05.2011 um 00:15 schrieb Alexander Graf:
Most of the code to support e500 style MMUs is already in place, but
we're missing on some of the special TLB0-TLB1 handling code and
slightly
different TLB modification.
This patch adds support for the FSL style
Hello qemu-devel
Would you like to earn an extra $200 everyday?, for just 45 minutes work? You
could quit your job and make double the money at home working for yourself.
visit->http:tinyurl.com/42e38u9
Regards,
Carmille Burns
Survey Human Resources Dept.
On 05/20/2011 01:48 PM, Corey Bryant wrote:
sVirt provides SELinux MAC isolation for Qemu guest processes and their
corresponding resources (image files). sVirt provides this support
by labeling guests and resources with security labels that are stored
in file system extended attributes. Some fil
> > +static void gen_window_check1(DisasContext *dc, unsigned r1)
> > +{
> > +if (option_enabled(dc, XTENSA_OPTION_WINDOWED_REGISTER) &&
> > +r1 / 4 > dc->used_window) {
> > +TCGv_i32 pc = tcg_const_i32(dc->pc);
> > +TCGv_i32 w = tcg_const_i32(r1 / 4);
> > +
> > +
sVirt provides SELinux MAC isolation for Qemu guest processes and their
corresponding resources (image files). sVirt provides this support
by labeling guests and resources with security labels that are stored
in file system extended attributes. Some file systems, such as NFS, do
not support the ext
On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote:
> JSON only supports int64_t.
By the way, where does this information come from?
The JSON RFC fails to define the range of numbers at all, just leaving
it completely up to the application, and if JSON is based on
Javascript then it
On 05/20/2011 08:22 PM, Richard Henderson wrote:
I think it might be clearer to have these two in a structure, rather
than two separate arrays. That does waste a bit of memory in padding
for 64-bit target, but I think it might clean up the code a bit.
You can use the padding to implement a gen
On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
> +case INDEX_op_or_i32:
> +case INDEX_op_and_i32:
> +#if TCG_TARGET_REG_BITS == 64
> +case INDEX_op_and_i64:
> +case INDEX_op_or_i64:
> +#endif
> +if (args[1] == args[2]) {
> +if (args[1] == a
On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
> +case INDEX_op_ext8s_i64:
> +return x & (1 << 7) ? x | ~0xffULL : x & 0xff;
> +
> +case INDEX_op_ext16s_i64:
> +return x & (1 << 15) ? x | ~0xULL : x & 0x;
> +
> +case INDEX_op_ext32s_i64:
> +return x & (1U
On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
> +case INDEX_op_sar_i32:
> +#if TCG_TARGET_REG_BITS == 64
> +x &= 0x;
> +y &= 0x;
> +#endif
> +r = x & 0x8000;
> +x &= ~0x8000;
> +x >>= y;
> +r |= r - (r >> y);
> +x |
I should add that not error checking and silently truncating numbers
in qemu is still a bug.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to
On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote:
> On 05/20/2011 01:03 PM, Richard W.M. Jones wrote:
> >
> >There seem to be a few unsafe uses of strto* functions. This patch
> >just fixes the one that affects me :-)
>
> Sending an integer of this size is not valid JSON.
>
> Your
On 05/20/2011 11:12 AM, Richard Henderson wrote:
> On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
>> +i = (op == INDEX_op_call) ?
>> +(args[0] >> 16) + (args[0] & 0x) + 3 :
>> +def->nb_args;
>> +while (i) {
>> +*gen_args = *
On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
> +static tcg_target_ulong vals[TCG_MAX_TEMPS];
> +static tcg_temp_state state[TCG_MAX_TEMPS];
Any particular reason to make these static? It's 4-6k on the host
stack depending on sizeof tcg_target_ulong. Large, but not excessive.
I think it'
On Fri, May 20, 2011 at 5:46 PM, Anthony Liguori wrote:
> On 05/20/2011 09:40 AM, Richard Henderson wrote:
>>
>> On 05/20/2011 07:31 AM, Anthony Liguori wrote:
>>>
>>> But is this a characteristic of devices or is this a characteristic of
>>> the chipset/CPU?
>>
>> Chipset.
>
> So if the chipset o
On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
> +i = (op == INDEX_op_call) ?
> +(args[0] >> 16) + (args[0] & 0x) + 3 :
> +def->nb_args;
> +while (i) {
> +*gen_args = *args;
> +args++;
> +gen_
On 05/20/2011 01:03 PM, Richard W.M. Jones wrote:
There seem to be a few unsafe uses of strto* functions. This patch
just fixes the one that affects me :-)
Sending an integer of this size is not valid JSON.
Your patch won't accept negative numbers, correct?
JSON only supports int64_t.
Rega
There seem to be a few unsafe uses of strto* functions. This patch
just fixes the one that affects me :-)
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PX
On 05/20/2011 07:48 PM, Paolo Bonzini wrote:
Is there any reason to keep a free function?
It's internal for SCSIDevice implementation, kind of a "base
implementation" for free_req
The pattern should be
that people just call the function to decrement the reference count,
and that frees the str
Hello qemu-devel
Would you like to earn an extra $200 everyday?, for just 45 minutes work? You
could quit your job and make double the money at home working for yourself.
visit->http:tinyurl.com/42e38u9
Regards,
Carmille Burns
Survey Human Resources Dept.
On Thu, May 19, 2011 at 5:12 PM, Avi Kivity wrote:
> The memory API separates the attributes of a memory region (its size, how
> reads or writes are handled, dirty logging, and coalescing) from where it
> is mapped and whether it is enabled. This allows a device to configure
> a memory region onc
On 05/20/2011 06:05 PM, Christoph Hellwig wrote:
Looks good, but the scsi_req_kick name doesn't sound to useful.
Either way some documentation on what it does would be useful.
Will change to scsi_req_continue.
On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
> This series implements some basic machine-independent optimizations. They
> simplify code and allow liveness analysis do it's work better.
>
> Suppose we have following ARM code:
>
> movwr12, #0xb6db
> movtr12, #0xdb6d
>
> In TCG before
On 05/20/2011 05:58 PM, Christoph Hellwig wrote:
>void scsi_req_free(SCSIRequest *req)
>{
> -scsi_req_dequeue(req);
> +assert(req->refcount == 0);
>qemu_free(req);
>}
Is there any reason to keep a free function?
It's internal for SCSIDevice implementation, kind of
On 05/20/2011 05:53 PM, Christoph Hellwig wrote:
qbus_create_inplace(&bus->qbus,&scsi_bus_info, host, NULL);
>bus->busnr = next_scsi_bus++;
>bus->tcq = tcq;
>bus->ndev = ndev;
> -bus->complete = complete;
> +bus->ops = *ops;
Normally bus->ops would be a p
On 05/20/2011 06:11 PM, Christoph Hellwig wrote:
+static void esp_command_complete(SCSIRequest *req, uint32_t arg)
Shouldn't the "arg" argument to the new ->command_complete be renamed
to something like "sense" or "status"?
+static void esp_transfer_data(SCSIRequest *req, uint32_t arg)
+{
+
On 05/20/2011 06:04 PM, Christoph Hellwig wrote:
-void scsi_req_enqueue(SCSIRequest *req)
+int32_t scsi_req_enqueue(SCSIRequest *req, uint8_t *buf)
{
+int32_t rc;
assert(!req->enqueued);
scsi_req_ref(req);
req->enqueued = true;
QTAILQ_INSERT_TAIL(&req->dev->requests,
On 05/20/2011 06:14 PM, Christoph Hellwig wrote:
I don't quite understand what you mean with path here. It doesn't
seem to map to any SAM concept, nor does it seem to be related
to traditional multipathing.
It's what SAM calls a "bus identifier" in the description of LUN
addressing modes.
On 05/20/2011 11:43 AM, Olivier Galibert wrote:
On Fri, May 20, 2011 at 09:51:41AM -0500, Anthony Liguori wrote:
Is there a use-case for a priority above 1 and if so, what does it mean?
In a modern northbridge mmconfig has priority over external access,
and other internal registers (apic for i
On Thu, May 19, 2011 at 11:30 AM, Jan Kiszka wrote:
> On 2011-05-19 10:26, Gleb Natapov wrote:
>> On Wed, May 18, 2011 at 09:27:55PM +0200, Jan Kiszka wrote:
if an I/O is to the APIC page,
it's handled by the APIC
>>>
>>> That's not that simple. We need to tell apart:
>>> - if a cpu
On Fri, May 20, 2011 at 00:29, Alexey Zaytsev wrote:
> On Tue, May 17, 2011 at 17:46, Alexander Graf wrote:
>>
>> On 15.05.2011, at 18:41, Alexey Zaytsev wrote:
>>
>>> Hi again.
>>>
>>> After reverting 667bb59, ahci works fine in Linux, if I boot it with
>>> -kernel, but grub seems to have some p
cpu_ioreq_move might move 8 bytes at a time so we must make sure that
the temporary variable can hold 8 bytes.
Signed-off-by: Stefano Stabellini
---
xen-all.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/xen-all.c b/xen-all.c
index 0eac202..6cb504c 100644
--- a/xen-a
Drop the open-coded MAC assignment from net_init_nic and replace it with
standard qemu_macaddr_default_if_unset which is also used by qdev. That
avoid creating colliding MACs when instantiating NICs via different
mechanisms.
This change requires to store the MAC as MACAddr in NICInfo, and the
rema
On Fri, May 20, 2011 at 09:51:41AM -0500, Anthony Liguori wrote:
> Is there a use-case for a priority above 1 and if so, what does it mean?
In a modern northbridge mmconfig has priority over external access,
and other internal registers (apic for instance) have priority over
mmconfig. Bios someti
Include the client type name into the output of 'info network'. The
result looks like this:
(qemu) info network
VLAN 0 devices:
rtl8139.0: type=nic,model=rtl8139,macaddr=52:54:00:12:34:57
Devices not on any VLAN:
virtio-net-pci.0: type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:56
\ ne
On 2011-05-20 18:12, Peter Maydell wrote:
> On 20 May 2011 17:07, Jan Kiszka wrote:
>> On 2011-05-20 18:04, Peter Maydell wrote:
>>> I think that avoiding MAC address clashes should be done by
>>> having net_init_nic() call qemu_macaddr_default_if_unset()
>>
>> You mean qemu_new_nic? Otherwise it
Looks good,
Reviewed-by: Christoph Hellwig
On Fri, May 20, 2011 at 05:03:31PM +0200, Paolo Bonzini wrote:
> This is the second part of my SCSI work. The first is still pending
> and this one is incomplete, but I still would like to get opinions
> early enough because this design directly affects the UI.
>
> This series is half of the work
On 20 May 2011 17:07, Jan Kiszka wrote:
> On 2011-05-20 18:04, Peter Maydell wrote:
>> I think that avoiding MAC address clashes should be done by
>> having net_init_nic() call qemu_macaddr_default_if_unset()
>
> You mean qemu_new_nic? Otherwise it wouldn't help. Will have a look to
> move that ov
On 2011-05-20 18:02, Jan Kiszka wrote:
> On 2011-05-18 10:09, Markus Armbruster wrote:
>> Jan Kiszka writes:
>>
>>> Include the client type name into the output of 'info network'. The
>>> result looks like this:
>>>
>>> (qemu) info network
>>> VLAN 0 devices:
>>> rtl8139.0 (NIC): model=rtl8139,m
> +static void esp_command_complete(SCSIRequest *req, uint32_t arg)
Shouldn't the "arg" argument to the new ->command_complete be renamed
to something like "sense" or "status"?
> +static void esp_transfer_data(SCSIRequest *req, uint32_t arg)
> +{
> +ESPState *s = DO_UPCAST(ESPState, busdev.qd
Looks good,
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
On 2011-05-20 18:04, Peter Maydell wrote:
> On 20 May 2011 16:55, Jan Kiszka wrote:
>> On 2011-05-20 17:49, Peter Maydell wrote:
>>> This patchset reverts commit f68b9d672, which was triggering
>>> spuriously for NICs created via -device rather than -net nic.
>>> It then reimplements the improved
> -typedef struct SCSIDiskReq {
> + typedef struct SCSIDiskReq {
Random whiyespace change.
Otherwise looks good,
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
Looks good, but the scsi_req_kick name doesn't sound to useful.
Either way some documentation on what it does would be useful.
> -void scsi_req_enqueue(SCSIRequest *req)
> +int32_t scsi_req_enqueue(SCSIRequest *req, uint8_t *buf)
> {
> +int32_t rc;
> assert(!req->enqueued);
> scsi_req_ref(req);
> req->enqueued = true;
> QTAILQ_INSERT_TAIL(&req->dev->requests, req, next);
> +
> +/* Make sure the
Looksgood,
Reviewed-by: Christoph Hellwig
On Wed, May 18, 2011 at 4:17 PM, Julien Grall wrote:
> On Tue, May 17, 2011 at 9:57 PM, Blue Swirl wrote:
>> On Tue, May 17, 2011 at 6:32 PM, Julien Grall wrote:
>>> Fix TA0_SHUTDOWN feature
>>
>> But what would be the bug?
>
> We try to add RTEMS's support on leon platform for QEMU. RTEMS uses
On 20 May 2011 16:55, Jan Kiszka wrote:
> On 2011-05-20 17:49, Peter Maydell wrote:
>> This patchset reverts commit f68b9d672, which was triggering
>> spuriously for NICs created via -device rather than -net nic.
>> It then reimplements the improved diagnostics with a different
>> approach which o
Looks good,
Reviewed-by: Christoph Hellwig
Hi,
This is my current PPC patch queue containing all the collected PPC work for
Qemu so far. Please pull.
Alex
The following changes since commit 1fddfba129f5435c80eda14e8bc23fdb888c7187:
Alexander Graf (1):
ahci: Fix non-NCQ accesses for LBA > 16bits
are available in the git reposit
Hello qemu-devel
Would you like to earn an extra $200 everyday?, for just 45 minutes work? You
could quit your job and make double the money at home working for yourself.
visit->http:tinyurl.com/42e38u9
Regards,
Carmille Burns
Survey Human Resources Dept.
Looks good,
Reviewed-by: Christoph Hellwig
On 2011-05-18 10:09, Markus Armbruster wrote:
> Jan Kiszka writes:
>
>> Include the client type name into the output of 'info network'. The
>> result looks like this:
>>
>> (qemu) info network
>> VLAN 0 devices:
>> rtl8139.0 (NIC): model=rtl8139,macaddr=52:54:00:12:34:57
>> Devices not on any V
Looks good,
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
On 2011-05-20 17:33, Anthony Liguori wrote:
> On 05/20/2011 04:01 AM, Avi Kivity wrote:
>> On 05/19/2011 07:32 PM, Anthony Liguori wrote:
Think of how a window manager folds windows with priorities onto a flat
framebuffer.
You do a depth-first walk of the tree. For each child li
Looks good,
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
On 05/17/2011 03:32 PM, Max Filippov wrote:
> +static void gen_window_check1(DisasContext *dc, unsigned r1)
> +{
> +if (option_enabled(dc, XTENSA_OPTION_WINDOWED_REGISTER) &&
> +r1 / 4 > dc->used_window) {
> +TCGv_i32 pc = tcg_const_i32(dc->pc);
> +TCGv_i32 w = tcg_c
> --- a/hw/scsi-bus.c
> +++ b/hw/scsi-bus.c
> @@ -136,6 +136,7 @@ SCSIRequest *scsi_req_alloc(size_t size, SCSIDevice *d,
> uint32_t tag, uint32_t l
> SCSIRequest *req;
>
> req = qemu_mallocz(size);
> +req->refcount = 2;
> req->bus = scsi_bus_from_device(d);
> req->dev =
On 2011-05-20 17:49, Peter Maydell wrote:
> This patchset reverts commit f68b9d672, which was triggering
> spuriously for NICs created via -device rather than -net nic.
> It then reimplements the improved diagnostics with a different
> approach which only applies to '-net nic'. (It's only -net nic
> qbus_create_inplace(&bus->qbus, &scsi_bus_info, host, NULL);
> bus->busnr = next_scsi_bus++;
> bus->tcq = tcq;
> bus->ndev = ndev;
> -bus->complete = complete;
> +bus->ops = *ops;
Normally bus->ops would be a pointer, so you can just assign it to
the address passed in
On Tue, May 17, 2011 at 01:00:49PM +0200, Paolo Bonzini wrote:
> This abstracts calling the command_complete callback, reducing churn
> in the following patches.
Adding the helper sounds fine to me, but the name seems rather badly
chosen. What about scsi_req_get_more_data or similar? Either way
This reverts commit f68b9d672b90dedc79aeb9b44607f484dbe46a6b.
That attempt at diagnosing unused -net nic options failed to account
for NICs created via -device; back it out cleanly in preparation
for implementing in a different manner.
Signed-off-by: Peter Maydell
---
net.c | 31 --
Diagnose the case where the user asked for a NIC via "-net nic"
but the board didn't instantiate that NIC (for example where the
user asked for two NICs but the board only supports one). Note
that this diagnostic doesn't apply to NICs created through -device,
because those are always instantiated.
Don't warn about the default network setup that you get if no command line
-net options are specified. There are two cases that we would otherwise
complain about:
(1) board doesn't support a NIC but the implicit "-net nic" requested one
(2) CONFIG_SLIRP not set, so the implicit "-net nic" sets up
This patchset reverts commit f68b9d672, which was triggering
spuriously for NICs created via -device rather than -net nic.
It then reimplements the improved diagnostics with a different
approach which only applies to '-net nic'. (It's only -net nic
devices that can be ignored (ie not instantiated);
On Tue, May 17, 2011 at 01:00:48PM +0200, Paolo Bonzini wrote:
> scsi-generic scsi_read_complete() should not -both- call the client
> complete callback with SCSI_REASON_DATA -and- call
> scsi_command_complete(). The former will cause the client to queue a
> new read or write request, while the la
Looks good,
Reviewed-by: Christoph Hellwig
1 - 100 of 199 matches
Mail list logo
