Re: [Qemu-devel] [PATCH 12/17] lm32: support for creating device tree

2011-02-11 Thread Blue Swirl
On Sat, Feb 12, 2011 at 12:40 AM, Michael Walle wrote: > Am Freitag 11 Februar 2011, 21:52:17 schrieb Blue Swirl: >> > +static inline void hwsetup_add_uart(struct hwsetup *hw, >> > +        const char *name, uint32_t base, uint32_t irq) >> > +{ >> > +    hwsetup_add_u32(hw, 56); /* size */ >> > +

Re: [Qemu-devel] [PATCH 11/17] lm32: system control model

2011-02-11 Thread Blue Swirl
On Sat, Feb 12, 2011 at 12:35 AM, Michael Walle wrote: > Am Freitag 11 Februar 2011, 22:03:40 schrieb Blue Swirl: >> > +static int lm32_sys_init(SysBusDevice *dev) >> > +{ >> > +    LM32SysState *s = FROM_SYSBUS(typeof(*s), dev); >> > +    int sys_regs; >> > + >> > +    sys_regs = cpu_register_io_

[Qemu-devel] Re: [PATCH] slirp: ensure minimum packet size

2011-02-11 Thread Hervé Poussineau
Hi, qemu-devel-requ...@nongnu.org a écrit : Date: Thu, 10 Feb 2011 15:54:28 -0700 From: "Bruce Rogers" Subject: [Qemu-devel] [PATCH] slirp: ensure minimum packet size To: Message-ID: <4d540a340248000a9...@novprvoes0310.provo.novell.com> Content-Type: text/plain; charset=US-ASCII With rece

Re: [Qemu-devel] [PATCH 09/17] lm32: timer model

2011-02-11 Thread Blue Swirl
On Sat, Feb 12, 2011 at 12:29 AM, Michael Walle wrote: > Am Freitag 11 Februar 2011, 22:22:32 schrieb Blue Swirl: >> > +static uint32_t timer_read(void *opaque, target_phys_addr_t addr) >> > +{ >> > +    LM32TimerState *s = opaque; >> > +    uint32_t r = 0; >> > + >> > +    addr >>= 2; >> > +    s

Re: [Qemu-devel] [PATCH 02/17] lm32: translation routines

2011-02-11 Thread Blue Swirl
On Sat, Feb 12, 2011 at 12:23 AM, Michael Walle wrote: > Hi, > > Regarding all the comments on raising an exception. The real hardware does > only support a few basic exception (like div by zero or interrupts and system > calls). There is no checking if an instruction is supported or not. If an >

Re: [Qemu-devel] qemu user x86 working?

2011-02-11 Thread Mulyadi Santosa
On Sat, Feb 12, 2011 at 05:27, Andi Kleen wrote: > static binary segfaults too. I wonder if it's some setup on my system. > > I tried disabling the usual suspects like address randomization, but that > didn't change things. > Or could it be the compiler (gcc 4.5)? > > I remember using this quite s

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-11 Thread Scott Wood
On Fri, 11 Feb 2011 22:07:11 +0100 Alexander Graf wrote: > > On 11.02.2011, at 21:53, Scott Wood wrote: > > > On Fri, 11 Feb 2011 02:41:35 +0100 > > Alexander Graf wrote: > > > Maybe we should go with Avi's proposal after all and simply keep the > full soft-mmu synced between kerne

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Kees Cook
** Changed in: qemu-kvm (Ubuntu Maverick) Assignee: Ubuntu Security Team (ubuntu-security) => Kees Cook (kees) ** Changed in: qemu-kvm (Ubuntu Lucid) Assignee: Ubuntu Security Team (ubuntu-security) => Kees Cook (kees) ** Changed in: qemu-kvm (Ubuntu Karmic) Importance: Undecided =>

[Qemu-devel] [PATCH 2/3] mainstone: convert FPGA emulation code to use QDev/SysBus

2011-02-11 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/mainstone.c | 10 +++-- hw/mainstone.h |3 -- hw/mst_fpga.c | 96 3 files changed, 54 insertions(+), 55 deletions(-) diff --git a/hw/mainstone.c b/hw/mainstone.c index 18d1415..9c8bc15

[Qemu-devel] [PATCH 3/3] Merge mainstone.h header into mainstone.c

2011-02-11 Thread Dmitry Eremin-Solenikov
Now the only user of mainstone.h is mainstone.c file. Merge header into board file. Signed-off-by: Dmitry Eremin-Solenikov --- hw/mainstone.c | 23 ++- hw/mainstone.h | 35 --- 2 files changed, 22 insertions(+), 36 deletions(-) delete mode

[Qemu-devel] [PATCH 1/3] mainstone: correct and simplify irq handling

2011-02-11 Thread Dmitry Eremin-Solenikov
Simplify IRQ handling to stop setting an input irq pin. As a win, also get correct IRQ status after save/load cycle. Signed-off-by: Dmitry Eremin-Solenikov --- hw/mst_fpga.c | 29 ++--- 1 files changed, 10 insertions(+), 19 deletions(-) diff --git a/hw/mst_fpga.c b/hw/

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Dustin Kirkland
Attaching debdiff for karmic. ** Patch added: "697197.karmic.debdiff" https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/697197/+attachment/1844267/+files/697197.karmic.debdiff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Kees Cook
** Changed in: libvirt (Ubuntu Natty) Importance: High => Undecided ** Changed in: libvirt (Ubuntu Natty) Assignee: Serge Hallyn (serge-hallyn) => (unassigned) ** Changed in: qemu-kvm (Ubuntu Maverick) Milestone: maverick-updates => None ** Changed in: libvirt (Ubuntu Lucid) S

[Qemu-devel] [Bug 604872] Re: qemu-system-arm segfaults emulating versatile machine after running debootstrap --second-stage inside vm

2011-02-11 Thread Loïc Minier
** Changed in: qemu-linaro (Ubuntu) Status: Fix Released => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/604872 Title: qemu-system-arm segfaults emulating versatile machine after ru

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Kees Cook
Thanks for preparing the debdiffs! It looks like karmic is vulnerable too, so we'll need that as well. I'll update the debdiffs to use proper DEP-3 and fix up the formatting of the changelogs a bit ("CVE-" vs "CVE: "), and get these building. ** Also affects: libvirt (Ubuntu Karmic) Importance:

[Qemu-devel] [Bug 604872] Re: qemu-system-arm segfaults emulating versatile machine after running debootstrap --second-stage inside vm

2011-02-11 Thread Peter Maydell
** Changed in: qemu-linaro (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/604872 Title: qemu-system-arm segfaults emulating versatile machine after ru

Re: [Qemu-devel] [PATCH 14/17] lm32: todo and documentation

2011-02-11 Thread Michael Walle
Am Freitag 11 Februar 2011, 21:41:14 schrieb Blue Swirl: > > +Special instructions > > + > > +The translation recognizes one special instruction to halt the cpu: > > + and r0, r0, r0 > > +On real hardware this instruction is a nop. It is not used by GCC and > > +should (hopeful

Re: [Qemu-devel] [PATCH 12/17] lm32: support for creating device tree

2011-02-11 Thread Michael Walle
Am Freitag 11 Februar 2011, 21:52:17 schrieb Blue Swirl: > > +static inline void hwsetup_add_uart(struct hwsetup *hw, > > +const char *name, uint32_t base, uint32_t irq) > > +{ > > +hwsetup_add_u32(hw, 56); /* size */ > > +hwsetup_add_tag(hw, HWSETUP_TAG_UART); > > +hwsetup_add_

Re: [Qemu-devel] [PATCH 1/7] Add scoop post_load callback that sets IRQs to loaded levels

2011-02-11 Thread andrzej zaborowski
On 11 February 2011 21:57, Dmitry Eremin-Solenikov wrote: > Signed-off-by: Dmitry Eremin-Solenikov > --- >  hw/zaurus.c |   19 ++- >  1 files changed, 18 insertions(+), 1 deletions(-) > > diff --git a/hw/zaurus.c b/hw/zaurus.c > index fca11a5..fb5e228 100644 > --- a/hw/zaurus.c >

Re: [Qemu-devel] [PATCH 11/17] lm32: system control model

2011-02-11 Thread Michael Walle
Am Freitag 11 Februar 2011, 22:03:40 schrieb Blue Swirl: > > +static int lm32_sys_init(SysBusDevice *dev) > > +{ > > +LM32SysState *s = FROM_SYSBUS(typeof(*s), dev); > > +int sys_regs; > > + > > +sys_regs = cpu_register_io_memory(sys_read_fn, sys_write_fn, s, > > +DEVICE_NAT

Re: [Qemu-devel] [PATCH 09/17] lm32: timer model

2011-02-11 Thread Michael Walle
Am Freitag 11 Februar 2011, 22:22:32 schrieb Blue Swirl: > > +static uint32_t timer_read(void *opaque, target_phys_addr_t addr) > > +{ > > +LM32TimerState *s = opaque; > > +uint32_t r = 0; > > + > > +addr >>= 2; > > +switch (addr) { > > +case R_SR: > > +case R_CR: > > +c

Re: [Qemu-devel] qemu user x86 working?

2011-02-11 Thread Andi Kleen
I don't have any problems running a statically linked x86_64 helloworld program in an i386 chroot. Dynamically linked programs try to use wrong libraries, but at least running /lib64/ld-linux-x86-64.so.2 directly works. static binary segfaults too. I wonder if it's some setup on my system. I

Re: [Qemu-devel] [PATCH 08/11] Add scoop post_load callback that sets IRQs to loaded levels

2011-02-11 Thread Dmitry Eremin-Solenikov
On 2/11/11, andrzej zaborowski wrote: > Hi Dmitry, > > On 31 January 2011 16:20, Dmitry Eremin-Solenikov > wrote: >> Signed-off-by: Dmitry Eremin-Solenikov >> --- >> hw/zaurus.c | 19 ++- >> 1 files changed, 18 insertions(+), 1 deletions(-) >> >> diff --git a/hw/zaurus.c b/hw/

Re: [Qemu-devel] [PATCH 02/17] lm32: translation routines

2011-02-11 Thread Michael Walle
Hi, Regarding all the comments on raising an exception. The real hardware does only support a few basic exception (like div by zero or interrupts and system calls). There is no checking if an instruction is supported or not. If an illegal opcode (like divu if the hardware divider is not enabled

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-11 Thread andrzej zaborowski
On 11 February 2011 21:18, Dmitry Eremin-Solenikov wrote: > On 2/11/11, andrzej zaborowski wrote: >> On 31 January 2011 16:20, Dmitry Eremin-Solenikov >> wrote: >>> pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with >>> references to arm-pic. Also use qdev/sysbus framework to

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-11 Thread andrzej zaborowski
Hi, On 11 February 2011 21:24, Dmitry Eremin-Solenikov wrote: > On 2/11/11, Dmitry Eremin-Solenikov wrote: >> I just planned to later reuse allocated arm-pic IRQ's (the new one) to >> be passed to pxa2xx-gpio (to drop usage of cpu-env). I think. I can >> still allocate >> arm-pic but use only th

Re: [Qemu-devel] qemu user x86 working?

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 9:49 PM, Andi Kleen wrote: > Hi, > > Is the linux-user qemu for x86-64/i386 supposed to work? > > For example running it with a simple hello world on FC14 in gdb: > > /home/ak/tsrc/hello: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), > dynamically linked (uses share

Re: [Qemu-devel] [PATCH 06/17] lm32: interrupt controller model

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 1:11 AM, Michael Walle wrote: > This patch adds the interrupt controller of the lm32. Because the PIC is > accessed through special control registers and opcodes, there are callbacks > from the lm32 translation code to this model. > > Signed-off-by: Michael Walle > --- >  

Re: [Qemu-devel] [PATCH 09/17] lm32: timer model

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 1:12 AM, Michael Walle wrote: > This patch adds support for the LatticeMico32 system timer. > > Signed-off-by: Michael Walle > --- >  Makefile.target |    1 + >  hw/lm32_timer.c |  227 > +++ >  trace-events    |    6 ++

Re: [Qemu-devel] [PATCH 10/17] lm32: uart model

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 1:12 AM, Michael Walle wrote: > This patch add support for the LatticeMico32 UART. > > Signed-off-by: Michael Walle > --- >  Makefile.target |    1 + >  hw/lm32_uart.c  |  292 > +++ >  trace-events    |    5 + >  3 files

Re: [Qemu-devel] [PATCH 07/17] lm32: juart model

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 1:12 AM, Michael Walle wrote: > This patch adds the JTAG UART model. It is accessed through special control > registers and opcodes. Therefore the translation uses callbacks to this > model. > > Signed-off-by: Michael Walle > --- >  hw/lm32_juart.c |  151 > ++

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-11 Thread Alexander Graf
On 11.02.2011, at 21:53, Scott Wood wrote: > On Fri, 11 Feb 2011 02:41:35 +0100 > Alexander Graf wrote: > Maybe we should go with Avi's proposal after all and simply keep the full soft-mmu synced between kernel and user space? That way we only need a setup call at first, no cop

Re: [Qemu-devel] [PATCH 11/17] lm32: system control model

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 1:12 AM, Michael Walle wrote: > This patch add support for a system control block. It is supposed to > act as helper for the emulated program. E.g. shutting down the VM or > printing test results. This model is intended for testing purposes only and > doesn't fit to any rea

[Qemu-devel] [PATCH 4/7] tc6393xb: correct NAND isr assertion

2011-02-11 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/tc6393xb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/tc6393xb.c b/hw/tc6393xb.c index 2104d4e..ed49e94 100644 --- a/hw/tc6393xb.c +++ b/hw/tc6393xb.c @@ -380,7 +380,7 @@ static void tc6393xb_nand_writeb(TC6393xbState

[Qemu-devel] [PATCH 6/7] max7310: finish qdev'ication

2011-02-11 Thread Dmitry Eremin-Solenikov
1) Move GPIO-related functionality to qdev. Now one can use directly qdev_get_gpio_in()/qdev_connect_gpio_out() on max7310 devices. 2) Make reset to be called through qdev.reset callback. Signed-off-by: Dmitry Eremin-Solenikov --- hw/i2c.h |5 - hw/max7310.c | 26 +

[Qemu-devel] [PATCH 7/7] pxa2xx: convert i2c master to use qdev/vmsd

2011-02-11 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/pxa2xx.c | 53 ++--- 1 files changed, 42 insertions(+), 11 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index d966846..9ebbce6 100644 --- a/hw/pxa2xx.c +++ b/hw/pxa2xx.c @@ -1262,10 +1262,12 @@

[Qemu-devel] [PATCH 1/7] Add scoop post_load callback that sets IRQs to loaded levels

2011-02-11 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/zaurus.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/hw/zaurus.c b/hw/zaurus.c index fca11a5..fb5e228 100644 --- a/hw/zaurus.c +++ b/hw/zaurus.c @@ -181,17 +181,34 @@ static int scoop_init(SysBusDevice *

[Qemu-devel] [PATCH 3/7] mainstone: pass one irq to the mst_fpga instead of the whole PIC

2011-02-11 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/mainstone.c |2 +- hw/mainstone.h |2 +- hw/mst_fpga.c | 12 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/mainstone.c b/hw/mainstone.c index 58e3f86..18d1415 100644 --- a/hw/mainstone.c +++ b/hw/mainstone.c

[Qemu-devel] [PATCH 5/7] tosa: we aren't connected to VBus, pass this info to Linux kernel

2011-02-11 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- hw/tosa.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/tosa.c b/hw/tosa.c index 0bfab16..b8b6c4f 100644 --- a/hw/tosa.c +++ b/hw/tosa.c @@ -25,6 +25,7 @@ #define TOSA_RAM0x0400 #define TOSA_ROM 0x0080

[Qemu-devel] [PATCH 2/7] Drop unnecessary inclusions of pxa.h header

2011-02-11 Thread Dmitry Eremin-Solenikov
Seceral files contained onnecessary dependencies on hw/pxa.h header. Drop unused references. Signed-off-by: Dmitry Eremin-Solenikov --- hw/tc6393xb.c |1 - hw/zaurus.c |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/tc6393xb.c b/hw/tc6393xb.c index c3fbe4e..2104

Re: [Qemu-devel] [PATCH 08/17] lm32: pic and juart helper functions

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 1:12 AM, Michael Walle wrote: > This patch adds init functions for the PIC and JTAG UART commonly used > in the board initialization. > > Signed-off-by: Michael Walle > --- >  hw/lm32.h |   31 +++ >  1 files changed, 31 insertions(+), 0 deletion

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-11 Thread Scott Wood
On Fri, 11 Feb 2011 02:41:35 +0100 Alexander Graf wrote: > >> Maybe we should go with Avi's proposal after all and simply keep the full > >> soft-mmu synced between kernel and user space? That way we only need a > >> setup call at first, no copying in between and simply update the user > >> sp

Re: [Qemu-devel] [PATCH 12/17] lm32: support for creating device tree

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 1:12 AM, Michael Walle wrote: > This patch adds helper functions to create a ROM, which contains a hardware > description of a board. This is used in Theobromas LM32 Linux port. > > Signed-off-by: Michael Walle > --- >  hw/lm32_hwsetup.h |  172 > +

Re: [Qemu-devel] [PATCH 13/17] lm32: EVR32 and uclinux BSP

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 1:12 AM, Michael Walle wrote: > This patch adds support for the following two BSPs: >  - LM32 EVR32 BSP (as used by RTEMS) >  - uclinux BSP by Theobroma Systems > > Signed-off-by: Michael Walle > --- >  Makefile.target                  |    3 + >  default-configs/lm32-soft

Re: [Qemu-devel] [PATCH 14/17] lm32: todo and documentation

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 1:12 AM, Michael Walle wrote: > This patch adds general target documentation and a todo list. > > Signed-off-by: Michael Walle > --- >  target-lm32/README |   46 ++ >  target-lm32/TODO   |    3 +++ >  2 files changed, 49 insertio

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-11 Thread Dmitry Eremin-Solenikov
Hello, On 2/11/11, Dmitry Eremin-Solenikov wrote: > On 2/11/11, andrzej zaborowski wrote: >> On 31 January 2011 16:20, Dmitry Eremin-Solenikov >> wrote: >>> pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with >>> references to arm-pic. Also use qdev/sysbus framework to handle

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/qemu-kvm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/697197 Title: Empty password allows access to VNC in libvirt Status in libvirt virtualization API: Unknown Stat

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-11 Thread Dmitry Eremin-Solenikov
On 2/11/11, andrzej zaborowski wrote: > On 31 January 2011 16:20, Dmitry Eremin-Solenikov > wrote: >> pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with >> references to arm-pic. Also use qdev/sysbus framework to handle >> pxa2xx-pic. > > The duplication involves about 4 lines

[Qemu-devel] qemu user x86 working?

2011-02-11 Thread Andi Kleen
Hi, Is the linux-user qemu for x86-64/i386 supposed to work? For example running it with a simple hello world on FC14 in gdb: /home/ak/tsrc/hello: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.32, not stripped [Thread debugging us

[Qemu-devel] [PATCH] eepro100: pad to ensure minimum packet size

2011-02-11 Thread Bruce Rogers
Recent gpxe e100pro drivers will drop small packets because the emulated nic will report an error for small frames. In the qemu model we should instead have the e100pro pad out the received frames to be the minimum size and not report this case as an error. Signed-off-by: Bruce Rogers --- hw/eep

Re: [Qemu-devel] Re: Porting QEMU to new hosts with unusual ABI (sizeof(long) != sizeof(void *))

2011-02-11 Thread malc
On Fri, 11 Feb 2011, Blue Swirl wrote: > On Fri, Feb 11, 2011 at 2:47 PM, Paolo Bonzini wrote: > > On 02/11/2011 06:05 AM, Rob Landley wrote: > >>> > >>> While this assumption works on QEMU's major hosts, it is not generally > >>> true. > >> > >> It is generally true.  There is exactly one operat

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2011-02-11 Thread Dustin Kirkland
Moving this bug over to the qemu-linaro package, which now provides qemu-system-arm ** Package changed: qemu-kvm (Ubuntu) => qemu-linaro (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/532733

[Qemu-devel] [Bug 604872] Re: qemu-system-arm segfaults emulating versatile machine after running debootstrap --second-stage inside vm

2011-02-11 Thread Dustin Kirkland
Moving this bug over to the qemu-linaro package, which now provides qemu-system-arm ** Package changed: qemu-kvm (Ubuntu) => qemu-linaro (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/604872

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Launchpad Bug Tracker
** Branch linked: lp:~kirkland/ubuntu/natty/qemu-kvm/fix-build -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/697197 Title: Empty password allows access to VNC in libvirt Status in libvirt virtuali

Re: [Qemu-devel] Re: Porting QEMU to new hosts with unusual ABI (sizeof(long) != sizeof(void *))

2011-02-11 Thread Blue Swirl
On Fri, Feb 11, 2011 at 2:47 PM, Paolo Bonzini wrote: > On 02/11/2011 06:05 AM, Rob Landley wrote: >>> >>> While this assumption works on QEMU's major hosts, it is not generally >>> true. >> >> It is generally true.  There is exactly one operating system that >> decided to go its own way, and the

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-11 Thread Blue Swirl
On Thu, Feb 10, 2011 at 6:05 PM, Anthony Liguori wrote: > On 02/10/2011 03:20 PM, Gleb Natapov wrote: >> >> Jugging by how well all previous conversion went we will end up with one >> more way of creating devices. One legacy, another qdev and your new one. >> And what is the problem with qdev agai

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-11 Thread Blue Swirl
On Thu, Feb 10, 2011 at 9:47 AM, Anthony Liguori wrote: > On 02/09/2011 09:15 PM, Blue Swirl wrote: >> >> On Wed, Feb 9, 2011 at 9:59 PM, Anthony Liguori >>  wrote: >> >>> >>> On 02/09/2011 06:48 PM, Blue Swirl wrote: >>> > > ISASerialState dev; > > isa_serial_init(&dev, 0, 0x274,

Re: [Qemu-devel] [PATCH] slirp: ensure minimum packet size

2011-02-11 Thread Bruce Rogers
>>> On 2/11/2011 at 01:26 AM, Anthony Liguori wrote: > On 02/10/2011 11:54 PM, Bruce Rogers wrote: >> With recent gpxe eepro100 drivers, short packets are rejected, >> so ensure the minimum ethernet packet size. >> >> Signed-off-by: Bruce Rogers >> > > This doesn't make much sense. I think

[Qemu-devel] [PATCH STABLE 0.14 8/9] qemu-img: Improve error messages for failed bdrv_open

2011-02-11 Thread Kevin Wolf
Output the error message string of the bdrv_open return code. Also set a non-empty device name for the images because the unknown feature error message includes it. Signed-off-by: Kevin Wolf Reviewed-by: Anthony Liguori (cherry picked from commit b9eaf9ecb15a9c69a592f386159163d5efc3b919) --- qe

[Qemu-devel] [PATCH 3/6] target-arm: fix unsigned 64 bit right shifts.

2011-02-11 Thread christophe.lyon
From: Christophe Lyon Fix range of shift amounts which always give 0 as result. Signed-off-by: Christophe Lyon --- target-arm/neon_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c index 1ac362f..907f7b7 10064

[Qemu-devel] [PATCH 1/6] target-arm: Fix rounding constant addition for Neon shift instructions.

2011-02-11 Thread christophe.lyon
From: Christophe Lyon Handle cases where adding the rounding constant could overflow in Neon shift instructions: VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN. Signed-off-by: Christophe Lyon --- target-arm/neon_helper.c | 149 ++ 1 files changed, 137 inse

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Dustin Kirkland
** Changed in: libvirt (Ubuntu Maverick) Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/697197 Title: Empty password allows access to VNC in libvirt Status in libvirt

[Qemu-devel] [PATCH STABLE 0.14 9/9] qcow2: Fix order in L2 table COW

2011-02-11 Thread Kevin Wolf
When copying L2 tables (this happens only with internal snapshots), the order wasn't completely safe, so that after a crash you could end up with a L2 table that has too low refcount, possibly leading to corruption in the long run. This patch puts the operations in the right order: First allocate

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Dustin Kirkland
@security team, Could you please sponsor this to the maverick-security queue? Thanks! ** Patch added: "697197.debdiff" https://bugs.launchpad.net/ubuntu/maverick/+source/qemu-kvm/+bug/697197/+attachment/1843528/+files/697197.debdiff ** Changed in: qemu-kvm (Ubuntu Maverick) Assignee: D

[Qemu-devel] [PULL STABLE 0.14 0/9] Block patches for stable-0.14

2011-02-11 Thread Kevin Wolf
The following changes since commit b03088c32f8a88e4674f6cdab47da79ef4188d88: linux-user: Fix possible realloc memory leak (2011-02-09 21:24:05 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-stable-0.14 Chunqiang Tang (1): QCOW2: bug fix - read base i

[Qemu-devel] [PATCH STABLE 0.14 2/9] QCOW2: bug fix - read base image beyond its size

2011-02-11 Thread Kevin Wolf
From: Chunqiang Tang This patch fixes the following bug in QCOW2. For a QCOW2 image that is larger than its base image, when handling a read request straddling over the end of the base image, the QCOW2 driver attempts to read beyond the end of the base image and the request would fail. This bug

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Neil Wilson
The patch needs to go into Lucid as well. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/697197 Title: Empty password allows access to VNC in libvirt Status in libvirt virtualization API: Unknown

Re: [Qemu-devel] [PATCH 1/2] target-arm: Move Neon VUZP to a helper function

2011-02-11 Thread Peter Maydell
On 11 February 2011 16:14, Peter Maydell wrote: > +void HELPER(neon_unzip)(CPUState *env, uint32_t insn) > +{ > +    int rd = ((insn >> 18) & 0x10) | ((insn >> 12) & 0x0f); > +    int rm = ((insn >> 1) & 0x10) | (insn & 0x0f); > +    int size = (insn >> 18) & 3; > +    if (insn & 0x40) { /* Q */ >

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Dustin Kirkland
** Changed in: qemu-kvm (Ubuntu) Importance: Undecided => Medium ** Changed in: qemu-kvm (Ubuntu) Status: Confirmed => In Progress ** Changed in: qemu-kvm (Ubuntu) Assignee: (unassigned) => Dustin Kirkland (kirkland) -- You received this bug notification because you are a member

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Dustin Kirkland
Confirmed that the affected code is also in Lucid. Adding a task for that, and attaching a debdiff for lucid-security too. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/697197 Title: Empty passwor

[Qemu-devel] [PATCH STABLE 0.14 3/9] qcow2: Fix error handling for immediate backing file read failure

2011-02-11 Thread Kevin Wolf
Requests could return success even though they failed when bdrv_aio_readv returned NULL for a backing file read. Reported-by: Chunqiang Tang Signed-off-by: Kevin Wolf (cherry picked from commit 3ab4c7e92d39d40e6dc0bdb1c2320889543691cb) --- block/qcow2.c |4 +++- 1 files changed, 3 insertion

Re: [Qemu-devel] [PATCH] qemu-lock.h: Remove non-pthreads spinlock implementations

2011-02-11 Thread Peter Maydell
On 31 January 2011 18:26, Peter Maydell wrote: > Since configure guarantees us that we have pthreads on all hosts > except mingw (which doesn't support a USER_ONLY config), we can > and should use the pthread_mutex based implementation of spin_lock() > and spin_unlock() in all USER_ONLY cases. Thi

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Dustin Kirkland
Looks good, thanks for doing this, Neil. I'm going to update it just slightly, as this debdiff will need to go through the security queue, since there's an associated CVE. I'll prep that upload and the security team will sponsor it into maverick- security. I'll get it uploaded to natty now. The

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Dustin Kirkland
Marking the libvirt tasks "invalid", as upstream libvirt has correctly pointed out that this bug is in qemu, and not libvirt: * https://bugzilla.redhat.com/show_bug.cgi?id=667097 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

[Qemu-devel] [PATCH 6/6] target-arm: fix decoding of Neon 64 bit shifts.

2011-02-11 Thread christophe.lyon
From: Christophe Lyon Fix decoding of 64 bits variants of VSHRN, VRSHRN, VQSHRN, VQSHRUN, VQRSHRN, VQRSHRUN, taking into account whether inputs are unsigned or not. Signed-off-by: Christophe Lyon --- target-arm/translate.c | 43 --- 1 files changed, 2

[Qemu-devel] [PATCH STABLE 0.14 1/9] Change snapshot_blkdev hmp to use correct argument type for device

2011-02-11 Thread Kevin Wolf
From: Jes Sorensen Pointed out by Markus Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf (cherry picked from commit 982aa95532a3a7b549695d5b3e18442975eecfb5) --- hmp-commands.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx i

[Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-11 Thread christophe.lyon
From: Christophe Lyon This patch series provides fixes such that ARM Neon instructions VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN now pass all my tests. I have reworked all these patches and I hope they are now easier to review. Christophe Lyon (6): target-arm: Fix roundi

[Qemu-devel] [PATCH STABLE 0.14 5/9] qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE

2011-02-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Anthony Liguori (cherry picked from commit f54e3641122e51c6343d587805422642f307462e) --- qerror.c |5 + qerror.h |3 +++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 9d0cdeb..4855604 100644 --- a/qerro

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Dustin Kirkland
Attaching Lucid debdiff. ** Patch added: "697197.lucid.debdiff" https://bugs.launchpad.net/ubuntu/lucid/+source/qemu-kvm/+bug/697197/+attachment/1843553/+files/697197.lucid.debdiff ** Changed in: qemu-kvm (Ubuntu Lucid) Assignee: Dustin Kirkland (kirkland) => Ubuntu Security Team (ubunt

Re: [Qemu-devel] [PATCH 1/2] target-arm: Move Neon VUZP to a helper function

2011-02-11 Thread Nathan Froyd
On Fri, Feb 11, 2011 at 04:53:30PM +, Peter Maydell wrote: > On 11 February 2011 16:14, Peter Maydell wrote: > > +void HELPER(neon_unzip)(CPUState *env, uint32_t insn) > > +{ > > +    int rd = ((insn >> 18) & 0x10) | ((insn >> 12) & 0x0f); > > +    int rm = ((insn >> 1) & 0x10) | (insn & 0x0f)

[Qemu-devel] [PATCH 1/2] target-arm: Move Neon VUZP to a helper function

2011-02-11 Thread Peter Maydell
From: Juha Riihimäki Move the implementation of the Neon VUZP unzip instruction from inline code to a helper function. (At 50+ TCG ops it was well over the ecommended limit for coding inline.) The helper implementation also fixes the handling of the quadword version of the instruction. Signed-of

[Qemu-devel] [PATCH STABLE 0.14 7/9] qed: Report error for unsupported features

2011-02-11 Thread Kevin Wolf
Instead of just returning -ENOTSUP, generate a more detailed error. Unfortunately we don't have a helpful text for features that we don't know yet, so just print the feature mask. It might be useful at least if someone asks for help. Signed-off-by: Kevin Wolf Reviewed-by: Anthony Liguori Acked-

Re: [Qemu-devel] [PATCH 1/2] target-arm: Move Neon VUZP to a helper function

2011-02-11 Thread Peter Maydell
On 11 February 2011 17:03, Nathan Froyd wrote: > On Fri, Feb 11, 2011 at 04:53:30PM +, Peter Maydell wrote: >> On 11 February 2011 16:14, Peter Maydell wrote: >> > +void HELPER(neon_unzip)(CPUState *env, uint32_t insn) >> > +{ >> > +    int rd = ((insn >> 18) & 0x10) | ((insn >> 12) & 0x0f);

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Dustin Kirkland
Uploading to Natty now... ** Also affects: libvirt (Ubuntu Lucid) Importance: Undecided Status: New ** Also affects: qemu-kvm (Ubuntu Lucid) Importance: Undecided Status: New ** Changed in: qemu-kvm (Ubuntu Lucid) Importance: Undecided => Medium ** Changed in: qemu-kvm (U

[Qemu-devel] [PATCH 2/6] target-arm: fix Neon right shifts with shift amount == input width.

2011-02-11 Thread christophe.lyon
From: Christophe Lyon Fix rshl helpers (s8, s16, s64, u8, u16) Signed-off-by: Christophe Lyon --- target-arm/neon_helper.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c index 3f1f3d4..1ac362f 100644 --- a/targe

[Qemu-devel] [PATCH 4/6] target-arm: fix saturated values for Neon right shifts.

2011-02-11 Thread christophe.lyon
From: Christophe Lyon Fix value returned by signed qrshl helpers (8, 16 and 32 bits). Signed-off-by: Christophe Lyon --- target-arm/neon_helper.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c index 907f7b7..8

[Qemu-devel] Re: [PULL STABLE 0.14 0/9] Block patches for stable-0.14

2011-02-11 Thread Justin M. Forbes
On Fri, 2011-02-11 at 15:21 +0100, Kevin Wolf wrote: > The following changes since commit b03088c32f8a88e4674f6cdab47da79ef4188d88: > > linux-user: Fix possible realloc memory leak (2011-02-09 21:24:05 +0100) > > are available in the git repository at: > git://repo.or.cz/qemu/kevin.git for-st

[Qemu-devel] [PATCH 5/6] target-arm: fix Neon VQSHRN and VSHRN.

2011-02-11 Thread christophe.lyon
From: Christophe Lyon Call the normal shift helpers instead of the rounding ones. Signed-off-by: Christophe Lyon --- target-arm/translate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 8791bc5..ace533f 100644

[Qemu-devel] [PATCH STABLE 0.14 4/9] qcow2: Fix error handling for reading compressed clusters

2011-02-11 Thread Kevin Wolf
When reading a compressed cluster failed, qcow2 falsely returned success. Signed-off-by: Kevin Wolf Reviewed-by: Markus Armbruster (cherry picked from commit 8af364884355b3f0c5d60a2d2f427927739658ea) --- block/qcow2-cluster.c |4 ++-- block/qcow2.c |4 +++- 2 files changed, 5 in

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu-kvm - 0.13.0+noroms-0ubuntu13 --- qemu-kvm (0.13.0+noroms-0ubuntu13) natty; urgency=low [ Neil Wilson ] * SECURITY UPDATE: Setting VNC password to empty string silently disables all authentication (LP: #697197) - debian/patches/69719

[Qemu-devel] [PATCH STABLE 0.14 6/9] qcow2: Report error for version > 2

2011-02-11 Thread Kevin Wolf
The qcow2 driver is now declared responsible for any QCOW image that has version 2 or greater (before this, version 3 would be detected as raw). For everything newer than version 2, an error is reported. Signed-off-by: Kevin Wolf Reviewed-by: Anthony Liguori (cherry picked from commit e8cdcec12

[Qemu-devel] [PATCH 2/2] target-arm: Move Neon VZIP to a helper function

2011-02-11 Thread Peter Maydell
From: Juha Riihimäki Move the implementation of the Neon VUZP unzip instruction from inline code to a helper function. (At 50+ TCG ops it was well over the recommended limit for coding inline.) The helper implementation also gives the correct answers where the inline implementation did not. Sign

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-11 Thread Dustin Kirkland
** Also affects: libvirt (Ubuntu Maverick) Importance: Undecided Status: New ** Also affects: qemu-kvm (Ubuntu Maverick) Importance: Undecided Status: New ** Also affects: libvirt (Ubuntu Natty) Importance: High Assignee: Serge Hallyn (serge-hallyn) Status: Inva

Re: [Qemu-devel] [PATCH 1/2] target-arm: Move Neon VUZP to a helper function

2011-02-11 Thread Nathan Froyd
On Fri, Feb 11, 2011 at 05:12:32PM +, Peter Maydell wrote: > On 11 February 2011 17:03, Nathan Froyd wrote: > > I do think the preferred way would be to extract rd, rm, size, and Q > > up-front, rather than having the helper twiddle instruction bits. > > OK. You're happy to still have the hel

[Qemu-devel] [PATCH 0/2] target-arm: fix Neon VUZP, VZIP instructions

2011-02-11 Thread Peter Maydell
This patch series is a pair of patches from the meego tree which fix bugs in the Neon VZIP and VUZP instructions by abandoning the existing inline implementations in favour of calling out to a straightforward helper function. The inline routines could generate 50+ TCG ops each, which is well over t

[Qemu-devel] [PATCH] target-arm: Correct conversion of Thumb Neon dp encodings into ARM

2011-02-11 Thread Peter Maydell
From: Juha Riihimäki We handle Thumb Neon data processing instructions by converting them into the equivalent ARM encoding, as the two are very close. However the ARM encoding should have bit 28 set, not clear. This wasn't causing any problems because we don't actually look at that bit during dec

Re: [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore "params" node

2011-02-11 Thread Kevin Wolf
Am 11.02.2011 13:59, schrieb Stefano Stabellini: > On Fri, 11 Feb 2011, Kevin Wolf wrote: >> Am 11.02.2011 13:38, schrieb Stefano Stabellini: >>> When disk is a cdrom and the drive is empty the "params" node in >>> xenstore might be missing completely: cope with it instead of >>> segfaulting. >>> >

Re: [Qemu-devel] Re: Porting QEMU to new hosts with unusual ABI (sizeof(long) != sizeof(void *))

2011-02-11 Thread Tristan Gingold
On Feb 11, 2011, at 1:47 PM, Paolo Bonzini wrote: > ps: HP-UX also uses IL32 on ia64. Now _that_ is hard to understand. Backward compatibility with hppa... VMS also uses IL32 on alpha and ia64, but it has both P32 and P64.

Re: [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore "params" node

2011-02-11 Thread Stefano Stabellini
On Fri, 11 Feb 2011, Kevin Wolf wrote: > Am 11.02.2011 13:38, schrieb Stefano Stabellini: > > When disk is a cdrom and the drive is empty the "params" node in > > xenstore might be missing completely: cope with it instead of > > segfaulting. > > > > Signed-off-by: Stefano Stabellini > > > > > >

[Qemu-devel] Re: [PATCH 6/7] add assertions on the owner of a QemuMutex

2011-02-11 Thread Jan Kiszka
On 2011-02-11 13:14, Paolo Bonzini wrote: > On 02/10/2011 07:25 PM, Jan Kiszka wrote: >> On 2011-02-10 18:37, Paolo Bonzini wrote: >>> These are already present in the Win32 implementation, add them to >>> the pthread wrappers as well. >> >> Better use PTHREAD_MUTEX_ERRORCHECK. > > True. However,

  1   2   >