Hello, On 2/11/11, Dmitry Eremin-Solenikov <dbarysh...@gmail.com> wrote: > On 2/11/11, andrzej zaborowski <balr...@gmail.com> wrote: >> On 31 January 2011 16:20, Dmitry Eremin-Solenikov <dbarysh...@gmail.com> >> wrote: >>> pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with >>> references to arm-pic. Also use qdev/sysbus framework to handle >>> pxa2xx-pic. >> >> The duplication involves about 4 lines of code, at this level I >> strongly prefer to not add a level of calls that can't be inlined in a >> fast path. I guess the choice not to involve arm_pic was conscious. > > I just planned to later reuse allocated arm-pic IRQ's (the new one) to > be passed to pxa2xx-gpio (to drop usage of cpu-env). I think. I can > still allocate > arm-pic but use only the last IRQ from it. Will that be suitable for you?
I recollected the reason for this change: there is no clean way to pass CPUState to qdev. So It's either DEFINE_PROP_PTR() - like hack, or encapsulating thins into qemu_irq arm_pic is used by several other ARM SoC emulators. -- With best wishes Dmitry
