Hi, On 11 February 2011 21:24, Dmitry Eremin-Solenikov <dbarysh...@gmail.com> wrote: > On 2/11/11, Dmitry Eremin-Solenikov <dbarysh...@gmail.com> wrote: >> I just planned to later reuse allocated arm-pic IRQ's (the new one) to >> be passed to pxa2xx-gpio (to drop usage of cpu-env). I think. I can >> still allocate >> arm-pic but use only the last IRQ from it. Will that be suitable for you? > > I recollected the reason for this change: there is no clean way to pass > CPUState > to qdev. So It's either DEFINE_PROP_PTR() - like hack, or > encapsulating thins into > qemu_irq
That's true, but in that patchset pxa2xx_pic is not turned into a qdev device (separate from pxa2xx core). Do you think there's any value in doing that? I think it's ok if it doesn't present any issues/overheads or if there's a clear benefit from doing that. Cheers
