[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: > On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > > +/* > > > + * This function returns device list as an array in a below format: > > > + * +-+---

[Qemu-devel] vishnumurthy prabhu wants to stay in touch on LinkedIn

2010-11-14 Thread vishnumurthy prabhu via LinkedIn
LinkedIn vishnumurthy prabhu requested to add you as a connection on LinkedIn: -- Jiajun, I'd like to add you to my professional network on LinkedIn. - vishnumurthy prabhu Accept invitation from vishnumurthy prabhu http://www.linkedin.com/e/-

[Qemu-devel] [PATCH v8 11/11] x3130/downstream: support aer.

2010-11-14 Thread Isaku Yamahata
add aer support. Signed-off-by: Isaku Yamahata --- hw/xio3130_downstream.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/xio3130_downstream.c b/hw/xio3130_downstream.c index 854eba8..f90415f 100644 --- a/hw/xio3130_downstream.c +++ b/hw/xio3130_downstrea

[Qemu-devel] Re: [PATCH v7 2/6] pcie/aer: helper functions for pcie aer capability

2010-11-14 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 04:35:12PM +0900, Isaku Yamahata wrote: > On Tue, Nov 02, 2010 at 02:57:12PM +0200, Michael S. Tsirkin wrote: > > > +pcie_add_capability(dev, PCI_EXT_CAP_ID_ERR, PCI_ERR_VER, > > > +offset, PCI_ERR_SIZEOF); > > > +exp = &dev->exp; > > > +e

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Gleb Natapov
On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > +/* > > + * This function returns device list as an array in a below format: > > + * +-+-+---+-+---+-- > > + * | n | l1 | devp

[Qemu-devel] [PATCH v8 05/11] pcie_regs.h: more constants

2010-11-14 Thread Isaku Yamahata
remove unnecessary sizeof. Signed-off-by: Isaku Yamahata --- hw/pcie_regs.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pcie_regs.h b/hw/pcie_regs.h index 3461a1b..4d123d9 100644 --- a/hw/pcie_regs.h +++ b/hw/pcie_regs.h @@ -94,7 +94,9 @@ #define PCI_ERR_CAP_MHR

[Qemu-devel] [PATCH v8 08/11] pcie/aer: glue aer error injection into qemu monitor

2010-11-14 Thread Isaku Yamahata
introduce pcie_aer_inject_error command. Signed-off-by: Isaku Yamahata --- Changes v7 -> v8: - use domain:slot.func:slot.func...:slot.func instead of domain:bus:slot.func - allow symbolic aer error name in addition to 32bit value Changes v6 -> v7: - check return value. Changes v3 -> v4: - s/PCI

[Qemu-devel] [PATCH v8 06/11] pcie/aer: helper functions for pcie aer capability

2010-11-14 Thread Isaku Yamahata
This patch implements helper functions for pcie aer capability which will be used later. Signed-off-by: Isaku Yamahata --- Changes v7 -> v8: - various changes to follow the review. - s/TLP_PRESENT/TLP_PREFIX_PRESENT/g Changes v6 -> v7: - make error log buffer non-ringed buffer - refactor pcie_ae

[Qemu-devel] Re: [PATCH v7 2/6] pcie/aer: helper functions for pcie aer capability

2010-11-14 Thread Isaku Yamahata
On Tue, Nov 02, 2010 at 02:57:12PM +0200, Michael S. Tsirkin wrote: > > +pcie_add_capability(dev, PCI_EXT_CAP_ID_ERR, PCI_ERR_VER, > > +offset, PCI_ERR_SIZEOF); > > +exp = &dev->exp; > > +exp->aer_cap = offset; > > +if (dev->exp.aer_log.log_max == PCIE_AER_LO

[Qemu-devel] [PATCH v8 09/11] ioh3420: support aer

2010-11-14 Thread Isaku Yamahata
Add aer support. Signed-off-by: Isaku Yamahata --- hw/ioh3420.c | 51 +-- 1 files changed, 45 insertions(+), 6 deletions(-) diff --git a/hw/ioh3420.c b/hw/ioh3420.c index 3cc129f..4eecf2f 100644 --- a/hw/ioh3420.c +++ b/hw/ioh3420.c @@ -36,25 +3

[Qemu-devel] [PATCH v8 07/11] pci: introduce a parser for pci device path

2010-11-14 Thread Isaku Yamahata
introduce a function to parse pci device path of the format, [Domain:]Slot.Function:Slot.Function:Slot.Function. Signed-off-by: Isaku Yamahata --- hw/pci.c | 87 ++ hw/pci.h |1 + 2 files changed, 88 insertions(+), 0 deletions

[Qemu-devel] [PATCH v8 04/11] pci: clean up of pci status register

2010-11-14 Thread Isaku Yamahata
This patch refine the initialization/reset of pci status registers. Signed-off-by: Isaku Yamahata --- hw/pci.c | 41 +++-- 1 files changed, 39 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 52fe655..fba765b 100644 --- a/hw/pci.c +++ b/

[Qemu-devel] [PATCH v8 02/11] pci: clean up pci command register io/memory bit initialization

2010-11-14 Thread Isaku Yamahata
This patch fixes the initialization of io/memory bit of command register. Those bits for type 1 device is RW. Those bits for type 0 device is RO = 0 if it has no io/memory BAR RW if it has io/memory BAR Signed-off-by: Isaku Yamahata --- hw/pci.c | 20 +--- 1 files changed,

[Qemu-devel] [PATCH v8 01/11] pci: revise pci command register initialization

2010-11-14 Thread Isaku Yamahata
This patch cleans up command register initialization with comments. Signed-off-by: Isaku Yamahata --- hw/pci.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 962886e..b70a568 100644 --- a/hw/pci.c +++ b

[Qemu-devel] [PATCH v8 03/11] pci: fix accesses to pci status register

2010-11-14 Thread Isaku Yamahata
pci status register is 16 bit, not 8 bit. So use helper function to manipulate status register. Signed-off-by: Isaku Yamahata --- hw/pci.c | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 2fc8ab1..52fe655 100644 --- a/hw/pci.

[Qemu-devel] [PATCH v8 10/11] x3130/upstream: support aer

2010-11-14 Thread Isaku Yamahata
add aer support. Signed-off-by: Isaku Yamahata --- hw/xio3130_upstream.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/xio3130_upstream.c b/hw/xio3130_upstream.c index d9d637f..29bc814 100644 --- a/hw/xio3130_upstream.c +++ b/hw/xio3130_upstream.c @@ -41,

[Qemu-devel] [PATCH v8 00/11] pcie port switch emulators

2010-11-14 Thread Isaku Yamahata
Here is v8 of the pcie switch emulators patch. This is for qemu main tree. Patch description: The patch series adds pcie/aer functionality to the pcie port emulators and adds new qemu command to inject aer into the guest. Changes v7 -> v8: - Added command to the forward declaration. - revise pci

Re:Re: [Qemu-devel] How to make shadow memory for a process? and how to trace the data propation from the instruction level in QEMU?

2010-11-14 Thread F. Zhang
>Please consider it a casual user trying to share simple ideas with you I am very pleased to share ideas with you. But my English is too poor, er…, I’ll try my best to make it clear.J > >Just before it goes too far, have you check quite similar project >which is Argos (http://www.fe

[Qemu-devel] Re: [PATCH] pci: split config update for dev assignment

2010-11-14 Thread Alex Williamson
On Sat, 2010-11-13 at 23:21 +0200, Michael S. Tsirkin wrote: > Device assignment in qemu-kvm wants to update > config array without any side-efects. > Make it easier to do so. This isn't exactly true. The change is a side-effect of qemu-kvm capability support currently being broken wrt wmask. De

[Qemu-devel] Re: [PATCH v2 9/9] pci: Store capability offsets in PCIDevice

2010-11-14 Thread Alex Williamson
On Sat, 2010-11-13 at 23:05 +0200, Michael S. Tsirkin wrote: > On Fri, Nov 12, 2010 at 10:47:21AM -0700, Alex Williamson wrote: > > This not only makes pci_find_capability a directly lookup, but also > > allows us to better track added capabilities and avoids the proliferation > > of random additio

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Kevin O'Connor
On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > +/* > + * This function returns device list as an array in a below format: > + * +-+-+---+-+---+-- > + * | n | l1 | devpath1| l2 | devpath2 | ... > + * +-+-+---+---

[Qemu-devel] Re: [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-14 Thread Chris Wright
* Hidetoshi Seto (seto.hideto...@jp.fujitsu.com) wrote: > This patch introduce a fallback mechanism for old systems that do not > support utimensat(). This fix build failure with following warnings: > > hw/virtio-9p-local.c: In function 'local_utimensat': > hw/virtio-9p-local.c:479: warning: impl

[Qemu-devel] Re: [PATCH] pci: allow hotplug removal of cold-plugged devices

2010-11-14 Thread Isaku Yamahata
Thank you for catching pcie part. The following fix is necessary. diff --git a/hw/pcie.c b/hw/pcie.c index 4df48b8..f461c1c 100644 --- a/hw/pcie.c +++ b/hw/pcie.c @@ -221,7 +221,7 @@ static int pcie_cap_slot_hotplug(DeviceState *qdev, */ assert(PCI_FUNC(pci_dev->devfn) == 0); -if

[Qemu-devel] [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-14 Thread Hidetoshi Seto
This patch introduce a fallback mechanism for old systems that do not support utimensat(). This fix build failure with following warnings: hw/virtio-9p-local.c: In function 'local_utimensat': hw/virtio-9p-local.c:479: warning: implicit declaration of function 'utimensat' hw/virtio-9p-local.c:479:

Re: [Qemu-devel] Re: [PATCH] virtio-9p: fix build on !CONFIG_UTIMENSAT v2

2010-11-14 Thread Hidetoshi Seto
(2010/11/14 14:58), Chris Wright wrote: > * Hidetoshi Seto (seto.hideto...@jp.fujitsu.com) wrote: >> +/* >> + * Fallback: use utimes() instead of utimensat(). >> + * See commit 74bc02b2d2272dc88fb98d43e631eb154717f517 for known >> problem. >> + */ >> +struct timeval tv[2]; >> +

[Qemu-devel] Re: [PATCH] pci: allow hotplug removal of cold-plugged devices

2010-11-14 Thread Isaku Yamahata
Looks good. Thank you for catching pcie case. On Sun, Nov 14, 2010 at 04:18:04PM +0200, Michael S. Tsirkin wrote: > This patch fixes 5beb8ad503c88a76f2b8106c3b74b4ce485a60e1 > which broke hotplug removal of cold plugged devices: > > - pass addition/removal state to hotplug callbacks > - use that

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.c |   14 ++ >  hw/fw_cfg.h |    4 +++- >  sysemu.h    |    1 + >  vl.c        |   51 +++ >  4 files changed, 69 insertions(+), 1 dele

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 09:13:03PM +, Blue Swirl wrote: > On Sun, Nov 14, 2010 at 8:54 PM, Michael S. Tsirkin wrote: > > On Sun, Nov 14, 2010 at 08:49:59PM +, Blue Swirl wrote: > >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > >> > > >> > Signed-off-by: Gleb Natapov > >> > ---

[Qemu-devel] [Bug 668799] Re: qemu-arm segfaults executing msgmerge (gettext)

2010-11-14 Thread Jan-Simon Möller
To me it looks like racy/double lockings. We already lock meantime before some functions up the code-path of cpu_unlink_tb . IMHO the spinlock in cpu_unlink_tb is now unnecessary - at least in this code- path. Maybe we exit the cpu before the previous/upper lock is released. HTH, have phun! -- qe

[Qemu-devel] [Bug 668799] Re: qemu-arm segfaults executing msgmerge (gettext)

2010-11-14 Thread Jan-Simon Möller
See linux-user/main.c function start_exclusive. -- qemu-arm segfaults executing msgmerge (gettext) https://bugs.launchpad.net/bugs/668799 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Bug description: upstream q

[Qemu-devel] Re: [PATCHv4 13/15] Add bootindex for option roms.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > Extend -option-rom command to have additional parameter ,bootindex=. This patch is broken: CCarm-softmmu/palm.o /src/qemu/hw/palm.c: In function 'palmte_init': /src/qemu/hw/palm.c:237: error: incompatible type for argument 1 of 'get_ima

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 8:54 PM, Michael S. Tsirkin wrote: > On Sun, Nov 14, 2010 at 08:49:59PM +, Blue Swirl wrote: >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: >> > >> > Signed-off-by: Gleb Natapov >> > --- >> >  hw/fw_cfg.c |   14 ++ >> >  hw/fw_cfg.h |    4 +++- >>

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 08:52:37PM +0200, Gleb Natapov wrote: > > > + > > > +len = strlen(bootpath); > > > +list = qemu_realloc(list, total + len + 1); > > > +list[total++] = len; > > > +memcpy(&list[total], bootpath, len); > > > +total += len; > > > +

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 08:52:37PM +0200, Gleb Natapov wrote: > On Sun, Nov 14, 2010 at 08:41:37PM +0200, Michael S. Tsirkin wrote: > > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > > > > > Signed-off-by: Gleb Natapov > > > --- > > > hw/fw_cfg.c | 14 ++ > > > h

[Qemu-devel] [Bug 668799] Re: qemu-arm segfaults executing msgmerge (gettext)

2010-11-14 Thread Peter Maydell
Thanks for the test case. I can confirm that I can reproduce this. (Detail: compiled with "gcc -fopenmp 668799.c -o 668799 -static" on an Ubuntu maverick ARM system. qemu-arm-user on x86-64 then segfaults when run with "OMP_NUM_THREADS=6 ./arm-linux-user/qemu-arm /tmp/668799".) The point when it

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 08:49:59PM +, Blue Swirl wrote: > On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > >  hw/fw_cfg.c |   14 ++ > >  hw/fw_cfg.h |    4 +++- > >  sysemu.h    |    1 + > >  vl.c        |   51

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.c |   14 ++ >  hw/fw_cfg.h |    4 +++- >  sysemu.h    |    1 + >  vl.c        |   51 +++ >  4 files changed, 69 insertions(+), 1 dele

Re: [Qemu-devel] [PATCH 00/14] preparation for autoconfy configure script

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 11:48 AM, Paolo Bonzini wrote: > This is part two of the configure series.  It does various miscellaneous > changes to the configure script that make it possible to later handle > an autoconfy command-line. > > Compared to the first submission, I simplified further the hand

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Gleb Natapov
On Sun, Nov 14, 2010 at 08:41:37PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > > hw/fw_cfg.c | 14 ++ > > hw/fw_cfg.h |4 +++- > > sysemu.h|1 + > > vl.c| 51 +++

[Qemu-devel] Re: [PATCHv4 08/15] Add get_fw_dev_path callback for pci bus.

2010-11-14 Thread Gleb Natapov
On Sun, Nov 14, 2010 at 08:27:20PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 14, 2010 at 05:39:34PM +0200, Gleb Natapov wrote: > > +static char *pcibus_get_fw_dev_path(DeviceState *dev) > > +{ > > +PCIDevice *d = (PCIDevice *)dev; > > +char path[50], name[33]; > > +int off; > > + >

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- > hw/fw_cfg.c | 14 ++ > hw/fw_cfg.h |4 +++- > sysemu.h|1 + > vl.c| 51 +++ > 4 files changed, 69 insertions(+

[Qemu-devel] Re: [PATCHv4 08/15] Add get_fw_dev_path callback for pci bus.

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 05:39:34PM +0200, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- > hw/pci.c | 108 - > 1 files changed, 85 insertions(+), 23 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 962886e..114b435

[Qemu-devel] [Bug 670883] Re: ARM : ldrexd and strexd implementation flawed

2010-11-14 Thread Peter Maydell
I sent a patch for this to the list: http://patchwork.ozlabs.org/patch/70149/ -- ARM : ldrexd and strexd implementation flawed https://bugs.launchpad.net/bugs/670883 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New B

Re: [Qemu-devel] [PATCH] ARM: semi-hosting support for stderr

2010-11-14 Thread Peter Maydell
On 19 August 2010 16:11, Christophe Lyon wrote: > On 25.06.2010 17:44, Christophe LYON wrote: >> I propose this small patch so that ARM semi-hosting handles stderr as >> expected when linking with Newlib/libgloss. Apologies for this rather belated reply, but I only recently managed to confirm the

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-11-14 Thread Peter Maydell
On 4 November 2010 22:21, Adam Lackorzynski wrote: > > Refine check on bkpt so that smc and undefined instruction encodings are > handled as an undefined instruction and trap. > > Signed-off-by: Adam Lackorzynski This patch looks good to me. I note that there's actually an implementation of SMC

[Qemu-devel] [PATCHv4 13/15] Add bootindex for option roms.

2010-11-14 Thread Gleb Natapov
Extend -option-rom command to have additional parameter ,bootindex=. Signed-off-by: Gleb Natapov --- hw/loader.c| 16 +++- hw/loader.h|8 hw/multiboot.c |3 ++- hw/ne2000.c|2 +- hw/nseries.c |2 +- hw/pc.c|7 --- hw/pci.c

[Qemu-devel] [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-14 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/fw_cfg.c | 14 ++ hw/fw_cfg.h |4 +++- sysemu.h|1 + vl.c| 51 +++ 4 files changed, 69 insertions(+), 1 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index 7b9434f..f6a67

[Qemu-devel] [PATCHv4 11/15] Add bootindex parameter to net/block/fd device

2010-11-14 Thread Gleb Natapov
If bootindex is specified on command line a string that describes device in firmware readable way is added into sorted list. Later this list will be passed into firmware to control boot order. Signed-off-by: Gleb Natapov --- block_int.h |4 +++- hw/e1000.c |4 hw/eepro100.c

[Qemu-devel] [PATCHv4 14/15] Add notifier that will be called when machine is fully created.

2010-11-14 Thread Gleb Natapov
Action that depends on fully initialized device model should register with this notifier chain. Signed-off-by: Gleb Natapov --- sysemu.h |2 ++ vl.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index 48f8eee..c42f33a 100644 -

[Qemu-devel] [PATCHv4 01/15] Introduce fw_name field to DeviceInfo structure.

2010-11-14 Thread Gleb Natapov
Add "fw_name" to DeviceInfo to use in device path building. In contrast to "name" "fw_name" should refer to functionality device provides instead of particular device model like "name" does. Signed-off-by: Gleb Natapov --- hw/fdc.c|1 + hw/ide/isa.c|1 + hw/ide/qdev.c |

[Qemu-devel] [PATCHv4 08/15] Add get_fw_dev_path callback for pci bus.

2010-11-14 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/pci.c | 108 - 1 files changed, 85 insertions(+), 23 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 962886e..114b435 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -43,12 +43,14 @@ static void pcibu

[Qemu-devel] [PATCHv4 10/15] Add get_dev_path callback for usb bus.

2010-11-14 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/usb-bus.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 256b881..8b4583c 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -5,11 +5,13 @@ #include "monitor.h"

[Qemu-devel] [PATCHv4 03/15] Keep track of ISA ports ISA device is using in qdev.

2010-11-14 Thread Gleb Natapov
Store all io ports used by device in ISADevice structure. Signed-off-by: Gleb Natapov --- hw/cs4231a.c |1 + hw/fdc.c |3 +++ hw/gus.c |4 hw/ide/isa.c |2 ++ hw/isa-bus.c | 25 + hw/isa.h |4 hw/m48t59.c

[Qemu-devel] [PATCHv4 06/15] Add get_fw_dev_path callback to IDE bus.

2010-11-14 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/ide/qdev.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 88ff657..01a181b 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -24,9 +24,12 @@ /* - */

[Qemu-devel] [PATCHv4 09/15] Record which USBDevice USBPort belongs too.

2010-11-14 Thread Gleb Natapov
Ports on root hub will have NULL here. This is needed to reconstruct path from device to its root hub to build device path. Signed-off-by: Gleb Natapov --- hw/usb-bus.c |3 ++- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |2 +- hw/usb-uhci.c |2 +- hw/usb.h

[Qemu-devel] [PATCHv4 05/15] Store IDE bus id in IDEBus structure for easy access.

2010-11-14 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/ide/cmd646.c |4 ++-- hw/ide/internal.h |3 ++- hw/ide/isa.c |2 +- hw/ide/piix.c |4 ++-- hw/ide/qdev.c |3 ++- hw/ide/via.c |4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/ide/cmd646.c b/

[Qemu-devel] [PATCHv4 07/15] Add get_dev_path callback for system bus.

2010-11-14 Thread Gleb Natapov
Prints out mmio or pio used to access child device. Signed-off-by: Gleb Natapov --- hw/pci_host.c |2 ++ hw/sysbus.c | 30 ++ hw/sysbus.h |4 3 files changed, 36 insertions(+), 0 deletions(-) diff --git a/hw/pci_host.c b/hw/pci_host.c index bc5b771

[Qemu-devel] [PATCHv4 00/15] boot order specification

2010-11-14 Thread Gleb Natapov
This is current state of the patch series for people to comment on. I am using open firmware naming scheme to specify device path names. In this submission I addressed all comment from previous one and added option rom support and rebased to qemu upstream. Kevin can you double check that the names

[Qemu-devel] [PATCHv4 12/15] Change fw_cfg_add_file() to get full file path as a parameter.

2010-11-14 Thread Gleb Natapov
Change fw_cfg_add_file() to get full file path as a parameter instead of building one internally. Two reasons for that. First caller may need to know how file is named. Second this moves policy of file naming out from fw_cfg. Platform may want to use more then two levels of directories for instance

[Qemu-devel] [PATCHv4 04/15] Add get_fw_dev_path callback to ISA bus in qdev.

2010-11-14 Thread Gleb Natapov
Use device ioports to create unique device path. Signed-off-by: Gleb Natapov --- hw/isa-bus.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index c0ac7e9..c423c1b 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -31,11 +31,13

[Qemu-devel] [PATCHv4 02/15] Introduce new BusInfo callback get_fw_dev_path.

2010-11-14 Thread Gleb Natapov
New get_fw_dev_path callback will be used for build device path usable by firmware in contrast to qdev qemu internal device path. Signed-off-by: Gleb Natapov --- hw/qdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index 9f90efe..dc669b3 10064

Re: [Qemu-devel] [PATCH 11/14] assume existence of "ln -sf"

2010-11-14 Thread Paolo Bonzini
On 11/14/2010 03:39 PM, Blue Swirl wrote: > The code in this patch was introduced for a Solaris port, but > ln -sf exists in Solaris 2.6 at least. The problem is not that 'ln -sf' would not exist, but rather that the force of the '-f' flag is too weak to actually remove anything. Oh well...

Re: [Qemu-devel] [PATCH 11/14] assume existence of "ln -sf"

2010-11-14 Thread Blue Swirl
On Sun, Nov 14, 2010 at 11:48 AM, Paolo Bonzini wrote: > The code in this patch was introduced for a Solaris port, but > ln -sf exists in Solaris 2.6 at least. The problem is not that 'ln -sf' would not exist, but rather that the force of the '-f' flag is too weak to actually remove anything.

[Qemu-devel] Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filteringlogin register about

2010-11-14 Thread Dragos Tatulea
I'd like to pick up this patch and rework it based on your suggestions. Need it for [1]. Most opinions seem to be pointing to a generic software mac filtering in the VLAN layer with hw support if necessary. Here's what I had in mind: - For the generic mac filtering we can use something similar to V

[Qemu-devel] [PATCH] pci: allow hotplug removal of cold-plugged devices

2010-11-14 Thread Michael S. Tsirkin
This patch fixes 5beb8ad503c88a76f2b8106c3b74b4ce485a60e1 which broke hotplug removal of cold plugged devices: - pass addition/removal state to hotplug callbacks - use that in piix and pcie This also fixes an assert on hotplug removal of coldplugged express devices. Reported-by: by Cam Macdonell

Re: [Qemu-devel] [PATCH] make trace options use autoconfy names

2010-11-14 Thread Paolo Bonzini
On 11/14/2010 02:38 PM, Andreas Färber wrote: - --trace-file=*) trace_file="$optarg" + --enable-trace-file=*) trace_file="$optarg" ;; but this should be --with-trace-file=... please. It is not being enabled, just set to a different value. --with-* should be reserved for library paths, but I c

Re: [Qemu-devel] [PATCH] make trace options use autoconfy names

2010-11-14 Thread Andreas Färber
Am 14.11.2010 um 12:50 schrieb Paolo Bonzini: These are not in any release, so I am splitting them off the other patch for autoconfy command line and not introducing deprecation. Signed-off-by: Paolo Bonzini --- configure |8 1 files changed, 4 insertions(+), 4 deletions(-) diff -

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-14 Thread Avi Kivity
On 11/14/2010 01:05 PM, Avi Kivity wrote: I agree, but let's enable virtio-ioeventfd carefully because bad code is out there. Sure. Note as long as the thread waiting on ioeventfd doesn't consume too much cpu, it will awaken quickly and we won't have the "transaction per timeslice" effect.

[Qemu-devel] [PATCH 13/14] move --srcdir detection earlier

2010-11-14 Thread Paolo Bonzini
This will help getting config.guess and config.sub from the srcdir. Signed-off-by: Paolo Bonzini --- configure | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/configure b/configure index e667b12..4412234 100755 --- a/configure +++ b/configure @@ -69,6 +69,7 @@

[Qemu-devel] [PATCH 12/14] simplify source_path handling

2010-11-14 Thread Paolo Bonzini
source_path_used is not necessary since we use mkdir -p and test -f. Also, dirname returns "." if a path has no directory component, as is the case for "sh configure". Signed-off-by: Paolo Bonzini --- configure | 45 - 1 files changed, 16 insertions

[Qemu-devel] [PATCH 11/14] assume existence of "ln -sf"

2010-11-14 Thread Paolo Bonzini
The code in this patch was introduced for a Solaris port, but ln -sf exists in Solaris 2.6 at least. Signed-off-by: Paolo Bonzini --- configure | 19 +-- 1 files changed, 5 insertions(+), 14 deletions(-) diff --git a/configure b/configure index 2d2d306..5a3b127 100755 --- a/co

[Qemu-devel] [PATCH 10/14] reorganize sdl-config tests

2010-11-14 Thread Paolo Bonzini
This also allows overriding it with SDL_CONFIG, and warning in suspicious cross-compilation scenarios. Signed-off-by: Paolo Bonzini --- configure | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/configure b/configure index 4556a1d..2d2d306 10075

[Qemu-devel] [PATCH 14/14] remove HOST_CC mention from roms/{sea, vga}bios/config.mak

2010-11-14 Thread Paolo Bonzini
Not used in the submodules. Signed-off-by: Paolo Bonzini --- configure |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 4412234..4cc3754 100755 --- a/configure +++ b/configure @@ -3113,7 +3113,6 @@ for rom in seabios vgabios ; do echo "CPP

[Qemu-devel] [PATCH 06/14] do not pass bogus $(SRC_PATH) include paths to cc during configure

2010-11-14 Thread Paolo Bonzini
Non-existent -I paths are dropped silently by the compiler, but still it is not polite to pass bogus options. Configure-time tests do not need any include files from the source path, so only include -I flags at make time (when they're properly expanded). Signed-off-by: Paolo Bonzini --- configu

[Qemu-devel] [PATCH 09/14] do not default to non-prefixed pkg-config when cross compiling

2010-11-14 Thread Paolo Bonzini
This can still be requested with PKG_CONFIG=/path/to/pkg-config. Just do not use it as a default, and print a warning. Signed-off-by: Paolo Bonzini --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 5ec1069..4556a1d 100755 --- a/

[Qemu-devel] [PATCH 05/14] test cc with the complete set of chosen flags

2010-11-14 Thread Paolo Bonzini
The "test the C compiler works ok" comes before a bunch of flags are added for --cpu or just depending on the host. It helps debugging if the test is done after these flags are (unconditionally) added. Signed-off-by: Paolo Bonzini --- configure | 50 +--

[Qemu-devel] [PATCH 08/14] fix spelling of $pkg_config, move default together with other cross tools

2010-11-14 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/configure b/configure index 1bc9b85..5ec1069 100755 --- a/configure +++ b/configure @@ -207,6 +207,7 @@ objcopy="${cross_prefix}${OBJCOPY-objcopy}

[Qemu-devel] [PATCH] make trace options use autoconfy names

2010-11-14 Thread Paolo Bonzini
These are not in any release, so I am splitting them off the other patch for autoconfy command line and not introducing deprecation. Signed-off-by: Paolo Bonzini --- configure |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 50fb3cd..4e7

[Qemu-devel] [PATCH 04/14] fix sparse support (?)

2010-11-14 Thread Paolo Bonzini
I didn't test with sparse, but the old code using += before a variable was set was wrong. Sparse support should probably be ripped out or redone, but this at least keeps some sanity. Signed-off-by: Paolo Bonzini --- configure | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH 03/14] move feature variables to the top

2010-11-14 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 160 ++-- 1 files changed, 80 insertions(+), 80 deletions(-) diff --git a/configure b/configure index 856f694..3ed0bc0 100755 --- a/configure +++ b/configure @@ -86,6 +86,86 @@ audio_pt_int=""

[Qemu-devel] [PATCH 07/14] provide portable HOST_LONG_BITS test

2010-11-14 Thread Paolo Bonzini
Do not hardcode the list of 64-bit CPUs. Use sizeof(void *) to compute it. Renaming it to HOST_LONG_BITS to HOST_POINTER_BITS is left for later. Signed-off-by: Paolo Bonzini --- configure | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/configure b/config

[Qemu-devel] [PATCH 02/14] default make and install to environment variables

2010-11-14 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 756d72e..856f694 100755 --- a/configure +++ b/configure @@ -79,8 +79,6 @@ audio_card_list="ac97 es1370 sb16" audio_possible_cards="ac

[Qemu-devel] [PATCH 01/14] default compilation tools to environment variables

2010-11-14 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 20 +++- 1 files changed, 7 insertions(+), 13 deletions(-) diff --git a/configure b/configure index f62c1fe..756d72e 100755 --- a/configure +++ b/configure @@ -74,19 +74,13 @@ interp_prefix="/usr/gnemul/qemu-%M" static="no" sparc_c

[Qemu-devel] [PATCH 00/14] preparation for autoconfy configure script

2010-11-14 Thread Paolo Bonzini
This is part two of the configure series. It does various miscellaneous changes to the configure script that make it possible to later handle an autoconfy command-line. Compared to the first submission, I simplified further the handling of srcdir (patches 11 to 13). Paolo Bonzini (14): default

[Qemu-devel] [Bug 673613] Re: ARM semihosting SYS_GET_CMDLINE does not return arguments

2010-11-14 Thread Peter Maydell
I see this bug has been reported before, for instance here: http://www.mail-archive.com/qemu-devel@nongnu.org/msg29250.html and Laurent Desnogues noticed the problem while reviewing a patch in this area: http://www.mail-archive.com/qemu-devel@nongnu.org/msg22251.html The only code which looks at t

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-14 Thread Avi Kivity
On 11/14/2010 12:37 PM, Stefan Hajnoczi wrote: On Sun, Nov 14, 2010 at 10:34 AM, Avi Kivity wrote: > On 11/12/2010 11:20 AM, Stefan Hajnoczi wrote: >> >> >Who guarantees that less common virtio-blk and virtio-net guest drivers >> >for non-Linux OSes are fine with it? Maybe you should

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-14 Thread Stefan Hajnoczi
On Sun, Nov 14, 2010 at 10:34 AM, Avi Kivity wrote: > On 11/12/2010 11:20 AM, Stefan Hajnoczi wrote: >> >> >  Who guarantees that less common virtio-blk and virtio-net guest drivers >> >  for non-Linux OSes are fine with it?  Maybe you should add a feature >> > flag >> >  that the guest has to ACK

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-14 Thread Avi Kivity
On 11/12/2010 11:20 AM, Stefan Hajnoczi wrote: > Who guarantees that less common virtio-blk and virtio-net guest drivers > for non-Linux OSes are fine with it? Maybe you should add a feature flag > that the guest has to ACK to enable it. Virtio-blk and virtio-net are fine. Both of those dev

[Qemu-devel] Re: Cannot not unplug cold-plugged devices

2010-11-14 Thread Michael S. Tsirkin
On Sun, Nov 14, 2010 at 11:57:52AM +0900, Isaku Yamahata wrote: > On Sat, Nov 13, 2010 at 10:59:15PM +0200, Michael S. Tsirkin wrote: > > On Fri, Nov 12, 2010 at 09:50:30PM +0900, Isaku Yamahata wrote: > > > On Fri, Nov 12, 2010 at 01:26:30PM +0200, Michael S. Tsirkin wrote: > > > > No, I am just t

Re: [Qemu-devel] How to make shadow memory for a process? and how to trace the data propation from the instruction level in QEMU?

2010-11-14 Thread Mulyadi Santosa
Hi Zhang... Please consider it a casual user trying to share simple ideas with you 2010/11/14 F. Zhang : > Hi, > > I am a newbie of QEMU. I want to use the QEMU for the dynamic analysis of > malware, usually called “taint analysis”. Just before it goes too far, have you check quite similar p