On Wed, Jan 13, 2010 at 05:58:35PM -0600, Anthony Liguori wrote:
> On 01/12/2010 10:51 PM, Kevin O'Connor wrote:
>> On Tue, Jan 12, 2010 at 01:43:47PM -0600, Anthony Liguori wrote:
>>
>>> Hi,
>>>
>>> I'm ready to cut another qemu stable release and I'm contemplating
>>> whether to update to 0.5
On (Wed) Jan 13 2010 [19:08:11], Blue Swirl wrote:
>
> Thanks. I fixed the warnings related to Sparc32. Were there really no
> new warnings for Sparc64?
Looks like it; vl.c gets reported three times at the same locations so 3
arches have been compiled.
My test machine is down ATM, I can confirm
On 01/13/2010 07:11 PM, malc wrote:
> On Wed, 13 Jan 2010, Cole Robinson wrote:
>
>> Current CDROM detection is hardcoded based on source file name.
>> Make this smarter by attempting a CDROM specific ioctl.
>>
>> This makes '-cdrom /dev/sr0' succeed with no media present.
>>
>> v2:
>> Give io
On Wed, 13 Jan 2010, Cole Robinson wrote:
> Current CDROM detection is hardcoded based on source file name.
> Make this smarter by attempting a CDROM specific ioctl.
>
> This makes '-cdrom /dev/sr0' succeed with no media present.
>
> v2:
> Give ioctl check higher priority than filename check
Markus Armbruster wrote:
> It should be optional if we want to support clients that don't want it.
> I don't think coping with it would be a terrible burden on clients, but
> neither is having to ask for it. Personally, I'd make it optional.
It wouldn't be a terrible burden, but it'll be easier t
On 01/12/2010 10:51 PM, Kevin O'Connor wrote:
On Tue, Jan 12, 2010 at 01:43:47PM -0600, Anthony Liguori wrote:
Hi,
I'm ready to cut another qemu stable release and I'm contemplating
whether to update to 0.5.1 in stable. Generally speaking, we try to
limit stable to bug fixes and changes th
Current legacy floppy detection is hardcoded based on source file
name. Make this smarter by attempting a floppy specific ioctl.
v2:
Give ioctl check higher priority than filename check
s/IDE/legacy/
v3:
Actually initialize 'prio' variable
Check for ioctl success rather than absen
Current CDROM detection is hardcoded based on source file name.
Make this smarter by attempting a CDROM specific ioctl.
This makes '-cdrom /dev/sr0' succeed with no media present.
v2:
Give ioctl check higher priority than filename check,
v3:
Actually initialize 'prio' variable
Check
On 01/13/2010 06:07 PM, Anthony Liguori wrote:
> On 01/12/2010 09:29 AM, Cole Robinson wrote:
>> Current legacy floppy detection is hardcoded based on source file
>> name. Make this smarter by attempting a floppy specific ioctl.
>>
>> v2: Give ioctl check higher priority than filename check,
>>
Christoph Hellwig wrote:
> On Tue, Jan 12, 2010 at 10:29:11AM -0500, Cole Robinson wrote:
> > static int cdrom_probe_device(const char *filename)
> > {
> > +int fd, ret, prio;
> > +
> > if (strstart(filename, "/dev/cd", NULL))
> > -return 100;
> > -return 0;
> > +prio
On 12/17/2009 10:19 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
Applied. Thanks.
Regards,
Anthony Liguori
---
I took the liberty to create docs/. Existing documentation should move
there, but I left that for another day, because I want to get this file
out.
docs/qd
On 01/13/2010 09:20 AM, Kevin Wolf wrote:
Commit 3a03bfa5 added a fallback in case the Linux kernel running qemu is older
than the kernel of the build system. Unfortunately, v1 was committed instead of
v2, so the code has a bug that was revealed in the review (checking for the
wrong error code).
On 01/13/2010 07:25 AM, Gleb Natapov wrote:
Initialize KVM paravirt cpuid leaf and allow user to control guest
visible PV features through -cpu flag.
Signed-off-by: Gleb Natapov
Applied. Thanks.
Regards,
Anthony Liguori
---
v1->v2
fix indentation
remove unneeded ifdefs
v2->v3
On 01/13/2010 07:05 AM, Paolo Bonzini wrote:
Move 200 lines out of vl.c already into common code that only needs to
be compiled once.
Signed-off-by: Paolo Bonzini
Applied. Thanks.
Regards,
Anthony Liguori
---
Makefile.objs |2 +-
input.c | 238
On 01/13/2010 06:30 AM, Christoph Hellwig wrote:
As pointed out by clang size is only ever written to, but never actually
used.
Signed-off-by: Christoph Hellwig
Applied. Thanks.
Regards,
Anthony Liguori
Index: qemu/hw/virtio-blk.c
===
On 01/13/2010 04:54 AM, Amit Shah wrote:
clang-analyzer pointed out the value of 'sockets' is never reused.
Signed-off-by: Amit Shah
CC: Andre Przywara
Applied. Thanks.
Regards,
Anthony Liguori
---
vl.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/vl
On 01/13/2010 02:52 AM, Paolo Bonzini wrote:
Since pkgconfig can give different output for different targets,
it should be tried with the cross-compilation prefix first.
Signed-off-by: Paolo Bonzini
Applied all. Thanks.
Regards,
Anthony Liguori
---
configure | 19 ++---
On 01/12/2010 06:49 AM, Christoph Hellwig wrote:
The backing device is only modified from bdrv_commit. So instead of
flushing it every time bdrv_flush is called for the front-end device
only flush it after we're written data to it in bdrv_commit.
Signed-off-by: Christoph Hellwig
Applied.
On 01/12/2010 05:55 AM, Kevin Wolf wrote:
If an image references a backing file that doesn't exist, qemu-img info fails
to open this image. Exactly in this case the info would be valuable, though:
the user might want to find out which file is missing.
This patch introduces a BDRV_O_NO_BACKING fl
On 01/07/2010 06:39 AM, Milan Plzik wrote:
According to RFC 1350 and RFC 2347, TFTP server should answer RRQ by
either OACK or DATA packet. Qemu's internal TFTP server answers RRQ with
additional options by sending both OACK and DATA packet, thus breaking
the "lock-step" feature of the protoco
On 01/12/2010 09:29 AM, Cole Robinson wrote:
Current legacy floppy detection is hardcoded based on source file
name. Make this smarter by attempting a floppy specific ioctl.
v2: Give ioctl check higher priority than filename check,
s/IDE/legacy/
Signed-off-by: Cole Robinson
---
block/raw
From: Igor V. Kovalenko
Currently we do not implement VLAN tagging for rtl8139(C+),
still data is read from ring buffer headers.
- augment unused assignment with TODO item
- cast txdw1 to void for now
Signed-off-by: Igor V. Kovalenko
---
hw/rtl8139.c |5 +
1 files changed, 5 insertion
On Tue, Jan 12, 2010 at 12:53 PM, Jan Kiszka wrote:
> Since kvm-kmod-2.6.32.2 we have an alternative source for recent KVM
> kernel headers. Use it when available and not overruled by --kerneldir.
>
Would it be possible to turn this into a configure option? Such that I
could say ./configure --wit
On Wed, Jan 13, 2010 at 04:24:43PM +0530, Amit Shah wrote:
> clang-analyzer points out value assigned to 'len' is not used.
>
> Signed-off-by: Amit Shah
Acked-by: Michael S. Tsirkin
> ---
> hw/virtio-net.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/virt
On 13.01.2010, at 20:37, Blue Swirl wrote:
> On Wed, Jan 13, 2010 at 7:17 PM, Alexander Graf wrote:
>>
>> On 13.01.2010, at 19:47, Blue Swirl wrote:
>>
>>> On Tue, Jan 12, 2010 at 10:11 PM, Alexander Graf wrote:
On 12.01.2010, at 21:52, Blue Swirl wrote:
> On Tue, Jan 12,
On Wed, Jan 13, 2010 at 7:17 PM, Alexander Graf wrote:
>
> On 13.01.2010, at 19:47, Blue Swirl wrote:
>
>> On Tue, Jan 12, 2010 at 10:11 PM, Alexander Graf wrote:
>>>
>>> On 12.01.2010, at 21:52, Blue Swirl wrote:
>>>
On Tue, Jan 12, 2010 at 8:34 PM, Alexander Graf wrote:
>
> On 12.
On 13.01.2010, at 19:47, Blue Swirl wrote:
> On Tue, Jan 12, 2010 at 10:11 PM, Alexander Graf wrote:
>>
>> On 12.01.2010, at 21:52, Blue Swirl wrote:
>>
>>> On Tue, Jan 12, 2010 at 8:34 PM, Alexander Graf wrote:
On 12.01.2010, at 20:45, Blue Swirl wrote:
> On Tue, Jan 12,
On Wed, Jan 13, 2010 at 7:02 AM, Amit Shah wrote:
> On (Tue) Jan 12 2010 [19:35:08], Blue Swirl wrote:
>> On Tue, Jan 12, 2010 at 6:13 PM, Amit Shah wrote:
>> > Hello,
>> >
>> > Here's a run of the clang analyzer on qemu sources for the x86_64
>> > target.
>> >
>> > See
>> >
>> > http://amitshah.
On Wed, 13 Jan 2010 12:59:25 -0600
Adam Litke wrote:
> > > +/*
> > > + * complete_stats_request - Clean up and report statistics.
> > > + */
> > > +static void complete_stats_request(VirtIOBalloon *vb)
> > > +{
> > > +QObject *stats = get_stats_qobject(vb);
> > > +
> > > +if (vb->stats_re
On Wed, 2010-01-13 at 16:04 -0200, Luiz Capitulino wrote:
> I've tried to apply this patch to play with it, but turns out it conflicts
> with recent changes in hw/virtio-balloon.
Ahh, I will continue my never-ending quest to stay current :)
> Some comments on the QMP side of the patch follows.
On Tue, Jan 12, 2010 at 10:11 PM, Alexander Graf wrote:
>
> On 12.01.2010, at 21:52, Blue Swirl wrote:
>
>> On Tue, Jan 12, 2010 at 8:34 PM, Alexander Graf wrote:
>>>
>>> On 12.01.2010, at 20:45, Blue Swirl wrote:
>>>
On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf wrote:
> I'm trying
On 01/13/2010 06:49 AM, Michael S. Tsirkin wrote:
Please pull the following changes: eepro100 changes have been
out for a week without comments, and pci one seems
obvious.
Applied. Thanks.
Regards,
Anthony Liguori
The following changes since commit 72ff25e4e98d6dba9286d032b9ff5432553bb
On 01/13/2010 11:14 AM, Markus Armbruster wrote:
Anthony Liguori writes:
On 01/12/2010 01:16 AM, Amit Shah wrote:
BTW I don't really want this too, I can get rid of it if everyone agrees
we won't support clipboard writes> 4k over vnc or if there's a better
idea.
Why both
On Mon, 11 Jan 2010 13:09:35 -0600
Adam Litke wrote:
> After some good discussion, V6 of this patch integrates well with the new QMP
> support. When the monitor is in QMP mode, the query-balloon command triggers
> a
> stats refresh request to the guest. This request is asynchronous. If the
>
On Wed, 13 Jan 2010 18:38:57 +0100
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Wed, 13 Jan 2010 17:53:38 +0100
> > Markus Armbruster wrote:
> >
> >> Luiz Capitulino writes:
> [...]
> >> > I'm thinking in something like this:
> >> >
> >> > 1. Connection is made, the greeting m
Luiz Capitulino writes:
> On Wed, 13 Jan 2010 17:53:38 +0100
> Markus Armbruster wrote:
>
>> Luiz Capitulino writes:
[...]
>> > I'm thinking in something like this:
>> >
>> > 1. Connection is made, the greeting message is sent and QMP is
>> > in 'handshake mode'
>> >
>> > 2. In this mode only
Anthony Liguori writes:
> On 01/12/2010 01:16 AM, Amit Shah wrote:
>> BTW I don't really want this too, I can get rid of it if everyone agrees
>> we won't support clipboard writes> 4k over vnc or if there's a better
>> idea.
>>
>
> Why bother trying to preserve message boundaries? I think
On Wed, 13 Jan 2010 17:53:38 +0100
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Mon, 11 Jan 2010 18:24:24 -0600
> > Anthony Liguori wrote:
> >
> >> On 01/11/2010 06:04 PM, Luiz Capitulino wrote:
> >> >
> >> > As async messages were one of the reasons for having QMP, I thought
On 01/13/2010 10:23 AM, Gleb Natapov wrote:
Or do you mean making so that PV leaf will be available via
cpu_x86_cpuid()? This make sense, but lets do it after merging this
code path with qemu-kvm and the proposed patch brings qemu and
qemu-kvm close together.
Yes, that's what I meant, and y
Luiz Capitulino writes:
> On Mon, 11 Jan 2010 18:24:24 -0600
> Anthony Liguori wrote:
>
>> On 01/11/2010 06:04 PM, Luiz Capitulino wrote:
>> >
>> > As async messages were one of the reasons for having QMP, I thought
>> > that there was a consensus that making it part of the "original"
>> > pro
On Wed, Jan 13, 2010 at 06:14:54PM +0200, Gleb Natapov wrote:
> On Wed, Jan 13, 2010 at 10:05:33AM -0600, Anthony Liguori wrote:
> > >+#ifdef CONFIG_KVM_PARA
> > >+/* Paravirtualization CPUIDs */
> > >+memcpy(signature, "KVMKVMKVM\0\0\0", 12);
> > >+c =&cpuid_data.entries[cpuid_i++];
>
On Wed, Jan 13, 2010 at 10:05:33AM -0600, Anthony Liguori wrote:
> >+#ifdef CONFIG_KVM_PARA
> >+/* Paravirtualization CPUIDs */
> >+memcpy(signature, "KVMKVMKVM\0\0\0", 12);
> >+c =&cpuid_data.entries[cpuid_i++];
> >+memset(c, 0, sizeof(*c));
> >+c->function = KVM_CPUID_SIGNATUR
On 01/13/2010 07:25 AM, Gleb Natapov wrote:
Initialize KVM paravirt cpuid leaf and allow user to control guest
visible PV features through -cpu flag.
Signed-off-by: Gleb Natapov
---
v1->v2
fix indentation
remove unneeded ifdefs
v2->v3
added needed ifdefs (CONFIG_KVM_PARA)
diff --gi
Commit 3a03bfa5 added a fallback in case the Linux kernel running qemu is older
than the kernel of the build system. Unfortunately, v1 was committed instead of
v2, so the code has a bug that was revealed in the review (checking for the
wrong error code).
Signed-off-by: Kevin Wolf
---
osdep.c |
Initialize KVM paravirt cpuid leaf and allow user to control guest
visible PV features through -cpu flag.
Signed-off-by: Gleb Natapov
---
v1->v2
fix indentation
remove unneeded ifdefs
v2->v3
added needed ifdefs (CONFIG_KVM_PARA)
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index
> I thought we will get rid of vpb_pci_config_addr, and fill in
> fields in PCIConfigAddress directly. If we don't, and still
> recode into PC format, this is not making code any prettier
> so I don't really see what this buys us.
I agree. This patch seems to be introducing churn for no benefit.
On Wed, Jan 13, 2010 at 01:02:50PM +, Paul Brook wrote:
> On Tuesday 12 January 2010, Isaku Yamahata wrote:
> > To use pci host framework, use PCIHostState instead of PCIBus in
> > PCIVPBState.
>
> No.
>
> pci_host.[ch] provides very specific functionality, it is not a generic PCI
> host de
Move 200 lines out of vl.c already into common code that only needs to
be compiled once.
Signed-off-by: Paolo Bonzini
---
Makefile.objs |2 +-
input.c | 238 +
vl.c | 214 +---
On Tuesday 12 January 2010, Isaku Yamahata wrote:
> To use pci host framework, use PCIHostState instead of PCIBus in
> PCIVPBState.
No.
pci_host.[ch] provides very specific functionality, it is not a generic PCI
host device. Specifically it provides indirect access to PCI config space via
a me
Please pull the following changes: eepro100 changes have been
out for a week without comments, and pci one seems
obvious.
The following changes since commit 72ff25e4e98d6dba9286d032b9ff5432553bbad5:
Juergen Lock (1):
Workaround for broken OSS_GETVERSION on FreeBSD, part two
are availabl
On Tue, 12 Jan 2010 19:57:29 +0100
Markus Armbruster wrote:
> Here's my stab at self-documenting commands. We need to describe the
> request, the reply, and possible errors. First the request part. Its
> format according to qemu-spec.txt is:
>
> { "execute": json-string, "arguments": json-obj
As pointed out by clang size is only ever written to, but never actually
used.
Signed-off-by: Christoph Hellwig
Index: qemu/hw/virtio-blk.c
===
--- qemu.orig/hw/virtio-blk.c 2010-01-13 13:25:00.911004071 +0100
+++ qemu/hw/virtio-
On 01/11/10 19:37, Michael S. Tsirkin wrote:
On Thu, Jan 07, 2010 at 05:13:30PM +0100, Stefan Weil wrote:
Use new way to associate ROM files to devices.
Patch looks good to me.
Maybe it is even possible to create a single
pxe-i8255x.bin which supports all eepro100 devices
(not supported with
On 12.01.2010, at 19:33, Michael S. Tsirkin wrote:
> Guys, I was wondering whether the following helper function will be
> helpful, as a lot of common code seems to be around identical b/w/l
> callbacks. Comments?
I like the idea. That could potentially clean up quite a bit of code in qemu.
Al
On (Wed) Jan 13 2010 [12:46:22], Paolo Bonzini wrote:
> On 01/13/2010 11:54 AM, Amit Shah wrote:
>> clang-analyzer points out a redundant assignment.
>>
>> Signed-off-by: Amit Shah
>> ---
>> block/qcow2-refcount.c |1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/b
On 01/13/2010 11:54 AM, Amit Shah wrote:
clang-analyzer points out a redundant assignment.
Signed-off-by: Amit Shah
---
block/qcow2-refcount.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 54b19f8..3a2d44a 100644
On Tue, Jan 12, 2010 at 04:39:52PM -0600, Anthony Liguori wrote:
> On 01/11/2010 11:22 AM, Michael S. Tsirkin wrote:
>> Looks like order got mixed up: vhost_net header
>> is added by a follow-up patch. Will be fixed
>> in the next revision.
>>
>> Signed-off-by: Michael S. Tsirkin
>> ---
>> net.c
clang-analyzer points out a redundant increment.
Signed-off-by: Amit Shah
---
json-parser.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/json-parser.c b/json-parser.c
index 7624c0f..e04932f 100644
--- a/json-parser.c
+++ b/json-parser.c
@@ -247,8 +247,6 @@ static QSt
clang-analyzer points out a redundant assignment.
Signed-off-by: Amit Shah
---
block/qcow2-refcount.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 54b19f8..3a2d44a 100644
--- a/block/qcow2-refcount.c
+++ b/block/qc
clang-analyzer points out a redundant assignment.
Signed-off-by: Amit Shah
---
hw/vga.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/vga.c b/hw/vga.c
index d05f1f9..6a1a059 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -1303,7 +1303,6 @@ static void vga_draw_text(VGAComm
clang-analyzer points out a redundant assignment.
Signed-off-by: Amit Shah
---
target-i386/translate.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 511a4ea..8078112 100644
--- a/target-i386/translate.c
+++ b/tar
clang-analyzer points out value assigned to 'len' is not used.
Signed-off-by: Amit Shah
---
hw/virtio-net.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 02d9180..6e48997 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -53
clang-analyzer pointed out the value of 'sockets' is never reused.
Signed-off-by: Amit Shah
CC: Andre Przywara
---
vl.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/vl.c b/vl.c
index b048e89..e49e7bd 100644
--- a/vl.c
+++ b/vl.c
@@ -2613,17 +2613,13 @@ static vo
Running the static checker clang-analyzer on the qemu sources, I found
a few dead assignments.
This patchset removes a few of those.
Amit Shah (6):
vl.c: Remove dead assignment
virtio: net: remove dead assignment
x86: translate.c: remove dead assignment
hw/vga.c: remove dead assignment
On Tue, Jan 12, 2010 at 04:36:45PM -0600, Anthony Liguori wrote:
> On 01/11/2010 11:17 AM, Michael S. Tsirkin wrote:
>> Add binding API to set iofd/irqfd support.
>> Will be used by vhost.
>>
>> Signed-off-by: Michael S. Tsirkin
>> ---
>> hw/virtio.c | 13 ++---
>> hw/virtio.h |4 +
On Tue, Jan 12, 2010 at 11:06:33PM +0100, Christoph Hellwig wrote:
> On Tue, Jan 12, 2010 at 09:50:55PM +0200, Michael S. Tsirkin wrote:
> > So the issue is that wrong block size (0x) was passed
> > to guest. Would it make sense to add some sanity checking in virtio-blk
> > to make it not
Am 12.01.2010 19:13, schrieb Christoph Hellwig:
> The backing device is only modified from bdrv_commit. So instead of
> flushing it every time bdrv_flush is called for the front-end device
> only flush it after we're written data to it in bdrv_commit.
>
> Also flush the frontend image if we have
On Tue, Jan 12, 2010 at 04:28:46PM -0600, Anthony Liguori wrote:
> On 01/12/2010 03:28 PM, Luiz Capitulino wrote:
> >On Mon, 11 Jan 2010 13:55:19 +
> >"Daniel P. Berrange" wrote:
> >
> >
> >>So perhaps we should declare that the lifecycle is
> >>
> >> - CONNECT (provide IP / port d
Signed-off-by: Paolo Bonzini
---
configure | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 2553724..b3d4640 100755
--- a/configure
+++ b/configure
@@ -1309,13 +1309,19 @@ fi
##
# curl probe
+
Together with the first patch this enables using the prefixed
pkg-config, thus picking up the correct flags for SDL.
Signed-off-by: Paolo Bonzini
---
configure | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index b8641b8..2553724 1007
After the next commit, pkg-config could be used for the shared library
configuration case and sdl-config for static libraries. So I prepare
the test here by doing two changes:
at the same time I remove useless backslashes from the invocation of
grep;
1) fixing a typo ($sd_cflags). The typo has
Since pkgconfig can give different output for different targets,
it should be tried with the cross-compilation prefix first.
Signed-off-by: Paolo Bonzini
---
configure | 19 ++-
1 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 5c056f5.
This is v3 of the series to simplify cross-compiling, by using
a cross pkg-config tool whenever possible.
I'm now using pkg-config also in the native compilation case
whenever possible. I also found and fixed a typo in the static
SDL case.
v2->v3: fix typo
v1->v2: always use pkg-config when ava
Signed-off-by: Paolo Bonzini
---
configure | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 2553724..b3d4640 100755
--- a/configure
+++ b/configure
@@ -1309,13 +1309,19 @@ fi
##
# curl probe
+
Together with the first patch this enables using the prefixed
pkg-config, thus picking up the correct flags for SDL.
Signed-off-by: Paolo Bonzini
---
configure | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index b8641b8..2553724 1007
After the next commit, pkg-config could be used for the shared library
configuration case and sdl-config for static libraries. So I prepare
the test here by doing two changes:
at the same time I remove useless backslashes from the invocation of
grep;
1) fixing a typo ($sd_cflags). The typo has
This is v2 of the series to simplify cross-compiling, by using
a cross pkg-config tool whenever possible.
I'm now using pkg-config also in the native compilation case
whenever possible. I also found and fixed a typo in the static
SDL case.
Paolo Bonzini (4):
use cross-prefix for pkgconfig
fi
Since pkgconfig can give different output for different targets,
it should be tried with the cross-compilation prefix first.
Signed-off-by: Paolo Bonzini
---
configure | 19 ++-
1 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 5c056f5.
78 matches
Mail list logo