On Wed, 13 Jan 2010 18:38:57 +0100 Markus Armbruster <arm...@redhat.com> wrote:
> Luiz Capitulino <lcapitul...@redhat.com> writes: > > > On Wed, 13 Jan 2010 17:53:38 +0100 > > Markus Armbruster <arm...@redhat.com> wrote: > > > >> Luiz Capitulino <lcapitul...@redhat.com> writes: > [...] > >> > I'm thinking in something like this: > >> > > >> > 1. Connection is made, the greeting message is sent and QMP is > >> > in 'handshake mode' > >> > > >> > 2. In this mode only commands to enable/disable protocol > >> > capabilities are allowed > >> > > >> > 3. When the client is done with the setup, it issues the > >> > command 'enable-qmp', which puts the protocol into 'running mode', > >> > where any command is accepted > >> > >> Really "any command"? What about commands to enable/disable protocol > >> capabilities? > > > > I think that playing with some protocol bits might be safe, like > > enabling async messages. > > > > I'm not saying this is a good practice, but forbidding it seems a bit > > extreme at first. > > Allowing stuff when it turns out to be needed is less painful than > outlawing stuff when it turns out to be problematic. I forgot to mention we can block them, that's fine. :) So, do we agree with the general design? I'll cook a RFC series.