> I thought we will get rid of vpb_pci_config_addr, and fill in > fields in PCIConfigAddress directly. If we don't, and still > recode into PC format, this is not making code any prettier > so I don't really see what this buys us.
I agree. This patch seems to be introducing churn for no benefit. See also comments about direct v.s. indirect access to PCI config space. I suspect you're trying to use a common implementation for two fundamentally different things. Paul
