[Qemu-devel] Re: [PATCH 06/14] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2009-12-30 Thread Paolo Bonzini
On 12/31/2009 02:33 AM, Kirill A. Shutemov wrote: + snprintf((char*)entry->name,8,"QEMU VV"); + snprintf((char*)entry->extension,3,"FAT"); Wrong, the split should be "QEMU VVF" and "AT". Even better, change it to "QEMU VVF" and "AT " with a trailing space and use memcpy since it's

[Qemu-devel] Re: [PATCH 01/14] Introduce qemu_write_full()

2009-12-30 Thread Paolo Bonzini
On 12/31/2009 02:33 AM, Kirill A. Shutemov wrote: diff --git a/qemu-common.h b/qemu-common.h index 8630f8c..a8144cb 100644 --- a/qemu-common.h +++ b/qemu-common.h @@ -160,6 +160,7 @@ void qemu_mutex_lock_iothread(void); void qemu_mutex_unlock_iothread(void); int qemu_open(const char *name, i

Re: [Qemu-devel] [PATCH 01/14] Introduce qemu_write_full()

2009-12-30 Thread malc
On Thu, 31 Dec 2009, Kirill A. Shutemov wrote: > On Thu, Dec 31, 2009 at 4:00 AM, malc wrote: > > On Thu, 31 Dec 2009, Kirill A. Shutemov wrote: > > > >> A variant of write(2) which handles partial write. > >> > >> Signed-off-by: Kirill A. Shutemov > >> --- > >>  osdep.c       |   27 +++

Re: [Qemu-devel] [PATCH 01/14] Introduce qemu_write_full()

2009-12-30 Thread Kirill A. Shutemov
On Thu, Dec 31, 2009 at 4:00 AM, malc wrote: > On Thu, 31 Dec 2009, Kirill A. Shutemov wrote: > >> A variant of write(2) which handles partial write. >> >> Signed-off-by: Kirill A. Shutemov >> --- >>  osdep.c       |   27 +++ >>  qemu-common.h |    1 + >>  2 files changed,

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Avi Kivity
On 12/31/2009 12:46 AM, Anthony Liguori wrote: I wasn't worried about that, only the increased code duplication. I wasn't thinking there would be an info ioapic command but rather a generic device-info command that would work with any qdev device. No code duplication (in fact, much, much le

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2009-12-30 Thread Jamie Lokier
john cooper wrote: > { > +.name = "Merom", > +.level = 2, > +.vendor1 = CPUID_VENDOR_INTEL_1, > +.vendor2 = CPUID_VENDOR_INTEL_2, > +.vendor3 = CPUID_VENDOR_INTEL_3, > +.family = 6, /* P6 */ > +.model = 2, > +.stepping = 3, > +

Re: [Qemu-devel] [PATCH 10/14] vl.c: fix warning with _FORTIFY_SOURCE

2009-12-30 Thread malc
On Thu, 31 Dec 2009, Kirill A. Shutemov wrote: > CCi386-softmmu/vl.o > cc1: warnings being treated as errors > /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'qemu_event_increment': > /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:3404: error: ignoring return value of > 'write', declared with attr

Re: [Qemu-devel] [PATCH 04/14] block/qcow.c: fix warnings with _FORTIFY_SOURCE

2009-12-30 Thread malc
On Thu, 31 Dec 2009, Kirill A. Shutemov wrote: > CCblock/qcow.o > cc1: warnings being treated as errors > block/qcow.c: In function 'qcow_create': > block/qcow.c:804: error: ignoring return value of 'write', declared with > attribute warn_unused_result > block/qcow.c:806: error: ignoring re

Re: [Qemu-devel] [PATCH 01/14] Introduce qemu_write_full()

2009-12-30 Thread malc
On Thu, 31 Dec 2009, Kirill A. Shutemov wrote: > A variant of write(2) which handles partial write. > > Signed-off-by: Kirill A. Shutemov > --- > osdep.c | 27 +++ > qemu-common.h |1 + > 2 files changed, 28 insertions(+), 0 deletions(-) > > diff --git a/osd

[Qemu-devel] [PATCH 14/14] Add -fstack-protector-all to CFLAGS

2009-12-30 Thread Kirill A. Shutemov
-fstack-protector-all emit extra code to check for buffer overflows, such as stack smashing attacks. This is done by adding a guard variable to functions with vulnerable objects. Signed-off-by: Kirill A. Shutemov --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --g

[Qemu-devel] [PATCH 13/14] Enable _FORTIFY_SOURCE=2

2009-12-30 Thread Kirill A. Shutemov
_FORTIFY_SOURCE is a Glibc feature which adds memory and string function protection. Signed-off-by: Kirill A. Shutemov --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 18aed43..0cdcdb3 100755 --- a/configure +++ b/configure @@ -9

[Qemu-devel] [PATCH 12/14] linux-user/mmap.c: fix warnings with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCi386-linux-user/mmap.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c: In function 'mmap_frag': /usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c:253: error: ignoring return value of 'pread', declared with attribute warn_unused_result /usr/src/RPM/B

[Qemu-devel] [PATCH 11/14] monitor.c: fix warnings with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCi386-softmmu/monitor.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c: In function 'do_memory_save': /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c:1318: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result /usr/src/RPM/BUILD/qemu

[Qemu-devel] [PATCH 10/14] vl.c: fix warning with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCi386-softmmu/vl.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'qemu_event_increment': /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:3404: error: ignoring return value of 'write', declared with attribute warn_unused_result /usr/src/RPM/BUILD/qemu-0.11.92/v

[Qemu-devel] [PATCH 08/14] net/slirp.c: fix warning with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCnet/slirp.o cc1: warnings being treated as errors net/slirp.c: In function 'slirp_smb_cleanup': net/slirp.c:470: error: ignoring return value of 'system', declared with attribute warn_unused_result make: *** [net/slirp.o] Error 1 Signed-off-by: Kirill A. Shutemov --- net/slirp.c |9

[Qemu-devel] [PATCH 09/14] usb-linux.c: fix warning with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCusb-linux.o cc1: warnings being treated as errors usb-linux.c: In function 'usb_host_read_file': usb-linux.c:1204: error: ignoring return value of 'fgets', declared with attribute warn_unused_result make: *** [usb-linux.o] Error 1 Signed-off-by: Kirill A. Shutemov --- usb-linux.c |8

[Qemu-devel] [PATCH 07/14] block/qcow2.c: fix warnings with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCblock/qcow2.o cc1: warnings being treated as errors block/qcow2.c: In function 'qcow_create2': block/qcow2.c:829: error: ignoring return value of 'write', declared with attribute warn_unused_result block/qcow2.c:838: error: ignoring return value of 'write', declared with attribute warn_un

[Qemu-devel] [PATCH 06/14] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCblock/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function 'commit_one_file': block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result make: *** [block/vvfat.o] Error 1 CCblock/vvfat.o In file included from /usr/i

[Qemu-devel] [PATCH 05/14] block/vmdk.o: fix warnings with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCblock/vmdk.o cc1: warnings being treated as errors block/vmdk.c: In function 'vmdk_snapshot_create': block/vmdk.c:236: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result block/vmdk.c: In function 'vmdk_create': block/vmdk.c:775: error: ignoring return v

[Qemu-devel] [PATCH 04/14] block/qcow.c: fix warnings with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCblock/qcow.o cc1: warnings being treated as errors block/qcow.c: In function 'qcow_create': block/qcow.c:804: error: ignoring return value of 'write', declared with attribute warn_unused_result block/qcow.c:806: error: ignoring return value of 'write', declared with attribute warn_unused_

[Qemu-devel] [PATCH 03/14] block/cow.c: fix warnings with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCblock/cow.o cc1: warnings being treated as errors block/cow.c: In function 'cow_create': block/cow.c:251: error: ignoring return value of 'write', declared with attribute warn_unused_result block/cow.c:253: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_r

[Qemu-devel] [PATCH 02/14] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE

2009-12-30 Thread Kirill A. Shutemov
CCposix-aio-compat.o cc1: warnings being treated as errors posix-aio-compat.c: In function 'aio_signal_handler': posix-aio-compat.c:505: error: ignoring return value of 'write', declared with attribute warn_unused_result make: *** [posix-aio-compat.o] Error 1 Signed-off-by: Kirill A. Shutem

[Qemu-devel] [PATCH 01/14] Introduce qemu_write_full()

2009-12-30 Thread Kirill A. Shutemov
A variant of write(2) which handles partial write. Signed-off-by: Kirill A. Shutemov --- osdep.c | 27 +++ qemu-common.h |1 + 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/osdep.c b/osdep.c index e4836e7..d2406f2 100644 --- a/osdep.c +++ b/o

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 05:07:14PM -0600, Anthony Liguori wrote: > On 12/30/2009 06:13 AM, Gleb Natapov wrote: > >On Wed, Dec 30, 2009 at 02:08:27PM +0200, Izik Eidus wrote: > >>On Wed, 30 Dec 2009 14:05:10 +0200 > >>Gleb Natapov wrote: > >> > >>>On Wed, Dec 30, 2009 at 12:01:28PM +, Blue Swir

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 05:04:53PM -0600, Anthony Liguori wrote: > On 12/30/2009 09:58 AM, Avi Kivity wrote: > >On 12/30/2009 05:53 PM, Gleb Natapov wrote: > >> > >>>This assumes there is only one ioapic. While I don't think there's > >>>a good reason to add more (the one we have is causing suffici

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 04:47:45PM -0600, Anthony Liguori wrote: > On 12/30/2009 08:30 AM, Gleb Natapov wrote: > >On Wed, Dec 30, 2009 at 04:26:11PM +0200, Gleb Natapov wrote: > >>On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote: > >>>On 12/30/2009 03:27 AM, Gleb Natapov wrote: > >>>

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 04:49:01PM -0600, Anthony Liguori wrote: > On 12/30/2009 08:26 AM, Gleb Natapov wrote: > >On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote: > >>On 12/30/2009 03:27 AM, Gleb Natapov wrote: > >>>On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote: >

[Qemu-devel] qemu/qemu-kvm-0.12.1.2 - migration still very slow

2009-12-30 Thread Nikola Ciprich
Hi, few months ago Pierre Riteau reported regression of exec migration in qemu. (http://lists.gnu.org/archive/html/qemu-devel/2009-08/msg01557.html) There was some discussion, but there is no clear conclusion. Today, I tried qemu-kvm-0.12.1.2 and migration is still very slow (using libvirt save com

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Anthony Liguori
On 12/30/2009 06:13 AM, Gleb Natapov wrote: On Wed, Dec 30, 2009 at 02:08:27PM +0200, Izik Eidus wrote: On Wed, 30 Dec 2009 14:05:10 +0200 Gleb Natapov wrote: On Wed, Dec 30, 2009 at 12:01:28PM +, Blue Swirl wrote: On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: Knowing ioapic co

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Anthony Liguori
On 12/30/2009 09:58 AM, Avi Kivity wrote: On 12/30/2009 05:53 PM, Gleb Natapov wrote: This assumes there is only one ioapic. While I don't think there's a good reason to add more (the one we have is causing sufficient trouble), I suggest returning an array of ioapics (or include gsibase: [{ io

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Anthony Liguori
On 12/30/2009 08:26 AM, Gleb Natapov wrote: On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote: On 12/30/2009 03:27 AM, Gleb Natapov wrote: On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote: On 12/24/2009 09:02 AM, Gleb Natapov wrote: Knowing ioapic configuration is

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Anthony Liguori
On 12/30/2009 08:30 AM, Gleb Natapov wrote: On Wed, Dec 30, 2009 at 04:26:11PM +0200, Gleb Natapov wrote: On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote: On 12/30/2009 03:27 AM, Gleb Natapov wrote: On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote: On 12/24/2009

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Anthony Liguori
On 12/30/2009 08:19 AM, Avi Kivity wrote: On 12/30/2009 04:17 PM, Anthony Liguori wrote: That's a good idea, but it would mean that we'd need into ioapic and info ioapic-kvm if we go for a split implementation. I don't think that's a problem. A developer will be smart enough to know that they

Re: [Qemu-devel] [PATCH] ARM semihosting improvements

2009-12-30 Thread Daniel Jacobowitz
On Wed, Dec 30, 2009 at 06:38:16PM +, Jamie Lokier wrote: > I see that you didn't start the semihosting support, but what's the > purpose of it? Why would you use it to run programs like cc1 instead > of qemu-arm, the user mode simulation? You use it to run an arm-none-eabi cc1, not an arm-no

Re: [Qemu-devel] [PATCH] ARM semihosting improvements

2009-12-30 Thread Jamie Lokier
Daniel Jacobowitz wrote: > From: Daniel Jacobowitz > > This patch improves ARM semihosting to the point where qemu-system-arm > can simulate cc1 from GCC. It can't simulate GCC itself, which > requires POSIXy bits like execve, but the backend works, including the > preprocessor. I see that you

Re: [Qemu-devel] [Bug] qemu-system-ppc: "invalid/unsupported opcode" during debug session

2009-12-30 Thread Alexander Graf
Am 30.12.2009 um 18:46 schrieb Aurelien Jarno : On Wed, Dec 30, 2009 at 03:39:32PM +0100, Alexander Graf wrote: Am 29.12.2009 um 22:07 schrieb Aurelien Jarno : On Tue, Dec 29, 2009 at 04:09:17PM +0100, Stefan Weil wrote: Test environment: * ppc-softmmu/qemu-system-ppc running on x86_64 ho

Re: [Qemu-devel] [PATCH] ARM semihosting improvements

2009-12-30 Thread Daniel Jacobowitz
From: Daniel Jacobowitz This patch improves ARM semihosting to the point where qemu-system-arm can simulate cc1 from GCC. It can't simulate GCC itself, which requires POSIXy bits like execve, but the backend works, including the preprocessor. * Use -kernel and -append for SYS_GET_CMDLINE. This

Re: [Qemu-devel] [Bug] qemu-system-ppc: "invalid/unsupported opcode" during debug session

2009-12-30 Thread Aurelien Jarno
On Wed, Dec 30, 2009 at 03:39:32PM +0100, Alexander Graf wrote: > > Am 29.12.2009 um 22:07 schrieb Aurelien Jarno : > >> On Tue, Dec 29, 2009 at 04:09:17PM +0100, Stefan Weil wrote: >>> Test environment: >>> >>> * ppc-softmmu/qemu-system-ppc running on x86_64 host >>> * emulated ppc is running debi

Re: [Qemu-devel] [PATCH] ARM semihosting improvements

2009-12-30 Thread Daniel Jacobowitz
On Wed, Dec 30, 2009 at 06:32:14PM +0100, Laurent Desnogues wrote: > > @@ -370,13 +385,21 @@ uint32_t do_arm_semihosting(CPUState *env) > >         return syscall_err; > >  #endif > >     case SYS_GET_CMDLINE: > > -#ifdef CONFIG_USER_ONLY > > -        /* Build a commandline from the original argv.

Re: [Qemu-devel] [PATCH] ARM semihosting improvements

2009-12-30 Thread Laurent Desnogues
On Wed, Dec 30, 2009 at 6:23 PM, Daniel Jacobowitz wrote: > From: Daniel Jacobowitz > > This patch improves ARM semihosting to the point where qemu-system-arm > can simulate cc1 from GCC.  It can't simulate GCC itself, which > requires POSIXy bits like execve, but the backend works, including the

[Qemu-devel] [PATCH] ARM semihosting improvements

2009-12-30 Thread Daniel Jacobowitz
From: Daniel Jacobowitz This patch improves ARM semihosting to the point where qemu-system-arm can simulate cc1 from GCC. It can't simulate GCC itself, which requires POSIXy bits like execve, but the backend works, including the preprocessor. * Use -kernel and -append for SYS_GET_CMDLINE. This

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-12-30 Thread Kevin O'Connor
On Tue, Dec 29, 2009 at 01:51:36PM -0800, H. Peter Anvin wrote: > Add generic support for debugging consoles (simple I/O ports which > when written to cause debugging output to be written to a target.) > The current implementation matches Bochs' port 0xe9, allowing the same > debugging code to be u

Re: [Qemu-devel] Re: qemu-kvm-0.12 bug?

2009-12-30 Thread Thomas Treutner
On Tuesday 29 December 2009 13:24:36 Luiz Capitulino wrote: > > > Is the "-balloon virtio" parameter passed on the command-line? > > > > # grep balloon /usr/local/var/log/libvirt/qemu/* | wc -l > > 0 > > > > These logs include some history - so the parameter isn't used by libvirt > > even when bal

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Avi Kivity
On 12/30/2009 05:53 PM, Gleb Natapov wrote: This assumes there is only one ioapic. While I don't think there's a good reason to add more (the one we have is causing sufficient trouble), I suggest returning an array of ioapics (or include gsibase: [{ ioapic: object, gsibase: 0 }, { ioapic: obje

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 05:04:08PM +0200, Avi Kivity wrote: > On 12/30/2009 01:50 PM, Gleb Natapov wrote: > >Knowing ioapic configuration is very useful for the poor soles > >how need to debug guest occasionally. > >+ > >+void do_info_ioapic(Monitor *mon, QObject **ret_data) > >+{ > >+int i; >

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Avi Kivity
On 12/30/2009 01:50 PM, Gleb Natapov wrote: Knowing ioapic configuration is very useful for the poor soles how need to debug guest occasionally. + +void do_info_ioapic(Monitor *mon, QObject **ret_data) +{ +int i; +QList *list; + +*ret_data = NULL; + +if (!ioapic) +return;

Re: [Qemu-devel] [Bug] qemu-system-ppc: "invalid/unsupported opcode" during debug session

2009-12-30 Thread Alexander Graf
Am 29.12.2009 um 22:07 schrieb Aurelien Jarno : On Tue, Dec 29, 2009 at 04:09:17PM +0100, Stefan Weil wrote: Test environment: * ppc-softmmu/qemu-system-ppc running on x86_64 host * emulated ppc is running debian lenny While debugging on the emulated ppc (each time when a shared library is

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 04:26:11PM +0200, Gleb Natapov wrote: > On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote: > > On 12/30/2009 03:27 AM, Gleb Natapov wrote: > > >On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote: > > >>On 12/24/2009 09:02 AM, Gleb Natapov wrote: >

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote: > On 12/30/2009 03:27 AM, Gleb Natapov wrote: > >On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote: > >>On 12/24/2009 09:02 AM, Gleb Natapov wrote: > >>>Knowing ioapic configuration is very useful for the poor soles > >>

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Avi Kivity
On 12/30/2009 04:17 PM, Anthony Liguori wrote: That's a good idea, but it would mean that we'd need into ioapic and info ioapic-kvm if we go for a split implementation. I don't think that's a problem. A developer will be smart enough to know that they need to do that (and will get an error

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Anthony Liguori
On 12/30/2009 12:53 AM, Avi Kivity wrote: On 12/30/2009 04:00 AM, Anthony Liguori wrote: On 12/24/2009 09:02 AM, Gleb Natapov wrote: Knowing ioapic configuration is very useful for the poor soles how need to debug guest occasionally. Can this be implemented in terms of VMState? That's a go

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Anthony Liguori
On 12/30/2009 03:27 AM, Gleb Natapov wrote: On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote: On 12/24/2009 09:02 AM, Gleb Natapov wrote: Knowing ioapic configuration is very useful for the poor soles how need to debug guest occasionally. Can this be implemented in terms of VMS

[Qemu-devel] Re: [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Luiz Capitulino
On Wed, 30 Dec 2009 15:22:19 +0200 Gleb Natapov wrote: > > > +void do_info_ioapic(Monitor *mon, QObject **ret_data) > > > +{ > > > +int i; > > > +QList *list; > > > + > > > +*ret_data = NULL; > > > + > > > +if (!ioapic) > > > +return; > > > + > > > +list = qlist_new();

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Luiz Capitulino
On Wed, 30 Dec 2009 12:01:28 + Blue Swirl wrote: > On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: > > Knowing ioapic configuration is very useful for the poor soles > > how need to debug guest occasionally. > > > +static struct IOAPICState *ioapic; > > Ugly. I really think the monit

[Qemu-devel] Re: [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 11:19:30AM -0200, Luiz Capitulino wrote: > On Wed, 30 Dec 2009 13:50:43 +0200 > Gleb Natapov wrote: > > > I am starring to learn this QObject kung-fu. > > Nice, you really got how to do it. Just two minor comments. > > > One question: > > Why qlist_iter(..., func, ...)

[Qemu-devel] Re: [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Luiz Capitulino
On Wed, 30 Dec 2009 13:50:43 +0200 Gleb Natapov wrote: > I am starring to learn this QObject kung-fu. Nice, you really got how to do it. Just two minor comments. > One question: > Why qlist_iter(..., func, ...) and not > FOREACH_QOBJ() { >do things > } Well, when I started working on t

[Qemu-devel] Re: commit rules for common git tree

2009-12-30 Thread Michael S. Tsirkin
On Sun, Dec 27, 2009 at 05:01:38PM -0600, Anthony Liguori wrote: > I think it's a good idea to use the mailing list whenever possible. > Likewise, if you see a patch go in that you think would have benefited > from being on the list, point it out. Sometimes it would have benefited *others* if

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Luiz Capitulino
On Wed, 30 Dec 2009 12:45:08 +0200 Gleb Natapov wrote: > On Tue, Dec 29, 2009 at 06:49:14PM -0200, Luiz Capitulino wrote: > > On Tue, 29 Dec 2009 20:49:53 +0200 > > Gleb Natapov wrote: > > > > > On Tue, Dec 29, 2009 at 03:39:29PM -0200, Luiz Capitulino wrote: > > > > On Tue, 29 Dec 2009 18:53:4

Re: [Qemu-devel] "Hot" resizing QCow2 image using a simple python script

2009-12-30 Thread Stefan Weil
Laurent Coustet schrieb: > I've seen the code on git a little bit, seems rather simple to me, but > what do you think is the better way to integrate such a fonctionality > ? New command ? > > The best approch for me I think is to extend "convert". > > Example: > qemu-img -f qcow2 -O qcow2 original5

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 02:08:27PM +0200, Izik Eidus wrote: > On Wed, 30 Dec 2009 14:05:10 +0200 > Gleb Natapov wrote: > > > On Wed, Dec 30, 2009 at 12:01:28PM +, Blue Swirl wrote: > > > On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: > > > > Knowing ioapic configuration is very useful

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Izik Eidus
On Wed, 30 Dec 2009 14:05:10 +0200 Gleb Natapov wrote: > On Wed, Dec 30, 2009 at 12:01:28PM +, Blue Swirl wrote: > > On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: > > > Knowing ioapic configuration is very useful for the poor soles > > > how need to debug guest occasionally. > > > >

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 12:01:28PM +, Blue Swirl wrote: > On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: > > Knowing ioapic configuration is very useful for the poor soles > > how need to debug guest occasionally. > > > +static struct IOAPICState *ioapic; > > Ugly. I really think the

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Blue Swirl
On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: > Knowing ioapic configuration is very useful for the poor soles > how need to debug guest occasionally. > +static struct IOAPICState *ioapic; Ugly. I really think the monitor interface needs to be changed to take an opaque parameter. The pa

[Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
Knowing ioapic configuration is very useful for the poor soles how need to debug guest occasionally. Signed-off-by: Gleb Natapov -- I am starring to learn this QObject kung-fu. One question: Why qlist_iter(..., func, ...) and not FOREACH_QOBJ() { do things } diff --git a/hw/ioapic.c b/hw/i

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Tue, Dec 29, 2009 at 06:49:14PM -0200, Luiz Capitulino wrote: > On Tue, 29 Dec 2009 20:49:53 +0200 > Gleb Natapov wrote: > > > On Tue, Dec 29, 2009 at 03:39:29PM -0200, Luiz Capitulino wrote: > > > On Tue, 29 Dec 2009 18:53:44 +0200 > > > Gleb Natapov wrote: > > > > > > > On Tue, Dec 29, 200

[Qemu-devel] Re: commit rules for common git tree

2009-12-30 Thread Michael S. Tsirkin
On Tue, Dec 29, 2009 at 09:03:18PM +0100, Aurelien Jarno wrote: > On Tue, Dec 29, 2009 at 08:12:57PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 29, 2009 at 06:40:31PM +0100, Aurelien Jarno wrote: > > > On Tue, Dec 29, 2009 at 07:23:28PM +0200, Michael S. Tsirkin wrote: > > > > On Sun, Dec 27,

Re: [Qemu-devel] Re: Help on "Could not initialize SDL - exiting"

2009-12-30 Thread Michael S. Tsirkin
On Sun, Dec 27, 2009 at 05:35:56AM -0300, Dejun.Liu wrote: > Hi, > > below is my DISPLAY info: > echo ${DISPLAY} > :0.0 > > and i have already added localhost to xhost with the command: > xhost localhost > > but the error continue the same. > > r...@dejunliu-desktop:~# echo ${DISPLAY} > :0.0 >

Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote: > On 12/24/2009 09:02 AM, Gleb Natapov wrote: > >Knowing ioapic configuration is very useful for the poor soles > >how need to debug guest occasionally. > > Can this be implemented in terms of VMState? > What do you mean and why it

Re: [Qemu-devel] "Hot" resizing QCow2 image using a simple python script

2009-12-30 Thread Laurent Coustet
Le 29/12/2009 21:49, Kevin Wolf a écrit : The right way would be a patch to qemu rather than an external python script anyway. I've seen the code on git a little bit, seems rather simple to me, but what do you think is the better way to integrate such a fonctionality ? New command ? The bes

Re: [Qemu-devel] "Hot" resizing QCow2 image using a simple python script

2009-12-30 Thread Laurent Coustet
Le 29/12/2009 21:49, Kevin Wolf a écrit : > You need to really resize the L1 table and not just extend the l1_size in the > qcow2 header. And don't use the script with snapshots. VM state is saved > after the end of the virtual disk, so if you extend the disk it might overlap > the VM state (