On Wed, Dec 23, 2009 at 02:12:23PM +0200, Naphtali Sprei wrote:
> Added 'access' option to -drive flag
>
> The new option is: access=[rw|ro|auto]
> rw: open the drive's file with Read and Write permission, don't continue if
> failed
> ro: open the file only with Read permission
> auto: open the f
On 12/24/2009 02:17 AM, Aurelien Jarno wrote:
On Tue, Dec 22, 2009 at 11:57:02AM +0200, Avi Kivity wrote:
The first such option rom will load at address 0, which isn't very nice,
and the second will report a conflict and abort, which is horrible.
Signed-off-by: Avi Kivity
---
Changes from
On (Wed) Dec 23 2009 [17:14:28], Anthony Liguori wrote:
>
>> +/*
>> + * Items in struct VirtIOSerialPort.
>> + */
>> +QTAILQ_FOREACH(port,&s->ports, next) {
>> +/*
>> + * We put the port number because we may not have an active
>> + * port at id 0 that's rese
On (Wed) Dec 23 2009 [17:12:22], Anthony Liguori wrote:
> On 12/23/2009 01:52 PM, Amit Shah wrote:
>> This commit converts the virtio-console device to create a new
>> virtio-serial bus that can host console and generic serial ports. The
>> file hosting this code is now called virtio-serial-bus.c.
On (Wed) Dec 23 2009 [23:07:24], Markus Armbruster wrote:
> >>
> >> Do you expect devices other than "virtconsole" to go on this bus?
> >
> > Yes; virtserialport, as the next patch in the series introduces.
> >
> > Also, virtserialvnc, etc.
>
> Since all devices on this bus need the same device a
On Mon, Dec 14, 2009 at 10:25:14AM +0100, Magnus Christensson wrote:
>>> --- a/src/acpi.c
>>> +++ b/src/acpi.c
>>> @@ -464,10 +464,12 @@ build_ssdt(void)
>>> // build processor scope header
>>> *(ssdt_ptr++) = 0x10; // ScopeOp
>>> if (cpu_length<= 0x3e) {
>>> +/* Handle 1-
On Mon, Dec 14, 2009 at 10:23:39AM +0100, Magnus Christensson wrote:
>> This function implement the same logic as pci_swizzle_interrupt_pin() in
>> Linux kernel. This logic defines how PCI bridge connects INTx of each
>> devices behind it to system board interrupt line and it is part of PCI
>> spec
On Tue, Dec 22, 2009 at 11:57:02AM +0200, Avi Kivity wrote:
> The first such option rom will load at address 0, which isn't very nice,
> and the second will report a conflict and abort, which is horrible.
>
> Signed-off-by: Avi Kivity
> ---
>
> Changes from v1:
> - use ->fw_file instead of ->add
On Thu, Dec 24, 2009 at 12:39:36AM +0100, Laurent Vivier wrote:
> Le mercredi 23 décembre 2009 à 10:55 +, Paul Brook a écrit :
> > > The problem is that the whole define is just plain wrong which tells me
> > > that the code is using the bswap functions incorrectly. This really
> > > needs to b
Store the register values in native endianness, by dropping all the
endianness conversion functions, and converting the endianness in
dbdma_readl/dbdma_writel instead.
Also guard the endianness conversion with TARGET_WORDS_BIGENDIAN to
simulate the backward connection of the bus.
Signed-off-by: A
Le mercredi 23 décembre 2009 à 10:55 +, Paul Brook a écrit :
> [2] My guess is that the code is cribbed from elsewhere, and the original
> source gave the CPU direct access to the ch->regs[] array.
In fact it comes from Mac-On-Linux, src/drivers/dbdma.c
Laurent
--
- laur
Le mercredi 23 décembre 2009 à 10:55 +, Paul Brook a écrit :
> > The problem is that the whole define is just plain wrong which tells me
> > that the code is using the bswap functions incorrectly. This really
> > needs to be fixed by someone who knows the dbdma device. I don't see how
> > calli
On Thu, Dec 24, 2009 at 12:22:00AM +0100, Michael Buesch wrote:
> On Wednesday 23 December 2009 23:43:44 Aurelien Jarno wrote:
> > It has already been applied long time ago:
>
> Is svn://svn.savannah.nongnu.org/qemu/trunk not used anymore?
>
No, you should use instead:
git://git.savannah.nongnu
On Wednesday 23 December 2009 23:43:44 Aurelien Jarno wrote:
> It has already been applied long time ago:
Is svn://svn.savannah.nongnu.org/qemu/trunk not used anymore?
--
Greetings, Michael.
On 12/23/2009 01:52 PM, Amit Shah wrote:
Guests send us one buffer at a time. Current guests send buffers sized
4K bytes. If guest userspace applications sent out> 4K bytes in one
write() syscall, the write request actually sends out multiple buffers,
each of 4K in size.
This usually isn't a pr
On 12/23/2009 01:52 PM, Amit Shah wrote:
The port 'id' or number is internal state between the guest kernel and
our bus implementation. This is invocation-dependent and isn't part of
the guest-host ABI.
To correcly enumerate and map ports between the host and the guest, the
'name' property is us
On 12/23/2009 01:52 PM, Amit Shah wrote:
Via control channel messages, the guest can tell us whether a port got
opened or closed. Similarly, we can also indicate to the guest of host
port open/close events.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 73
On 12/23/2009 01:52 PM, Amit Shah wrote:
This commit converts the virtio-console device to create a new
virtio-serial bus that can host console and generic serial ports. The
file hosting this code is now called virtio-serial-bus.c.
The virtio console is now a very simple qdev device that sits on
On 12/23/2009 01:52 PM, Amit Shah wrote:
Hello,
This series splits up the patches by functionality. Note, however,
that patches 2-6 introduce some functionality that's advertised to the
guest as having to work all at once or not at all. Also, the savevm
version is bumped only once but save/resto
On Wed, Dec 23, 2009 at 04:52:34PM +0100, Michael Buesch wrote:
> This fixes a possible endianness issue in the usb-ohci hw module.
> hcca.frame and ohci->frame_number are 16bit, so use cpu_to_le16().
>
> Signed-off-by: Michael Buesch
>
> ---
>
> Resend. This patch was already sent on 2009/07/0
Amit Shah writes:
> On (Wed) Dec 23 2009 [20:02:19], Markus Armbruster wrote:
>> Amit Shah writes:
>>
>> > On (Wed) Dec 23 2009 [14:54:55], Markus Armbruster wrote:
>> >> Amit Shah writes:
>> >>
>> >> > This patch migrates virtio-console to the qdev infrastructure and
>> >> > creates a new vi
There's nothing target-dependent in the virtio-serial code so allow it
to be compiled just once for all the targets.
Signed-off-by: Amit Shah
---
Makefile.hw |2 +-
Makefile.target |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.hw b/Makefile.hw
index b
This patch adds generic serial ports over the virtio serial bus.
These ports have a few more options that are not relevant for
virtio console ports: the ability to cache buffers that are
received for a port while it's disconnected, setting of limits
to the bytes that are cached so as to prevent OOM
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |2 ++
hw/virtio-serial.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 12317ba..0a85f6e 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@
Guests send us one buffer at a time. Current guests send buffers sized
4K bytes. If guest userspace applications sent out > 4K bytes in one
write() syscall, the write request actually sends out multiple buffers,
each of 4K in size.
This usually isn't a problem but for some apps, like VNC, the enti
The port 'id' or number is internal state between the guest kernel and
our bus implementation. This is invocation-dependent and isn't part of
the guest-host ABI.
To correcly enumerate and map ports between the host and the guest, the
'name' property is used.
Example:
-device virtserialport,n
Via control channel messages, the guest can tell us whether a port got
opened or closed. Similarly, we can also indicate to the guest of host
port open/close events.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 73
hw/virtio-serial.c
This commit converts the virtio-console device to create a new
virtio-serial bus that can host console and generic serial ports. The
file hosting this code is now called virtio-serial-bus.c.
The virtio console is now a very simple qdev device that sits on the
virtio-serial-bus and communicates bet
VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
hw/virtio.h.
Also, bump up the value of the maximum allowed virtqueues to 32. This is
in preparation to allow multiple ports per virtio-console device.
Signed-off-by: Amit Shah
---
hw/virtio.c |2 --
hw/virtio.h |2
Hello,
This series splits up the patches by functionality. Note, however,
that patches 2-6 introduce some functionality that's advertised to the
guest as having to work all at once or not at all. Also, the savevm
version is bumped only once but save/restore state is added in each of
the patches. T
On (Wed) Dec 23 2009 [20:02:19], Markus Armbruster wrote:
> Amit Shah writes:
>
> > On (Wed) Dec 23 2009 [14:54:55], Markus Armbruster wrote:
> >> Amit Shah writes:
> >>
> >> > This patch migrates virtio-console to the qdev infrastructure and
> >> > creates a new virtio-serial bus on which mult
Amit Shah writes:
> On (Wed) Dec 23 2009 [14:54:55], Markus Armbruster wrote:
>> Amit Shah writes:
>>
>> > This patch migrates virtio-console to the qdev infrastructure and
>> > creates a new virtio-serial bus on which multiple ports are exposed as
>> > devices. The bulk of the code now resides
Paolo Bonzini wrote:
> The vpath directive has two advantages over the VPATH variable:
> 1) it allows to skip searching of .o files; 2) the default semantics
> are to append to the vpath, so there is no confusion between "VPATH=xyz"
> and "VPATH+=xyz".
>
> Since "vpath %.c %.h PATH" is not valid,
On Mon, Dec 21, 2009 at 09:09:22AM +0100, Paolo Bonzini wrote:
> Make the timer subsystem register its own bottom half instead of
> placing the bottom half code in the heart of the main loop. To
> test if an alarm timer is pending, just check if the bottom half is
> scheduled.
>
> Signed-off-by:
Signed-off-by: Juan Quintela
---
.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index cdd6aad..d7d2146 100644
--- a/.gitignore
+++ b/.gitignore
@@ -46,6 +46,7 @@ qemu-monitor.texi
patches
pc-bios/bios-pq/status
pc-bios/vgabios-pq/st
On Thursday 17 December 2009 14:29:47 Anthony Liguori wrote:
> Rob Landley wrote:
> > For background of CELF project proposals, see:
> >
> > http://elinux.org/CELF_Open_Project_Proposal_2010
> >
> > Summary:
> >
> > Integrate a flattened device tree parser into the emulator QEMU, so QEMU
> > can
On 12/23/2009 06:59 PM, Marcelo Tosatti wrote:
On Mon, Dec 21, 2009 at 09:09:24AM +0100, Paolo Bonzini wrote:
tcg_has_work is the only user of cpu-exec.c's qemu_cpu_has_work export.
Just move everything into cpu-exec.c.
cpu_has_work is going to be used by Glauber's KVM SMP patchset soon.
Is
On Mon, Dec 21, 2009 at 09:09:24AM +0100, Paolo Bonzini wrote:
> tcg_has_work is the only user of cpu-exec.c's qemu_cpu_has_work export.
> Just move everything into cpu-exec.c.
cpu_has_work is going to be used by Glauber's KVM SMP patchset soon.
On Wed, Dec 23, 2009 at 05:04:19PM +1030, Rusty Russell wrote:
> On Wed, 23 Dec 2009 01:21:43 am Anthony Liguori wrote:
> > On 12/22/2009 05:26 AM, Michael S. Tsirkin wrote:
> > > On Tue, Dec 08, 2009 at 06:18:18PM +0200, Michael S. Tsirkin wrote:
> > >
> > >> The following fixes a class of lon
On Wed, Dec 23, 2009 at 03:13:05PM +, Paul Brook wrote:
> > > > > Given we need both, why not actually defined an API that gives you
> > > > > this?
> > > >
> > > > Because, I do not want to define APIs, I want to reuse an existing one.
> > >
> > > Except that, say you said later in your email,
This fixes a possible endianness issue in the usb-ohci hw module.
hcca.frame and ohci->frame_number are 16bit, so use cpu_to_le16().
Signed-off-by: Michael Buesch
---
Resend. This patch was already sent on 2009/07/08, but the problem is still
present in trunk.
---
hw/usb-ohci.c |4 ++--
This is the accompanying qemu patch for the maximum number of total sectors
in an I/O feature.
Please CC me on replies, as I am not subscribed.
Thanks,
Avishay
Signed-off-by: Avishay Traeger
---
diff --git a/block.c b/block.c
index 3f3496e..9fa97b8 100644
--- a/block.c
+++ b/block.c
@@ -807,6
This is a revised patch that allows the guest and host to negotiate the
maximum number of total sectors in an I/O. This feature has already been
added by Rusty to the virtio spec.
Please CC me on replies, as I am not subscribed.
Thanks,
Avishay
Signed-off-by: Avishay Traeger
---
diff --git a
> > > > Given we need both, why not actually defined an API that gives you
> > > > this?
> > >
> > > Because, I do not want to define APIs, I want to reuse an existing one.
> >
> > Except that, say you said later in your email, no API exists for doing
> > atomic accesses, so you need different code
This includes pci cleanups, which I think are very safe. They have been
out for quite a while. It also puts back interrupt disable bit support,
which was mistakenly reverted on master.
The following changes since commit 59d1c1c2d774cccb0a88ff73501f97bea190c154:
Scott Tsai (1):
USB: Imp
On (Wed) Dec 23 2009 [14:54:55], Markus Armbruster wrote:
> Amit Shah writes:
>
> > This patch migrates virtio-console to the qdev infrastructure and
> > creates a new virtio-serial bus on which multiple ports are exposed as
> > devices. The bulk of the code now resides in a new file with
> > vir
Link to data sheet at intel.com so people can find it.
Signed-off-by: Michael S. Tsirkin
---
hw/e1000.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 51c9d7d..fd3059a 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1,6 +1,9 @@
/*
* QEMU
On Wed, Dec 23, 2009 at 01:32:53PM +, Paul Brook wrote:
> On Wednesday 23 December 2009, Michael S. Tsirkin wrote:
> > On Wed, Dec 23, 2009 at 12:25:46PM +, Paul Brook wrote:
> > > > > > So possibly this means that we
> > > > > > could optimize the barrier away, but I don't think this amoun
On Wednesday 23 December 2009, Michael S. Tsirkin wrote:
> On Wed, Dec 23, 2009 at 12:25:46PM +, Paul Brook wrote:
> > > > > So possibly this means that we
> > > > > could optimize the barrier away, but I don't think this amounts to
> > > > > a serious issue, I guess portability/readability is
On Wed, Dec 23, 2009 at 12:25:46PM +, Paul Brook wrote:
> > > > So possibly this means that we
> > > > could optimize the barrier away, but I don't think this amounts to a
> > > > serious issue, I guess portability/readability is more important.
> > >
> > > The more important issue is that regu
> > > So possibly this means that we
> > > could optimize the barrier away, but I don't think this amounts to a
> > > serious issue, I guess portability/readability is more important.
> >
> > The more important issue is that regular devices which to not require
> > coherency or ordering can omit th
On Wed, Dec 23, 2009 at 01:58:04PM +0200, Michael S. Tsirkin wrote:
> > Where does it say that stw_phys is atomic?
> >
> > By my reading stw_phys is implemented using memcpy. This means that it is
> > almost certainly not atomic. My guess is that this works entirely by
> > chance,
> > because
Added 'access' option to -drive flag
The new option is: access=[rw|ro|auto]
rw: open the drive's file with Read and Write permission, don't continue if
failed
ro: open the file only with Read permission
auto: open the file with Read and Write permission, if failed, try only Read
permision
For c
On Wed, Dec 23, 2009 at 11:36:34AM +, Paul Brook wrote:
> > > I mean have a single function that does both the atomic load/store and
> > > the memory barrier. Instead of:
> > >
> > > stw_phys(addr, val)
> > > barrier();
> > >
> > > We do:
> > >
> > > stw_phys_barrier(addr, val).
> >
> >
Is your OS 32- or 64-bit? How do you configure?
64-bit.
By running the configure command (is there another way?) with no arguments.
Make sure to make distclean before building anything.
Naturally I did that before posting here.
Laurent
-Nigel
On 12/23/2009 12:58 PM, Thomas Treutner wrote:
On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:
Please post a full log, after 'make clean'.
http://pastebin.com/f404c8648
Oh, I missed it at first - looks like libxenguest and libxenctrl conflict.
Copying Gerd for an opin
> > I mean have a single function that does both the atomic load/store and
> > the memory barrier. Instead of:
> >
> > stw_phys(addr, val)
> > barrier();
> >
> > We do:
> >
> > stw_phys_barrier(addr, val).
>
> Well, I think it's a good idea to use Linux APIs instead of
> inventing our own. A
On 12/22/2009 11:56 PM, Jamie Lokier wrote:
Are you joking? Even as a casual users, when would you ever run
Windows without networking these days???! I don't think you can even
buy a computer without networking any more:-)
Probably not. :)
Or do you mean something else by "networked images"
> The problem is that the whole define is just plain wrong which tells me
> that the code is using the bswap functions incorrectly. This really
> needs to be fixed by someone who knows the dbdma device. I don't see how
> calling incorrect calls even more incorrect makes any difference.
The real pr
On Wed, Dec 23, 2009 at 11:44 AM, Nigel Horne wrote:
> Laurent Desnogues wrote:
>>
>> On Wed, Dec 23, 2009 at 11:04 AM, Nigel Horne wrote:
>>
>>>
>>> I get this error on my Debian box:
>>>
>>> ...
>>> CC alpha-linux-user/fpu/softfloat.o
>>> In file included from /home/njh/src/qemu/fpu/softfloat.h
Laurent Desnogues wrote:
On Wed, Dec 23, 2009 at 11:04 AM, Nigel Horne wrote:
I get this error on my Debian box:
...
CC alpha-linux-user/fpu/softfloat.o
In file included from /home/njh/src/qemu/fpu/softfloat.h:523,
from /home/njh/src/qemu/fpu/softfloat.c:35:
...
/home/njh/src/qemu/fpu/softf
On 12/22/2009 06:12 PM, Anthony Liguori wrote:
I think the only two Fully Correct approachs are to support a very
specific CPU (e.g. Xeon-X5270) or provide the ability to individually
tweak cpu flags.
Yes. By a curious coincidence these are what the hardware vendors
define (unlike compat c
On Wed, Dec 23, 2009 at 11:04 AM, Nigel Horne wrote:
> I get this error on my Debian box:
>
> ...
> CC alpha-linux-user/fpu/softfloat.o
> In file included from /home/njh/src/qemu/fpu/softfloat.h:523,
> from /home/njh/src/qemu/fpu/softfloat.c:35:
> ...
> /home/njh/src/qemu/fpu/softfloat-specialize.
On Tue, Dec 22, 2009 at 3:46 PM, Laurent Desnogues
wrote:
> On Tue, Dec 22, 2009 at 1:02 AM, Richard Henderson wrote:
>> On 12/21/2009 03:08 PM, Laurent Desnogues wrote:
>>>
>>> If you wanted to use movcond, you'd have to make
>>> cond + move a special case...
>>
>> You'd certainly want the ARM f
On 23.12.2009, at 11:06, Aurelien Jarno wrote:
> On Wed, Dec 23, 2009 at 10:29:53AM +0100, Alexander Graf wrote:
>>
>> On 23.12.2009, at 07:12, Aurelien Jarno wrote:
>>
>>> On Tue, Dec 22, 2009 at 02:45:17PM +0100, Alexander Graf wrote:
When we get an MMIO request, we always get variables
On Wed, Dec 23, 2009 at 10:29:53AM +0100, Alexander Graf wrote:
>
> On 23.12.2009, at 07:12, Aurelien Jarno wrote:
>
> > On Tue, Dec 22, 2009 at 02:45:17PM +0100, Alexander Graf wrote:
> >> When we get an MMIO request, we always get variables in host endianness.
> >> The
> >> only time we need t
I get this error on my Debian box:
...
CC alpha-linux-user/fpu/softfloat.o
In file included from /home/njh/src/qemu/fpu/softfloat.h:523,
from /home/njh/src/qemu/fpu/softfloat.c:35:
...
/home/njh/src/qemu/fpu/softfloat-specialize.h: In function ‘float_raise’:
/home/njh/src/qemu/fpu/softfloat-speci
On 23.12.2009, at 07:12, Aurelien Jarno wrote:
> On Tue, Dec 22, 2009 at 02:45:17PM +0100, Alexander Graf wrote:
>> When we get an MMIO request, we always get variables in host endianness. The
>> only time we need to actually reverse byte order is when we read bytes from
>> guest memory.
>>
>> A
Amit Shah writes:
> On (Tue) Dec 22 2009 [18:55:16], Alexander Graf wrote:
>> Amit Shah wrote:
>> > This patch migrates virtio-console to the qdev infrastructure and
>> > creates a new virtio-serial bus on which multiple ports are exposed as
>> > devices. The bulk of the code now resides in a new
Anthony Liguori writes:
> On 12/22/2009 11:49 AM, Amit Shah wrote:
>> This patch migrates virtio-console to the qdev infrastructure and
>> creates a new virtio-serial bus on which multiple ports are exposed as
>> devices. The bulk of the code now resides in a new file with
>> virtio-console.c bei
On Tue, Dec 22, 2009 at 10:58:16PM +, Paul Brook wrote:
> > > Given this is supposed to be portable code, I wonder if we should have
> > > atomic ordered memory accessors instead.
> > >
> > > Paul
> >
> > Could you clarify please?
> >
> > The infiniband bits I used as base are very portable,
71 matches
Mail list logo
