On 12/24/2009 02:17 AM, Aurelien Jarno wrote:
On Tue, Dec 22, 2009 at 11:57:02AM +0200, Avi Kivity wrote:
The first such option rom will load at address 0, which isn't very nice,
and the second will report a conflict and abort, which is horrible.
Signed-off-by: Avi Kivity<a...@redhat.com>
---
Changes from v1:
- use ->fw_file instead of ->addr to distinguish between host-loaded and
firmware-loaded roms
- add the same check in a couple more places
This patch is a lot better and does not break the versatile platform
anymore. I do wonder though if the same change should also be done for
find_rom() and rom_copy().
Since I'm not sure what these are used for, I left them as is. IMO the
API should be improved by splitting the functions dealing with
qemu-loaded and firmware-loaded ROMs to avoid confusion.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
