Amit Shah <amit.s...@redhat.com> writes: > On (Tue) Dec 22 2009 [18:55:16], Alexander Graf wrote: >> Amit Shah wrote: >> > This patch migrates virtio-console to the qdev infrastructure and >> > creates a new virtio-serial bus on which multiple ports are exposed as >> > devices. The bulk of the code now resides in a new file with >> > virtio-console.c being just a simple qdev device. >> > >> > This interface enables spawning of multiple virtio consoles as well as >> > generic >> > serial ports. >> > >> > The older -virtconsole argument still works, but when using the new >> > functionality, it is recommended to use >> > >> > -device virtio-serial-pci -device virtconsole,... >> > >> > The virtconsole device type accepts a chardev as an argument and a 'name' >> > argument to identify the corresponding consoles on the host as well as the >> > guest. The name, if given, is exposed via the 'name' sysfs attribute in the >> > guest. >> > >> > Care has been taken to ensure compatibility with kernels that do not >> > support multiple ports as well as accepting incoming migrations from older >> > qemu versions. >> > >> > Signed-off-by: Amit Shah <amit.s...@redhat.com> >> > >> >> Please split this patch. I got dizzy after only reading 1/4th of it :-). > > Ah, sooner the better I guess. I'll do that soon. [...]
Yes, please!