[Qemu-devel] load-store experiment...

2009-11-10 Thread Chad
(this is mostly to get some ideas going rather than trying to get anything upstream... yet!) This version of tcg_out_mov for i386's tcg-target.c filters out the mov %ebx, %edx mov %ebx, [some index] mov %edx, %ebx I don't have benchmarks, but it does remove a few mov's and qemu can still load an

Re: [Qemu-devel] [PATCH V3 0/3] usb-gotemp: USB thermometer emulation

2009-11-10 Thread Paul Brook
On Wednesday 11 November 2009, Scott Tsai wrote: > I reworked the second patch in this series to add generic monitor commands > to change the temperature reported from thermometers. > Thermometer devices can now include "sensor.h" and call > 'qemu_add_therm_temp_handler' to register themselves. T

Re: [Qemu-devel] [sneak preview] major scsi overhaul

2009-11-10 Thread Paul Brook
On Friday 06 November 2009, Gerd Hoffmann wrote: >Hi, > > http://repo.or.cz/w/qemu/kraxel.git/shortlog/refs/heads/scsi.v6 > > What is in there? > (3) New interface for HBA <=> SCSIDevice interaction: > * building on the new SCSIRequest struct. > * the silly read_data/write_data

Re: [Qemu-devel] Re: [PATCH 0/2] Build fixes

2009-11-10 Thread Paul Brook
On Thursday 05 November 2009, Juan Quintela wrote: > Daniel Jacobowitz wrote: > > On Thu, Nov 05, 2009 at 05:17:46PM +0100, Juan Quintela wrote: > >> How are you compiling? > >> It works for me compiling in-tree with make -j3 (only 2 cores) > > > > I can reliably reproduce it by building all my QE

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver

2009-11-10 Thread Rusty Russell
On Wed, 11 Nov 2009 10:37:56 am Anthony Liguori wrote: > Rusty Russell wrote: > > You register an outbuf at initialization time. The host hands it back when > > it wants you to refill it with stats. > > That's strangely backwards. Guest send a stat buffer that's filled out, > host acks it when

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Scott Tsai
On Wed, Nov 11, 2009 at 8:09 AM, Anthony Liguori wrote: > That said, if we position this as an example device, I think that makes > sense.  But that suggests that we should document the heck out of it and > make it a learning experience for QEMU too.  It could be an example of how > to write a sim

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-11-10 Thread Paul Brook
> But I certainly do _not_ want to update the SCSI disk > emulation, as this is really quite tied to the SCSI parallel > interface used by the old lsi53c895a.c. This is completely untrue. scsi-disk.c contains no transport-specific code. It is deliberately designed to be independent of both the tr

Re: [Qemu-devel] net packet storms with multiple NICs

2009-11-10 Thread Anthony Liguori
Mark McLoughlin wrote: On Fri, 2009-10-23 at 20:25 +0400, Michael Tokarev wrote: I've two questions: o what's the intended usage of all-vlan-equal case, when kvm (or qemu) reflects packets from one interface to another? It's what bridge in linux is for, I think. I don't think i

Re: [Qemu-devel] [PATCH] qemu/virtio: make wmb compiler barrier + comments

2009-11-10 Thread Paul Brook
On Monday 26 October 2009, Michael S. Tsirkin wrote: > wmb must be at least a compiler barrier, even without SMP. Why? Paul

Re: [Qemu-devel] net packet storms with multiple NICs

2009-11-10 Thread Paul Brook
> I immediately reproduced the problem locally. It turns out that > kvm reflects packets coming from one guest NIC on another guest > NIC, and since both are connected to the same bridge we're getting > endless packet storm. To a level when kvm process becomes 100% > busy and does not respond to

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Scott Tsai
On Wed, Nov 11, 2009 at 8:57 AM, Greg KH wrote: > > What code?  Where is it at? http://patchwork.ozlabs.org/patch/38118/ This code emulates a Vernier Go!Temp device in qemu. I wrote this to enable people to follow your driver tutorial without buying the gadget. (I implemented functionality not e

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Alexander Graf
On 11.11.2009, at 01:57, Greg KH wrote: On Wed, Nov 11, 2009 at 01:15:45AM +0100, Alexander Graf wrote: On 11.11.2009, at 01:09, Anthony Liguori wrote: Scott Tsai wrote: On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino wrote: I'd certainly like to make this code useful for something ot

Re: [Qemu-devel] Re: [PATCH 01/12] TCG "sync" op

2009-11-10 Thread Paul Brook
On Thursday 22 October 2009, Aurelien Jarno wrote: > On Wed, Oct 21, 2009 at 03:52:22PM +0200, Ulrich Hecht wrote: > > sync allows concurrent accesses to locations in memory through different > > TCG variables. This comes in handy when you are emulating CPU registers > > that can be used as either

[Qemu-devel] [PATCH V3 3/3] Documentation: -usbdevice thermometer option

2009-11-10 Thread Scott Tsai
Adds documentation for the '-usbdevice thermometer' option. Signed-off-by: Scott Tsai --- qemu-options.hx |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index b65fd74..c2e3b6c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -396

[Qemu-devel] [PATCH V3 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Scott Tsai
Emulate the Vernier Go!Temp USB thermometer (see: http://www.vernier.com/go/gotemp.html) used in Greg Kroah-Hartman's "Write a Real, Working, Linux Driver" talk. The emulation is complete enough for gregkh's sample driver and using the vendor supplied SDK through the in-kernel 'ldusb' module under

[Qemu-devel] [PATCH V3 1/3] usb: move HID request defines to hw/usb.h

2009-11-10 Thread Scott Tsai
Move USB HID request constants from hw/usb-hid.c to hw/usb.h to allow other modules to use them. Signed-off-by: Scott Tsai --- hw/usb-hid.c | 20 ++-- hw/usb.h |8 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c inde

[Qemu-devel] [PATCH V3 0/3] usb-gotemp: USB thermometer emulation

2009-11-10 Thread Scott Tsai
I reworked the second patch in this series to add generic monitor commands to change the temperature reported from thermometers. Thermometer devices can now include "sensor.h" and call 'qemu_add_therm_temp_handler' to register themselves. I went with separate 'therm_set DEVICE_INDEX' and 'therm_

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Alexander Graf
On 11.11.2009, at 01:09, Anthony Liguori wrote: Scott Tsai wrote: On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino > wrote: I'd certainly like to make this code useful for something other than developer training. How about a new monitor command "thermometer_set" that works like "mouse_mo

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Anthony Liguori
Scott Tsai wrote: On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino wrote: I'd certainly like to make this code useful for something other than developer training. How about a new monitor command "thermometer_set" that works like "mouse_move"? "thermometer_set" would just set the temperature

[Qemu-devel] [PATCH V3 2/3] usb-gotemp: reworked to add monitor commands

2009-11-10 Thread Scott Tsai
I reworked the patch to add generic monitor commands to change the temperature reported from thermometers. Thermometer devices can now include "sendor.h" and call 'qemu_add_therm_temp_handler' to register themselves. I went with separate 'therm_set DEVICE_INDEX' and 'therm_temp TEMPERATURE' com

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver

2009-11-10 Thread Anthony Liguori
Rusty Russell wrote: On Wed, 11 Nov 2009 08:22:42 am Anthony Liguori wrote: Rusty Russell wrote: On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote: A simpler approach is to collect memory statistics in the virtio balloon driver and communicate them to the host via the device c

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver

2009-11-10 Thread Rusty Russell
On Wed, 11 Nov 2009 08:22:42 am Anthony Liguori wrote: > Rusty Russell wrote: > > On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote: > > > >> A simpler approach is to collect memory statistics in the virtio > >> balloon driver and communicate them to the host via the device config > >> space. >

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver

2009-11-10 Thread Rusty Russell
On Wed, 11 Nov 2009 01:06:14 am Anthony Liguori wrote: > Rusty Russell wrote: > > On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote: > > > >> A simpler approach is to collect memory statistics in the virtio > >> balloon driver and communicate them to the host via the device config > >> space. >

Re: [Qemu-devel] [PATCH 00/18] target-arm cleanup

2009-11-10 Thread Aurelien Jarno
On Tue, Nov 10, 2009 at 11:38:49PM +, Paul Brook wrote: > > > Some of the generated tcg code is not very optimal, for example a > > > single vld4.8 instruction can generate over 250 tcg ops. I did some > > > optimizations and got it under 200 but do you think it could be an > > > issue that a s

Re: [Qemu-devel] [PATCH 00/18] target-arm cleanup

2009-11-10 Thread Paul Brook
> On the code itself, I don't really like the remaining, new_tmp(), > dead_tmp(), and even more the fact that some functions can allocate > (e.g load_reg) or free (e.g. store_reg) some TCG variables implicitely. > This is a way to make errors by reallocating or forgetting to free some > > variable

Re: [Qemu-devel] [PATCH 00/18] target-arm cleanup

2009-11-10 Thread Paul Brook
> > Some of the generated tcg code is not very optimal, for example a > > single vld4.8 instruction can generate over 250 tcg ops. I did some > > optimizations and got it under 200 but do you think it could be an > > issue that a single instruction can expand to so many tcg ops? I mean > > besides

[Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver

2009-11-10 Thread Anthony Liguori
Rusty Russell wrote: On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote: A simpler approach is to collect memory statistics in the virtio balloon driver and communicate them to the host via the device config space. There are two issues I see with this. First, there's an atomicity proble

Re: [Qemu-devel] arm, mips and mipsel broken

2009-11-10 Thread Aurelien Jarno
On Tue, Nov 10, 2009 at 11:19:40PM +0200, Blue Swirl wrote: > On Tue, Nov 10, 2009 at 10:50 PM, Aurelien Jarno wrote: > > Please note that at least qemu-system-arm, qemu-system-mips and > > qemu-system-mipsel are broken by this commit: > > Given that none of the devices touched by the commit shou

Re: [Qemu-devel] arm, mips and mipsel broken

2009-11-10 Thread Blue Swirl
On Tue, Nov 10, 2009 at 10:50 PM, Aurelien Jarno wrote: > Please note that at least qemu-system-arm, qemu-system-mips and > qemu-system-mipsel are broken by this commit: Given that none of the devices touched by the commit should be used by these targets, the breakage comes from just the single n

[Qemu-devel] [PATCH] scsi-disk: Inquiry with allocation length of CDB < 36 (v2)

2009-11-10 Thread Artyom Tarasenko
According to SCSI-2 specification, http://ldkelley.com/SCSI2/SCSI2/SCSI2/SCSI2-08.html#8.2.5 , "if the allocation length of the command descriptor block (CDB) is too small to transfer all of the parameters, the additional length shall not be adjusted to reflect the truncation." The 36 mandatory byt

[Qemu-devel] Re: ppc64 target broken

2009-11-10 Thread Blue Swirl
On Tue, Nov 10, 2009 at 8:04 PM, Alexander Graf wrote: > Hi list, > > For quite some time the PPC64 target (-M mac99 -cpu 970fx) is broken in > early init code: > > <6>OF: ** translation for device > /p...@f200/p...@d/mac...@10/interrupt-control...@4 ** > <6>OF: bus is default (na=1, ns=1)

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Luiz Capitulino
On Wed, 11 Nov 2009 01:52:12 +0800 Scott Tsai wrote: > On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino > wrote: > >> > >> I'd certainly like to make this code useful for something other than > >> developer training. > >> How about a new monitor command "thermometer_set" that works like > >> "

[Qemu-devel] arm, mips and mipsel broken

2009-11-10 Thread Aurelien Jarno
Please note that at least qemu-system-arm, qemu-system-mips and qemu-system-mipsel are broken by this commit: commit c169998802505c244b8bcad562633f29de7d74a4 Author: Glauber Costa Date: Thu Nov 5 16:05:15 2009 -0200 v3: don't call reset functions on cpu initialization There is absolu

[Qemu-devel] Fedora9-32/64 dvd boot broken

2009-11-10 Thread Ryan Harper
Tip is broken booting a Fedora 9 DVD. Host: Fedora 11 x86_64 configured with: ./configure --target-list=x86_64-softmmu --prefix=/usr/local/qemu-regression Guest run with: qemu-system-x86_64 -name 'vm1' -monitor stdio \ -drive file=fc9-32.qcow2,if=ide,cache=writeback \

[Qemu-devel] Re: [PATCH] Fix incoming migration

2009-11-10 Thread Juan Quintela
Mark McLoughlin wrote: > On Tue, 2009-11-10 at 18:03 +0100, Juan Quintela wrote: >> Mark McLoughlin wrote: >> > On Fri, 2009-11-06 at 15:58 +0100, Juan Quintela wrote: >> >> commit b04c4134d6de28c249277de19e523bfbe4aebbd6 >> >> broke incoming migration. After talking with Gleb, code was intended

[Qemu-devel] ppc64 target broken

2009-11-10 Thread Alexander Graf
Hi list, For quite some time the PPC64 target (-M mac99 -cpu 970fx) is broken in early init code: <6>OF: ** translation for device /p...@f200/p...@d/mac...@10/ interrupt-control...@4 ** <6>OF: bus is default (na=1, ns=1) on /p...@f200/p...@d/mac...@10 <4>OF: translating address:

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Scott Tsai
On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino wrote: >> >> I'd certainly like to make this code useful for something other than >> developer training. >> How about a new monitor command "thermometer_set" that works like >> "mouse_move"? >> "thermometer_set" would just set the temperature of th

[Qemu-devel] Re: [PATCH] Fix incoming migration

2009-11-10 Thread Mark McLoughlin
On Tue, 2009-11-10 at 18:03 +0100, Juan Quintela wrote: > Mark McLoughlin wrote: > > On Fri, 2009-11-06 at 15:58 +0100, Juan Quintela wrote: > >> commit b04c4134d6de28c249277de19e523bfbe4aebbd6 > >> broke incoming migration. After talking with Gleb, code was intended > >> to be the way is in this

Re: [Qemu-devel] [PATCH] Fix incoming migration

2009-11-10 Thread Glauber Costa
On Tue, Nov 10, 2009 at 04:47:59PM +, Mark McLoughlin wrote: > On Fri, 2009-11-06 at 15:58 +0100, Juan Quintela wrote: > > commit b04c4134d6de28c249277de19e523bfbe4aebbd6 > > broke incoming migration. After talking with Gleb, code was intended > > to be the way is in this fix. This fixes migr

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Luiz Capitulino
On Tue, 10 Nov 2009 23:55:10 +0800 Scott Tsai wrote: > On Tue, Nov 10, 2009 at 11:33 PM, Alexander Graf wrote: > > How about having a monitor command to change the temperature, leveraging a > > "common interface"? > > That way in the future real host temperature measurements could maybe get > >

[Qemu-devel] Re: [PATCH] Fix incoming migration

2009-11-10 Thread Juan Quintela
Mark McLoughlin wrote: > On Fri, 2009-11-06 at 15:58 +0100, Juan Quintela wrote: >> commit b04c4134d6de28c249277de19e523bfbe4aebbd6 >> broke incoming migration. After talking with Gleb, code was intended >> to be the way is in this fix. This fixes migration here. > > Tried to reproduce and it wo

Re: [Qemu-devel] [PATCH 3/4] S/390 host support for TCG

2009-11-10 Thread Aurelien Jarno
On Mon, Nov 09, 2009 at 06:54:28PM +0200, Ulrich Hecht wrote: > On Monday 02 November 2009, Aurelien Jarno wrote: > > First of all I have a question about s390/s390x. It seems that you > > plan to support both s390 and s390x in the same file. Is that correct? > > Actually, I didn't think about sup

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Avi Kivity
On 11/10/2009 05:33 PM, Alexander Graf wrote: How about having a monitor command to change the temperature, leveraging a "common interface"? That way in the future real host temperature measurements could maybe get forwarded there too. At least for battery I've had several people ask already if

Re: [Qemu-devel] [PATCH] Fix incoming migration

2009-11-10 Thread Mark McLoughlin
On Fri, 2009-11-06 at 15:58 +0100, Juan Quintela wrote: > commit b04c4134d6de28c249277de19e523bfbe4aebbd6 > broke incoming migration. After talking with Gleb, code was intended > to be the way is in this fix. This fixes migration here. Tried to reproduce and it works fine for me. More details?

[Qemu-devel] Re: [PATCH V6 27/32] pci: teach pci_default_config_write() ROM bar for normal/bridge device .

2009-11-10 Thread Michael S. Tsirkin
On Fri, Oct 30, 2009 at 09:21:21PM +0900, Isaku Yamahata wrote: > When updated ROM expantion address of header type 0, it missed > to update mappings. > Add PCI_ROM_ADDRESS check whether to call pci_update_mappings() > Also update pci mapping when PCI_ROM_ADDRESS1 is written for header type 1. > >

Re: [Qemu-devel] [PATCH 2/9] S/390 CPU emulation

2009-11-10 Thread Aurelien Jarno
On Mon, Nov 09, 2009 at 06:55:23PM +0200, Ulrich Hecht wrote: > On Monday 02 November 2009, Laurent Desnogues wrote: > > That indeed looks strange: fixing the TB chaining on ARM > > made nbench i386 three times faster. Note the gain was > > less for FP parts of the benchmark due to the use of > >

[Qemu-devel] Re: [PATCH V6 26/32] pci: use range helper functions.

2009-11-10 Thread Michael S. Tsirkin
On Fri, Oct 30, 2009 at 09:21:20PM +0900, Isaku Yamahata wrote: > clean up pci_default_write_config() by the range helper functions. > > Suggested by Michael S. Tsirkin > Cc: Michael S. Tsirkin > Signed-off-by: Isaku Yamahata Mabe you can float this patch up so I can put it on pci tree. > ---

[Qemu-devel] Re: [PATCH V6 22/32] pci_host: change the signature of pci_data_{read, write}.

2009-11-10 Thread Michael S. Tsirkin
On Fri, Oct 30, 2009 at 09:21:16PM +0900, Isaku Yamahata wrote: > change the first argument, void *opaque to PCIBus *s > of the pci_data_{read, write}. > They aren't used as direct callback so the argument type > don't have to be void*. So change it to the right type. > > Signed-off-by: Isaku Yama

[Qemu-devel] Re: [PATCH V6 20/32] pci: factor out the conversion logic from io port address into pci device.

2009-11-10 Thread Michael S. Tsirkin
On Fri, Oct 30, 2009 at 09:21:14PM +0900, Isaku Yamahata wrote: > factor out the logic which converts io port address into pci device > and offset in PCI configuration space. > > Signed-off-by: Isaku Yamahata > --- > hw/pci.c | 32 ++-- > 1 files changed, 18 inserti

Re: [Qemu-devel] PATCH: Qemu user-mode - fork - exec -

2009-11-10 Thread Paul Brook
On Monday 12 October 2009, Toni wrote: > Hi guys, > I found a solution for the problems with the fork and the exec under qemu > user-mode. > With the fork I enabled the NPTL and now it seems to work fine. > For the exec the problem was that it was execute natively, and so the qemu > process was kil

[Qemu-devel] Re: [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Scott Tsai
On Tue, Nov 10, 2009 at 11:39 PM, Juan Quintela wrote: > Change them in the middle of one interval? > once then arrived same limit, 40° or so go back to 20°? I can do this.

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Scott Tsai
On Tue, Nov 10, 2009 at 11:33 PM, Alexander Graf wrote: > How about having a monitor command to change the temperature, leveraging a > "common interface"? > That way in the future real host temperature measurements could maybe get > forwarded there too. At least for battery I've had several people

[Qemu-devel] Re: [PATCH V6 19/32] pci: make pci configuration transaction more accurate.

2009-11-10 Thread Michael S. Tsirkin
On Fri, Oct 30, 2009 at 09:21:13PM +0900, Isaku Yamahata wrote: > This patch sorts out/enhances pci code to track pci bus topology > more accurately. > - Track host bus bridge with pci domain number. Although the > current qemu implementation supports only pci domian 0 yet. > - Track pci bridge p

[Qemu-devel] Re: [PATCH V6 18/32] pci: remove bus_num member from struct PCIBus.

2009-11-10 Thread Michael S. Tsirkin
On Tue, Nov 10, 2009 at 05:33:22PM +0200, Michael S. Tsirkin wrote: > On Fri, Oct 30, 2009 at 09:21:12PM +0900, Isaku Yamahata wrote: > > Since It can be retrieved from pci configuration space, > > the member is unnecessary. > > > > Signed-off-by: Isaku Yamahata > > Acked-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 00/16] Add a -netdev option

2009-11-10 Thread Mark McLoughlin
On Tue, 2009-11-10 at 15:44 +, Paul Brook wrote: > On Thursday 08 October 2009, Mark McLoughlin wrote: > > Hi, > > Here's a series of patches which gets the ball rolling on adding > > a -netdev option. > >... > > The idea is to de-emphasise the vlan support, and instead make > >

Re: [Qemu-devel] [PATCH 00/16] Add a -netdev option

2009-11-10 Thread Paul Brook
On Thursday 08 October 2009, Mark McLoughlin wrote: > Hi, > Here's a series of patches which gets the ball rolling on adding > a -netdev option. >... > The idea is to de-emphasise the vlan support, and instead make > a nic directly connected to a host backend the default and recomme

[Qemu-devel] Re: [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Juan Quintela
Scott Tsai wrote: >>> +    s->temperature++; >>> >> You're going to overheat very quickly. >> Apart from making the driver work, is this actually useful? > > I wanted the temperature to change with time to give a sense of > "something is happening" ^_^ > > The main user I had in mind was someone n

Re: [Qemu-devel] [PATCH 1/3] tcg: add ext{8,16,32}u_i{32,64} TCG ops

2009-11-10 Thread Aurelien Jarno
On Tue, Nov 10, 2009 at 02:51:21PM +, Paul Brook wrote: > On Wednesday 30 September 2009, Aurelien Jarno wrote: > > Currently zero extensions ops are implemented by a and op with a > > constant. This is then catched in some backend, and replaced by > > a zero extension instruction. While this w

[Qemu-devel] Re: [PATCH V6 18/32] pci: remove bus_num member from struct PCIBus.

2009-11-10 Thread Michael S. Tsirkin
On Fri, Oct 30, 2009 at 09:21:12PM +0900, Isaku Yamahata wrote: > Since It can be retrieved from pci configuration space, > the member is unnecessary. > > Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin > --- > hw/pci.c | 21 ++--- > 1 files changed, 10 insertions

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Alexander Graf
On 10.11.2009, at 16:14, Scott Tsai wrote: +s->temperature++; You're going to overheat very quickly. Apart from making the driver work, is this actually useful? I wanted the temperature to change with time to give a sense of "something is happening" ^_^ The main user I had in mind was

Re: [Qemu-devel] [PATCH, RFC] mips: fix cpu_reset memory leak

2009-11-10 Thread Aurelien Jarno
On Sun, Nov 08, 2009 at 12:50:21PM +0200, Blue Swirl wrote: > Both mmu_init() and mvp_init() allocate structures, so call cpu_mips_register > only when creating a CPU. > > In addition, maybe some of the some of the field initialization stuff > in cpu_mips_register, mmu_init, mvp_init, fpu_init et

[Qemu-devel] Re: [PATCH V6 08/32] pci: clean up pci_init_wmask()

2009-11-10 Thread Michael S. Tsirkin
On Fri, Oct 30, 2009 at 09:21:02PM +0900, Isaku Yamahata wrote: > use pci_set_word() for pci command register. > > Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin I thought I acked this already. It's an obvious one. > --- > hw/pci.c |4 ++-- > 1 files changed, 2 insertions(+),

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Laurent Vivier
>>> +    s->temperature++; >>> >> You're going to overheat very quickly. >> Apart from making the driver work, is this actually useful? > >I wanted the temperature to change with time to give a sense of >"something is happening" ^_^ > >The main user I had in mind was someone new to USB and Linux dr

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Scott Tsai
>> +    s->temperature++; >> > You're going to overheat very quickly. > Apart from making the driver work, is this actually useful? I wanted the temperature to change with time to give a sense of "something is happening" ^_^ The main user I had in mind was someone new to USB and Linux driver deve

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver

2009-11-10 Thread Anthony Liguori
Avi Kivity wrote: On 11/10/2009 04:36 PM, Anthony Liguori wrote: A stats vq might solve this more cleanly? actual and target are both really just stats. Had we implemented those with a vq, I'd be inclined to agree with you but since they're implemented in the config space, it seems natura

Re: [Qemu-devel] [PATCH 1/3] tcg: add ext{8,16,32}u_i{32,64} TCG ops

2009-11-10 Thread Paul Brook
On Wednesday 30 September 2009, Aurelien Jarno wrote: > Currently zero extensions ops are implemented by a and op with a > constant. This is then catched in some backend, and replaced by > a zero extension instruction. While this works well on RISC > machines, this adds a useless register move on n

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Avi Kivity
On 11/10/2009 11:37 AM, Scott Tsai wrote: Emulate the Vernier Go!Temp USB thermometer (see: http://www.vernier.com/go/gotemp.html) used in Greg Kroah-Hartman's "Write a Real, Working, Linux Driver" talk. The emulation is complete enough for gregkh's sample driver and using the vendor supplied SD

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver

2009-11-10 Thread Avi Kivity
On 11/10/2009 04:36 PM, Anthony Liguori wrote: A stats vq might solve this more cleanly? actual and target are both really just stats. Had we implemented those with a vq, I'd be inclined to agree with you but since they're implemented in the config space, it seems natural to extend the con

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver

2009-11-10 Thread Anthony Liguori
Rusty Russell wrote: On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote: A simpler approach is to collect memory statistics in the virtio balloon driver and communicate them to the host via the device config space. There are two issues I see with this. First, there's an atomicity proble

Re: [Qemu-devel] [PATCH] gdbstub: x86: Switch 64/32 bit registers dynamically

2009-11-10 Thread Paul Brook
> No question, this is a gdb issue. But, as it was confirmed in several > discusssions with gdb people, it is a non-trivial thing to fix. So until > qemu finds a gdb version attach with a rework x86 support, we have to > work around it by switching the register layout as the guest switches > its ex

Re: [Qemu-devel] [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-10 Thread Jamie Lokier
Avi Kivity wrote: > On 11/09/2009 09:35 PM, Jamie Lokier wrote: > > > >What I'd like to know is, if all of QEMU's state is appropriately > >recreated in the child instance, and KVM's device is reopened with a > >copy of the kvm state (by using the recently introduced ioctls to get > >and set it), w

Re: [Qemu-devel] [RFC] virtio: Report new guest memory statistics pertinent to memory ballooning (V2)

2009-11-10 Thread Jamie Lokier
Anthony Liguori wrote: > Jamie Lokier wrote: > >Adam Litke wrote: > > > >>+s->stats.pswapin = has_feature(dev, > >>VIRTIO_BALLOON_F_RPT_SWAP_OUT) ? > >>+ dev->stats.pswapin : -1; > >> > > > >(etc.) > > > >Why not simply have the guest fill in the

Re: [Qemu-devel] PC machine types switched to SeaBIOS/gPXE

2009-11-10 Thread Alexander Graf
On 10.11.2009, at 14:07, Avi Kivity wrote: On 11/10/2009 03:03 PM, Alexander Graf wrote: Anywhere you put it the bios has a right to trample. Of course our bios (and its maintainer) are cooperative, but there's not reason to impose on that if we can do the right thing and load the data a

Re: [Qemu-devel] PC machine types switched to SeaBIOS/gPXE

2009-11-10 Thread Avi Kivity
On 11/10/2009 03:03 PM, Alexander Graf wrote: Anywhere you put it the bios has a right to trample. Of course our bios (and its maintainer) are cooperative, but there's not reason to impose on that if we can do the right thing and load the data at the right moment. Right. The only thing we'r

Re: [Qemu-devel] PC machine types switched to SeaBIOS/gPXE

2009-11-10 Thread Alexander Graf
On 10.11.2009, at 14:02, Avi Kivity wrote: On 11/09/2009 08:41 PM, Glauber Costa wrote: pc.c: } else { /* High and recent kernel */ real_addr= 0x1; cmdline_addr = 0x2; prot_addr= 0x10; } If I'm not totally mistaken, 0x1 is< 1

Re: [Qemu-devel] PC machine types switched to SeaBIOS/gPXE

2009-11-10 Thread Avi Kivity
On 11/09/2009 08:41 PM, Glauber Costa wrote: pc.c: } else { /* High and recent kernel */ real_addr= 0x1; cmdline_addr = 0x2; prot_addr= 0x10; } If I'm not totally mistaken, 0x1 is< 1MB :-). So yes, I think there should be

Re: [Qemu-devel] [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-10 Thread Avi Kivity
On 11/09/2009 09:35 PM, Jamie Lokier wrote: What I'd like to know is, if all of QEMU's state is appropriately recreated in the child instance, and KVM's device is reopened with a copy of the kvm state (by using the recently introduced ioctls to get and set it), will it fork the _guest RAM_ mappe

Re: [Qemu-devel] [PATCH 4/4] Add support for -net bridge

2009-11-10 Thread Avi Kivity
On 11/09/2009 04:20 PM, Anthony Liguori wrote: Avi Kivity wrote: On 11/08/2009 12:11 AM, Anthony Liguori wrote: You don't need root privileges to use a tap device. You can access a preconfigured tap device but you cannot allocate a tap device and connect it to a bridge without CAP_NET_ADM

[Qemu-devel] [PATCH V2 3/3] Documentation: -usbdevice thermometer option

2009-11-10 Thread Scott Tsai
Adds documentation for the '-usbdevice thermometer' option. Signed-off-by: Scott Tsai --- qemu-options.hx |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index b65fd74..c2e3b6c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -396

[Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer

2009-11-10 Thread Scott Tsai
Emulate the Vernier Go!Temp USB thermometer (see: http://www.vernier.com/go/gotemp.html) used in Greg Kroah-Hartman's "Write a Real, Working, Linux Driver" talk. The emulation is complete enough for gregkh's sample driver and using the vendor supplied SDK through the in-kernel 'ldusb' module under

[Qemu-devel] [PATCH V2 1/3] usb: move HID request defines to hw/usb.h

2009-11-10 Thread Scott Tsai
Move USB HID request constants from hw/usb-hid.c to hw/usb.h to allow other modules to use them. Signed-off-by: Scott Tsai --- hw/usb-hid.c | 20 ++-- hw/usb.h |8 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c inde

[Qemu-devel] [PATCH V2 0/3] usb-gotemp: USB thermometer emulation

2009-11-10 Thread Scott Tsai
Rebased on top of the master branch of git://git.savannah.nongnu.org/qemu.git since last posting. Any advice on how to get these reviewed and merged or rejected greatly appreciated! Greg Kroah-Hartman has been giving a talk titled "Write a Real, Working, Linux Driver" for the past four years at