Re: zipfile stupidly broken

2007-05-20 Thread Thorsten Kampe
* Gabriel Genellina (Wed, 16 May 2007 16:38:39 -0300) > En Wed, 16 May 2007 12:18:35 -0300, Martin Maney <[EMAIL PROTECTED]> > escribió: > > So the author knows that there's a hard limit of 64K on the comment > > size, but feels it's more important to fail a little more quickly when > > fed somet

Re: zipfile stupidly broken

2007-05-19 Thread Nick Craig-Wood
Martin Maney <[EMAIL PROTECTED]> wrote: > Nick Craig-Wood <[EMAIL PROTECTED]> wrote: > > You don't need to do that, you can just "monkey patch" the _EndRecData > > function. > > For a quick & dirty test, sure. If I were certain I'd only ever use > this on one machine for a limited time (viz, n

Re: zipfile stupidly broken

2007-05-19 Thread Martin Maney
Nick Craig-Wood <[EMAIL PROTECTED]> wrote: > To search 64k for all zip files would slow down the opening of all zip > files whereas most zipfiles don't have comments. No, actually it would only slow down for files which do have comments, assuming I understand the code correctly. IME most zipfiles

Re: zipfile stupidly broken

2007-05-18 Thread Nick Craig-Wood
Martin Maney <[EMAIL PROTECTED]> wrote: > To quote from zipfile.py (2.4 library): > > # Search the last END_BLOCK bytes of the file for the record signature. > # The comment is appended to the ZIP file and has a 16 bit length. > # So the comment may be up to 64K long. We limit the

Re: zipfile stupidly broken

2007-05-16 Thread Gabriel Genellina
En Wed, 16 May 2007 23:14:38 -0300, Asun Friere <[EMAIL PROTECTED]> escribió: > On May 17, 5:38 am, "Gabriel Genellina" <[EMAIL PROTECTED]> > wrote: > >> This is not a good place for reporting bugs - use >> http://sourceforge.net/bugs/?group_id=5470 > > I disagree. Given that most suspected

Re: zipfile stupidly broken

2007-05-16 Thread Asun Friere
On May 17, 5:38 am, "Gabriel Genellina" <[EMAIL PROTECTED]> wrote: > This is not a good place for reporting bugs - use > http://sourceforge.net/bugs/?group_id=5470 I disagree. Given that most suspected bugs aren't, new users especially would be wise to post their "bugs' here before filing a bu

Re: zipfile stupidly broken

2007-05-16 Thread Larry Bates
Martin Maney wrote: > To quote from zipfile.py (2.4 library): > > # Search the last END_BLOCK bytes of the file for the record signature. > # The comment is appended to the ZIP file and has a 16 bit length. > # So the comment may be up to 64K long. We limit the search for the > #

Re: zipfile stupidly broken

2007-05-16 Thread Gabriel Genellina
En Wed, 16 May 2007 12:18:35 -0300, Martin Maney <[EMAIL PROTECTED]> escribió: > So the author knows that there's a hard limit of 64K on the comment > size, but feels it's more important to fail a little more quickly when > fed something that's not a zipfile - or a perfectly legitimate zipfile >

zipfile stupidly broken

2007-05-16 Thread Martin Maney
To quote from zipfile.py (2.4 library): # Search the last END_BLOCK bytes of the file for the record signature. # The comment is appended to the ZIP file and has a 16 bit length. # So the comment may be up to 64K long. We limit the search for the # signature to a few Kbytes at th