[issue18373] implement sys.get/setbyteswarningflag()

2014-01-15 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue20269] Inconsistent behavior in pdb when pressing Ctrl-C

2014-01-15 Thread Xavier de Gaye
New submission from Xavier de Gaye: With this script: # START def foo(): while 1: pass import pdb; pdb.set_trace() foo() # END The following sequence of pdb commands aborts the script with a KeyboardInterrupt exception: next Ctrl-C continue While the equivalent following seq

[issue20187] The Great Argument Clinic Conversion Derby Meta-Issue

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I want to warn against the converting of base objects (whose sources lie in Objects/). Their performance is critical and the converting can worsen it. Often they even don't use PyArg_ParseTuple due to performance reasons or because argument parsing is too sp

[issue14455] plistlib unable to read json and binary plist files

2014-01-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1a8149ba3000 by Ronald Oussoren in branch 'default': Issue #14455: Fix some issues with plistlib http://hg.python.org/cpython/rev/1a8149ba3000 -- ___ Python tracker __

[issue20185] Derby #17: Convert 49 sites to Argument Clinic across 13 files

2014-01-15 Thread Vajrasky Kok
Vajrasky Kok added the comment: Here is the patch for Python/marshal.c. A couple of issues: 1. I can not have bytes as argument. bytes: Py_buffer -> not possible So I changed it to byte. 2. I can not give default value, marshal.version, to argument. version: int(c_default="Py_MARSHAL_VER

[issue14455] plistlib unable to read json and binary plist files

2014-01-15 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue20270] urllib.parse doesn't work with empty port

2014-01-15 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: According to RFC 3986 the port subcomponent is defined as zero or more decimal digits delimited from the host by a single colon. I.e. 'python.org:' is valid (but not normalized) form. Empty port is equivalent to absent port. >>> import urllib.parse >>> p =

[issue20271] urllib.parse.urlparse() accepts wrong URLs

2014-01-15 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: >>> import urllib.parse >>> p = urllib.parse.urlparse('http://[::1]spam:80') >>> p ParseResult(scheme='http', netloc='[::1]spam:80', path='', params='', query='', fragment='') >>> p.hostname '::1' >>> p.port 80 'http://[::1]spam:80' is invalid URL, but urll

[issue20271] urllib.parse.urlparse() accepts wrong URLs

2014-01-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +urllib.parse doesn't work with empty port ___ Python tracker ___ ___ Python-bugs-list

[issue18191] urllib2/urllib.parse.splitport does not handle IPv6 correctly

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Julien's patch is subject to bugs described in issue20270 and issue20271. As far as OpenStack Oslo library. -- dependencies: +urllib.parse doesn't work with empty port, urllib.parse.urlparse() accepts wrong URLs type: -> behavior versions: +Python 3

[issue14455] plistlib unable to read json and binary plist files

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I see that plistlib incorrectly writes large ints from 2**63 to 2**64-1 as negative values. >>> d = plistlib.dumps({'a': 18446744073709551615}, fmt=plistlib.FMT_BINARY) >>> plistlib.loads(d) {'a': -1} My patch did this correct (as 128-bit integer), and as yo

[issue14455] plistlib unable to read json and binary plist files

2014-01-15 Thread Ronald Oussoren
Ronald Oussoren added the comment: However, I have no idea how to write that file using Apple's APIs. I'd prefer to either be compatible with Apple's API (current behavior), or just outright reject values that cannot be represented as a 64-bit signed integer. The file you generated happens

[issue20009] Property should expose wrapped function.

2014-01-15 Thread Nick Coghlan
Nick Coghlan added the comment: __wrapped__ is specifically for the case where the outer function is a relatively straightforward wrapper around the inner one (i.e. those cases where it would be appropriate to use functools.wraps or Graham Dumpleton's more sophisticated wrapt module). More co

[issue14455] plistlib unable to read json and binary plist files

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > However, I have no idea how to write that file using Apple's APIs. Look in CFBinaryPList.c. It have a code for creating 128-bit integers: CFSInt128Struct val; val.high = 0; val.low = bigint; *plist = CFNumberC

[issue14455] plistlib unable to read json and binary plist files

2014-01-15 Thread Ronald Oussoren
Ronald Oussoren added the comment: kCFNumberSInt128Type is not public API, see the list of number types in . I agree that CFBinaryPlist.c contains support for those, and for writ

[issue14455] plistlib unable to read json and binary plist files

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: You have at least one way to create a 128 bit CFNumber. Read plist file (and you can create plist in XML format with big integers in any text editor). In any case it is not good to produce incorrect plist for big integers. If you don't want to support intege

[issue14455] plistlib unable to read json and binary plist files

2014-01-15 Thread Ronald Oussoren
Ronald Oussoren added the comment: Reopening because Cocoa behaves differently that I had noticed earlier... The (Objective-C) code below serialises an NSDictionary with an unsigned long of value ULLONG_MAX and then reads it back. I had expected that restored value contained a negative number,

[issue16251] pickle special methods are looked up on the instance rather than the type

2014-01-15 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue14455] plistlib unable to read json and binary plist files

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > I'm going to do some more spelunking to find out what's going on here, and > will adjust the plistlib code to fully represent all values of unsigned > 64-bit integers (likely based on your code for supporting 128-bit integers) My last patch supports only val

[issue20261] Cannot pickle some objects that have a __getattr__()

2014-01-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'll go ahead and dupe this to 16251, but will note the __getnewargs__() regression in 3.4. -- superseder: -> pickle special methods are looked up on the instance rather than the type ___ Python tracker

[issue16251] pickle special methods are looked up on the instance rather than the type

2014-01-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I ran into this recently while porting nose to 3.4. I duped http://bugs.python.org/issue20261 to this issue, but note that in http://bugs.python.org/issue20261#msg208109 I notice that the presence or absence of __getnewargs__() regresses the specific behavio

[issue19804] test_uuid.TestUUID.test_find_mac() fails

2014-01-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue14031] logging module cannot format str.format log messages

2014-01-15 Thread Vinay Sajip
Vinay Sajip added the comment: Cookbook updated. See changesets 7c4f0c3dedaf and 0056aaf42bf7 for more information - docs.python.org should update within a day. -- ___ Python tracker __

[issue14044] IncompleteRead error with urllib2 or urllib.request -- fine with urllib, wget, or curl

2014-01-15 Thread Laurento Frittella
Laurento Frittella added the comment: I had the same problem using urllib2 and the following trick worked for me import httplib httplib.HTTPConnection._http_vsn = 10 httplib.HTTPConnection._http_vsn_str = 'HTTP/1.0' Source: http://stackoverflow.com/a/20645845 -- nosy: +laurento.frittel

[issue14044] IncompleteRead error with urllib2 or urllib.request -- fine with urllib, wget, or curl

2014-01-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka type: -> behavior versions: +Python 3.3, Python 3.4 -Python 2.6, Python 3.1, Python 3.2 ___ Python tracker ___ _

[issue20187] The Great Argument Clinic Conversion Derby Meta-Issue

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: Can you give me an example of performance degradation due to Argument Clinic? What percentage slowdown is common? -- ___ Python tracker ___ __

[issue20187] The Great Argument Clinic Conversion Derby Meta-Issue

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have no any numbers. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue20187] The Great Argument Clinic Conversion Derby Meta-Issue

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: Until you have some numbers, your assertion has no weight and should be ignored. (As Carl Sagan once wrote: "That which can be asserted without evidence can be dismissed without evidence." And as Donald Knuth wrote: "Premature optimization is the root of all

[issue20262] Convert some debugging prints in zipfile to warnings

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I'm not sure. This is why I had added Larry and Georg to nosy list. This issue looks in a half-way between fixing a bug and adding new feature. -- ___ Python tracker ___

[issue20260] Argument Clinic: add unsigned integers converters

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: We can use this now. So I bumped it to the top of my queue and reviewed it. I had only minor feedback--thanks! -- ___ Python tracker ___

[issue20226] Argument Clinic: support for simple expressions?

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: That's okay, email me a sample at larry at hastings dot org and I'll take a look at it. Be sure to tell me which patch(es) were applied at the time. (Note: all you need to send is the Clinic block.) -- ___ Python

[issue19974] tarfile doesn't overwrite symlink by directory

2014-01-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue19974] tarfile doesn't overwrite symlink by directory

2014-01-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: patch review -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue20226] Argument Clinic: support for simple expressions?

2014-01-15 Thread Zachary Ware
Zachary Ware added the comment: Just confirmed that this patch fixes the traceback I was getting from winreg in #20172, but this has a new oddity: >>> help(winreg) ... ConnectRegistry(computer_name=, key=) ... Every param of every function has this kind of thing, positional or keyword, de

[issue15858] tarfile missing entries due to omitted uid/gid fields

2014-01-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: -> test needed versions: +Python 2.7, Python 3.3, Python 3.4 -3rd party, Python 2.6 ___ Python tracker ___ __

[issue20226] Argument Clinic: support for simple expressions?

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: I'd prefer it if you emailed me as I asked. That will help me get to it a lot quicker. -- ___ Python tracker ___ _

[issue20226] Argument Clinic: support for simple expressions?

2014-01-15 Thread Zachary Ware
Zachary Ware added the comment: Actually, I can reproduce on tip with just this patch applied; os.chmod shows it. And I was wrong, params that have a default are correct, it's just ones without. -- ___ Python tracker

[issue20241] Bad reference to RFC in document of ipaddress?

2014-01-15 Thread Fran Bull
Fran Bull added the comment: http://tools.ietf.org/html/rfc5735.html Special Use IPv4 Addresses does indeed agree with the docstring @property def is_unspecified(self): """Test if the address is unspecified. Returns: A boolean, True if this is the unspecifie

[issue20260] Argument Clinic: add unsigned integers converters

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Unfortunately I have discovered that there is significant difference between uint_converter in Modules/zlibmodule.c and proposed _PyLong_UnsignedInt_Converter. And there are tests in Lib/test/test_zlib.py which fail when _PyLong_UnsignedInt_Converter is used

[issue20262] Convert some debugging prints in zipfile to warnings

2014-01-15 Thread Georg Brandl
Georg Brandl added the comment: I'm actually more on the "fixing a bug" side. For me this is fine for 3.3. -- ___ Python tracker ___

[issue20260] Argument Clinic: add unsigned integers converters

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, and of course 5th option: do nothing. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue20232] Argument Clinic NULL default falsely implies None acceptability

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: One mandate I've given myself for this project: When a function provides a signature, it must be 100% accurate. A specific corollary of this: If you call a function, and for every optional parameter you explicitly pass it in with its default value from t

[issue20272] chain.from_iterable in the overview table not linking to the function

2014-01-15 Thread SilentGhost
New submission from SilentGhost: chain.from_iterable is not linkified in the overview table at the top of the itertools docs. The patch requires reformat of the table. -- assignee: docs@python components: Documentation files: linkify.diff keywords: patch messages: 208184 nosy: SilentGho

[issue20272] chain.from_iterable in the overview table not linking to the function

2014-01-15 Thread SilentGhost
Changes by SilentGhost : -- versions: -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue20231] Argument Clinic accepts no-default args after default args

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: I'll fix this, but it's lower priority than the new features for Clinic that people need in order to get unblocked. -- ___ Python tracker ___ _

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: In the past few days I added "cloning" functions, which lets you reuse the parameters and return converter from an existing function. That might help with Modules/_ctypes/_ctypes. -- ___ Python tracker

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: All the functions in curses_panel are convertable. The threeMETH_NOARGS functions simply get no arguments. And here's new_panel: new_panel window: object(subclass_of='&PyCursesWindow_Type') / -- ___ Python tra

[issue20273] Argument Clinic: unhelpful crashes

2014-01-15 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Sometimes when Argument Clinic see something wrong, it raises exception and exit with printed traceback, instead of output helpful error message which points on line with illegal syntax. I open this issue to report about such problems. $ ./python Tools/cl

[issue20274] sqlite module has bad argument parsing code, including undefined behavior in C

2014-01-15 Thread Larry Hastings
New submission from Larry Hastings: The code in Modules/_sqlite/connection.c is sloppy. The functions pysqlite_connection_execute, pysqlite_connection_executemany, and pysqlite_connection_executescript accept a third "PyObject *kwargs". However none of these functions are marked METH_KEYWORD.

[issue20273] Argument Clinic: unhelpful crashes

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I suppose this crash is caused by this code: /*[clinic input] zlib.Compress.flush self: self(type="compobject *") mode: int(c_default="Z_FINISH") = zlib.Z_FINISH One of the constants Z_SYNC_FLUSH, Z_FULL_FLUSH, Z_FINISH. If mode == Z_F

[issue20274] sqlite module has bad argument parsing code, including undefined behavior in C

2014-01-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue8876] distutils should not assume that hardlinks will work

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: Has this been fixed? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue20273] Argument Clinic: unhelpful crashes

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: I'm marking this as a duplicate of #20226, the "add general-purpose expressions" issue, because that will fix the behavior you're seeing. As for "in general Argument Clinic should have better error reporting", this is too general for an issue right now. In t

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

2014-01-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +Argument Clinic: support for simple expressions? ___ Python tracker ___ ___ Python-bug

[issue20235] Argument Clinic: recover a bit more gracefully from exceptions

2014-01-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue20273] Argument Clinic: unhelpful crashes

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Zachary. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue20273] Argument Clinic: unhelpful crashes

2014-01-15 Thread Zachary Ware
Zachary Ware added the comment: Georg already opened an issue with a patch about providing a little more information in unexpected exceptions, see issue20235. -- nosy: +zach.ware superseder: -> Argument Clinic: support for simple expressions? ___ Py

[issue20235] Argument Clinic: recover a bit more gracefully from exceptions

2014-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. This patch helps me (issue20273). Thank you. -- components: +Demos and Tools stage: -> commit review type: -> enhancement versions: +Python 3.4 ___ Python tracker ___

[issue20235] Argument Clinic: recover a bit more gracefully from exceptions

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: LGTM, please commit. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

2014-01-15 Thread Zachary Ware
Zachary Ware added the comment: About cloning: Cloned functions still expect their own impl function. In current winreg, OpenKey and OpenKeyEx literally are the same function by two names; is the best approach for this to define winreg_OpenKeyEx_impl as `return winreg_OpenKey_impl(module, ke

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
New submission from Yury Selivanov: Can we remove debug timing around "self._selector.select(timeout)" (or at least make it configurable) from BaseEventLoop? Right now the code is: # TODO: Instrumentation only in debug mode? t0 = self.time() event_list = self._selector.s

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Yury Selivanov added the comment: And I'd be happy to help with the patch. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue20260] Argument Clinic: add unsigned integers converters

2014-01-15 Thread Stefan Krah
Stefan Krah added the comment: I think we cannot change PyLong_AsUnsignedLong() without a deprecation period, if at all. That leaves the option of changing the converters. My preference is to raise either OverflowError or ValueError for *both* out-of-range conditions. People may me used to Ove

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Guido van Rossum
Guido van Rossum added the comment: What part of the debug timing is more expensive than the select call itself? -- ___ Python tracker ___ ___

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread STINNER Victor
STINNER Victor added the comment: I'm also in favor of removing this code, or a debug flag to enable it. -- nosy: +haypo ___ Python tracker ___ __

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Guido van Rossum
Guido van Rossum added the comment: Can you check for the level of the logger? That would work for me. -- ___ Python tracker ___ ___ P

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Guido van Rossum
Guido van Rossum added the comment: So you admit you just want to optimize prematurely? -- ___ Python tracker ___ ___ Python-bugs-list

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Yury Selivanov added the comment: > What part of the debug timing is more expensive than the select call itself? Well, there is nothing really expensive there, but: - time.monotonic() is still a syscall - logging.log executes a fair amount of code too -- __

[issue20274] sqlite module has bad argument parsing code, including undefined behavior in C

2014-01-15 Thread R. David Murray
R. David Murray added the comment: Why do you want to fix it in order versions? Can it lead to a crash? For __call__, it seems to me we should do a deprecation and remove it in 3.5. Otherwise we'll risk breaking working code for no good reason (working code with useless parameters, but still

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread STINNER Victor
STINNER Victor added the comment: > So you admit you just want to optimize prematurely? I don't understand the purpose of these timing information, I don't use them. I would be more interested to know which functions take longer than XXX ms and so hangs the event loop. By the way, it's not do

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Yury Selivanov added the comment: I wrote a small micro-benchmark, that creates 100K tasks and executes them. With debug code the execution time is around 2.8-3.1s, with debug comment commented out it's around 2.3-2.4s. Again, it's a micro-benchmark, and in a real application the impact is goi

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Yury Selivanov added the comment: The micro-benchmark i used is here: https://gist.github.com/1st1/8446175 -- ___ Python tracker ___ _

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread STINNER Victor
STINNER Victor added the comment: > With debug code the execution time is around 2.8-3.1s, with debug comment > commented out it's around 2.3-2.4s. Wow, that's impressive that such minor syscalls can take so much times! I modified your script to repeat the test 5 times and take the minimum tim

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Guido van Rossum
Guido van Rossum added the comment: I have definitely used this log message. It typically tells me that something is responding too slow. Regarding the microbench, please count and report how many times it actually calls select(). -- ___ Python tr

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Yury Selivanov added the comment: > Wow, that's impressive that such minor syscalls can take so much times! Apparently, it's not syscalls, it's logging. Actually, with commented out "logging.log" code I can't see a difference wether there are calls to monotonic or not. So we can keep the code

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread STINNER Victor
Changes by STINNER Victor : -- keywords: +patch Added file: http://bugs.python.org/file33485/debug_flag.patch ___ Python tracker ___ _

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread STINNER Victor
STINNER Victor added the comment: Here are two patches: - logger_is_enabled_for.patch: use logger.isEnabledFor(INFO) to avoid the call - add a _debug flag to BaseEventLoop Benchmark: - original: 3.90 - logger: 3.04 - _debug: 2.81 I like the _debug flag because it's faster, but I'm not sure th

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Yury Selivanov added the comment: > Regarding the microbench, please count and report how many times it actually > calls select(). I'm on MacOS X, so it's KqueueSelector. It's 'select' method (and self._kqueue.control respectively) is called twice more times. So for 100K tasks, select gets ca

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Yury Selivanov added the comment: Victor, Re your patch: since it's not really time syscalls, and Guido said he's using this debug code, how about we just have something like: t0 = self.time() event_list = self._selector.select(timeout) t1 = self.time() if t1 -

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Guido van Rossum
Guido van Rossum added the comment: I like logger_is_enabled_for.patch. If you want to add other debug features please propose something on the Tulip tracker: http://code.google.com/p/tulip/issues/list . -- ___ Python tracker

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Yury Selivanov added the comment: And, I think that "asyncio._DEBUG" or even "asyncio.DEBUG" would be a great idea. -- ___ Python tracker ___ ___

[issue18373] implement sys.get/setbyteswarningflag()

2014-01-15 Thread Jakub Wilk
Changes by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Yury Selivanov added the comment: Victor, Guido, Please take a look at the attached one. I believe it's slightly better, than the "logger_is_enabled_for.patch", since it doesn't log stuff that was faster than 1 second, and is simpler too. -- ___ Pyt

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Changes by Yury Selivanov : Added file: http://bugs.python.org/file33487/greater_than_1sec_logging.patch ___ Python tracker ___ ___ Python-bug

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Changes by Yury Selivanov : Removed file: http://bugs.python.org/file33487/greater_than_1sec_logging.patch ___ Python tracker ___ ___ Python-b

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Changes by Yury Selivanov : Added file: http://bugs.python.org/file33488/greater_than_1sec_logging.patch ___ Python tracker ___ ___ Python-bug

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread STINNER Victor
STINNER Victor added the comment: I opened an issue to propose asyncio.DEBUG: BaseEventLoop._run_once() -- ___ Python tracker ___ ___

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Guido van Rossum
Guido van Rossum added the comment: I really want to log the time every time if level == DEBUG and only if > 1 sec for other levels, so maybe all you need to do is remove the comment? :-) (Or maybe logger.isEnabledFor(logging.INFO) is faster than logger.log() when nothing gets logged? --

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread STINNER Victor
STINNER Victor added the comment: I opened an issue to propose asyncio.DEBUG: http://code.google.com/p/tulip/issues/detail?id=104 (woops, copy/paste failure :-)) -- ___ Python tracker _

[issue20275] asyncio: remove debug code from BaseEventLoop

2014-01-15 Thread Yury Selivanov
Yury Selivanov added the comment: > I really want to log the time every time if level == DEBUG and only if > 1 > sec for other levels, so maybe all you need to do is remove the comment? :-) > (Or maybe logger.isEnabledFor(logging.INFO) is faster than logger.log() when > nothing gets logged?

[issue20274] sqlite module has bad argument parsing code, including undefined behavior in C

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: You're right, deprecation sounds best. If Georg or Benjamin want the fix in earlier releases I'll split the pysqlite_connection_call into another issue, otherwise I won't bother. As for fixing the undefined behavior in older versions: since its behavior is u

[issue15858] tarfile missing entries due to omitted uid/gid fields

2014-01-15 Thread Tom Lynn
Tom Lynn added the comment: The secondary issue, which the patch doesn't address, is that TarFile.next() seems unpythonic; it treats any {Invalid,Empty,Truncated}HeaderError after offset 0 as EOF rather than propagating the exception. It looks deliberate, but I'm not sure why it would be done

[issue20276] ctypes._dlopen should not force RTLD_NOW

2014-01-15 Thread Albert Zeyer
New submission from Albert Zeyer: On MacOSX, when you build an ARC-enabled Dylib with backward compatibility for e.g. MacOSX 10.6, some unresolved functions like `_objc_retainAutoreleaseReturnValue` might end up in your Dylib. Some reference about the issue: 1. http://stackoverflow.com/q/21119

[issue20276] ctypes._dlopen should not force RTLD_NOW

2014-01-15 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files

2014-01-15 Thread Ryan Smith-Roberts
Ryan Smith-Roberts added the comment: Forgot to linewrap a paragraph. -- Added file: http://bugs.python.org/file33489/argument_clinic_socketmodule_v2.patch ___ Python tracker __

[issue20189] inspect.Signature doesn't recognize all builtin types

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: Nick, could you maybe review this? -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list ma

[issue20260] Argument Clinic: add unsigned integers converters

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: I'm glad you caught that! First things first: the converted code should behave identically to the existing code, including raising the same exceptions. If you examine the exception hierarchy: http://docs.python.org/3.4/library/exceptions.html#exception-hi

[issue20276] ctypes._dlopen should not force RTLD_NOW

2014-01-15 Thread Ned Deily
Changes by Ned Deily : -- nosy: +ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue20227] Argument Clinic: rename arguments in generated C?

2014-01-15 Thread Larry Hastings
Larry Hastings added the comment: I don't see the big win from this. You can rename variables in C any way you like. "functionname as c_basename" is to fix otherwise unavoidable collisions; this seems like a nice-to-have. And I already have a lot on my plate. I could consider it later but

  1   2   >