[issue8852] _socket fails to build on OpenSolaris x64

Antoine Pitrou added the comment: Committed in r85868 (3.2), r85869 (3.1) and r85870 (2.7). Thank you. -- resolution: accepted -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue8852] _socket fails to build on OpenSolaris x64

Antoine Pitrou added the comment: Ok, here is an updated patch with finer-grained constants injection. -- Added file: http://bugs.python.org/file19383/buildsocket.patch ___ Python tracker __

[issue8852] _socket fails to build on OpenSolaris x64

John Levon added the comment: The posted patch: better if the PACKET_* tests were just at the two missing ones rather than removing all of the ones that are actually there like PACKET_OUTGOING. -- ___ Python tracker

[issue8852] _socket fails to build on OpenSolaris x64

Antoine Pitrou added the comment: David's patch works here (OpenSolaris build 134). -- components: +Build, Extension Modules nosy: +laca, movement, pitrou resolution: -> accepted stage: -> commit review versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6 ___

[issue8852] _socket fails to build on OpenSolaris x64

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: Thank you Mark for confirming what I found. I understand your reservations about the code if you don't know of its correctness. I must admit I don't myself. I don't have a clue how this _socket module should be built. But it is clear to me that the original

[issue8852] _socket fails to build on OpenSolaris x64

Mark Dickinson added the comment: I'm also seeing the failure of the _socket module to build on OpenSolaris build snv_134 (the most recent development build). The socketmodule.c.patch patch fixes that failure for me, allowing the test-suite to run. I'm afraid I don't feel competent to commen

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: Sorry, I put that note on the wrong issue! ignore it. -- ___ Python tracker ___ ___ Python-bugs-list

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: I think I spoke too soon. I just downloaded the 2.7.rc2. Using both 32 and 64-bit builds, with the only patch being that I attached to issue8852 some months back, the problem occurs again. test_float test test_float failed -- Traceback (most recent call las

[issue8852] _socket fails to build on OpenSolaris x64

Martin v. Löwis added the comment: > I appreciate your point. But do you know if anyone has it on their > TODO list? It's on my todo list, but that still might mean I can only get to it next year. > If not, is there anything I could do about it? You could invoke the 5-for-one deal. Review 5 i

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: Hi Martin, I appreciate your point. But do you know if anyone has it on their TODO list? If not, is there anything I could do about it? I don't have commit access to the Python source code, but if there is anything else I can do I'd like to. This is a pretty

[issue8852] _socket fails to build on OpenSolaris x64

Martin v. Löwis added the comment: > Is there anything I can do to get someone to do something about it? I > would have thought with a patch, it would not be hard for someone to > fix. Sure. Unfortunately, the day has only 24 hours. -- ___ Python tr

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: Is there anything I can do to get someone to do something about it? I would have thought with a patch, it would not be hard for someone to fix. -- ___ Python tracker ___

[issue8852] _socket fails to build on OpenSolaris x64

Martin v. Löwis added the comment: > Has anyone done anything about fixing this issue? AFAICT, nobody did. -- ___ Python tracker ___

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: Has anyone done anything about fixing this issue? The patch I attached appears to allow _socket to build on OpenSolaris and when I run the test suite, there is no failure of _socket. I've just downloaded the latest source code for the 3.1.2, 2.6.5 and Python-

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: I'd made a mistake when manually applying your patch, although my mistake made no practical difference. I'm attaching a corrected patch, which has all the changes needed to get this to build on OpenSolaris. It basically only checks for things before trying to c

[issue8852] _socket fails to build on OpenSolaris x64

Changes by David Kirkby : Removed file: http://bugs.python.org/file17497/socketmodule.c.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: I forget to say I had attached the patch 'socketmodule.c.patch' which allows _socket to build. (I know you can see that if you look, but I thought it useful to write it). I do have some other modules not building on OpenSolaris (_curses, _curses_panel, _tkint

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: Hi, thank you for the patch. I hope you can keep Python building the same modules on Solaris as Linux, as that would be a real shame if it did not. This module is used in the Sage maths software. I had some difficulty applying your patch using the 'patch' c

[issue8852] _socket fails to build on OpenSolaris x64

Martin v. Löwis added the comment: The AF_PACKET support was original meant for Linux. When Solaris now also supports that socket family, and with a similar interface, it might be interesting to port that support to Solaris. If nobody volunteers, it might be easier to restrict this to Linux o

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: Two points I should have stated. 1) http://www.lotuseyes.de/blog/error-installing-plone-on-opensolaris-using-the-unified-installer has a discussion about this issue. It was related to someone trying to install "Plone" but the problem is a failure of _socket t

[issue8852] _socket fails to build on OpenSolaris x64

David Kirkby added the comment: I was obviously looking for the wrong file. ./pyconfig.h shows: /* Define to 1 if you have the header file. */ #define HAVE_NETPACKET_PACKET_H 1 the file does indeed exist drkir...@hawk:~$ find /usr/include -name packet.h /usr/include/netpacket/packet.h -

[issue8852] _socket fails to build on OpenSolaris x64

Martin v. Löwis added the comment: Please verify that HAVE_NETPACKET_PACKET_H does indeed get defined, looking at pyconfig.h. Please inspect config.log to find out why it does get defined. -- nosy: +loewis ___ Python tracker

[issue8852] _socket fails to build on OpenSolaris x64

New submission from David Kirkby : Using Python 2.6.5, the module _socket is failing to build on OpenSolaris. The problem can be worked around with a hack, but I've not verified if the hack actually results in working code - but at least it compiles. See below. The problem seems to be that HA