[issue11549] Build-out an AST optimizer, moving some functionality out of the peephole optimizer

Changes by Jeremy Hylton : -- nosy: +Jeremy.Hylton ___ Python tracker <http://bugs.python.org/issue11549> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9997] function named 'top' gets unexpected namespace/scope behaviour

Jeremy Hylton added the comment: Let me fix that. -- nosy: +Jeremy.Hylton ___ Python tracker <http://bugs.python.org/issue9997> ___ ___ Python-bugs-list mailin

[issue6500] urllib2 maximum recursion depth exceeded

Jeremy Hylton added the comment: Ok. I'll take a look, too. Jeremy On Sat, Feb 27, 2010 at 4:30 AM, Ezio Melotti wrote: > > Changes by Ezio Melotti : > > > -- > nosy: +orsenthil > status: pending -> open > > __

[issue4199] add shorthand global and nonlocal statements

Jeremy Hylton added the comment: I guess there's some question about whether the syntax in the PEP was considered carefully when it was approved. If so, I'm not sure that we want to re-open the discussion. On the other hand, it's been a long time since the PEP was approved a

Re: [issue4199] add shorthand global and nonlocal statements

does have the downside that you need to enforce this unwritten constraint of the AST in ast.c and in the ast module. It also means that the AST will change in a non-backwards compatible way. I don't see how to do that given that we're also changing the language spec. (Do you want to

[issue4199] add shorthand global and nonlocal statements

Jeremy Hylton added the comment: On Sat, Dec 6, 2008 at 1:28 PM, Benjamin Peterson wrote: > > Benjamin Peterson added the comment: > > I think I may have been merging add_ast_fields when I wrote the patch. > > Here's a new patch that handles "global x, = (5,)"

[issue4199] add shorthand global and nonlocal statements

Jeremy Hylton added the comment: Is deferred blocker a higher priority? Jeremy On Tue, Feb 23, 2010 at 4:37 PM, Georg Brandl wrote: > > Georg Brandl added the comment: > > "High" is not high enough :) > > -- > pri

[issue4617] SyntaxError when free variable name is also an exception target

Jeremy Hylton added the comment: The patch looks pretty good. I'd factor out the common error-checking code (common between LOAD_DEREF and DELETE_DEREF) into a helper function. It would also be good to add some test cases. Jeremy On Tue, Feb 23, 2010 at 9:38 AM, Guido van Rossum

[issue4617] SyntaxError when free variable name is also an exception target

Jeremy Hylton added the comment: On Mon, Feb 22, 2010 at 6:10 PM, Guido van Rossum wrote: > > Guido van Rossum added the comment: > > All examples so far (*) have to do with our inability to have properly nested > blocks. If we did, I'd make the except clause a block, an

Re: [issue4617] SyntaxError when free variable name is also an exception target

It's an interesting bug. Maybe the compiler shouldn't allow you to use such a variable as a free variable in a nested function? On Thu, Feb 11, 2010 at 9:09 PM, Craig McQueen wrote: > > Craig McQueen added the comment: > > There's also this one which caught me out: > > def outer(): >  x = 0 >  

[issue7806] httplib.HTTPConnection.getresponse closes socket which destroys the response

Jeremy Hylton added the comment: On Sun, Feb 21, 2010 at 5:38 PM, Robert Buchholz wrote: > > Robert Buchholz added the comment: > > almost... HTTPConnection is calling close() on the socket object, but > HTTPResponse still has an open file-like object from a previous makefile(

[issue7806] httplib.HTTPConnection.getresponse closes socket which destroys the response

Jeremy Hylton added the comment: In particular, I mean this part of the socket API: socket.makefile([mode[, bufsize]]) Return a file object associated with the socket. (File objects are described in File Objects.) The file object references a dup()ped version of the socket file descriptor, so

[issue7806] httplib.HTTPConnection.getresponse closes socket which destroys the response

Jeremy Hylton added the comment: On Sat, Feb 20, 2010 at 12:06 AM, R. David Murray wrote: > > R. David Murray added the comment: > > But the docs (which presumably describe the API) say that the socket is > unusable after the call to close, which argues that the param

[issue7806] httplib.HTTPConnection.getresponse closes socket which destroys the response

Jeremy Hylton added the comment: On Fri, Feb 19, 2010 at 6:22 PM, R. David Murray wrote: > > R. David Murray added the comment: > > But a goal is for the standard library to work with Python implementations > other than CPython, and the reference counting behavior described

Re: [issue7806] httplib.HTTPConnection.getresponse closes socket which destroys the response

I don't think the HTTPConnection class was designed to work with sockets that don't follow the Python socket API. If you want to use a different socket, you should create some wrapper that emulates the Python socket ref count behavior. Jeremy On Mon, Feb 1, 2010 at 5:23 PM, Robert Buchholz wrot

[issue1540] Refleak tests: test_doctest and test_gc are failing

Jeremy Hylton added the comment: Amaury-- I think that will work. I put together a small patch that seems to pass all the tests, but it too messy. We need some care to make sure we don't spin forever if there's some degenerate case where we never

[issue1540] Refleak tests: test_doctest and test_gc are failing

Jeremy Hylton added the comment: One last thought on this bug. The problem is that after we try to delete garbage, we really can't know much about the state of the objects in the finalizers list. If any of the objects that are cleared end up causing a finalizer to run, then any o

[issue1540] Refleak tests: test_doctest and test_gc are failing

Jeremy Hylton added the comment: I spent some time to understand the example script today. The specific issue is that a set of objects get put into the list of unreachable objects with finalizers (both Immutable and Finalizer instances). When Cycle's __dict__ is cleared, it also de

[issue1540] Refleak tests: test_doctest and test_gc are failing

Jeremy Hylton added the comment: I'm trying to figure out the attached script. If I run Python 3.0, the script doesn't run because of the undefined gc.DEBUG_OBJECTS. If I just remove that, the script runs without error. Does that mean the problem is fixed? Or is running withou

Re: [issue3566] httplib persistent connections violate MUST in RFC2616 sec 8.1.4.

Not that we've removed the try one more time branch of the code, because it was causing other problems. Jeremy On Sun, Aug 16, 2009 at 6:24 PM, Gregory P. Smith wrote: > > Gregory P. Smith added the comment: > > btw, when using async io (poll, select, etc) I -think- your socket will > see a read

[issue5578] unqualified exec in class body

Jeremy Hylton added the comment: Why did it change from 2.5 to 2.6? I'm not sure that the change makes any sense. (Dreading the answer that I changed it...) -- ___ Python tracker <http://bugs.python.org/i

[issue5628] TextIOWrapper fails with SystemError when reading HTTPResponse

Jeremy Hylton added the comment: I just wanted to mention that the current head of py3k returns an http.client.HTTPResponse and not a urllib.respone.addinfourl. That doesn't mean it is the right thing to pass to TextIOWrapper. It's an instance of

[issue5628] TextIOWrapper fails with SystemError when reading HTTPResponse

New submission from Jeremy Hylton : import io import urllib.request f_bytes = urllib.request.urlopen("http://www.python.org/";) f_string = io.TextIOWrapper(f_bytes, "iso-8859-1") print(f_string.read()) -- components: Library (Lib) messages: 84840 nosy: jhylton sev

[issue2344] Using an iteration variable outside a list comprehension needs a Py3K warning

Jeremy Hylton added the comment: Seemed like a good idea, but no one knew how to do it. -- resolution: -> wont fix status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue2344] Using an iteration variable outside a list comprehension needs a Py3K warning

Changes by Jeremy Hylton : -- nosy: +jhylton ___ Python tracker <http://bugs.python.org/issue2344> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1346238] A constant folding optimization pass for the AST

Changes by Jeremy Hylton : -- priority: high -> normal ___ Python tracker <http://bugs.python.org/issue1346238> ___ ___ Python-bugs-list mailing list Unsubscri

[issue4199] add shorthand global and nonlocal statements

Changes by Jeremy Hylton : -- nosy: +jhylton ___ Python tracker <http://bugs.python.org/issue4199> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5524] execfile() removed from Python3

Jeremy Hylton added the comment: It doesn't seem helpful to leave this issue open, particularly since the title suggest there's a problem with execfile being removed and that's not going to change. -- nosy: +jhylton status: open -> closed

[issue5578] unqualified exec in class body

Jeremy Hylton added the comment: exec is allowed in a class statement -- resolution: accepted -> rejected status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue4831] exec() behavior - revisited

Jeremy Hylton added the comment: I think this bug ran out of steam. Python is behaving as intended, and I think Georg addressed all of David's questions. -- nosy: +jhylton resolution: -> works for me status: open -> closed ___ Pyt

[issue991196] An inconsistency with nested scopes

Jeremy Hylton added the comment: This code behaves as intended. The module-level execution environment is different than other environments. The global scope and local scope are the same dictionary. Assignments at the top-level become globals because of this behavior of the execution

[issue991196] An inconsistency with nested scopes

Changes by Jeremy Hylton : -- assignee: -> jhylton nosy: +jhylton ___ Python tracker <http://bugs.python.org/issue991196> ___ ___ Python-bugs-list mai

[issue1153622] eval does not bind variables in lambda bodies correctly

Jeremy Hylton added the comment: The current docs cover this case: http://docs.python.org/reference/executionmodel.html#interaction-with-dynamic-features It basically says that code compiled via exec / eval can't access free variables. -- resolution: -> wont fix stat

[issue4315] On some Python builds, exec in a function can't create shadows of variables if these are declared "global" in another function of the same module

Jeremy Hylton added the comment: Committed revision 70809 (trunk). Needs to be backported. -- nosy: +jhylton resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue1659410] Minor AST tweaks

Changes by Jeremy Hylton : -- nosy: +jhylton ___ Python tracker <http://bugs.python.org/issue1659410> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4675] urllib's splitpasswd does not accept newline chars in passwords

Jeremy Hylton added the comment: looks good to me -- nosy: +jhylton ___ Python tracker <http://bugs.python.org/issue4675> ___ ___ Python-bugs-list mailin

[issue4962] urlparse & nfs url (rfc 2224)

Jeremy Hylton added the comment: looks good to me -- nosy: +jhylton ___ Python tracker <http://bugs.python.org/issue4962> ___ ___ Python-bugs-list mailin

[issue5578] unqualified exec in class body

Changes by Jeremy Hylton : -- assignee: -> jhylton nosy: +jhylton resolution: -> accepted type: -> behavior ___ Python tracker <http://bugs.python.o

[issue4773] HTTPMessage not documented and has inconsistent API across 2.6/3.0

Jeremy Hylton added the comment: The attached file is vaguely related to the current discussion. I'd like to document the API for the urllib response, but I'd also like to simplify the implementation on the py3k side. We can document the simple API on the py3k side, then support so

[issue918368] urllib doesn't correct server returned urls

Changes by Jeremy Hylton : -- nosy: +jhylton ___ Python tracker <http://bugs.python.org/issue918368> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1153027] http_error_302() crashes with 'HTTP/1.1 400 Bad Request

Changes by Jeremy Hylton : -- nosy: +jhylton ___ Python tracker <http://bugs.python.org/issue1153027> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue3243] Support iterable bodies in httplib

Jeremy Hylton added the comment: Seems like a reasonable feature request. I'm going to apply a variant of the patch in 3.1 first. -- assignee: -> jhylton nosy: +jhylton resolution: -> accepted ___ Python tracker <http://bugs.python

[issue5542] Socket is closed prematurely in httplib, if server sends response before request body has been sent

Jeremy Hylton added the comment: I think it makes sense to leave the socket open in this case. (In general, I think httplib is too aggressive about closing the socket.) I'm checking in a version for py3k, and will get around to backporting it later. Committed revision

[issue5542] Socket is closed prematurely in httplib, if server sends response before request body has been sent

Jeremy Hylton added the comment: Wow! Old issue. This behavior was present in Greg's original version of the code. -- ___ Python tracker <http://bugs.python.org/i

[issue5542] Socket is closed prematurely in httplib, if server sends response before request body has been sent

Changes by Jeremy Hylton : -- assignee: -> jhylton nosy: +jhylton ___ Python tracker <http://bugs.python.org/issue5542> ___ ___ Python-bugs-list mai

[issue5314] http client error

Jeremy Hylton added the comment: Committed revision 70638. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue5314] http client error

Jeremy Hylton added the comment: Ok. Discovered that RFC 2616 says that iso-8859-1 is the default charset, so I will use that to encode strings instead of ascii. If you want utf-8, you could encode the string yourself before calling request(). Presumably, you should also add a content-type

[issue5314] http client error

Jeremy Hylton added the comment: The documentation is pretty vague on this point. If you send something other than plain ascii, it gets a bit tricky to figure out what other headers need to be added. It would be safer for the client to pick an encoding (e.g. utf-8) and encode the string

[issue5468] urlencode does not handle "bytes", and could easily handle alternate encodings

Jeremy Hylton added the comment: Indeed, I think I confused some other character encoding issues related to HTTP with the URI issue. The discussion in RFC 3986 is length and only occasionally clarifying for this issue. That is, it doesn't say anything definitive like applications are fr

[issue5314] http client error

Jeremy Hylton added the comment: I'm not sure what to do here. I guess changing to utf-8 is safe insofar as the current code only accepts ascii, so the only code that breaks will be code that depends on the encode() call raising an exception. It seems like the client out to specif

[issue5418] urllib.response.addinfourl does not support __exit__

Jeremy Hylton added the comment: Makes sense to me. Committed revision 70625. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue5418] urllib.response.addinfourl does not support __exit__

Changes by Jeremy Hylton : -- assignee: -> jhylton nosy: +jhylton resolution: -> accepted ___ Python tracker <http://bugs.python.org/issue5418> ___ ___

[issue4773] HTTPMessage not documented and has inconsistent API across 2.6/3.0

Jeremy Hylton added the comment: A plausible solution is to pick some core set of functionality that we think people need and document that API. We can modify one or both of the current implementations to include that functionality. What do we need

[issue4773] HTTPMessage not documented and has inconsistent API across 2.6/3.0

Jeremy Hylton added the comment: No deep thought was given to the HTTPMessage API. Here's the extent of the discussion that I can find. I've changed the names, but you can find the full discussion at http://bugs.python.org/issue2848 A: mimetools.Message is compa

[issue5468] urlencode does not handle "bytes", and could easily handle alternate encodings

Jeremy Hylton added the comment: I'm not sure I understand the part of the code that deals with binary strings. I agree the current behavior is odd. RFC 2396 says that non-ascii characters must be encoded as utf-8 and then percent escaped. In the test case you started with, you enco

[issue4631] urlopen returns extra, spurious bytes

Jeremy Hylton added the comment: I have a patch here that seems to work for the specific url and that passes all the tests. Can anyone check whether it works for a larger set of cases? I'm a little concerned because I don't understand the new io library in much detail. There

[issue4631] urlopen returns extra, spurious bytes

Jeremy Hylton added the comment: Brief update: The Python 2.x code works because readline() is provided by socket._fileobject. The Python 3.x code fails because it grabs the HTTPResponse.fp instance variable at the end of AbstractHTTPHandler.do_open. That method needs to pass the response to

[issue3761] urllib.request and urllib.response cannot handle HTTP1.1 chunked encoding

Jeremy Hylton added the comment: I'm sorry that I didn't notice this bug report in September! The chunked support does exist in the http package, but it doesn't work with urllib. Tracking in 4631. -- nosy: +jhylton resolution: -> duplicate status: open -&

[issue4631] urlopen returns extra, spurious bytes

Changes by Jeremy Hylton : -- assignee: -> jhylton ___ Python tracker <http://bugs.python.org/issue4631> ___ ___ Python-bugs-list mailing list Unsubscri

Re: [issue4631] urlopen returns extra, spurious bytes

Does the same thing happen with 2.6? Jeremy On Thu, Dec 11, 2008 at 8:53 AM, Jean-Paul Calderone wrote: > > Jean-Paul Calderone added the comment: > > The "f65" is the chunk length for the first chunk returned when > requesting that URL. A proxy could easily hide this by switching to a > diffe

Re: [issue4608] urllib.request.urlopen does not return an iterable object

Oops. I didn't think it translate the code in addinfobase to the new style of iterators. Jeremy On Tue, Dec 9, 2008 at 7:50 AM, Senthil <[EMAIL PROTECTED]> wrote: > > Senthil <[EMAIL PROTECTED]> added the comment: > > I verified this bug in the Py3.0 and Py3.1. Shall come out with a patch > for

[issue4336] Fix performance issues in xmlrpclib

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: I submitted r67442, which combines the headers and body in a single send() call. We should look at the buffering issue now, although I probably won't have any time to check on it until Friday. ___

[issue4456] xmlrpc is broken

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: I don't think I understand this report. The TransportSubclassTestCase class tests the behavior of overridable methods that don't exist in Python 3.0. Is this really a Python 3.0 problem? I'm not sure why we expect it t

[issue4336] Fix performance issues in xmlrpclib

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: I did the simple part of the patch, where the request and headers are sent at the same time. The applied patch didn't pass the test suite, and I want to think about the buffering change a bit more. It's definitely tricky.

Re: [issue4336] Fix performance issues in xmlrpclib

I think we're making progress, but I'm still not sure about the new httplib api. My current worry is that endheaders() behaves very differently when send_data is false. My chief concern is that the __state variable is going to indicate that the request has been sent when we're really depending on

[issue1208304] urllib2's urlopen() method causes a memory leak

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: Python 2.4 is now in security-fix-only mode. No new features are being added, and bugs are not fixed anymore unless they affect the stability and security of the interpreter, or of Python applications. http://www.python.org/download/re

Re: [issue4336] Fix performance issues in xmlrpclib

d for efficiency. Jeremy On Mon, Nov 24, 2008 at 12:32 PM, Jeremy Hylton <[EMAIL PROTECTED]> wrote: > > Jeremy Hylton <[EMAIL PROTECTED]> added the comment: > > This patch makes sense in principle, but some of the details need to > change. The _send_output() method

[issue4327] Patch: simplify complex constant assignment statements

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: I haven't thought about the code in a while, but what code that modifies the AST are we worried about? There are lots of modifications in ast.c, since it is being created there. The case we really care about is sequences, where

[issue4336] Fix performance issues in xmlrpclib

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: Just wanted to mention that the best solution is to update as much code as possible to use HTTPConnection instead of HTTP. I'm not sure how easy it is to do for xmlrpclib, since it exposes methods like send_content(). I guess we c

[issue4336] Fix performance issues in xmlrpclib

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: This patch makes sense in principle, but some of the details need to change. The _send_output() method is used by some clients, merely because it can be used :-(. It's fairly easy to preserve this API for backwards compatibility.

Re: [issue4327] Patch: simplify complex constant assignment statements

On Mon, Nov 24, 2008 at 12:14 PM, David Turner <[EMAIL PROTECTED]> wrote: > > David Turner <[EMAIL PROTECTED]> added the comment: > > jhylton, keep in mind that this would require an additional "parent" > argument to each function which takes a stmt. Do you think this added > complexity is worth i

[issue4327] Patch: simplify complex constant assignment statements

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: It seems generally useful to have a helper function to replace a range of nodes in a sequence of statements with another sequence of nodes. A general API like that would allow you to insert or delete nodes as well as replacing one node

[issue3347] urllib.robotparser doesn't work in Py3k

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: Committed revision 65118. I applied a simple version of this patch and added a unittest. -- assignee: -> jhylton nosy: +jhylton status: open -> closed ___ Python tracker <[EMAIL PR

[issue3377] Invalid child node access in ast.c

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: Committed revision 65064. -- status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3377] Invalid child node access in ast.c

Changes by Jeremy Hylton <[EMAIL PROTECTED]>: -- assignee: -> jhylton nosy: +jhylton ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2885] Create the urllib package

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: Oops. Let me look at this tomorrow. It was down to one failing test that last time I checked. Jeremy On Wed, Jun 11, 2008 at 10:10 PM, Barry A. Warsaw <[EMAIL PROTECTED]> wrote: > > Barry A. Warsaw <[EMAIL PROTECTE

[issue1348] httplib closes socket, then tries to read from it

Changes by Jeremy Hylton <[EMAIL PROTECTED]>: -- nosy: +jhylton __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1348> __ ___ Python-bugs-list mailin

[issue2775] Implement PEP 3108

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: I think we should move robotparser into the urllib package. Anyone disagree? Jeremy __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue1346238] A constant folding optimization pass for the AST

Changes by Jeremy Hylton <[EMAIL PROTECTED]>: -- nosy: +jhylton _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1346238> _ ___ Python-bugs

[issue2775] Implement PEP 3108

Jeremy Hylton <[EMAIL PROTECTED]> added the comment: I'm working on the new urllib package. -- nosy: +jhylton __ Tracker <[EMAIL PROTECTED]> <http://bugs.

Re: sys.settrace closure interaction bug

Can you file a bug report for this? I'm guessing that the trace code has some bad interaction with LOAD_LOCALS, such that a free variable passed through the class gets treated as local instead. I can reproduce this problem in Python 2.4, so it's a long-standing bug. Also, as a matter of terminol

Re: [ python-Bugs-1569998 ] 2.5 incorrectly permits break inside try statement

I'm working on this bug now, but can't get an SF login to update the bug report. Jeremy On 10/3/06, SourceForge.net <[EMAIL PROTECTED]> wrote: > Bugs item #1569998, was opened at 2006-10-03 14:04 > Message generated for change (Settings changed) made by gbrandl > You can respond by visiting: > ht