Actually, the patch doesn't work :-). The httplib API allows you to pass a file or a string for the body of the request. The getheaderdata() + body case only works for the string. Easy to fix, but I worry that he still run into Nagle problems with the file case, which was presumably added for efficiency.
Jeremy On Mon, Nov 24, 2008 at 12:32 PM, Jeremy Hylton <[EMAIL PROTECTED]> wrote: > > Jeremy Hylton <[EMAIL PROTECTED]> added the comment: > > This patch makes sense in principle, but some of the details need to > change. The _send_output() method is used by some clients, merely > because it can be used :-(. It's fairly easy to preserve this API for > backwards compatibility. > > I am also worried about this new api call getheaderdata(). It > complicates the API. Even if it were necessary, it needs a better name, > because getheaderdata() doesn't sound like a method that changes the > connection state or consumes buffered header data. > > I think it would be better to have the new behavior exposed only through > HTTPConnection and not HTTP, since that's a Python 1.5.2 compatibility > API(!). We can make some small changes to xmlrpclib to use the newer > API. It would probably be a good change merely because py3k now uses > the newer API. > > I've got a working local change, but it's still a little ugly. > > ---------- > assignee: -> jhylton > nosy: +jhylton > status: open -> pending > > _______________________________________ > Python tracker <[EMAIL PROTECTED]> > <http://bugs.python.org/issue4336> > _______________________________________ > _______________________________________________ > Python-bugs-list mailing list > Unsubscribe: > http://mail.python.org/mailman/options/python-bugs-list/jeremy%40alum.mit.edu > > _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
