[issue44556] ctypes unittest crashes with libffi 3.4.2

2021-11-19 Thread Eli Rykoff
Eli Rykoff added the comment: To add a bit more color, I don't think you can explicitly set LIBFFI_INCLUDE_DIR, it's set by the configure script explicitly. The problem is that some time between python 3.9 and 3.10 the configure script has (at least in our system) failed to figu

[issue43884] Cannot cleanly kill a subprocess using high-level asyncio APIs

2021-08-19 Thread Eli Skeggs
Eli Skeggs added the comment: I'm also experiencing this, with virtually identical code, on macOS 10.15.7. The given fix (process._transport.close()) also works for me, so I'm just using that workaround for the time being. -- nosy

[issue43617] Missing definition in configure.ac causing autoreconf to create damaged configure script

2021-04-11 Thread Eli Schwartz
Eli Schwartz added the comment: Hmm, I've seen this accomplished elsewhere using m4_pattern_forbid, which would make autoreconf fail with the following message: ``` configure.ac:17: error: possibly undefined macro: AX_C_FLOAT_WORDS_BIGENDIAN If this token and others are legit

[issue43282] Add split install targets to install tests separately from lib

2021-04-11 Thread Eli Schwartz
Eli Schwartz added the comment: I started to look into this, but it seems like I'd need a bit of duplication to handle byte compiling the installed files in two different Makefile targets. The alternatives are templating, automake style, or GNU make'isms like the $(call) fu

[issue40059] Provide a toml module in the standard library

2021-03-02 Thread Eli Schwartz
Change by Eli Schwartz : -- nosy: +eschwartz ___ Python tracker <https://bugs.python.org/issue40059> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27640] Add --disable-test-modules configure option to not build nor install tests

2021-02-20 Thread Eli Schwartz
Eli Schwartz added the comment: I filed issue43282 for this. -- ___ Python tracker <https://bugs.python.org/issue27640> ___ ___ Python-bugs-list mailin

[issue43282] Add split install targets to install tests separately from lib

2021-02-20 Thread Eli Schwartz
New submission from Eli Schwartz : cf. https://bugs.python.org/issue27640#msg386758 Carrying on from the addition of --disable-test-modules, I would find it convenient to be able to still provide the tests, but install them separately. The end result would be two distro packages, one slim

[issue27640] Add --disable-test-modules configure option to not build nor install tests

2021-02-09 Thread Eli Schwartz
Eli Schwartz added the comment: I have a slightly different interest in declining to install tests... Arch Linux provides the tests as a split subpackage with currently some hacky shell globbing to delete the tests after make install, then do a second libinstall and delete everything but

[issue42688] ctypes memory error on Apple Silicon with external libffi

2020-12-20 Thread Eli Rykoff
Eli Rykoff added the comment: Thanks for your quick feedback! I signed the CLA after submitting the PR, but I think it takes a bit of time to percolate through the system. As for the "why", until 3.9.1 conda-forge had been successfully using an external ffi (with 3.9.0 + osx-arm

[issue42688] ctypes memory error on Apple Silicon with external libffi

2020-12-19 Thread Eli Rykoff
Change by Eli Rykoff : -- keywords: +patch pull_requests: +22730 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23868 ___ Python tracker <https://bugs.python.org/issu

[issue42688] ctypes memory error on Apple Silicon with external libffi

2020-12-19 Thread Eli Rykoff
New submission from Eli Rykoff : Building python 3.9.1 on Apple Silicon compiled against a external (non-os-provided) libffi makes the following code return a MemoryError: Test: import ctypes @ctypes.CFUNCTYPE(None, ctypes.c_int, ctypes.c_char_p) def error_handler(fif, message): pass I

[issue2504] Add gettext.pgettext() and variants support

2019-11-23 Thread Eli Schwartz
Eli Schwartz added the comment: Interestingly enough, the final accepted patch (and the 2010 one) also fixes a bug where gettext.install(..., names='ngettext') would incorrectly work, in violation of the documentation. I think it would also incorrectly install 'gettext'

[issue1724822] provide a shlex.split alternative for Windows shell syntax

2019-10-08 Thread Eli Schwartz
Change by Eli Schwartz : -- nosy: +eschwartz ___ Python tracker <https://bugs.python.org/issue1724822> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34022] 6 tests fail using SOURCE_DATE_EPOCH env var

2018-09-26 Thread Eli Schwartz
Change by Eli Schwartz : -- nosy: +eschwartz ___ Python tracker <https://bugs.python.org/issue34022> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34095] [2.7] test_idle fails with: /usr/bin/xvfb-run: line 181: 3617 Segmentation fault

2018-07-11 Thread Eli Schwartz
Eli Schwartz added the comment: Note the last line, which shows that the testsuite itself is executed using xvfb-run. The archlinux32 build script is based off the original PKGBUILD for archlinux: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/python2 xvfb

[issue32799] returned a result with an error set

2018-03-15 Thread Eli Ribble
Eli Ribble added the comment: You can feel free to close the bug - I no longer work for the company that had this problem and I was only reporting the bug because the documentation specifically requested I do so. I don't have the ability now to try upgrading the version of Python to s

[issue32799] returned a result with an error set

2018-02-08 Thread Eli Ribble
Eli Ribble added the comment: To my knowledge, no, we don't use any python extensions. Unless extensions can be installed via pip, in which case I would need to audit our many dependencies to determine if any of them ultimately pull in any extensions as part of a pip install. I

[issue32799] returned a result with an error set

2018-02-08 Thread Eli Ribble
New submission from Eli Ribble : We've had about 200 occurrences of this error in various parts of our code. I have captured stack traces using sentry so I may be able to provide more detail if requested. The ultimate problem is that a SystemError is raised from within contextlib. The me

[issue29708] support reproducible Python builds

2018-01-13 Thread Eli Schwartz
Eli Schwartz added the comment: So, a couple of things. It seems to me, that properly supporting SOURCE_DATE_EPOCH means using exactly that and nothing else. To that end, I'm not entirely sure why things like --clamp-mtime even exist, as the original timestamp of a source file doesn&#x

[issue29346] datetime.utcfromtimestamp() returns strange result for very large values

2017-01-23 Thread Eli Collins
Eli Collins added the comment: My apologies, I think Alexander is right, this is a duplicate of #29100 I'd seen the first message in that issue talking about a core dump, and thought this was different problem; but I see the scope of the issue broadened to cover general bounds issues in

[issue29346] datetime.utcfromtimestamp() returns strange result for very large values

2017-01-22 Thread Eli Collins
New submission from Eli Collins: I've found an odd behavior when passing very large values to ``datetime.datetime.utcfromtimestamp()`` and ``.fromtimestamp()`` under python 3.6. Under python 3.5, ``utcfromtimestamp(1<<40)`` would throw a ValueError that the year was out of ra

[issue672115] Assignment to __bases__ of direct object subclasses

2016-12-07 Thread Eli Collins
Changes by Eli Collins : -- nosy: +eli.collins ___ Python tracker <http://bugs.python.org/issue672115> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28054] Diff for visually comparing actual with expected in mock.assert_called_with.

2016-09-09 Thread Eli Rose
New submission from Eli Rose: When I call unittest.TestCase.assertEqual(a, b) on e.g. two unequal dictionaries, I get a nice diff pointing me to the differences. >>> class A(unittest.TestCase): ... def test_foo(self): ... self.assertEqual(dict(foo='bar', zab=&#

[issue25455] Some repr implementations don't check for self-referential structures

2015-11-23 Thread Eli Bendersky
Changes by Eli Bendersky : -- nosy: -eli.bendersky ___ Python tracker <http://bugs.python.org/issue25455> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25455] Some repr implementations don't check for self-referential structures

2015-11-23 Thread Eli Bendersky
Eli Bendersky added the comment: As I've mentioned elsewhere, I'll have to temporarily take myself off these issues as I don't have the time to work on them (even review patches). I think Raymond may have gotten his Stefans mixed up and meant Stefan Behnel, who's also b

[issue25455] Some repr implementations don't check for self-referential structures

2015-11-23 Thread Eli Bendersky
Changes by Eli Bendersky : -- nosy: -eli.bendersky ___ Python tracker <http://bugs.python.org/issue25455> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19687] Fixes for elementtree integer overflow

2015-11-21 Thread Eli Bendersky
Eli Bendersky added the comment: Serhiy, I'm truly sorry but for this and other issues you pinged -- I currently have zero bandwidth to invest in this. Feel free to ask around on pydev if there are other folks interested in reviewing patches and decisions w.r.t the etree module. I'm

[issue21724] resetwarnings doesn't reset warnings registry

2015-07-26 Thread Eli Collins
Eli Collins added the comment: I'm not sure how generally applicable this is, but it might be useful as a starting point: Attached is a bit of code I've been using: it's a reset_warnings_registry() context manager, which backs up & clears the registry state for the dura

[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-05-18 Thread Eli Bendersky
Eli Bendersky added the comment: I'm not sure. This is why I'm proposing asking on python-dev -- ___ Python tracker <http://bugs.python.org/issue19176> ___ __

[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-05-16 Thread Eli Bendersky
Eli Bendersky added the comment: I don't know how important this is to really warrant removal. Removal means potentially breaking working code when trying to run it with Python 3.5, and my impression was that the core devs are somewhat alergic to this, at least while the transition to P

[issue23896] lib2to3 doesn't provide a grammar where exec is a function

2015-04-09 Thread Eli Bendersky
New submission from Eli Bendersky: lib2to3 helpfully provides pygram.python_grammar_no_print_statement for parsing Python 3 ('print' has the semantics of an identifier, not a keyword) However, the same courtesy is not extended to 'exec', which also turns from a statement

[issue23894] lib2to3 doesn't recognize rb'...' as a raw byte string in Python 3

2015-04-09 Thread Eli Bendersky
Changes by Eli Bendersky : -- stage: -> needs patch type: -> behavior ___ Python tracker <http://bugs.python.org/issue23894> ___ ___ Python-bugs-list

[issue23894] lib2to3 doesn't recognize rb'...' as a raw byte string in Python 3

2015-04-09 Thread Eli Bendersky
New submission from Eli Bendersky: lib2to3 tokenizes br'abc' as a single STRING token, but rb'abc' as two separate tokens (NAME "rb" and STRING 'abc') This is because pgen2/tokenize.py doesn't list rb'' as a viable prefix for a stri

[issue23549] heapq docs should be more precise about how to access the smallest element

2015-03-14 Thread Eli Bendersky
Changes by Eli Bendersky : -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue23549> ___ ___ Python-bugs-list

[issue23549] heapq docs should be more precise about how to access the smallest element

2015-03-04 Thread Eli Bendersky
Eli Bendersky added the comment: Raymond - gentle ping. Do you see a reason not to check this in? -- ___ Python tracker <http://bugs.python.org/issue23

[issue23549] heapq docs should be more precise about how to access the smallest element

2015-02-28 Thread Eli Bendersky
Eli Bendersky added the comment: Good catch. Attaching a new version of the patch with the typo fixed. -- Added file: http://bugs.python.org/file38280/issue23549.2.patch ___ Python tracker <http://bugs.python.org/issue23

[issue23549] heapq docs should be more precise about how to access the smallest element

2015-02-28 Thread Eli Bendersky
Eli Bendersky added the comment: Proposed patch (generated vs. the 3.4 docs) is attached -- keywords: +patch Added file: http://bugs.python.org/file38277/issue23549.1.patch ___ Python tracker <http://bugs.python.org/issue23

[issue23549] heapq docs should be more precise about how to access the smallest element

2015-02-28 Thread Eli Bendersky
New submission from Eli Bendersky: The heapq documentation has this paragraph after the doc of nsmallest: The latter two functions perform best for smaller values of n. For larger values, it is more efficient to use the sorted() function. Also, when n==1, it is more efficient to use the

[issue17963] Deprecate the frame hack for implicitly getting module details

2015-02-25 Thread Eli Bendersky
Eli Bendersky added the comment: I don't have time, unfortunately. So other folks can pick this up. I don't remember if I made any progress on this - will post whatever I have if I find something. -- ___ Python tracker <http://bu

[issue21793] httplib client/server status refactor

2015-02-10 Thread Eli Bendersky
Changes by Eli Bendersky : -- nosy: -eli.bendersky ___ Python tracker <http://bugs.python.org/issue21793> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23292] Enum doc suggestion

2015-01-24 Thread Eli Bendersky
Eli Bendersky added the comment: Georg, each library writer is entitled to do whatever she wants. Naturally, we can't prevent dumping contents of enums into the module namespaces, and yes, backwards compatibility makes sense for some modules. However, that's tangential to *encoura

[issue23292] Enum doc suggestion

2015-01-24 Thread Eli Bendersky
Eli Bendersky added the comment: I'm not sure why the current situation is annoying? Python explicitly does not pollute the enclosing namespace with an Enum's members. So when you: import A It's fairly natural that you have access to A.MyEnum and not its members, no? Some mod

[issue22505] Expose an Enum object's serial number

2014-09-28 Thread Eli Bendersky
Eli Bendersky added the comment: >> I could continue the discussion about databases, but it feels like a waste >> of time to me. The main principle is: If something has an important property >> (in this case an enum object's numerical value), it should be publicly >

[issue14910] argparse: disable abbreviation

2014-08-07 Thread Eli Bendersky
Eli Bendersky added the comment: Ezio, could you see if your comments were addressed? Steven, do you want to take another look, or is this OK to commit? -- ___ Python tracker <http://bugs.python.org/issue14

[issue14910] argparse: disable abbreviation

2014-08-03 Thread Eli Bendersky
Eli Bendersky added the comment: No worries, Daniel. You should have received an email when comments were posted to the review, did you? If you you may want to check your settings in the bug tracker. I left a couple of additional comments on the documentation file, but other than that this

[issue14910] argparse: disable abbreviation

2014-08-02 Thread Eli Bendersky
Eli Bendersky added the comment: Daniel, I left some comments in Rietveld. Also it doesn't seem that you addressed the previously left comments when you fixed up the patch. -- ___ Python tracker <http://bugs.python.org/is

[issue18780] SystemError when formatting int subclass

2014-06-24 Thread Eli Bendersky
Eli Bendersky added the comment: On Tue, Jun 24, 2014 at 3:18 PM, Ned Deily wrote: > > Ned Deily added the comment: > > It is described in the developer's guide. The current status is > summarized here: > > https://docs.python.org/devguide/devcycle.html#summary

[issue18780] SystemError when formatting int subclass

2014-06-24 Thread Eli Bendersky
Eli Bendersky added the comment: On Tue, Jun 24, 2014 at 2:29 PM, Ned Deily wrote: > > Ned Deily added the comment: > > The 3.3 branch is now only open for security fixes so this issue doesn't > appear to warrant backporting there. > > -- > These questio

[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'

2014-06-24 Thread Eli Bendersky
Eli Bendersky added the comment: [sorry, the first question mark shouldn't be - the patch indeed looks reasonable to me] Steven - how about launching a subprocess for stdin tests to avoid weird issues? -- ___ Python tracker <http://bugs.py

[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'

2014-06-24 Thread Eli Bendersky
Eli Bendersky added the comment: The patch looks reasonable? Is the only remaining problem with crafting the test? -- ___ Python tracker <http://bugs.python.org/issue14

[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'

2014-06-22 Thread Eli Bendersky
Eli Bendersky added the comment: Nosy-ing myself since I just ran into it. Annoying issue that precludes from using argparse's builtin '-' recognition for reading binary data. I'll try to carve some time later to look at the patches. -- nosy: +eli.bendersky v

[issue21706] Add base for enumerations (Functional API)

2014-06-10 Thread Eli Bendersky
Eli Bendersky added the comment: Is it really worthwhile to complicate the API for the sake of providing a less flexible solution for rare cases that saves a few keystrokes? -- ___ Python tracker <http://bugs.python.org/issue21

[issue21480] A build now requires...

2014-05-12 Thread Eli Bendersky
Eli Bendersky added the comment: Skip, PTAL at the devguide. https://docs.python.org/devguide/setup.html#avoiding-re-creating-auto-generated-files -- ___ Python tracker <http://bugs.python.org/issue21

[issue19655] Replace the ASDL parser carried with CPython

2014-05-10 Thread Eli Bendersky
Eli Bendersky added the comment: This is also described in the Dev Guide: https://docs.python.org/devguide/setup.html -- ___ Python tracker <http://bugs.python.org/issue19

[issue19655] Replace the ASDL parser carried with CPython

2014-05-10 Thread Eli Bendersky
Eli Bendersky added the comment: Stefan, you need to run `make touch` if you want to avoid rebuilding. See #15964 for more details. [all bots run `make touch` before building now] -- ___ Python tracker <http://bugs.python.org/issue19

[issue19655] Replace the ASDL parser carried with CPython

2014-05-09 Thread Eli Bendersky
Changes by Eli Bendersky : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue21403] cElementTree's Element creation handles attrib argument different from ET

2014-05-01 Thread Eli Bendersky
Eli Bendersky added the comment: > Note that this has been fixed in Py3 already (Py3.3, I guess). The only > question is whether the behaviour will be changed in Py2.7. > I don't think this issue is acute enough to warrant fixes in 2.7; however, a documentation patch wo

[issue19655] Replace the ASDL parser carried with CPython

2014-04-05 Thread Eli Bendersky
Eli Bendersky added the comment: Updated patch attached: 1. Python 3.3+ supported (I suspect 3.2 will work too) 2. Incorporated Serhiy's suggestions (thanks for the review!) -- Added file: http://bugs.python.org/file34742/new-asdl-parser.issue19655.2.

[issue19655] Replace the ASDL parser carried with CPython

2014-04-05 Thread Eli Bendersky
Eli Bendersky added the comment: Nick, it shouldn't be hard to drop to 3.3, but I'm curious why would the 3.4 requirement break Fedora, or anything for that matter? Does Fedora regenerate the C implementation of the AST for some reason on every build? AFAIU, building Python from s

[issue19655] Replace the ASDL parser carried with CPython

2014-04-04 Thread Eli Bendersky
Eli Bendersky added the comment: On Fri, Apr 4, 2014 at 6:10 AM, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > Now make fails when system Python is older than 3.4. > > This is why the .h & .c files are checked in - someone just building Python doesn&#

[issue20375] ElementTree: Document handling processing instructions

2014-04-03 Thread Eli Bendersky
Eli Bendersky added the comment: On Thu, Apr 3, 2014 at 1:19 PM, Nikolaus Rath wrote: > > Nikolaus Rath added the comment: > > Thanks for the commit! > > My intention is to fix the behavior itself for 3.5 (see issue 9521), so I > think adding testcases for the old behavior

[issue19655] Replace the ASDL parser carried with CPython

2014-04-03 Thread Eli Bendersky
Eli Bendersky added the comment: Since there has mostly been support for this, I'll wait a couple more days and commit it unless someones objects or asks for more time for review. -- ___ Python tracker <http://bugs.python.org/is

[issue20375] ElementTree: Document handling processing instructions

2014-04-03 Thread Eli Bendersky
Eli Bendersky added the comment: Thanks. Doc patch committed with some slight rewording. Would you like to prepare a separate patch for the tests, default branch only this time? -- versions: -Python 3.4 ___ Python tracker <http://bugs.python.

[issue21028] ElementTree objects should support all the same methods as Element objects

2014-04-02 Thread Eli Bendersky
Eli Bendersky added the comment: > Do you have concrete suggestions? Make the tree iterable? > > Add all element methods to the tree, implicitly forwarding to the root? > > Yes, that is the feature request. Add all the element methods to the > elementtree object. > >

[issue20375] ElementTree: Document handling processing instructions

2014-04-02 Thread Eli Bendersky
Eli Bendersky added the comment: I left some comments in Rietveld. There shouldn't be a problem getting these into 3.4 too - doc changes are usually excempt from most restrictions. -- ___ Python tracker <http://bugs.python.org/is

[issue21028] ElementTree objects should support all the same methods as Element objects

2014-03-31 Thread Eli Bendersky
Eli Bendersky added the comment: Raymond, you are right that the APIs presented by Element and ElementTree are somewhat different. As Stefan mentioned, they were really meant to represent different things, but with time some "convenience" features crept in and made the differenc

[issue20375] ElementTree: Document handling processing instructions

2014-03-31 Thread Eli Bendersky
Eli Bendersky added the comment: The patch appears to contain code (tests) along with the documentation. Is this intended? This issue is not tagged properly if it is. I'd suggest to split them to separate patches. -- versions: +Python 3.5 -Python 2.7, Python 3.3, Pytho

[issue19655] Replace the ASDL parser carried with CPython

2014-03-31 Thread Eli Bendersky
Eli Bendersky added the comment: Attaching patch that implements this. To make it easier, the patch only replaces the ASDL parser - not touching anything else and leaving the output intact. With this patch applied, when the Makefile is rerun it regenerates the actual AST code in: Include

[issue19655] Replace the ASDL parser carried with CPython

2014-03-30 Thread Eli Bendersky
Eli Bendersky added the comment: There were no serious objections bar the pre-release timing. Now that we're safely in 3.5 territory, can I go ahead and create a patch? Note that for purposes of review, the Github project linked in the original message is more convenient,

[issue14332] Better explain "junk" concept in difflib doc

2014-03-19 Thread Eli Bendersky
Eli Bendersky added the comment: Revised patch LGTM. -- ___ Python tracker <http://bugs.python.org/issue14332> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20920] Turtle module transparency.

2014-03-13 Thread Eli Innis
New submission from Eli Innis: Python's Turtle module doesn't support transparency. I emailed the developer that was listed in the Turtle module code, thinking that was the right way to get help updating it. I then messaged Python&

[issue20653] Pickle enums by name

2014-02-22 Thread Eli Bendersky
Eli Bendersky added the comment: Can you upload the new patch? -- ___ Python tracker <http://bugs.python.org/issue20653> ___ ___ Python-bugs-list mailin

[issue20653] Pickle enums by name

2014-02-21 Thread Eli Bendersky
Eli Bendersky added the comment: > Many comments, Eli's and Serhey's code changes incorporated. Looks better, thanks. I left some comments in Rietveld. -- ___ Python tracker <http://bugs.pytho

[issue20679] 3.4 cherry-pick: 587fd4b91120 improve Enum subclass behavior

2014-02-20 Thread Eli Bendersky
Eli Bendersky added the comment: The discussion in #20653 is ongoing but I have to say I don't feel confident about this issue at all. If anything, I'd prefer to explicitly mark "advanced pickling support" for enums as provisional in 3.4 - this is a simple documentation fi

[issue20653] Pickle enums by name

2014-02-20 Thread Eli Bendersky
Eli Bendersky added the comment: If you were enlightened about how to use the pickle protocols, please explains this better in the code. Currently the code says: # check for a supported pickle protocols, and if not present sabotage +# pickling, since it won't work a

[issue20679] 3.4 cherry-pick: 587fd4b91120 improve Enum subclass behavior

2014-02-20 Thread Eli Bendersky
Eli Bendersky added the comment: I left some comments in #20653 As for cherry-picking this into 3.4, I'm not sure. Ethan - what is the worst scenario this patch enables to overcome? Someone getting locked in to by-value pickling with certain enums i

[issue20653] Pickle enums by name

2014-02-20 Thread Eli Bendersky
Eli Bendersky added the comment: Ethan, the patch you committed here seems obscure to me. Why __reduce_ex__ and not __reduce__? Where are the accompanying documentation changes? Can you clarify more how the full logic of pickling now works - preferably in comments withing the code

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Eli Bendersky
Eli Bendersky added the comment: Yep, the overriding of the type name was inadvertent. Nothing sacred about it, so Ethan's SocketKind is just as good. -- ___ Python tracker <http://bugs.python.org/is

[issue20001] pathlib inheritance diagram too large

2013-12-16 Thread Eli Bendersky
Eli Bendersky added the comment: The source for the diagram is here: https://docs.google.com/drawings/d/1F8do-1WL1sIGkZuiufcxcpZRtS0w4SwAowq-Uamrwt8/edit?usp=sharing Anyone - feel free to copy that doc over and create a new diagram with smaller whitespacing. Let me know if there are any

[issue18986] Add a case-insensitive case-preserving dict

2013-12-13 Thread Eli Bendersky
Changes by Eli Bendersky : -- nosy: -eli.bendersky ___ Python tracker <http://bugs.python.org/issue18986> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19687] Fixes for elementtree integer overflow

2013-12-05 Thread Eli Bendersky
Eli Bendersky added the comment: Thanks. I left some comments in the code review tool -- ___ Python tracker <http://bugs.python.org/issue19687> ___ ___ Python-bug

[issue19814] Document prefix matching behavior of argparse, particularly for parse_known_args

2013-12-02 Thread Eli Bendersky
Changes by Eli Bendersky : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue19799] Clarifications for the documentation of pathlib

2013-11-28 Thread Eli Bendersky
Eli Bendersky added the comment: Committed in 90b56ec318b6 -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: +Python 3.2 -Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.or

[issue19814] Document prefix matching behavior of argparse, particularly for parse_known_args

2013-11-28 Thread Eli Bendersky
Eli Bendersky added the comment: If I don't see any further objections I'll go ahead and commit this by the end of the week -- ___ Python tracker <http://bugs.python.o

[issue19815] ElementTree segmentation fault in expat_start_ns_handler

2013-11-28 Thread Eli Bendersky
Eli Bendersky added the comment: Thanks for the report & patches. Fixed in all active branches. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.pytho

[issue19814] Document prefix matching behavior of argparse, particularly for parse_known_args

2013-11-28 Thread Eli Bendersky
Eli Bendersky added the comment: I don't see how these implementation details are relevant. The patch adds a link to the existing abbreviations section, which mentions parse_args - so it's clear that this behavior exists in both. Yes, #14910 (to which I pointed in the original messa

[issue19799] Clarifications for the documentation of pathlib

2013-11-27 Thread Eli Bendersky
Eli Bendersky added the comment: > > STINNER Victor added the comment: > > Which tool did you use to draw this schema? You may attach also the source > if someone would like to modify it in the future. > Sorry, but there's no source. I drew it graphically. But since I did

[issue19799] Clarifications for the documentation of pathlib

2013-11-27 Thread Eli Bendersky
Changes by Eli Bendersky : Added file: http://bugs.python.org/file32871/pathlib-inheritance.png ___ Python tracker <http://bugs.python.org/issue19799> ___ ___ Python-bug

[issue19799] Clarifications for the documentation of pathlib

2013-11-27 Thread Eli Bendersky
Eli Bendersky added the comment: On Wed, Nov 27, 2013 at 6:21 AM, STINNER Victor wrote: > > STINNER Victor added the comment: > > Could you please attach the picture separatly? > > Done -- ___ Python tracker <http://bugs.

[issue19814] Document prefix matching behavior of argparse, particularly for parse_known_args

2013-11-27 Thread Eli Bendersky
Eli Bendersky added the comment: Here's a patch for 3.3; if it looks ok i'll merge it to default and also to 2.7 -- keywords: +patch Added file: http://bugs.python.org/file32870/issue19814.doc33.patch ___ Python tracker <http://bu

[issue19814] Document prefix matching behavior of argparse, particularly for parse_known_args

2013-11-27 Thread Eli Bendersky
New submission from Eli Bendersky: Prefix matching behavior can lead to bugs when combined with parse_known_args. See this thread for more details: https://mail.python.org/pipermail/python-dev/2013-November/130601.html Issue #14910 deals with making it optional, but until 3.5 we'll have

[issue19799] Clarifications for the documentation of pathlib

2013-11-27 Thread Eli Bendersky
Eli Bendersky added the comment: Just in case it isn't: https://dl.dropboxusercontent.com/u/15602400/images/pathlib-inheritance.png -- ___ Python tracker <http://bugs.python.org/is

[issue19799] Clarifications for the documentation of pathlib

2013-11-27 Thread Eli Bendersky
Eli Bendersky added the comment: Attaching a new patch. Hopefully the image will be viewable in the code review tool -- Added file: http://bugs.python.org/file32869/issue19799.2.patch ___ Python tracker <http://bugs.python.org/issue19

[issue14910] argparse: disable abbreviation

2013-11-26 Thread Eli Bendersky
Changes by Eli Bendersky : -- nosy: +eli.bendersky ___ Python tracker <http://bugs.python.org/issue14910> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19624] Switch constants in the errno module to IntEnum

2013-11-26 Thread Eli Bendersky
Changes by Eli Bendersky : -- keywords: -easy ___ Python tracker <http://bugs.python.org/issue19624> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19799] Clarifications for the documentation of pathlib

2013-11-26 Thread Eli Bendersky
Changes by Eli Bendersky : -- keywords: +patch Added file: http://bugs.python.org/file32858/issue19799.initial.patch ___ Python tracker <http://bugs.python.org/issue19

[issue19799] Clarifications for the documentation of pathlib

2013-11-26 Thread Eli Bendersky
New submission from Eli Bendersky: Following up from Issue #19673; The initial patch clarifies the use cases of pure vs. concrete paths a bit and adds explicit signatures for the path class constructors (moving the construction discussion under the parent class). Also, IMHO an inheritance

[issue19673] PEP 428 implementation

2013-11-24 Thread Eli Bendersky
Eli Bendersky added the comment: Thanks for the clarifications, Antoine. I'll see if I can come up with a doc patch that will try to emphasize these points. I'll probably just open a new, doc-issue to stop overloading this one. --

[issue19655] Replace the ASDL parser carried with CPython

2013-11-24 Thread Eli Bendersky
Eli Bendersky added the comment: On Sun, Nov 24, 2013 at 2:58 PM, Larry Hastings wrote: > > Larry Hastings added the comment: > > The rule is, no new features. Bug and security fixes from now on. > > It isn't always clear whether or not something is a new "feat

[issue19655] Replace the ASDL parser carried with CPython

2013-11-24 Thread Eli Bendersky
Eli Bendersky added the comment: Larry Hastings added the comment: > > Are the generated files *byte for byte* the same as produced by the > existing parser generation process? > Correct. The generator runs during the build (in the Makefile), but only if the files were out-of-da

  1   2   3   4   5   6   7   8   9   10   >