Eli Schwartz <eschwart...@gmail.com> added the comment:

Interestingly enough, the final accepted patch (and the 2010 one) also fixes a 
bug where gettext.install(..., names='ngettext') would incorrectly work, in 
violation of the documentation.

I think it would also incorrectly install 'gettext', too...

It used to just check if names.__contains__ is a valid attribute, then check if 
'foo' in names, so a dumb string "worked" and even matched more things than it 
should have.

How I discovered this: I fixed a bug in a python project that stopped working 
on python 3.8, and had a bit of a head-scratch regarding how it ever worked to 
begin with: https://github.com/linuxmint/cinnamon/pull/8964

----------
nosy: +eschwartz

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue2504>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to