[issue14746] Remove redundant paragraphs from getargs.c skipitem()

Larry Hastings added the comment: Thanks for the double-check. I should have more confidence! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker __

[issue14746] Remove redundant paragraphs from getargs.c skipitem()

Roundup Robot added the comment: New changeset 8ab37fa24e58 by Larry Hastings in branch 'default': Issue #14746: Remove redundant paragraphs from skipitem() in Python/getargs.c. http://hg.python.org/cpython/rev/8ab37fa24e58 -- nosy: +python-dev ___ P

[issue14746] Remove redundant paragraphs from getargs.c skipitem()

Antoine Pitrou added the comment: > > At least Py_ssize_t *could* have a different width from "PyObject *". > > Not "Py_ssize_t", "Py_ssize_t *". Ah, fair enough then. Looks ok to me. -- ___ Python tracker _

[issue14746] Remove redundant paragraphs from getargs.c skipitem()

Larry Hastings added the comment: > I'm not sure what you're proposing to fix. It seems to save at > most a couple of lines of (obvious) code? Well, I *did* specify low priority. Attached is the patch for what I had in mind. > At least Py_ssize_t *could* have a different width from "PyObject

[issue14746] Remove redundant paragraphs from getargs.c skipitem()

Antoine Pitrou added the comment: I'm not sure what you're proposing to fix. It seems to save at most a couple of lines of (obvious) code? At least Py_ssize_t *could* have a different width from "PyObject *". -- nosy: +mark.dickinson, pitrou ___ Pyt

[issue13210] Support Visual Studio 2010

Martin v. Löwis added the comment: I'd say go ahead and apply it. We can deal with any aftermath later (which, by my VS 2008 experience, will well take several years - we still haven't fully recovered from the switch to VS 2008). -- ___ Python trac

[issue13815] tarfile.ExFileObject can't be wrapped using io.TextIOWrapper

Antoine Pitrou added the comment: Well, if it's not documented, it's technically a private API. Also, there doesn't seem to be any explicit use of ExFileObject outside of tarfile.py: http://code.google.com/codesearch#search&q=lang:python+exfileobject -- nosy: +pitrou

[issue14744] Use _PyUnicodeWriter API in str.format() internals

Antoine Pitrou added the comment: > According to my benchmark (see below), formating a small number (5 > decimal digits) is 17% faster with my patch version 2 compared to tip, > and 38% faster compared to Python 3.3 before my optimizations on str% > tuples or str.format(). Creating a temporary P

[issue13210] Support Visual Studio 2010

Éric Araujo added the comment: Strange that you had to edit packaging.compiler.msvc9compiler but not the same module in distutils. -- ___ Python tracker ___ ___

[issue13210] Support Visual Studio 2010

Brian Curtin added the comment: Attached is full_vs2010_port.diff. It's 13000 lines, mostly taken up by the conversion of project, filter, and solution files - tons of XML. -- Added file: http://bugs.python.org/file25504/full_vs2010_port.diff ___ Py

[issue13210] Support Visual Studio 2010

Brian Curtin added the comment: The tip of the vs2010 branch now works just as well as default does. There are no outstanding test failures that aren't seen on default -- test_email still fails for some line ending stuff, but that's not relevant here. Attached is a patch showing just the code

[issue14759] Berkeley DB License conditions are onerous (and poorly documented)

Jeff Laing added the comment: With all due respect, I think that the 2.7.3 License Page is still being actively used by people as a reference, and it should be accurate. I agree that the code developers can't do anything, but the documentation for all releases, particularly in such a sensitiv

[issue14759] Berkeley DB License conditions are onerous (and poorly documented)

R. David Murray added the comment: Berkeley DB is no longer part of Python3, so I'm doubtful that this is going to be addressed. If it is addressed, it would have to be by the PSF rather than the developers, since the PSF is responsible for licensing issues. If you wish to pursue this I sug

[issue14759] Berkeley DB License conditions are onerous (and poorly documented)

New submission from Jeff Laing : As part of an audit of license compliance, I was looking at the terms in the LICENSE.txt that describe the Berkeley DB product. I had thought this would be under the standard Berkeley license, but Oracle have added their own zinger. * 3. Redistributions in any

[issue10765] Build regression from automation changes on windows

Martin v. Löwis added the comment: As there is an easy work-around (just don't use spaces in directory names), I still consider this issue as irrelevant as two years ago. -- ___ Python tracker ___

[issue14744] Use _PyUnicodeWriter API in str.format() internals

STINNER Victor added the comment: > Fill the ascii buffer and then copying can be cheaper than using > _PyUnicodeWriter with general non-ascii string. Here is a new patch using _PyUnicodeWriter directly in longobject.c. According to my benchmark (see below), formating a small number (5 decimal

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

R. David Murray added the comment: I don't think it is necessary to rewrite the existing tests, just add some that test the socket functionality. -- ___ Python tracker ___

[issue13815] tarfile.ExFileObject can't be wrapped using io.TextIOWrapper

R. David Murray added the comment: Indeed, even though it is not a documented API, our backward compatibility policy pretty much requires that something named ExFileObject still exist, just in case. And in this case it probably should still be the thing returned. -- nosy: +r.david.mu

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

Giampaolo Rodola' added the comment: Agreed. The only problem I see is that unit tests rely on a mock socket object and should be rewritten by using an actual socket. -- ___ Python tracker ___

[issue14735] Version 3.2.3 IDLE CTRL-Z plus Carriage Return to end does not work

Changes by Roger Serwy : -- keywords: +patch Added file: http://bugs.python.org/file25501/ctrl_z_doc.patch ___ Python tracker ___ ___

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

Changes by Antoine Pitrou : -- nosy: +giampaolo.rodola, r.david.murray stage: -> needs patch type: behavior -> enhancement versions: -Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.4 ___ Python tracker

[issue14727] test_multiprocessing failure under Linux

Vinay Sajip added the comment: test_multiprocessing now passes. Thanks for the quick turnaround. -- assignee: -> sbt resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker _

[issue14750] Tkinter application doesn't run from source build on Windows

Vinay Sajip added the comment: The test script works if tcl85.dll and tk85.dll are copied into the build directory. This can be done using a small batch file and the XML added to each build configuration in PCbuild\_tkinter.vcproj (can be added through the UI, of course). -- compon

[issue14757] INCA: Inline Caching meets Quickening in Python 3.3

Stefan Krah added the comment: > > Modules/_decimal/tests/bench.py: > > > > > > Not much change for floats and decimal.py, 8-10% slowdown for _decimal! > > This result is not unexpected, as I have no inline cached versions of > functions using this module. The d

[issue14727] test_multiprocessing failure under Linux

Richard Oudkerk added the comment: I found a race where a connection attempt could happen before the listening socket's listen() method was called. Vinay, could you update and try again please. -- ___ Python tracker

[issue5945] PyMapping_Check returns 1 for lists

Changes by Ezio Melotti : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue14727] test_multiprocessing failure under Linux

Roundup Robot added the comment: New changeset 3d900c9641c9 by Richard Oudkerk in branch 'default': Issue #14727: Fix race in test_multiprocessing http://hg.python.org/cpython/rev/3d900c9641c9 -- nosy: +python-dev ___ Python tracker

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

New submission from Ivan Sergeev : The SMTPServer class of the smtpd module creates a server socket with the IPv4 socket.AF_INET address family hardcoded, and this prevents it from later binding to an IPv6 local address. This occurs on line 282 of smtpd.py for the Python 2.7 branch: http://hg.

[issue14757] INCA: Inline Caching meets Quickening in Python 3.3

stefan brunthaler added the comment: > This looks quite impressive, so sorry for immediately jumping in with > criticism. -- I've benchmarked the things I worked on, and I can't see > any speedups but some significant slowdowns. This is on 64-bit Linux > with a Core 2 Duo, both versions compiled

[issue14750] importlib fails with tkinter application on Windows

Vinay Sajip added the comment: > Does it work with 3.2? I'm not able to build 3.2 - make_buildinfo fails, seemingly because it can't find some Subversion-related files. I'll keep looking into it. -- ___ Python tracker

[issue14757] INCA: Inline Caching meets Quickening in Python 3.3

Stefan Krah added the comment: This looks quite impressive, so sorry for immediately jumping in with criticism. -- I've benchmarked the things I worked on, and I can't see any speedups but some significant slowdowns. This is on 64-bit Linux with a Core 2 Duo, both versions compiled with just `./

[issue14757] INCA: Inline Caching meets Quickening in Python 3.3

Changes by Dave Malcolm : -- nosy: +dmalcolm ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue14754] Emacs configuration to enforce PEP7

Georg Brandl added the comment: As much as I like Emacs, I don't think it is special enough to warrant a special file in the root directory. Editor-specific directories in Misc/ are fine, and you can put instructions there how to add your own .dir-locals.el, and we can even add this to .hgign

[issue14727] test_multiprocessing failure under Linux

Vinay Sajip added the comment: > Does "repeatably" mean you always get the failure? Yes, every time. The first symptom is always a ConnectionRefusedError. > I have not seen any failures on the Linux buildbots. I'm running a fairly old version of Ubuntu, which might be relevant, or it may be

[issue14750] importlib fails with tkinter application on Windows

Antoine Pitrou added the comment: > I went back a fair way, and the failure still keeps happening. So now > I'm wondering - is a Tk app *supposed* to work from a source build? Does it work with 3.2? Did you try debugging at the prompt? e.g. looking what tkinter.__file__ is, etc. -- __

[issue14750] importlib fails with tkinter application on Windows

Vinay Sajip added the comment: I went back a fair way, and the failure still keeps happening. So now I'm wondering - is a Tk app *supposed* to work from a source build? I've verified that the test script works OK when run from an installed Python. So, this issue may be invalid, if we don't ca

[issue14757] INCA: Inline Caching meets Quickening in Python 3.3

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue13815] tarfile.ExFileObject can't be wrapped using io.TextIOWrapper

Amaury Forgeot d'Arc added the comment: I think it would have been better to keep the ExFileObject class, and base it on io.BufferedReader: class ExFileObject(io.BufferedReader): def __init__(self, tarfile, tarinfo): raw = _FileInFile(tarfile.fileobj, tari

[issue14757] INCA: Inline Caching meets Quickening in Python 3.3

h code is rather unlikely, but one never knows...) Additional memory overhead is minimal, too, since the technique only requires space for the new derivatives and is something along the lines of 80-100 KiB. -- components: Interpreter Core files: 20120508-inca.patch hgrepos: 124 keyword

[issue10765] Build regression from automation changes on windows

Martin added the comment: Yes, this is still reproducible. For instance, by: > hg clone -b default 3.3 "feature branch" > cd "feature branch/PCbuild" > call build_env.bat > call build.bat It seems python33.dll now does get created so it's less severe, but the python3dll still fails due to the

[issue14755] Distutils2 doesn't have a Python 3 version on PyPI

Éric Araujo added the comment: This comes from the fact that d2 is developed with two Mercurial branches, not build-time 2to3 conversion (which I dislike as ugly and not fully correct) nor single-source (which I dislike as ugly and hard to maintain :). PyPI does not work well with that workfl

[issue14756] Empty Dict in Initializer is Shared Betwean Objects

Changes by Antoine Pitrou : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue14756] Empty Dict in Initializer is Shared Betwean Objects

Antoine Pitrou added the comment: This is not a bug, see http://docs.python.org/dev/faq/design.html#why-are-default-values-shared-between-objects -- nosy: +pitrou resolution: -> invalid stage: -> committed/rejected ___ Python tracker

[issue14756] Empty Dict in Initializer is Shared Betwean Objects

Changes by Matthew Walker : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue14756] Empty Dict in Initializer is Shared Betwean Objects

New submission from Matthew Walker : When initializing a class with an empty dict() object as a default initializer, if it is not overridden, multiple instances of the class will share the dictionary. IE: class test(object): def __init__(self, obj=dict()): self.obj = obj a = test() b =

[issue14725] test_multiprocessing failure under Windows

Changes by Richard Oudkerk : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14755] Distutils2 doesn't have a Python 3 version on PyPI

New submission from Nick Wilson : PyPI only has a version of distutils2 for Python 2, not for Python 3. There is an "ImportError: No module named ConfigParser" when trying to "pip install distutils2" from Python 3. -- assignee: eric.araujo components: Distutils2 messages: 160211 nosy:

[issue14748] spwd.getspall() is returning LDAP (non local) users too

Dave Malcolm added the comment: Like passwd and group information, the shadow password entries are pulled through libc's Name Service Switch and modules for it, depending on configuration. See "man nsswitch.conf". Hence this is likely to be a configuration difference between the two boxes.

[issue14727] test_multiprocessing failure under Linux

Richard Oudkerk added the comment: > I've recently started seeing this failure repeatably on Linux (Ubuntu > Jaunty): The test is newly enabled. Does "repeatably" mean you always get the failure? I have not seen any failures on the Linux buildbots. -- __

[issue14754] Emacs configuration to enforce PEP7

Changes by Antoine Pitrou : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue14754] Emacs configuration to enforce PEP7

New submission from Damien Cassou : Please find attached a patch that adds an emacs configuration file to enforce PEP7. The patch is also in commit #518f2af0a687 of my hg repository under the branch emacs-configuration. -- components: Demos and Tools files: emacs-configuration-pep7.pat

[issue14750] importlib fails with tkinter application on Windows

Brian Curtin added the comment: Reproduced here as well. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue14753] multiprocessing treats negative timeouts differently from before

New submission from Richard Oudkerk : In version 3.2 and earlier, Process.join() and Connection.poll() treat negative timeouts as zero timeouts. (Thread.join() does the same.) In the current 3.3 version, they treat negative timeouts as infinite timeouts. Also multiprocessing.connection.wait(

[issue9260] A finer grained import lock

Antoine Pitrou added the comment: Updated patch against tip. I also changed the internal API of module locks a bit (acquire() raises _DeadlockError instead of returning False, and deadlock detection is not optional anymore). -- Added file: http://bugs.python.org/file25496/module_locks

[issue14752] Memleak in typeobject add_methods()

Roundup Robot added the comment: New changeset d937b527b76e by Benjamin Peterson in branch '3.2': fix possible refleak (closes #14752) http://hg.python.org/cpython/rev/d937b527b76e New changeset 5319a4bf72e7 by Benjamin Peterson in branch '2.7': fix possible refleak (closes #14752) http://hg.py

[issue9260] A finer grained import lock

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue14752] Memleak in typeobject add_methods()

New submission from Damien Cassou : In add_methods() function from typeobject.c, it looks like Py_DECREF is not called where it should be. Please find attached a patch that fixes the leak. The patch is also in commit #85a01718b3e3 of my hg repository under the branch fix_add_methods_leak. Thi

[issue14751] Pdb does not stop at a breakpoint

New submission from Xavier de Gaye : When a breakpoint is set in one of the frames of the frame stack, Pdb may not stop at that breakpoint when the frame does not have a trace function. This problem is closely related to issue 13183 and issue 14728. The following scenario demonstrates this proble

[issue14748] spwd.getspall() is returning LDAP (non local) users too

Changes by Antoine Pitrou : -- nosy: +dmalcolm ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue14750] importlib fails with tkinter application on Windows

Antoine Pitrou added the comment: For the record, the script works fine under Linux. Vinay, can you bisect and find out which revision introduced the issue? -- nosy: +brian.curtin, pitrou ___ Python tracker __

[issue14732] PEP 3121 Refactoring applied to _csv module

Antoine Pitrou added the comment: PyModule_AddObject steals the value's reference, so you need to INCREF it before. Besides that, I don't see any obvious bug, but perhaps Martin wants to take a look. -- nosy: +pitrou priority: normal -> low stage: -> patch review ___

[issue14749] Add 'Z' to skipitem() in Python/getargs.c

Benjamin Peterson added the comment: No test? -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue14750] importlib fails with tkinter application on Windows

New submission from Vinay Sajip : I'm now getting failures to import tkinter on Windows: C:\Users\Vinay\Projects\scratch>..\cpython\PCbuild\python tkhello.py Traceback (most recent call last): File "tkhello.py", line 1, in from tkinter import * File "", line 977, in _find_and_load Fil

[issue14743] on terminating, Pdb debugs itself

Xavier de Gaye added the comment: Uploaded a new patch, pdb_botframe_default_2.patch (that applies to the current tip of the default branch) with: * a correction to the initial change made to fix sigint_handler() * the two test cases -- Added file: http://bugs.python.org/file2

[issue14749] Add 'Z' to skipitem() in Python/getargs.c

Changes by Larry Hastings : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue14749] Add 'Z' to skipitem() in Python/getargs.c

Roundup Robot added the comment: New changeset b32baa5b7626 by Larry Hastings in branch 'default': Merge from 3.2. Issue #14749: Add support for 'Z' to skipitem(). http://hg.python.org/cpython/rev/b32baa5b7626 -- ___ Python tracker

[issue14749] Add 'Z' to skipitem() in Python/getargs.c

Roundup Robot added the comment: New changeset 91612618985b by Larry Hastings in branch '3.2': Issue #14749: Add support for 'Z' to skipitem() in Python/getargs.c. http://hg.python.org/cpython/rev/91612618985b -- nosy: +python-dev ___ Python tracker

[issue14744] Use _PyUnicodeWriter API in str.format() internals

Serhiy Storchaka added the comment: > "x={}".format(123) uses a temporary buffer for "123". This, apparently, is inevitable. I doubt that it is able to considerably optimize, not worsened str(int) (which is optimal for current algorithm). Note that the more complex formatting (with width) will

[issue14749] Add 'Z' to skipitem() in Python/getargs.c

Georg Brandl added the comment: Sound good. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue14732] PEP 3121 Refactoring applied to _csv module

Skip Montanaro added the comment: > Changes by Éric Araujo : > > > -- > nosy: +skip.montanaro Thanks, but I'm out of the Python development business, except as it pertains to my day job... Skip -- nosy: +skip.montanaro ___ Python tracker <

[issue14732] PEP 3121 Refactoring applied to _csv module

Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue14749] Add 'Z' to skipitem() in Python/getargs.c

New submission from Larry Hastings : skipitem() (in Python/getargs.c) has to be taught about all the "format units" understood by PyArg_Parse. There's a note at the top of the format-unit-understanding code saying When you add new format codes, please don't forget poor skipitem() below.

[issue14744] Use _PyUnicodeWriter API in str.format() internals

Mark Dickinson added the comment: > Issue3451 looks much more promising for int formatting. But it will take > a lot of time to carefully check this. I disagree: Issue 3451 is about *asymptotically* fast base conversion, and the changes proposed there are only going to kick in for numbers wit

[issue14744] Use _PyUnicodeWriter API in str.format() internals

STINNER Victor added the comment: _PyUnicodeWriter in long_to_decimal_string() for example. > > long_to_decimal_string() is already creates a string of known size. How > _PyUnicodeWriter can help here? "x={}".format(123) uses a temporary buffer for "123". Using _PyUnicodeWriter even to format 1

[issue14748] spwd.getspall() is returning LDAP (non local) users too

New submission from halfie : spwd.getspall() is returning LDAP (non local) users too. On RHEL 6.2 machine with LDAP authentication configured, spwd.getspall() is returning LDAP (non local) users too. On a similarly configured CentOS 6.2 machine, spwd.getspall() is returning only local users.