Re: [pve-devel] [PATCH manager v2 1/3] ui: rename global 'Help' button to 'Manual'

2017-10-10 Thread Dietmar Maurer
> On October 10, 2017 at 3:25 PM Dominik Csapak wrote: > > > On 10/10/2017 01:04 PM, Dietmar Maurer wrote: > > I don't really like that, because it is an additional string to translate. > > > > i would argue that this patch improves the distinction between the > different "Help Buttons" a l

Re: [pve-devel] [PATCH manager v2 1/3] ui: rename global 'Help' button to 'Manual'

2017-10-10 Thread Thomas Lamprecht
On 10/10/2017 01:04 PM, Dietmar Maurer wrote: > I don't really like that, because it is an additional string to translate. > I had never a problem to run a translation cycle before every release, the problem is that I am only able to maintain German and Italian (with the great review help of our

Re: [pve-devel] [PATCH manager v2 1/3] ui: rename global 'Help' button to 'Manual'

2017-10-10 Thread Dominik Csapak
On 10/10/2017 01:04 PM, Dietmar Maurer wrote: I don't really like that, because it is an additional string to translate. i would argue that this patch improves the distinction between the different "Help Buttons" a lot, meaning it is clearer which is a contextual help button and which is a b

Re: [pve-devel] [PATCH manager v2 1/3] ui: rename global 'Help' button to 'Manual'

2017-10-10 Thread Dietmar Maurer
I don't really like that, because it is an additional string to translate. > On October 10, 2017 at 12:49 PM Thomas Lamprecht > wrote: > > > To make it more clear that this will always end you on the > Manual index. > > Also, multiple Help buttons which all may or may not do something > diffe

[pve-devel] [PATCH manager v2 1/3] ui: rename global 'Help' button to 'Manual'

2017-10-10 Thread Thomas Lamprecht
To make it more clear that this will always end you on the Manual index. Also, multiple Help buttons which all may or may not do something different are a bit weird/confusing - thus distinction is important IMO. Adapt the icon displayed to `fa-book` which resembles the icon which is often used fo