I don't really like that, because it is an additional string to translate.

> On October 10, 2017 at 12:49 PM Thomas Lamprecht <t.lampre...@proxmox.com>
> wrote:
> 
> 
> To make it more clear that this will always end you on the
> Manual index.
> 
> Also, multiple Help buttons which all may or may not do something
> different are a bit weird/confusing - thus distinction is important
> IMO.
> 
> Adapt the icon displayed to `fa-book` which resembles the icon which
> is often used for manuals and is clearer than a '?', IMO.
> ---
>  www/manager6/Workspace.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
> index 9376cea5..6e50abcb 100644
> --- a/www/manager6/Workspace.js
> +++ b/www/manager6/Workspace.js
> @@ -326,9 +326,10 @@ Ext.define('PVE.StdWorkspace', {
>                           xtype: 'pveHelpButton',
>                           hidden: false,
>                           baseCls: 'x-btn',
> -                         iconCls: 'fa fa-info-circle 
> x-btn-icon-el-default-toolbar-small ',
> +                         iconCls: 'fa fa-book 
> x-btn-icon-el-default-toolbar-small ',
>                           listenToGlobalEvent: false,
>                           onlineHelp: 'pve_documentation_index',
> +                         text: gettext('Manual'),
>                           margin: '0 5 0 0'
>                       },
>                       createVM, 
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to