Any comment ?
- Mail original -
De: "aderumier"
À: "pve-devel"
Cc: "aderumier"
Envoyé: Vendredi 6 Octobre 2017 16:49:10
Objet: [PATCH qemu-server 0/4] qemu_fw_cfg support for vm init
This patch series add support for qemu_fw_cfg,
which allow to send through a firmware the content th
> On October 10, 2017 at 3:25 PM Dominik Csapak wrote:
>
>
> On 10/10/2017 01:04 PM, Dietmar Maurer wrote:
> > I don't really like that, because it is an additional string to translate.
> >
>
> i would argue that this patch improves the distinction between the
> different "Help Buttons" a l
On Tue, Oct 10, 2017 at 04:04:26PM +0200, Thomas Lamprecht wrote:
> Thanks for this, useful to test the other patches.
>
> I am yet in the process of looking at the code changes but tested
> a bit around. I noticed three problems:
>
> * when using the `help --verbose` command, e.g.,:
> pveum help
On 10/10/2017 03:58 PM, Philip Abernethy wrote:
> On Tue, Oct 10, 2017 at 03:53:45PM +0200, Thomas Lamprecht wrote:
>> On 10/10/2017 03:44 PM, Philip Abernethy wrote:
>>> Checks ACL paths for logical validity before application. Checks of
>>> the various IDs are done by the existing format checkers
Thanks for this, useful to test the other patches.
I am yet in the process of looking at the code changes but tested
a bit around. I noticed three problems:
* when using the `help --verbose` command, e.g.,:
pveum help --verbose
All but the first `USAGE: ...` strings are intended, which wasn't
th
On Tue, Oct 10, 2017 at 03:53:45PM +0200, Thomas Lamprecht wrote:
> On 10/10/2017 03:44 PM, Philip Abernethy wrote:
> > Checks ACL paths for logical validity before application. Checks of
> > the various IDs are done by the existing format checkers to avoid code
> > duplication.
> > Also introduces
On 10/10/2017 03:44 PM, Philip Abernethy wrote:
> Checks ACL paths for logical validity before application. Checks of
> the various IDs are done by the existing format checkers to avoid code
> duplication.
> Also introduces a distinction between malformed (syntactically
> incorrect) and invalid (sy
was erroneously registered as verify_groupname, overriding the previous
registration
---
PVE/AccessControl.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm
index 07f0c21..f0fb7dc 100644
--- a/PVE/AccessControl.pm
+++ b/PVE/AccessCon
Checks ACL paths for logical validity before application. Checks of
the various IDs are done by the existing format checkers to avoid code
duplication.
Also introduces a distinction between malformed (syntactically
incorrect) and invalid (syntactically correct, but contextually wrong)
paths.
---
P
On 10/10/2017 01:04 PM, Dietmar Maurer wrote:
> I don't really like that, because it is an additional string to translate.
>
I had never a problem to run a translation cycle before every
release, the problem is that I am only able to maintain German
and Italian (with the great review help of our
On 10/10/2017 01:04 PM, Dietmar Maurer wrote:
I don't really like that, because it is an additional string to translate.
i would argue that this patch improves the distinction between the
different "Help Buttons" a lot, meaning it is clearer which is a
contextual help button and which is a b
applied
On Tue, Oct 10, 2017 at 11:54:54AM +0200, Fabian Grünbichler wrote:
> while OSDs units should only be runtime enable and disappear on reboots,
> this serves as an additional safeguard to ensure no leftover units can
> exist.
>
> Signed-off-by: Fabian Grünbichler
> ---
> Note: runtime ena
applied
On Tue, Oct 10, 2017 at 12:03:35PM +0200, Fabian Grünbichler wrote:
> Reported-By: Waschbüsch IT-Services GmbH
> Signed-off-by: Fabian Grünbichler
> ---
> PVE/API2/Ceph.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
> ind
I don't really like that, because it is an additional string to translate.
> On October 10, 2017 at 12:49 PM Thomas Lamprecht
> wrote:
>
>
> To make it more clear that this will always end you on the
> Manual index.
>
> Also, multiple Help buttons which all may or may not do something
> diffe
Lets add a onlineHelp title for the ConfigPanel lxc, qemu, node and
pool (omitting only dc). As we fall back to the current ConfigPanels
help link when a tab (or sub panel) has no own specific help defined
this then can be shown so that the user sees which help will open
before clicking the button.
changes since v1:
* use the shorter name 'Manual' instead of 'Documenation' (note: our
screenshots are based on a 1280 pixel wide window, so both would be
OK)
* use the 'fa-book' font awesome symbol for the global 'Manual' button
* use shorter names for VM and CT onlineHelpTitle in their config
If there is a onlineHelp set for the current active card then use
the card title, which is already translated and limited in length.
---
www/manager6/button/HelpButton.js | 12 +---
www/manager6/panel/ConfigPanel.js | 6 +-
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git
To make it more clear that this will always end you on the
Manual index.
Also, multiple Help buttons which all may or may not do something
different are a bit weird/confusing - thus distinction is important
IMO.
Adapt the icon displayed to `fa-book` which resembles the icon which
is often used fo
Reported-By: Waschbüsch IT-Services GmbH
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Ceph.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index e9211325..f89b7bfe 100644
--- a/PVE/API2/Ceph.pm
+++ b/PVE/API2/Ceph.pm
@@ -123,7 +123,7 @
while OSDs units should only be runtime enable and disappear on reboots,
this serves as an additional safeguard to ensure no leftover units can
exist.
Signed-off-by: Fabian Grünbichler
---
Note: runtime enabling was broken in Luminous < 12.2.1-pve3 .. so any OSDs
destroyed on those versions will
On Mon, Oct 09, 2017 at 02:34:04PM +0200, Tom Weber wrote:
> Anyone care about this?
> I have two cases of containers were i have to manually fix after a
> restore.
>
> Tom
>
> Am Dienstag, den 26.09.2017, 15:29 +0200 schrieb Tom Weber:
> > If you use mountpoints inside a container, and change
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
---
src/PVE/LXC.pm | 86 ++
1 file changed, 86 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 811af21..3ea2409 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1527,5 +1527,91 @@ sub userns_command {
return [];
}
---
src/PVE/LXC/Config.pm | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index c45ce7e..3d529be 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -1175,8 +1175,8 @@ sub classify_mountpoint
---
src/PVE/LXC.pm | 87 +-
1 file changed, 56 insertions(+), 31 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index bce032a..811af21 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1321,6 +1321,59 @@ sub destroy_disks {
---
src/PVE/API2/LXC.pm | 212
1 file changed, 113 insertions(+), 99 deletions(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 0397224..2d84f0b 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -1191,6 +1191,9 @@ __P
---
src/PVE/API2/LXC.pm | 152
src/PVE/CLI/pct.pm | 1 +
2 files changed, 153 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 2d84f0b..aceedb6 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -1504,4 +
Changes since v3:
* Patch 2:
- don't mount to /tmp due to permission issues
- perform mount© with an unshared mount namespace
- now requires the pve-common patch for PVE::Tools::run_fork
* Patch 3:
- refactor locking as suggested by fabian
- use remove_lock instead of manually removing $conf->
---
We have run_fork_with_timeout in order to run a piece of code
in a fork while being able to return values from it and pass
along exceptions, but we still had no way of doing this without
a timeout...
src/PVE/Tools.pm | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --gi
The log function is used by storage replication to redirect the output in the
correct log.
---
PVE/Storage.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index b226082..94be04e 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -536,7 +
This redirect the output form pvesm export to the correct log instead of the
syslog.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
This will redirect export and import output to the correct log, instead of
paring it into the syslog.
---
PVE/Replication.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/PVE/Replication.pm b/PVE/Replication.pm
index e53928e..c25ed44 100644
--- a/PVE/Replication.pm
+++
Signed-off-by: Fabian Grünbichler
---
src/Makefile | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/Makefile b/src/Makefile
index 109577c..5089fe6 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -40,8 +40,7 @@ install: pct lxc-pve.conf lxc-pve-prestart-hook
lxc-pve
Signed-off-by: Fabian Grünbichler
---
src/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile b/src/Makefile
index 19931e5..9c5fbc3 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -10,7 +10,7 @@ LXC_SCRIPT_DIR=${PREFIX}/share/lxc
LXC_TMPL_DIR=${LXC_SCRIPT_DI
Signed-off-by: Fabian Grünbichler
---
src/PVE/API2/LXC/Status.pm | 2 +-
src/PVE/VZDump/LXC.pm | 2 +-
src/lxc-pve-poststop-hook | 7 ---
src/lxc-pve-reboot-trigger | 3 ++-
4 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Stat
turns out v3 was incomplete because systemd generates a slice with
DefaultDependencies=yes for instances of a service template unit, even if the
template itself has DefaultDependencies=no.
introduce our own slice (with strangely escaped (file)name) to work around this
problem.
Fabian Grünbichler
to replace lxc@.service.
we want our unit to only start when manually invoked (by our code), and
stop on shutdown via pve-guests or pve-ha-lrm. lxc@ units are stopped by
systemd on shutdown, because of transitive dependencies.
since all instances of template service units are by default assigned
37 matches
Mail list logo
