On 09/08/2017 02:56 PM, Philip Abernethy wrote:
Using the nodename is not correct and can lead to mails not forwarding
in restrictive mail server configurations.
---
src/PVE/HA/Env/PVE2.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/
---
pvecm.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pvecm.adoc b/pvecm.adoc
index 4414d20..179406e 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -846,7 +846,7 @@ NOTE: It is always a good idea to use an uninterruptible
power supply
(``UPS'', also called ``battery bac
On 09/12/2017 02:44 PM, Emmanuel Kasper wrote:
This will benefit the BusTypeSelector, the DiskFormatSelector, the CD
FileSelector,
and possibily other long fields like vm name, pool name.
---
www/manager6/form/ControllerSelector.js | 4 ++--
www/manager6/qemu/CDEdit.js | 3 +++
w
On 09/12/2017 02:44 PM, Emmanuel Kasper wrote:
SCSI is redundant in the VirtIO SCSI controller type.
VirtIO blk allows to better understand the different choices in the Combobox
and is also the name used by Qemu upstream.
---
www/manager6/Utils.js| 4 ++--
www/manager6/form/Bus
On 09/12/2017 02:44 PM, Emmanuel Kasper wrote:
This was happening without giving the user feedback, and changes a value
which should be set somewhere in the Options Panel.
So why not giving the user feedback instead?
Doesn't the user could get this feedback with the last patch from this series?
> On September 12, 2017 at 12:21 PM Matthias Urban
> wrote:
>
>
> Just sent the signed CLA to the Proxmox office. I'll later give git
> send-mail another try. Do I have to add patch comments again?
A short commit message is enough.
___
pve-devel m
> - my $logfile = $task->{logfile} = "$opts->{dumpdir}/$basename.log";
> + my $logfile = $task->{logfile} = !$opts->{stdout} ?
> "$opts->{dumpdir}/$basename.log" : '';
Why don't we want logs here?
>
> my $ext = $vmtype eq 'qemu' ? '.vma' : '.tar';
> my ($comp, $comp_ext) =
Checks for dumpdir or tmpdir backups don't apply to stdout, so we can
skip the checks involved in those methods.
---
PVE/VZDump.pm | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 004672d1..e5777ea5 100644
--- a/PVE/VZDump.pm
+++ b/PVE
Mostly whitespace fixes, a stray semicolon, some style fixes and a
grammar correction
---
PVE/VZDump.pm | 113 --
1 file changed, 54 insertions(+), 59 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index e5777ea5..86b8960d 100644
--
>>In the future please put the version tag into the brackets so that
>>`git am` doesn't include it as part of the commit message
>>("[PATCH v2] message..."), like Thomas already mentioned.
ok, sorry. Thanks !
- Mail original -
De: "Wolfgang Bumiller"
À: "aderumier"
Cc: "pve-devel"
Envo
This will benefit the BusTypeSelector, the DiskFormatSelector, the CD
FileSelector,
and possibily other long fields like vm name, pool name.
---
www/manager6/form/ControllerSelector.js | 4 ++--
www/manager6/qemu/CDEdit.js | 3 +++
www/manager6/qemu/CreateWizard.js | 1 +
www/ma
---
www/manager6/form/ControllerSelector.js | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/www/manager6/form/ControllerSelector.js
b/www/manager6/form/ControllerSelector.js
index 14ad574e..15023a7a 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/m
---
www/manager6/qemu/OSTypeEdit.js | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js
index 162a92ec..a779ab91 100644
--- a/www/manager6/qemu/OSTypeEdit.js
+++ b/www/manager6/qemu/OSTypeEdit.js
@@ -22,1
Since we started in PVE 4.3 to autoselect SCSI for new Linux VMs,
it was not clear that this controller actually uses a pv virtio
driver, which is confusing for users.
See for example:
https://forum.proxmox.com/threads/proxmox-hypervisor-scsi-or-virtio.36506/#post-179056
The vm configuration is o
SCSI is redundant in the VirtIO SCSI controller type.
VirtIO blk allows to better understand the different choices in the Combobox
and is also the name used by Qemu upstream.
---
www/manager6/Utils.js| 4 ++--
www/manager6/form/BusTypeSelector.js | 2 +-
2 files changed, 3 insertio
---
www/manager6/form/ControllerSelector.js | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/www/manager6/form/ControllerSelector.js
b/www/manager6/form/ControllerSelector.js
index 15023a7a..489b97de 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/manager6
This allow those properties to be easily overriden in subclasses in a later step
---
www/manager6/window/Wizard.js | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/www/manager6/window/Wizard.js b/www/manager6/window/Wizard.js
index 7ae58776..26c3ceaf 100644
---
The bus selector is displayed when we add a Hard Disk or CD Drive.
When it is displayed, we *always* preselect the next available
slot on the controller of our choice.
So this test is not needed.
We keep the test on the string value of 'autoselect' to select
a bus position when adding a CD Drive.
SCSI is a valid bus for Disks and CD drives, so it should always
be appear in the bus list.
---
www/manager6/form/BusTypeSelector.js| 6 +-
www/manager6/form/ControllerSelector.js | 6 +-
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/www/manager6/form/BusTypeSelector.
This was happening without giving the user feedback, and changes a value
which should be set somewhere in the Options Panel.
---
www/manager6/qemu/CreateWizard.js | 2 +-
www/manager6/qemu/HDEdit.js | 4
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/www/manager6/qemu/Cre
changes since v1:
* from Dominik hints:
* use a fixed hint for bus id selector, so we can flex the controller type
on the remaining width
* fixe VirtIO typo
* from Wolfgang B hints:
* make controller type selector non editable
* also write 'VirtIO blk' without hyphen in the controlle
On 09/12/2017 02:30 PM, Wolfgang Bumiller wrote:
> On Thu, Sep 07, 2017 at 10:00:07AM +0200, Emmanuel Kasper wrote:
>> any feedback on this ?
>> cancelling an action because it has been cancelled it not such an
>> helpful error message ;)
>
> Wouldn't this result in:
> drive-scsi0: Cancelling blo
applied...
On Mon, Sep 04, 2017 at 12:43:04PM +0200, Wolfgang Bumiller wrote:
> There's no guarantee that there's a timestamp in an skb, so
> nflog_get_timestamp can fail.
> ---
> Alternatively we could leave out the timestamp entirely in this case,
> but then the gui won't show any timestamps at
On Thu, Sep 07, 2017 at 10:00:07AM +0200, Emmanuel Kasper wrote:
> any feedback on this ?
> cancelling an action because it has been cancelled it not such an
> helpful error message ;)
Wouldn't this result in:
drive-scsi0: Cancelling block job
2017-07-31 17:51:44 ERROR: online migrate failure - m
thanks, applied
In the future please put the version tag into the brackets so that
`git am` doesn't include it as part of the commit message
("[PATCH v2] message..."), like Thomas already mentioned.
On Tue, Sep 05, 2017 at 11:46:17AM +0200, Alexandre Derumier wrote:
> We only use it to send comma
applied
On Tue, Sep 12, 2017 at 01:25:30PM +0200, Thomas Lamprecht wrote:
> Encode the result or the error in JSON. This way complex objects or
> exceptions may be passed to the parent in a generic way.
>
> This allows to remove the second pipe 'pipe_err'.
>
> Allow also to return undef without
Encode the result or the error in JSON. This way complex objects or
exceptions may be passed to the parent in a generic way.
This allows to remove the second pipe 'pipe_err'.
Allow also to return undef without any warnings to our caller.
This avoids a "use of uninitialized variable ..." warning
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied
On Wed, Sep 06, 2017 at 02:37:33PM +0200, Emmanuel Kasper wrote:
> This makes our man pages follow the GNU long option recommandations
> where non-single character options are prefixed with a double hyphen
> (https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html)
>
> The
Just sent the signed CLA to the Proxmox office. I'll later give git
send-mail another try. Do I have to add patch comments again?
On 12.09.2017 08:04, Fabian Grünbichler wrote:
On Tue, Sep 12, 2017 at 07:33:23AM +0200, Dietmar Maurer wrote:
2. The VM.Clone privilege alone is not enough to clo
With 2.1 a bunch of keys were renamed for consistency, and
network interface configuration is now done with explicit
indices.
Since we allow various custom "lxc.*" keys in our container
configuration we need to deal with this change and we now
inform the user about this with a warning.
---
Changes
On 09/12/2017 11:35 AM, Dietmar Maurer wrote:
would it be more generic to decode/encode the data as JSON?
print encode_json({ res => $res });
...
That way we can also return complex data structures, for example
exceptions.
eval {
$res = $sub->();
print {$pipe_
applied
On Mon, Sep 11, 2017 at 12:31:06PM +0200, Fabian Grünbichler wrote:
> preserve the old behaviour of selecting auth_supported based on the
> existence of the keyring, but limit it to external clusters.
>
> this allows switching 'auth XXX required' in the pveceph-managed
> ceph.conf while s
would it be more generic to decode/encode the data as JSON?
print encode_json({ res => $res });
...
That way we can also return complex data structures, for example
exceptions.
eval {
$res = $sub->();
print {$pipe_out} encode_json({ data => $res });
}
On Tue, Sep 12, 2017 at 08:41:54AM +0200, Wolfgang Link wrote:
> A base snapshot can be a replication snapshot or a normal snapshot.
> Normal snapshots use the format configid.
> ---
> src/PVE/JSONSchema.pm | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/src/PVE/JSONSchem
allow also to return undef without any warnings to our caller.
This avoids a "use of unitialised variable ..." warning
Add a single char at the start which allows us to differ between
returning undef and returning all other values.
Signed-off-by: Thomas Lamprecht
---
changes v1 -> v2:
* method
applied both patches
On Mon, Sep 11, 2017 at 05:42:34PM +0200, Philip Abernethy wrote:
> ---
> www/manager6/lxc/CreateWizard.js | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/www/manager6/lxc/CreateWizard.js
> b/www/manager6/lxc/CreateWizard.js
> index 8515877a..
Hello,
pveproxy has already a reload command - which seems to reopen the logs
correctly. Is there any reason why restart is used in the postrotate
part of logrotate?
Greets,
Stefan
Am 12.09.2017 um 09:13 schrieb Stefan Priebe - Profihost AG:
> Hello,
>
> we're heavily using the pve api - doing
Hello,
we're heavily using the pve api - doing a lot of calls every few minutes.
Currently the log rotation does a pveproxy restart which makes the API
unavailable for a few seconds. This is pretty bad.
I see the following solution:
- add a special signal like SIGUSR1 to pveproxy and spiceproxy
39 matches
Mail list logo
