On 09/12/2017 02:44 PM, Emmanuel Kasper wrote:
SCSI is redundant in the VirtIO SCSI controller type.
VirtIO blk allows to better understand the different choices in the Combobox
and is also the name used by Qemu upstream.
---
www/manager6/Utils.js | 4 ++--
www/manager6/form/BusTypeSelector.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 0b850977..9f79506a 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -202,9 +202,9 @@ Ext.define('PVE.Utils', { utilities: {
} else if (value === 'megasas') {
return 'MegaRAID SAS 8708EM2';
} else if (value === 'virtio-scsi-pci') {
- return 'VirtIO SCSI';
+ return 'VirtIO';
} else if (value === 'virtio-scsi-single') {
- return 'VirtIO SCSI single';
+ return 'VirtIO single';
} else if (value === 'pvscsi') {
return 'VMware PVSCSI';
} else {
diff --git a/www/manager6/form/BusTypeSelector.js
b/www/manager6/form/BusTypeSelector.js
index afcbb1eb..79a4a2bb 100644
--- a/www/manager6/form/BusTypeSelector.js
+++ b/www/manager6/form/BusTypeSelector.js
@@ -7,7 +7,7 @@ Ext.define('PVE.form.BusTypeSelector', {
// ordering matters
busList: [
['ide', 'IDE'],
- ['virtio', 'VirtIO'],
+ ['virtio', 'VirtIO blk'],
IMO, "VirtIO Block", the full name [1] of this HW should tell the user
more here – especially when searching – than "blk".
[1]
https://git.qemu.org/gitweb.cgi?p=qemu.git;a=blob;f=hw/block/virtio-blk.c;h=a16ac750906afb8413cd553405fea28797534a4a;hb=HEAD#l2
['scsi', 'SCSI'],
['sata', 'SATA']
],
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
