> - my $logfile = $task->{logfile} = "$opts->{dumpdir}/$basename.log";
> + my $logfile = $task->{logfile} = !$opts->{stdout} ?
> "$opts->{dumpdir}/$basename.log" : '';
Why don't we want logs here?
>
> my $ext = $vmtype eq 'qemu' ? '.vma' : '.tar';
> my ($comp, $comp_ext) = compressor_info($opts);
> @@ -823,6 +825,8 @@ sub exec_backup_task {
>
> if ($opts->{tmpdir}) {
> $task->{tmpdir} = "$opts->{tmpdir}/vzdumptmp$$";
> + } elsif ($opts->{stdout}) {
> + $task->{tmpdir} = "/var/tmp/vzdumptmp$$";
why? $opts->{stdout} just specifies where we want the output stream.
I am quite sure that I never want to use /var/tmp/ to store
backup data.
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
