i agree with all your points:
patches 1-3 require more work as to really solve the cyclic dependency
-> todo in the future
patches 4-12 require rework to get the format from the storage api call
we make anyway instead of the whole thing in /version,
i will send a v2 as soon as i have some ti
On 08/24/2017 08:30 AM, Fabian Grünbichler wrote:
On Thu, Aug 24, 2017 at 07:05:35AM +0200, Thomas Lamprecht wrote:
On 08/23/2017 07:15 PM, Alexandre DERUMIER wrote:
for me, this patch is ok.
if the job is complete, we don't need to unplug. (and that mean that vm need to
support unplug too, w
looks good, I will apply this once 12.2.0 is out and we have a
(hopefully stable) final output schema for the various ceph status and
health commands.
On Wed, Aug 23, 2017 at 08:27:45PM +0200, Waschbüsch IT-Services GmbH wrote:
> Reflect changed output for 'ceph pg dump -f json'.
>
> Signed-off-b
On Thu, Aug 24, 2017 at 07:05:35AM +0200, Thomas Lamprecht wrote:
> On 08/23/2017 07:15 PM, Alexandre DERUMIER wrote:
> > for me, this patch is ok.
> >
> > if the job is complete, we don't need to unplug. (and that mean that vm
> > need to support unplug too, we can't be sure that guest support t
some comments inline
On 08/23/2017 07:02 PM, Alwin Antreich wrote:
add version check to ceph init to require luminous or higher and
fix #1481: check existence of ceph binaries before use
Signed-off-by: Alwin Antreich
---
PVE/API2/Ceph.pm | 17 -
PVE/CephTools.pm | 44 +++
On 08/23/2017 07:15 PM, Alexandre DERUMIER wrote:
for me, this patch is ok.
if the job is complete, we don't need to unplug. (and that mean that vm need to
support unplug too, we can't be sure that guest support this).
Is it possible that the problem was the previous bug with unix socket, were
Reflect changed output for 'ceph pg dump -f json'.
Signed-off-by: Martin Waschbüsch
---
Without this patch, all osds will show a latency of 0.
Sadly, that is not true. :-)
PVE/API2/Ceph.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
inde
for me, this patch is ok.
if the job is complete, we don't need to unplug. (and that mean that vm need to
support unplug too, we can't be sure that guest support this).
Is it possible that the problem was the previous bug with unix socket, were the
target vm was not paused after migration ?
add version check to ceph init to require luminous or higher and
fix #1481: check existence of ceph binaries before use
Signed-off-by: Alwin Antreich
---
PVE/API2/Ceph.pm | 17 -
PVE/CephTools.pm | 44 +++-
2 files changed, 55 insertions(+)
On 08/23/2017 05:30 PM, Philip Abernethy wrote:
Disables the quota checkbox for unprivileged containers in the creation wizard,
as well as when editing or adding mountpoints.
---
With the editor windows I got confused by the caps.vms['Config.VM.Disk']
earlier, but that's access control. Removed t
On 08/23/2017 05:20 PM, Dietmar Maurer wrote:
nitpick: I know JS standard is weird for not allowing trailing commas,
but you can always add it in between to avoid touching multiple lines.
So far we do not add trailing commas as defined in the standard.
Yes, I never stated the difference :)
I j
Disables the quota checkbox for unprivileged containers in the creation wizard,
as well as when editing or adding mountpoints.
---
With the editor windows I got confused by the caps.vms['Config.VM.Disk']
earlier, but that's access control. Removed the distinction altogether.
Recarding the commas I'
> nitpick: I know JS standard is weird for not allowing trailing commas,
> but you can always add it in between to avoid touching multiple lines.
So far we do not add trailing commas as defined in the standard.
___
pve-devel mailing list
pve-devel@pve.p
Adds a check if an unprivileged container is configured to use
quota on any of its mountpoints. If so an understandable error
message is given. Ideally I'd like to catch those
configurations on the GUI, too, to avoid users just running
into it.
---
That suggestion evidently slipped my mind.
src/PV
On 08/23/2017 04:27 PM, Philip Abernethy wrote:
Adds a check if an unprivileged container is configured to use
quota on any of its mountpoints. If so an understandable error
message is given. Ideally I'd like to catch those
configurations on the GUI, too, to avoid users just running
into it.
---
some comments inline.
On 08/23/2017 04:31 PM, Philip Abernethy wrote:
Disables the quota checkbox for unprivileged containers in the creation wizard,
as well as when editing or adding mountpoints.
---
www/manager6/lxc/CreateWizard.js | 20 +++-
www/manager6/lxc/ResourceEdit.js
I wonder if this simplified version works:
if ($conf->{unprivileged}) {
PVE::LXC::Config->foreach_mountpoint($conf, sub {
my ($ms, $mountpoint) = @_;
die "Quotas are not supported by unprivileged
containers.\n" if
$mountpoint->{q
Disables the quota checkbox for unprivileged containers in the creation wizard,
as well as when editing or adding mountpoints.
---
www/manager6/lxc/CreateWizard.js | 20 +++-
www/manager6/lxc/ResourceEdit.js | 10 --
www/manager6/lxc/Resources.js| 27 +++
Adds a check if an unprivileged container is configured to use
quota on any of its mountpoints. If so an understandable error
message is given. Ideally I'd like to catch those
configurations on the GUI, too, to avoid users just running
into it.
---
Done. GUI fix coming up.
src/PVE/API2/LXC/Status.
On 07/19/2017 03:45 PM, Dominik Csapak wrote:
this series does a few things:
(i did not split it up, because the hunks are near each other,
and then only the first applied series would work or none at all)
patches 01/17 - 03/17 are for preparing to resolve a cyclic dependency
in pve-access-contr
On 07/19/2017 03:45 PM, Dominik Csapak wrote:
this will be used in the gui, for selecting/creating disks/mps/etc.
this means, that we get the information about a storage from
the backend, instead of hardcoding types in the frontend
(like the lun selector for iscsi)
The api calls:
GET /storage
On 07/19/2017 03:45 PM, Dominik Csapak wrote:
the code is copied from the /access/ticket api call
from the pve-access-control package
I see why you did this. But am really not happy with it...
I'd try to remove the PVE:::Storage usage in AccessControl completely,
the compute_api_permission co
On Wed, Aug 23, 2017 at 10:59:55AM +0200, Wolfgang Link wrote:
> ---
> PVE/CLI/pvesm.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm
> index 9455595..6b37c05 100755
> --- a/PVE/CLI/pvesm.pm
> +++ b/PVE/CLI/pvesm.pm
> @@ -183,7 +1
Any feedback on this ?
The current status of local migration with ide disks if quite ugly at
the moment, as the source VM hangs suspended and locked when reaching
the unplug step, since IDE disks do not hotplug.
If we prefer to have the disk unplugging around, then we should exclude
VMs with ide d
On 08/23/2017 11:27 AM, Thomas Lamprecht wrote:
diff --git a/www/manager6/qemu/CmdMenu.js b/www/manager6/qemu/CmdMenu.js
index 0fb832d4..c76c511b 100644
--- a/www/manager6/qemu/CmdMenu.js
+++ b/www/manager6/qemu/CmdMenu.js
@@ -111,7 +111,10 @@ Ext.define('PVE.qemu.CmdMenu', {
In general OK, but same problem as IOThread has, the checkbox should be cleared
on disable.
Else, it may confuse users or give them the idea that they can outsmart the
wizard
and set discard on sata (for example).
I sent a patch which addresses this with IOThread, and some other which will
cau
base idea OK, comments inline.
On 07/19/2017 03:45 PM, Dominik Csapak wrote:
Signed-off-by: Dominik Csapak
---
www/manager6/lxc/CmdMenu.js | 9 -
www/manager6/qemu/CmdMenu.js | 3 ++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/www/manager6/lxc/CmdMenu.js b/www/
Reviewed and tested, looks good.
As this checks is now in a few places a PVE.Utils helper could be appropriate?
On 07/19/2017 03:45 PM, Dominik Csapak wrote:
Signed-off-by: Dominik Csapak
---
www/manager6/lxc/Config.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/lxc/Con
Reviewed and tested, looks good to me.
On 07/19/2017 03:45 PM, Dominik Csapak wrote:
this hides not usuable buttons for qemu
e.g. start/shutdown for templates
migrate for non-cluster setups
Signed-off-by: Dominik Csapak
---
www/manager6/qemu/Config.js | 10 +-
1 file changed, 9 inse
---
PVE/CLI/pvesm.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm
index 9455595..6b37c05 100755
--- a/PVE/CLI/pvesm.pm
+++ b/PVE/CLI/pvesm.pm
@@ -183,7 +183,7 @@ __PACKAGE__->register_method ({
base => {
des
Signed-off-by: Alwin Antreich
---
data/src/pmxcfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data/src/pmxcfs.c b/data/src/pmxcfs.c
index 8fa3bcc..5547d5d 100644
--- a/data/src/pmxcfs.c
+++ b/data/src/pmxcfs.c
@@ -909,7 +909,7 @@ int main(int argc, char *argv[])
Signed-off-by: Alwin Antreich
---
data/src/pmxcfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data/src/pmxcfs.c b/data/src/pmxcfs.c
index 8fa3bcc..5547d5d 100644
--- a/data/src/pmxcfs.c
+++ b/data/src/pmxcfs.c
@@ -909,7 +909,7 @@ int main(int argc, char *argv[])
On Wed, Aug 23, 2017 at 10:15:49AM +0200, Thomas Lamprecht wrote:
> when a stopped VM managed by HA got backuped the HA stack
> continuously tried to shut it down as check_running returns only if a
> PID for the VM exists.
> As the VM was locked the shutdown tries were blocked, but still a lot
> of
when a stopped VM managed by HA got backuped the HA stack
continuously tried to shut it down as check_running returns only if a
PID for the VM exists.
As the VM was locked the shutdown tries were blocked, but still a lot
of annoying messages and task spawns happened during the backup
period.
As qu
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
ping
On Wed, May 31, 2017 at 09:38:00AM +0200, Fabian Grünbichler wrote:
> blowfish, 3des and arcfour are not enabled by default on the
> server side anyway.
>
> on most hardware, AES is about 3 times faster than Chacha20
> because of hardware accelerated AES, hence the changed order
> of prefere
A user may set the `iothread` option and then change the bus type to
something which does not support it (sata, ide), while we disable
it the previously set value remains, which is confusing.
An user could think he coulkd trick the Wizard into using iothreads
for SATA/IDE but we just ignore the val
Signed-off-by: Thomas Lamprecht
---
www/manager6/qemu/HDEdit.js | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index c97f530c..09fd1a0b 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/
The bus tye selector gets now 2/3 of the space and the bus number
spinner gets 1/3.
It looked a bit strange with both of them getting half of the space,
as on a lot of GUIs the spinner get less space (its just a number
(max 13) vs a wider text).
Signed-off-by: Thomas Lamprecht
---
www/manager6/
40 matches
Mail list logo
