On 07/19/2017 03:45 PM, Dominik Csapak wrote:
this series does a few things:
(i did not split it up, because the hunks are near each other,
and then only the first applied series would work or none at all)
patches 01/17 - 03/17 are for preparing to resolve a cyclic dependency
in pve-access-control
Could have been own series, I know you just wanted to avoid merge conflicts
as it touches similar parts as 04/17 but with such a big series, a possible
need to respin one patch sound almost neater to me (and by reducing the diff
context on format-patch and reordering hunks, the merge conflict could have
been avoided too).
patches 04/17 - 12/17 are for getting the storage type information
from the backend instead of hardcoding values in the frontend
(with one exception for lxc mountpoints)
Base idea looks good and promising. Really nice to see the multiple duplicate
disk selector code parts go away. I did not looked to much a the JS part, as
it may change a bit if we go the "ship needed info in existing storage
API calls" way.
patches 13/17 - 15/17 are for hiding several buttons and entries
when not needed (e.g. start/stop buttons for templates)
This - together with 16/20 - definitively should've been in a own series
– it's completely independent of the other patches.
patch 16/17 and 17/17 are seperate but touch code near the
other patches
@Emmanuel - could you please take a look at the extjs patches?
Dominik Csapak (17):
copy api permission calculation to /version api call
get the api permissions info from /version
whitespace cleanup
get storage type info in /version api call
get storage info from /version api call in gui
add new DiskStorageSelector.js
move lxc mountpoint edit from ResourceEdit.js to MPEdit.js
use DiskStorageSelector in qemu/HDEdit.js
use DiskStorageSelector in qemu/HDEfi.js
use DiskStorageSelector in qemu/Clone.js
use DiskStorageSelector in qemu/HDMove.js
use DiskStorageSelector in lxc/MPEdit.js
hide not usable buttons for qemu
hide migrate button in lxc for non cluster setups
hide migrate in contextmenu when no cluster or no rights
disable discard for non-scsi disks
fix #1358: add clustername to datacenter element in tree
PVE/API2.pm | 118 ++++++++-
www/manager6/Makefile | 2 +
www/manager6/Utils.js | 55 +++++
www/manager6/Workspace.js | 17 +-
www/manager6/form/DiskStorageSelector.js | 109 +++++++++
www/manager6/lxc/CmdMenu.js | 9 +-
www/manager6/lxc/Config.js | 1 +
www/manager6/lxc/MPEdit.js | 340 ++++++++++++++++++++++++++
www/manager6/lxc/ResourceEdit.js | 395 -------------------------------
www/manager6/qemu/Clone.js | 70 +-----
www/manager6/qemu/CmdMenu.js | 3 +-
www/manager6/qemu/Config.js | 10 +-
www/manager6/qemu/HDEdit.js | 85 +------
www/manager6/qemu/HDEfi.js | 67 +-----
www/manager6/qemu/HDMove.js | 55 +----
www/manager6/tree/ResourceTree.js | 8 +
16 files changed, 688 insertions(+), 656 deletions(-)
create mode 100644 www/manager6/form/DiskStorageSelector.js
create mode 100644 www/manager6/lxc/MPEdit.js
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
