On 08/23/2017 04:27 PM, Philip Abernethy wrote:
Adds a check if an unprivileged container is configured to use
quota on any of its mountpoints. If so an understandable error
message is given. Ideally I'd like to catch those
configurations on the GUI, too, to avoid users just running
into it.
---
Done. GUI fix coming up.
src/PVE/API2/LXC/Status.pm | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm
index 89a2fca..5959bc3 100644
--- a/src/PVE/API2/LXC/Status.pm
+++ b/src/PVE/API2/LXC/Status.pm
@@ -177,6 +177,16 @@ __PACKAGE__->register_method({
PVE::LXC::Config->check_lock($conf);
}
+ if ($conf->{unprivileged}) {
+ my $uses_quota = 0;
+ PVE::LXC::Config->foreach_mountpoint($conf, sub {
+ my ($ms, $mountpoint) = @_;
+ $uses_quota = $uses_quota || $mountpoint->{quota};
+ });
+
+ die "Quotas are not supported by unprivileged
containers.\n" if ($uses_quota);
+ }
+
would have been great if you incorporated Dominik's suggestion, i.e.:
+ if ($conf->{unprivileged}) {
+ PVE::LXC::Config->foreach_mountpoint($conf, sub {
+ my ($ms, $mountpoint) = @_;
+ die "Quotas are not supported by unprivileged
containers.\n" if $mountpoint->{quota};
+ });
+ }
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
