[pve-devel] [PATCH qemu-server] Change target in replication-state when replication direction is switched.

2017-06-20 Thread Wolfgang Link
This is necessary to avoid a full sync which will fail because the disk already exists. --- PVE/QemuMigrate.pm | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 8e541bf..0c931c5 100644 --- a/PVE/QemuMigrate.pm +++ b/P

[pve-devel] applied: [PATCH manager] OSD: rename 'remove' to 'destroy'

2017-06-20 Thread Wolfgang Bumiller
applied On Wed, May 17, 2017 at 12:40:27PM +0200, Thomas Lamprecht wrote: > To have consistency with the CLI tools `pveceph destroyosd` command. > This is also more clear about the resulting action, as 'Remove' could > also just mean 'Remove from Config', for example. > > Signed-off-by: Thomas La

[pve-devel] applied: [PATCH manager] pvereport: improve output and add timeouts to commands

2017-06-20 Thread Wolfgang Bumiller
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster v2 1/2] factor out corosync methods to own module

2017-06-20 Thread Wolfgang Bumiller
applied both patches ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container] API HA tasks: we request states not execute them

2017-06-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- src/PVE/API2/LXC.pm| 2 +- src/PVE/API2/LXC/Status.pm | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 2e116d8..8c3645c 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm

[pve-devel] [PATCH qemu-server] API HA tasks: we request states not execute them

2017-06-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/API2/Qemu.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 76fd0e4..6b502df 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1756,7 +1756,7 @@ __PACKAGE__->register_method({

[pve-devel] [trivial] reword task description of HA controlled CT/VM API calls

2017-06-20 Thread Thomas Lamprecht
On CT/VM {migrate,start,stop,shutdown} use "Requesting" instead of "Executing". This should make it clear that we currently do not actually anything (i.e execute) but ask the HA stack to bring the service in the respective state (i.e. requesting). The HA stack may need some time (LRM could be idle

[pve-devel] applied: Re: [RFC ha-manager] explicitly sync journal when disabling watchdog updates

2017-06-20 Thread Thomas Lamprecht
Just for the record: this got applied to master by Dietmar On 05/23/2017 02:35 PM, Thomas Lamprecht wrote: Without syncing the journal could loose logs for a small interval (ca 10-60 seconds), but these last seconds are really interesting for analyzing the cause of a triggered watchdog. Also wi

Re: [pve-devel] [PATCH v7 pve-storage 00/10] FreeNAS storage plugin

2017-06-20 Thread Michael Rasmussen
On Tue, 20 Jun 2017 22:39:52 +0200 m...@datanom.net wrote: A hole bunch of words. I forgot to mention that in response to previous comments from Fabian the following is on the todo list so no need to raise those again: TODO * Make target prefix configurable in gui * Configurable in gui whether t

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread Michael Rasmussen
On Tue, 20 Jun 2017 09:22:52 +0200 Fabian Grünbichler wrote: > once you are happy with your commits: > "git format-patch -v7 --signoff --cover-letter HEAD~N" (where N is the > number of commits) > Just realized that FreeNAS 11 was released last week ;-) So when this first version is acceptet and

[pve-devel] [PATCH v3 pve-container 1/3] First beta of FreeNAS storage plugin

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- src/PVE/API2/LXC.pm | 9 + src/PVE/LXC.pm | 6 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index d9ad5ff..9cf22de 100644 --- a/src/PVE/API2/LXC.pm +++ b/

[pve-devel] [PATCH v3 pve-container 0/3] FreeNAS storage plugin

2017-06-20 Thread mir
From: Michael Rasmussen Enable FreeNAS as a valid storage plugin for LXC Changes since v2: * Fix bug in FreeNASPlugin.pm which prevented online resize. This reverts changes in v2 * Repatch to comply to Proxmox git workflow Changes since v1: * Disable online resize Michael Ras

[pve-devel] [PATCH v3 pve-container 3/3] Revert special case for LXC online resize.

2017-06-20 Thread mir
From: Michael Rasmussen The special handling is not needed since a fix is provided in FreeNAS.pm Signed-off-by: Michael Rasmussen --- src/PVE/API2/LXC.pm | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index d333bea..3ea7

[pve-devel] [PATCH v3 pve-container 2/3] Correctly bail when online resize for CT is requested.

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- src/PVE/API2/LXC.pm | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 9cf22de..d333bea 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.p

[pve-devel] [PATCH v7 pve-storage 09/10] Implement support for linked clones.

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/FreeNASPlugin.pm | 56 1 file changed, 56 insertions(+) diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.pm index f954dc8..bfd3ee8 100644 --- a/PVE/Storage

[pve-devel] [PATCH v7 pve-storage 08/10] Implement support for snapshots

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/FreeNASPlugin.pm | 72 +++- 1 file changed, 71 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.pm index 9c0136d..f954dc8 100644 --

[pve-devel] [PATCH v7 pve-storage 10/10] Enable plugin in current storage system

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage.pm| 2 ++ PVE/Storage/Makefile | 2 +- PVE/Storage/Plugin.pm | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index ee2295a..f33249f 100755 --- a/PVE/Storage.p

[pve-devel] [PATCH v7 pve-storage 03/10] Basic iscsiadm interaction code

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/FreeNASPlugin.pm | 119 +++ 1 file changed, 119 insertions(+) diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.pm index a50a2f6..e930cea 100644 --- a/PVE/Storag

[pve-devel] [PATCH v7 pve-storage 05/10] Refactor method to find next lun number.

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/FreeNASPlugin.pm | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.pm index 3a18a31..91a1b0c 100644 --- a/PVE/Stor

[pve-devel] [PATCH v7 pve-storage 02/10] Basic FreeNAS API interaction code

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/FreeNASPlugin.pm | 415 +++ 1 file changed, 415 insertions(+) diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.pm index cf33e68..a50a2f6 100644 --- a/PVE/Storag

[pve-devel] [PATCH v7 pve-storage 01/10] FreeNAS storage plugin. Skeleton code.

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/FreeNASPlugin.pm | 66 1 file changed, 66 insertions(+) create mode 100644 PVE/Storage/FreeNASPlugin.pm diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.p

[pve-devel] [PATCH v7 pve-storage 07/10] Implement support for cloning images.

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/FreeNASPlugin.pm | 27 +++ 1 file changed, 27 insertions(+) diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.pm index 943eeab..9c0136d 100644 --- a/PVE/Storage/FreeNASPlugin.pm

[pve-devel] [PATCH v7 pve-storage 06/10] Implement support for volume resize

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/FreeNASPlugin.pm | 31 +++ 1 file changed, 31 insertions(+) diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.pm index 91a1b0c..943eeab 100644 --- a/PVE/Storage/FreeNASPlugi

[pve-devel] [PATCH v7 pve-storage 04/10] Basic storage operations.

2017-06-20 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/FreeNASPlugin.pm | 597 ++- 1 file changed, 589 insertions(+), 8 deletions(-) diff --git a/PVE/Storage/FreeNASPlugin.pm b/PVE/Storage/FreeNASPlugin.pm index e930cea..3a18a31 100644

[pve-devel] [PATCH v7 pve-storage 00/10] FreeNAS storage plugin

2017-06-20 Thread mir
From: Michael Rasmussen This patch series adds a storage plugin for FreeNAS using the FreeNAS API. The plugin supports both Qemu and LXC VM. Features supported, see below: VM CT create YES YES delete YES YES resize

[pve-devel] [PATCH docs] New chapter "Hyper-converged Infrastructure" with Proxmox ceph server

2017-06-20 Thread Friedrich Ramberger
The new chapter "Hyper-converged Infrastructure" is added. It contains a general statement about it and as subchapter "Ceph server in Proxmox VE Cluster" The latter is derived from the corresponding Wiki article. Since the Wiki article contains a lot of additional best practice information it

[pve-devel] [PATCH manager] Better Status description for jobs which are about to be run

2017-06-20 Thread Emmanuel Kasper
--- NB: 'pending' has not been translated yet. We have only 'pending changes'. However new features might need new text to be understood. PVE/CLI/pvesr.pm | 2 +- www/manager6/grid/Replication.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvesr.

[pve-devel] [PATCH] change replica log timestamp to a human readable format

2017-06-20 Thread Dominik Csapak
modeled after the timestamps in vm migration this does not impact the regression tests, because they overwrite 'get_log_time' anyway Signed-off-by: Dominik Csapak --- PVE/Replication.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread datanom.net
On 2017-06-20 12:59, datanom.net wrote: s/Are first commit!/After first commit!/ Strange, works now after starting over. To optimistic. If I cherry pick code in the first commit I am only able to add new code which is considered new if this code is in the original file is below the first chun

[pve-devel] Trying to create a patch for changing migration settings in the GUI

2017-06-20 Thread Caspar Smit
Hi all, I'm trying to create a patch which allows the migration settings (from datacenter.cfg) to be edited from the GUI. But since this is a setting containing multiple parameters (type and network) and my javascript skills are horrible, i got stuck. Here's what i got so far: Added the migratio

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread datanom.net
s/Are first commit!/After first commit!/ Strange, works now after starting over. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael rasmussen cc http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E mir datanom net http://pgp.mit.edu:11371/pks/lookup?op=get&search=

[pve-devel] applied: [PATCH qemu-server] PVE/QemuMigrate.pm: use replication job, transfer replication state

2017-06-20 Thread Dietmar Maurer
applied with suggested fixes ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 3/3] better default column sizes for replication grid

2017-06-20 Thread Emmanuel Kasper
serie looks good to me On 06/19/2017 04:25 PM, Dominik Csapak wrote: > to see the full date, and save space from the other columns > > Signed-off-by: Dominik Csapak > --- > www/manager6/grid/Replication.js | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/www/manage

[pve-devel] applied: [PATCH pve-guest-common 5/5] PVE::Replication::run_replication - add verbose parameter

2017-06-20 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-manager] PVE/API2/Replication.pm: add $verbose parameter run_jobs()

2017-06-20 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-guest-common 4/5] PVE::Replication::run_replication - return replicated $volumes

2017-06-20 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-guest-common 3/5] PVE::ReplicationState - new helpers record_job_start/record_job_end

2017-06-20 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-guest-common 2/5] PVE::Replication::find_common_replication_snapshot - new helper

2017-06-20 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-guest-common 1/5] PVE::ReplicationConfig::find_local_replication_job - new helper

2017-06-20 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-guest-common 1/5] PVE::ReplicationConfig::find_local_replication_job - new helper

2017-06-20 Thread Wolfgang Link
On 06/20/2017 10:50 AM, Dietmar Maurer wrote: Signed-off-by: Dietmar Maurer --- PVE/ReplicationConfig.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 845d9c3..1e813dd 100644 --- a/PVE/ReplicationConfig.pm +++ b/PV

Re: [pve-devel] [PATCH qemu-server] PVE/QemuMigrate.pm: use replication job, transfer replication state

2017-06-20 Thread Fabian Grünbichler
On Tue, Jun 20, 2017 at 11:01:24AM +0200, Dietmar Maurer wrote: > Signed-off-by: Dietmar Maurer > --- > PVE/QemuMigrate.pm | 54 > +- > 1 file changed, 53 insertions(+), 1 deletion(-) > > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm >

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread datanom.net
On 2017-06-20 11:14, datanom.net wrote: On 2017-06-20 09:22, Fabian Grünbichler wrote: followed by the following for each commit: "git add -p PVE/Storage/FreeNASPlugin.pm" (to selectively add parts of the plugin code to the staging area) "git diff --cached" (to review what you are about to commi

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread datanom.net
On 2017-06-20 09:22, Fabian Grünbichler wrote: followed by the following for each commit: "git add -p PVE/Storage/FreeNASPlugin.pm" (to selectively add parts of the plugin code to the staging area) "git diff --cached" (to review what you are about to commit) "git commit" (to create a commit) Do

[pve-devel] [PATCH qemu-server] PVE/QemuMigrate.pm: use replication job, transfer replication state

2017-06-20 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/QemuMigrate.pm | 54 +- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index bf0bb44..85fa6ff 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @

[pve-devel] [PATCH pve-manager] PVE/API2/Replication.pm: add $verbose parameter run_jobs()

2017-06-20 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/API2/Replication.pm| 6 +++--- bin/test/ReplicationTestEnv.pm | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index c4a37e4b..117fe57d 100644 --- a/PVE/API2/Replication.pm +++ b/

[pve-devel] [PATCH pve-guest-common 1/5] PVE::ReplicationConfig::find_local_replication_job - new helper

2017-06-20 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/ReplicationConfig.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 845d9c3..1e813dd 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -209,6 +209,19 @@ sub ch

[pve-devel] [PATCH pve-guest-common 3/5] PVE::ReplicationState - new helpers record_job_start/record_job_end

2017-06-20 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/Replication.pm | 24 PVE/ReplicationState.pm | 33 + 2 files changed, 37 insertions(+), 20 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 1762f2d..7686222 100644 --- a/PVE

[pve-devel] [PATCH pve-guest-common 2/5] PVE::Replication::find_common_replication_snapshot - new helper

2017-06-20 Thread Dietmar Maurer
This is just a cleanup (simply factor out code from replicate()). Signed-off-by: Dietmar Maurer --- PVE/Replication.pm | 73 +++--- 1 file changed, 47 insertions(+), 26 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index ed8d07

[pve-devel] [PATCH pve-guest-common 5/5] PVE::Replication::run_replication - add verbose parameter

2017-06-20 Thread Dietmar Maurer
used for regression tests Signed-off-by: Dietmar Maurer --- PVE/Replication.pm | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 64432eb..0db427d 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -301,7 +30

[pve-devel] [PATCH pve-guest-common 4/5] PVE::Replication::run_replication - return replicated $volumes

2017-06-20 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/Replication.pm | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 7686222..64432eb 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -208,7 +208,7 @@ sub replicate {

Re: [pve-devel] [RFC PATCH] Fixes: #1415 https://bugzilla.proxmox.com/show_bug.cgi?id=1415

2017-06-20 Thread Thomas Lamprecht
On 06/20/2017 09:23 AM, Wolfgang Bumiller wrote: Please don't use a link as commit message. .. s/commit message/commit message header/, its just fine in the commit messages body, imo. But for our own bug links the #XYZ should be enough. On Mon, Jun 19, 2017 at 11:21:09AM +0200, Emmanuel Kaspe

Re: [pve-devel] [RFC PATCH] Fixes: #1415 https://bugzilla.proxmox.com/show_bug.cgi?id=1415

2017-06-20 Thread Wolfgang Bumiller
Please don't use a link as commit message. On Mon, Jun 19, 2017 at 11:21:09AM +0200, Emmanuel Kasper wrote: > Wrap the -d test with run_or_get_killed sub this test > can make pvestatd hang on I/O wait when a nfsd process is stopped > --- > PVE/Storage/Plugin.pm | 9 +++-- > 1 file changed, 7

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread Fabian Grünbichler
On Mon, Jun 19, 2017 at 05:13:18PM +0200, m...@datanom.net wrote: > From: Michael Rasmussen > > (Resending, Diregard previous) this is almost the opposite of what I requested (I haven't looked at the actual changes, I am talking about the organization of the patches). I'll do further review once

Re: [pve-devel] [RFC PATCH 1/1] Add run_or_get_killed utility

2017-06-20 Thread Wolfgang Bumiller
On Tue, Jun 20, 2017 at 09:11:13AM +0200, Wolfgang Bumiller wrote: > > +if (!defined($child)) { > > + warn "fork failed: $!\n"; > > Why not just die? This is an actual exception after all. Ah I see, df() does the same. It probably shouldn't but its only user currently doesn't want it to thr

Re: [pve-devel] [RFC PATCH 1/1] Add run_or_get_killed utility

2017-06-20 Thread Wolfgang Bumiller
On Mon, Jun 19, 2017 at 11:21:08AM +0200, Emmanuel Kasper wrote: > This runs subroutine in a forked process > and kills it after a timeout > --- > src/PVE/Tools.pm | 43 +++ > 1 file changed, 43 insertions(+) > > diff --git a/src/PVE/Tools.pm b/src/PVE/Tool